Review Request 46969: Added (Framework/Executor/Command}Info to authorizer object message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46969/ --- Review request for mesos, Adam B and Alexander Rojas. Bugs: MESOS-5169

Re: Review Request 46958: Added Ubuntu 16.04 LTS to getting started document.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46958/ --- (Updated May 4, 2016, 4:31 p.m.) Review request for mesos, Adam B, haosdent

Re: Review Request 46958: Added Ubuntu 16.04 LTS to getting started document.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46958/#review131647 --- Patch looks great! Reviews applied: [46958] Passed command:

Re: Review Request 46613: Introduced VIEW_(FRAMEWORK, TASK}_WITH_INFO actions to authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46613/ --- (Updated May 4, 2016, 10:05 a.m.) Review request for mesos, Adam B and

Re: Review Request 46958: Added Ubuntu 16.04 LTS to getting started document.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46958/#review131642 --- Fix it, then Ship it! docs/getting-started.md (line 47)

Re: Review Request 46958: Added Ubuntu 16.04 LTS to getting started document.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46958/ --- (Updated May 4, 2016, 5:03 p.m.) Review request for mesos, Adam B, haosdent

Re: Review Request 46958: Added Ubuntu 16.04 LTS to getting started document.

> On May 4, 2016, 4:57 p.m., Neil Conway wrote: > > docs/getting-started.md, line 47 > > > > > > This should end in a period. Also, I'd say "(Only necessary if SSL and > > libevent are enabled)." Thank you very

Re: Review Request 46140: Added test "ROOT_CommandTaskNoRootfsWithVolumes".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46140/ --- (Updated 五月 4, 2016, 8:54 a.m.) Review request for mesos, Gilbert Song and Jie

Re: Review Request 46969: Added (Framework/Executor/Command}Info to authorizer object message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46969/#review131649 --- Bad patch! Reviews applied: [46969, 46613] Failed command:

Re: Review Request 42028: Added test "ROOT_CommandTaskNoRootfsFailedWithSameVolumes".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42028/ --- (Updated 五月 4, 2016, 9:03 a.m.) Review request for mesos, Gilbert Song and Jie

Re: Review Request 38451: Added test "ROOT_CommandTaskNoRootfsSlaveRecovery".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38451/ --- (Updated 五月 4, 2016, 10:14 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 46613: Introduced VIEW_(FRAMEWORK, TASK}_WITH_INFO actions to authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46613/ --- (Updated May 4, 2016, 12:57 p.m.) Review request for mesos, Adam B and

Re: Review Request 46969: Added (Framework/Executor/Command}Info to authorizer object message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46969/ --- (Updated May 4, 2016, 12:58 p.m.) Review request for mesos, Adam B and

Re: Review Request 46969: Added (Framework/Executor/Command}Info to authorizer object message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46969/#review131666 --- Patch looks great! Reviews applied: [46613, 46969] Passed

Re: Review Request 39474: Added test "ROOT_CommandTaskRootfsWithVolumes".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39474/ --- (Updated 五月 4, 2016, 2:33 p.m.) Review request for mesos, Gilbert Song and Jie

Re: Review Request 46874: Enhanced log message when launch mesos-containerizer.

> On 五月 3, 2016, 10:36 p.m., Gilbert Song wrote: > > It seems to me that we have `Starting container..` in launch() and `cloning > > child..` in fork(). Yes, but what I want to hightlight is the flags that we used to start `mesos-containerizer`, so just using `lauch mesos-containerizer`, any

Re: Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.

> On April 28, 2016, 11:52 p.m., Michael Park wrote: > > 3rdparty/libprocess/src/subprocess_windows.cpp, lines 534-539 > > > > > > A few comments here. > > > > (1) I think we can simply this to: > > >

Re: Review Request 46964: Using the summary attribute of the table element.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46964/ --- (Updated 五月 5, 2016, 2:14 a.m.) Review request for mesos, Zhiwei Chen and

Re: Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.

> On May 2, 2016, 9:14 p.m., Michael Park wrote: > > 3rdparty/libprocess/src/subprocess_windows.cpp, line 89 > > > > > > The initialization with `INVALID_HANDLE_VALUE` has no semantic meaning, > > right? We should

Re: Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46608/ --- (Updated May 5, 2016, 3:12 a.m.) Review request for mesos, Alex Naparu, Daniel

Re: Review Request 46435: Added the test "CniIsolatorTest.ROOT_VerifyCheckpointedInfo".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46435/#review131761 --- src/tests/containerizer/cni_isolator_tests.cpp (lines 180 - 189)

Review Request 46966: Form controls must have associated labels.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46966/ --- Review request for mesos, Zhiwei Chen and haosdent huang. Bugs: MESOS-5201

Review Request 46975: Add title and heading in Mesos Log Page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46975/ --- Review request for mesos, Zhiwei Chen and haosdent huang. Bugs: MESOS-5201

Re: Review Request 46096: Updated prepare() method of "network/cni" isolator for tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46096/#review131757 --- Ship it! Ship It! - Jie Yu On April 26, 2016, 3:53 p.m.,

Re: Review Request 46435: Added the test "CniIsolatorTest.ROOT_VerifyCheckpointedInfo".

> On May 5, 2016, 7:49 a.m., Jie Yu wrote: > > src/tests/containerizer/cni_isolator_tests.cpp, lines 180-189 > > > > > > Hum, i thought you already pulled these into a helper? Do you need to > > update this patch?

Re: Review Request 46979: Introduced 'cni/config' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46979/ --- (Updated May 5, 2016, 10:01 a.m.) Review request for mesos, Avinash sridharan

Re: Review Request 46980: Implemented adding a cni network config via 'cni/config' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46980/ --- (Updated May 5, 2016, 10:44 a.m.) Review request for mesos, Avinash sridharan

Re: Review Request 42028: Added test "ROOT_CommandTaskNoRootfsFailedWithSameVolumes".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42028/ --- (Updated 五月 4, 2016, 11:32 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 39474: Added test "ROOT_CommandTaskRootfsWithVolumes".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39474/#review131697 --- Patch looks great! Reviews applied: [46680, 46681, 46682, 46140,

Re: Review Request 46540: Updated pkg-config file to include module dependency info.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46540/ --- (Updated May 4, 2016, 11:22 a.m.) Review request for mesos, Cody Maloney, Alex

Re: Review Request 46540: Updated pkg-config file to include module dependency info.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46540/#review131691 --- configure.ac (line 591)

Review Request 46980: Implemented adding a cni network config via 'cni/config' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46980/ --- Review request for mesos, Avinash sridharan and Jie Yu. Bugs: MESOS-5310

Review Request 46979: Introduced 'cni/config' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46979/ --- Review request for mesos, Avinash sridharan and Jie Yu. Bugs: MESOS-5310

Re: Review Request 46540: Updated pkg-config file to include module dependency info.

> On May 4, 2016, 11:33 a.m., James Peach wrote: > > configure.ac, line 591 > > > > > > So in practice, libraries would be installed in either > > ``3rdparty/lib64`` or ``3rdparty/lib``, but not both? > > > >

Re: Review Request 46990: Removed authorization from libprocess endpoint handlers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46990/#review131783 --- Bad patch! Reviews applied: [46990, 46989, 46882, 46881, 46880,

Review Request 47003: Fixed table accessibility.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47003/ --- Review request for mesos. Bugs: MESOS-5201

Review Request 47001: Fix race conditions in ROOT_XFS_QuotaTest.NoCheckpointRecovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47001/ --- Review request for mesos, Gilbert Song and Jiang Yan Xu. Bugs: MESOS-5308

Re: Review Request 46540: Updated pkg-config file to include module dependency info.

> On May 4, 2016, 3:33 p.m., James Peach wrote: > > configure.ac, line 591 > > > > > > So in practice, libraries would be installed in either > > ``3rdparty/lib64`` or ``3rdparty/lib``, but not both? > > > >

Review Request 46964: Using the summary attribute of the table element.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46964/ --- Review request for mesos, Zhiwei Chen and haosdent huang. Bugs: MESOS-5201

Re: Review Request 46954: Ensuring that id attributes are unique on a Web page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46954/ --- (Updated 五月 5, 2016, 1:19 a.m.) Review request for mesos, Zhiwei Chen and

Re: Review Request 38451: Added test "ROOT_CommandTaskNoRootfsSlaveRecovery".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38451/ --- (Updated 五月 5, 2016, 1:46 a.m.) Review request for mesos, Gilbert Song and Jie

Re: Review Request 46395: Windows: Removed `std::bind` from `process.cpp` to build on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46395/#review131755 --- 3rdparty/libprocess/src/process.cpp (lines 896 - 897)

Re: Review Request 46140: Added test "ROOT_CommandTaskNoRootfsWithVolumes".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46140/#review131756 --- Thanks Yu Jie, I saw that

Re: Review Request 46140: Added test "ROOT_CommandTaskNoRootfsWithVolumes".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46140/#review131715 --- Fix it, then Ship it! I'll make the change for you for this

Review Request 46989: Added authorization handling to 'ProcessBase::visit'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46989/ --- Review request for mesos, Alexander Rojas and Kapil Arya. Bugs: MESOS-5286

Review Request 46990: Removed authorization from libprocess endpoint handlers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46990/ --- Review request for mesos, Alexander Rojas and Kapil Arya. Bugs: MESOS-5286

Re: Review Request 46936: Documented the agent endpoint '/flags'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46936/#review131739 --- src/slave/http.cpp (lines 356 - 357)

Re: Review Request 46935: Documented the agent endpoint '/metrics/snapshot'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46935/#review131738 --- Please run the script and include the .md change into this patch.

Re: Review Request 46965: Using ARIA landmarks to identify regions of a page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46965/#review131640 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 46958: Added Ubuntu 16.04 LTS to getting started document.

> On May 4, 2016, 3:48 p.m., Neil Conway wrote: > > docs/getting-started.md, line 64 > > > > > > Is automake also required for 14.04? my falt, it will be automatically installed. Will remove it in next patch. > On

Re: Review Request 46958: Added Ubuntu 16.04 LTS to getting started document.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46958/#review131637 --- docs/getting-started.md (line 64)

Review Request 46965: Using ARIA landmarks to identify regions of a page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46965/ --- Review request for mesos. Repository: mesos Description --- Using ARIA

Re: Review Request 46923: Added framework failover timeout validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46923/#review131635 --- I notice that `Master::_exited` also checks that the

Re: Review Request 46960: Remove un-necessary copying of `slave->tasks` in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46960/#review131630 --- Patch looks great! Reviews applied: [46960] Passed command:

Re: Review Request 46140: WIP: Added test "ROOT_CommandTaskNoRootfsWithVolumes".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46140/ --- (Updated 五月 4, 2016, 6:53 a.m.) Review request for mesos, Gilbert Song and Jie

Re: Review Request 46140: WIP: Added test "ROOT_CommandTaskNoRootfsWithVolumes".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46140/ --- (Updated 五月 4, 2016, 7:01 a.m.) Review request for mesos, Gilbert Song and Jie

Re: Review Request 46866: Enabled authorization of libprocess HTTP endpoints (libprocess).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46866/ --- (Updated May 4, 2016, 9:18 p.m.) Review request for mesos, Alexander Rojas and

Re: Review Request 46866: Enabled authorization of libprocess HTTP endpoints (libprocess).

> On May 4, 2016, 3:24 a.m., Kapil Arya wrote: > > 3rdparty/libprocess/include/process/http.hpp, lines 89-91 > > > > > > Is that the correct line-break here? Can we make it better? I read through the relevant

Re: Review Request 46989: Added authorization handling to 'ProcessBase::visit'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46989/ --- (Updated May 4, 2016, 9:21 p.m.) Review request for mesos, Alexander Rojas and