Re: Review Request 46501: Updated authorization.md to reflect current changes.

2016-05-10 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46501/#review132501 --- docs/authorization.md (line 10)

Review Request 46520: Added --with-stout flag to libprocess configure.

2016-05-10 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46520/ --- Review request for mesos, Cody Maloney and Joris Van Remoortere. Bugs:

Re: Review Request 46532: Updated LDADD flags for libprocess tests.

2016-05-10 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46532/ --- (Updated May 10, 2016, 3:25 p.m.) Review request for mesos, Cody Maloney, Alex

Re: Review Request 46522: Sanitized libprocess/3rdparty/Makefile.am.

2016-05-10 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46522/ --- (Updated May 10, 2016, 3:23 p.m.) Review request for mesos, Cody Maloney, Alex

Re: Review Request 36383: Updated docker volume test case by adding checkpoint verify logic.

2016-05-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36383/#review132524 --- Patch looks great! Reviews applied: [46428, 36383] Passed

Re: Review Request 46424: Windows: Added libprocess to build.

2016-05-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46424/#review132513 --- Bad patch! Reviews applied: [46424, 47162, 46794, 46608, 46423,

Re: Review Request 46521: Added --with-{libproces, stout} flags to top-level configure.ac.

2016-05-10 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46521/ --- (Updated May 10, 2016, 3:23 p.m.) Review request for mesos, Cody Maloney, Alex

Re: Review Request 46515: Libprocess: Renamed --without-zlib to --disable-zlib.

2016-05-10 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46515/ --- (Updated May 10, 2016, 3:23 p.m.) Review request for mesos, Cody Maloney, Alex

Review Request 47186: Added some INFO logging in docker volume isolator.

2016-05-10 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47186/ --- Review request for mesos, Gilbert Song and Guangya Liu. Repository: mesos

Re: Review Request 46883: Added authorization callback for '/metrics/snapshot'.

2016-05-10 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46883/ --- (Updated May 10, 2016, 8:31 p.m.) Review request for mesos, Alexander Rojas

Re: Review Request 46867: Enabled authorization of libprocess HTTP endpoints (Mesos).

2016-05-10 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46867/ --- (Updated May 10, 2016, 8:30 p.m.) Review request for mesos, Alexander Rojas

Re: Review Request 46537: Added --enable-install-module-dependencies.

2016-05-10 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46537/ --- (Updated May 10, 2016, 3:26 p.m.) Review request for mesos, Cody Maloney, Alex

Re: Review Request 46538: Install module dependencies in build/3rdparty as well.

2016-05-10 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46538/ --- (Updated May 10, 2016, 3:26 p.m.) Review request for mesos, Cody Maloney, Alex

Re: Review Request 46525: Moved 3rdparty packages from libprocess/3rdparty/ to 3rdparty/.

2016-05-10 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46525/ --- (Updated May 10, 2016, 5:45 p.m.) Review request for mesos, Cody Maloney, Alex

Re: Review Request 46526: Updated 3rdparty paths in Python build scripts.

2016-05-10 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46526/ --- (Updated May 10, 2016, 5:46 p.m.) Review request for mesos, Cody Maloney, Alex

Re: Review Request 46529: Moved stout from libprocess/3rdparty/ to 3rdparty/.

2016-05-10 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46529/ --- (Updated May 10, 2016, 5:49 p.m.) Review request for mesos, Cody Maloney, Alex

Re: Review Request 46516: Sorted option checks for libprocess configure.ac.

2016-05-10 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46516/ --- (Updated May 10, 2016, 5:40 p.m.) Review request for mesos, Cody Maloney, Alex

Re: Review Request 47169: Windows: Impemented `killtree` using NT job objects.

2016-05-10 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47169/ --- (Updated May 10, 2016, 9:57 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 47169: Windows: Impemented `killtree` using NT job objects.

2016-05-10 Thread Daniel Pravat
> On May 10, 2016, 4:31 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp, line 681 > > > > > > Is there no extra information we can pass from this failure? No

Re: Review Request 46869: Allowed tests to authorize libprocess HTTP endpoints.

2016-05-10 Thread Greg Mann
> On May 9, 2016, 10:38 a.m., Alexander Rojas wrote: > > src/tests/cluster.cpp, lines 424-432 > > > > > > Since callbacks are a libprocess property and not really additive, > > wouldn't this effectively overwrite

Re: Review Request 46866: Enabled authorization of libprocess HTTP endpoints (libprocess).

2016-05-10 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46866/ --- (Updated May 10, 2016, 8:30 p.m.) Review request for mesos, Alexander Rojas

Re: Review Request 46519: Copied libprocess-specific configure options to top-level configure.ac.

2016-05-10 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46519/ --- (Updated May 10, 2016, 5:43 p.m.) Review request for mesos, Cody Maloney, Alex

Re: Review Request 46520: Added --with-stout flag to libprocess configure.

2016-05-10 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46520/ --- (Updated May 10, 2016, 5:43 p.m.) Review request for mesos, Cody Maloney and

Re: Review Request 47186: Added some INFO logging in docker volume isolator.

2016-05-10 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47186/#review132551 --- Ship it! Ship It! - Guangya Liu On May 10, 2016, 7:11 p.m.,

Re: Review Request 46876: Fixed tests to work with authorized '/metrics/snapshot'.

2016-05-10 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46876/ --- (Updated May 10, 2016, 8:37 p.m.) Review request for mesos, Alexander Rojas

Re: Review Request 46870: Added MetricsTests with authorization.

2016-05-10 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46870/ --- (Updated May 10, 2016, 8:36 p.m.) Review request for mesos, Alexander Rojas

Re: Review Request 46866: Enabled authorization of libprocess HTTP endpoints (libprocess).

2016-05-10 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46866/#review132535 --- Ship it! Ship It! - Kapil Arya On May 10, 2016, 4:30 p.m.,

Re: Review Request 46869: Allowed tests to authorize libprocess HTTP endpoints.

2016-05-10 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46869/#review132543 --- Ship it! Ship It! - Kapil Arya On May 10, 2016, 4:36 p.m.,

Re: Review Request 46518: Sorted option checks for top-level configure.ac.

2016-05-10 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46518/ --- (Updated May 10, 2016, 5:42 p.m.) Review request for mesos, Cody Maloney, Alex

Re: Review Request 46527: Updated stout/configure.ac to include several '--with-XXX' options.

2016-05-10 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46527/ --- (Updated May 10, 2016, 5:47 p.m.) Review request for mesos, Cody Maloney, Alex

Re: Review Request 47161: Fixed replica log restore tests.

2016-05-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47161/#review132546 --- Patch looks great! Reviews applied: [47161] Passed command:

Re: Review Request 46528: Updated stout/Makefile.am to reflect bundled dependencies.

2016-05-10 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46528/ --- (Updated May 10, 2016, 5:47 p.m.) Review request for mesos, Cody Maloney, Alex

Re: Review Request 46515: Libprocess: Renamed --without-zlib to --disable-zlib.

2016-05-10 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46515/ --- (Updated May 10, 2016, 5:38 p.m.) Review request for mesos, Cody Maloney, Alex

Re: Review Request 46514: Libprocess: Sorted configure.ac AC_ARG_{ENABLE, WITH} entries.

2016-05-10 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46514/ --- (Updated May 10, 2016, 5:37 p.m.) Review request for mesos, Cody Maloney, Alex

Re: Review Request 46538: Install module dependencies in build/3rdparty as well.

2016-05-10 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46538/ --- (Updated May 10, 2016, 5:50 p.m.) Review request for mesos, Cody Maloney, Alex

Re: Review Request 46534: Updated stout path for mesos_split.py.

2016-05-10 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46534/ --- (Updated May 10, 2016, 5:49 p.m.) Review request for mesos, Cody Maloney, Alex

Re: Review Request 46882: Added a LoggingTest with authorization.

2016-05-10 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46882/ --- (Updated May 10, 2016, 8:38 p.m.) Review request for mesos, Alexander Rojas

Re: Review Request 46881: Added authorization callback for '/logging/toggle'.

2016-05-10 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46881/ --- (Updated May 10, 2016, 8:38 p.m.) Review request for mesos, Alexander Rojas

Re: Review Request 46883: Added authorization callback for '/metrics/snapshot'.

2016-05-10 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46883/#review132537 --- Ship it! Ship It! - Kapil Arya On May 10, 2016, 4:31 p.m.,

Re: Review Request 46870: Added MetricsTests with authorization.

2016-05-10 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46870/#review132538 --- Ship it! Ship It! - Kapil Arya On May 10, 2016, 4:36 p.m.,

Re: Review Request 46882: Added a LoggingTest with authorization.

2016-05-10 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46882/#review132540 --- Ship it! Ship It! - Kapil Arya On May 10, 2016, 4:38 p.m.,

Re: Review Request 46881: Added authorization callback for '/logging/toggle'.

2016-05-10 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46881/#review132532 --- Ship it! src/common/http.cpp (lines 590 - 592)

Re: Review Request 46867: Enabled authorization of libprocess HTTP endpoints (Mesos).

2016-05-10 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46867/#review132536 --- Ship it! Ship It! - Kapil Arya On May 10, 2016, 4:30 p.m.,

Re: Review Request 46522: Sanitized libprocess/3rdparty/Makefile.am.

2016-05-10 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46522/ --- (Updated May 10, 2016, 5:43 p.m.) Review request for mesos, Cody Maloney, Alex

Re: Review Request 46521: Added --with-{libproces, stout} flags to top-level configure.ac.

2016-05-10 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46521/ --- (Updated May 10, 2016, 5:43 p.m.) Review request for mesos, Cody Maloney, Alex

Re: Review Request 46524: Sanitized src/Makefile.am.

2016-05-10 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46524/ --- (Updated May 10, 2016, 5:44 p.m.) Review request for mesos, Cody Maloney, Alex

Re: Review Request 46523: Sanitized libprocess/Makefile.am.

2016-05-10 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46523/ --- (Updated May 10, 2016, 5:43 p.m.) Review request for mesos, Cody Maloney, Alex

Re: Review Request 46532: Updated LDADD flags for libprocess tests.

2016-05-10 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46532/ --- (Updated May 10, 2016, 5:49 p.m.) Review request for mesos, Cody Maloney, Alex

Re: Review Request 46540: Updated pkg-config file to include module dependency info.

2016-05-10 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46540/ --- (Updated May 10, 2016, 5:50 p.m.) Review request for mesos, Cody Maloney, Alex

Re: Review Request 46539: Removed libprocess/3rdparty references from misc files.

2016-05-10 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46539/ --- (Updated May 10, 2016, 5:50 p.m.) Review request for mesos, Cody Maloney, Alex

Re: Review Request 46530: Libprocess: Replaced $(top_srcdir) with $(srcdir) in Makefile.am.

2016-05-10 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46530/ --- (Updated May 10, 2016, 5:49 p.m.) Review request for mesos, Cody Maloney, Alex

Re: Review Request 46531: Added explicit ldflags '-static -fpic' to libprocess.la.

2016-05-10 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46531/ --- (Updated May 10, 2016, 5:49 p.m.) Review request for mesos, Cody Maloney, Alex

Re: Review Request 46536: Updated stout path in newbie-guide.

2016-05-10 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46536/ --- (Updated May 10, 2016, 5:50 p.m.) Review request for mesos, Cody Maloney, Alex

Re: Review Request 46537: Added --enable-install-module-dependencies.

2016-05-10 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46537/ --- (Updated May 10, 2016, 5:50 p.m.) Review request for mesos, Cody Maloney, Alex

Review Request 47198: Added labels to docker v1 spec config.

2016-05-10 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47198/ --- Review request for mesos, Ben Mahler, Artem Harutyunyan, Jie Yu, and Kevin

Review Request 47200: Modified docker spec test for docker label support.

2016-05-10 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47200/ --- Review request for mesos, Ben Mahler, Artem Harutyunyan, Jie Yu, and Kevin

Review Request 47199: Implemented parsing docker labels in v1 spec.

2016-05-10 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47199/ --- Review request for mesos, Ben Mahler, Artem Harutyunyan, Jie Yu, and Kevin

Re: Review Request 47161: Fixed replica log restore tests.

2016-05-10 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47161/#review132572 --- Fix it, then Ship it! I'll touch the comment and the

Re: Review Request 46609: Add the test "SlaveRecoveryTest.RecoverTerminatedHTTPExecutor".

2016-05-10 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46609/#review132577 --- Ship it! Ship It! - Vinod Kone On May 5, 2016, 7:39 a.m.,

Re: Review Request 46816: Fix the absolute symlink path issue of include/slave.

2016-05-10 Thread Zhiwei Chen
> On May 11, 2016, 7:12 a.m., Vinod Kone wrote: > > Can you copy the description from the ticket to the description section in > > this review? Done, thanks. - Zhiwei --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 46816: Fix the absolute symlink path issue of include/slave.

2016-05-10 Thread Zhiwei Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46816/ --- (Updated May 11, 2016, 9:17 a.m.) Review request for mesos, zhou xing, Jie Yu,

Re: Review Request 45668: Enable CMake build for Linux as a BUILDTOOL option.

2016-05-10 Thread Vinod Kone
> On April 18, 2016, 6:18 p.m., Vinod Kone wrote: > > support/docker_build.sh, lines 127-140 > > > > > > Hmm. I was hoping for something more generic than hard coding these 3 > > configurations. But if it's not

Re: Review Request 47199: Implemented parsing docker labels in v1 spec.

2016-05-10 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47199/#review132576 --- src/docker/spec.cpp (line 164)

Review Request 47209: Establish TCP connection after backing off.

2016-05-10 Thread David Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47209/ --- Review request for mesos, Ben Mahler, Ian Downes, and Cong Wang. Bugs:

Re: Review Request 46821: Avoided slicing of flags in subprocess.

2016-05-10 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46821/#review132594 --- LGTM. Can you add @mpark or @joris to the reviews for a second

Review Request 47192: Fixed a head-of-line blocking bug in libevent SSL socket.

2016-05-10 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47192/ --- Review request for mesos, haosdent huang, Joris Van Remoortere, and Till

Re: Review Request 46540: Updated pkg-config file to include module dependency info.

2016-05-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46540/#review132561 --- Bad patch! Reviews applied: [46540, 46538, 46537, 46539, 46536,

Re: Review Request 47168: Windows: Implemented `kill`.

2016-05-10 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47168/ --- (Updated May 10, 2016, 11:34 p.m.) Review request for mesos, Artem

Re: Review Request 46608: Libprocess: Implemented `subprocess_windows.cpp`.

2016-05-10 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46608/ --- (Updated May 10, 2016, 11:44 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 46923: Added framework failover timeout validation.

2016-05-10 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46923/#review132571 --- src/master/master.hpp (line 929)

Re: Review Request 46725: Set default Content-Type for HTTP responses.

2016-05-10 Thread Vinod Kone
> On April 27, 2016, 11:44 p.m., Anand Mazumdar wrote: > > LGTM, just 2 minor nits. > > > > Also, as per our offline discussion: This doesn't handle scenarios where a > > client explicitly expects a error response encoded in a particular type > > specified via the `Accept` header. We would

Re: Review Request 47198: Added labels to docker v1 spec config.

2016-05-10 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47198/#review132575 --- include/mesos/docker/v1.proto (lines 55 - 60)

Review Request 47207: Fixed the idle connection libevent SSL problem.

2016-05-10 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47207/ --- Review request for mesos, Alexander Rukletsov, Ben Mahler, haosdent huang, and

Re: Review Request 47186: Added some INFO logging in docker volume isolator.

2016-05-10 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47186/#review132563 --- Ship it! Ship It! - Gilbert Song On May 10, 2016, 12:11

Re: Review Request 46867: Enabled authorization of libprocess HTTP endpoints (Mesos).

2016-05-10 Thread Greg Mann
> On May 9, 2016, 10:35 a.m., Alexander Rojas wrote: > > src/master/main.cpp, lines 430-431 > > > > > > Does it? The container `Option` is copied, but all copies of that > > `Option` will be refering to the same

Re: Review Request 46867: Enabled authorization of libprocess HTTP endpoints (Mesos).

2016-05-10 Thread Greg Mann
> On May 9, 2016, 10:35 a.m., Alexander Rojas wrote: > > src/master/main.cpp, lines 430-431 > > > > > > Does it? The container `Option` is copied, but all copies of that > > `Option` will be refering to the same

Re: Review Request 46816: Fix the absolute symlink path issue of include/slave.

2016-05-10 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46816/#review132565 --- Ship it! Can you copy the description from the ticket to the

Review Request 47208: Made logic for executor path consistent across example frameworks.

2016-05-10 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47208/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 47208: Made logic for executor path consistent across example frameworks.

2016-05-10 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47208/#review132582 --- Ship it! Ship It! - Vinod Kone On May 11, 2016, 12:44 a.m.,

Review Request 47150: Implemented new asynchronous docker pre-launch hook.

2016-05-10 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47150/ --- Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, and Kapil Arya.

Review Request 47149: Split DockerContainerizerProcess::launch into two functions.

2016-05-10 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47149/ --- Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, and Kapil Arya.

Review Request 47215: Changed the dockerized docker command executor CommandInfo usage.

2016-05-10 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47215/ --- Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, and Kapil Arya.

Review Request 47214: Replaced subprocess flag stringification with flags.toVector().

2016-05-10 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47214/ --- Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, and Kapil Arya.

Review Request 47212: Removed duplicate call to containerizer::executorEnvironment.

2016-05-10 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47212/ --- Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, and Kapil Arya.

Review Request 47205: Added optional environment variable argument to mesos-docker-executor.

2016-05-10 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47205/ --- Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, and Kapil Arya.

Review Request 47213: Added FlagsBase::toVector method as an alternative to stringify(flags).

2016-05-10 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47213/ --- Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, and Kapil Arya.

Re: Review Request 47192: Fixed a head-of-line blocking bug in libevent SSL socket.

2016-05-10 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47192/#review132596 --- Verify this works on my machine both `SSL_SUPPORT_DOWNGRADE`

Re: Review Request 46923: Added framework failover timeout validation.

2016-05-10 Thread Jose Guilherme Vanz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46923/ --- (Updated May 11, 2016, 3:47 a.m.) Review request for mesos, Guangya Liu, Kevin

Re: Review Request 46371: Added basic tests for capabilities API.

2016-05-10 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46371/ --- (Updated May 11, 2016, 4:34 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 46370: Introduced linux capabilities API.

2016-05-10 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46370/ --- (Updated May 11, 2016, 4:34 a.m.) Review request for mesos, Jie Yu and Kevin

Re: Review Request 47199: Implemented parsing docker labels in v1 spec.

2016-05-10 Thread Gilbert Song
> On May 10, 2016, 5:50 p.m., Kevin Klues wrote: > > src/docker/spec.cpp, line 164 > > > > > > Is there always a "config" and a "container_config" (below) in every > > image? If not, won't we error out

Re: Review Request 45671: Added version checking for dvdcli.

2016-05-10 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45671/ --- (Updated 五月 11, 2016, 2:51 a.m.) Review request for mesos, Gilbert Song and

Review Request 47217: Deprecate 'slave' in CLI.

2016-05-10 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47217/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3784

Re: Review Request 47209: Establish TCP connection after backing off.

2016-05-10 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47209/#review132597 --- Ship it! Ship It! - Cong Wang On May 11, 2016, 12:58 a.m.,

Review Request 47216: WIP: Wired up the new docker environment hook.

2016-05-10 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47216/ --- Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, and Kapil Arya.

Review Request 47219: Used `collect` for waiting on establishing connection.

2016-05-10 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47219/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 47192: Fixed a head-of-line blocking bug in libevent SSL socket.

2016-05-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47192/#review132595 --- Patch looks great! Reviews applied: [47192] Passed command:

Re: Review Request 37989: Enhanced log message when launching mesos docker executor.

2016-05-10 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37989/ --- (Updated 五月 11, 2016, 3:30 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 47198: Added labels to docker v1 spec config.

2016-05-10 Thread Gilbert Song
> On May 10, 2016, 5:41 p.m., Kevin Klues wrote: > > include/mesos/docker/v1.proto, lines 55-60 > > > > > > I don't quite understand this comment. WHy isn't this just a repeated > > optional string? WHy isn't this

Re: Review Request 46369: Added capabilities support in ContanerInfo protobuf.

2016-05-10 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46369/ --- (Updated May 11, 2016, 4:27 a.m.) Review request for mesos and Jie Yu.

  1   2   >