Re: Review Request 47511: Added documentation for `docker/volume` isolator.

2016-05-20 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47511/ --- (Updated May 20, 2016, 1:51 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 47635: Removed /observe document.

2016-05-20 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47635/#review134109 --- Ship it! Ship It! - haosdent huang On May 20, 2016, 6:17

Review Request 47636: Fixed some coding error in mesos-ps.

2016-05-20 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47636/ --- Review request for mesos, Benjamin Mahler, Jie Yu, and Vinod Kone. Repository:

Review Request 47635: Removed /observe document.

2016-05-20 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47635/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5408

Re: Review Request 47510: Adjusted style to make website mobile friendly.

2016-05-20 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47510/#review134114 --- site/source/assets/css/main.css (lines 131 - 137)

Re: Review Request 47633: Isolation/networking: check if IPv6 is loaded before trying to disable it

2016-05-20 Thread Zhengju Sha
> On 五月 20, 2016, 5:02 a.m., Cong Wang wrote: > > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp, line 3927 > > > > > > You need to move this check into the script rather than in the C++ > >

Re: Review Request 47646: Updated the outdated website section in release-guide.md.

2016-05-20 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47646/#review134161 --- docs/release-guide.md (line 182)

Re: Review Request 47646: Updated the outdated website section in release-guide.md.

2016-05-20 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47646/ --- (Updated May 20, 2016, 5:29 p.m.) Review request for mesos, Tomasz

Re: Review Request 47646: Updated the outdated website section in release-guide.md.

2016-05-20 Thread haosdent huang
> On May 20, 2016, 5:01 p.m., Kevin Klues wrote: > > docs/release-guide.md, line 190 > > > > > > s/Noted/Note > > > > s/when build it/ > > s/when building it/ > > > > Is it obvious how to do

Re: Review Request 47646: Updated the outdated website section in release-guide.md.

2016-05-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47646/#review134177 --- Patch looks great! Reviews applied: [47646] Passed command:

Review Request 47641: Fix navbar alignment on large screen.

2016-05-20 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47641/ --- Review request for mesos, Freddy Ayuso-Henson, haosdent huang, Tim Anderegg,

Re: Review Request 47641: Fix navbar alignment on large screen.

2016-05-20 Thread Freddy Ayuso-Henson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47641/#review134121 --- Ship it! Ship It! - Freddy Ayuso-Henson On May 20, 2016,

Re: Review Request 47636: Fixed some coding error in mesos-ps.

2016-05-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47636/#review134118 --- Patch looks great! Reviews applied: [47636] Passed command:

Re: Review Request 47633: Isolation/networking: check if IPv6 is loaded before trying to disable it

2016-05-20 Thread Zhengju Sha
> On 五月 20, 2016, 5:09 a.m., haosdent huang wrote: > > Thank you for your patch. For summary and description, it should be limited > > in 72 characters, otherwise could not pass jenkins build. Yeah, I received the failed message. Thanks for the reminding! > On 五月 20, 2016, 5:09 a.m.,

Re: Review Request 47633: Isolation/networking: check if IPv6 is loaded before trying to disable it

2016-05-20 Thread haosdent huang
> On May 20, 2016, 5:02 a.m., Cong Wang wrote: > > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp, line 3927 > > > > > > You need to move this check into the script rather than in the C++ > >

Re: Review Request 47510: Adjusted style to make website mobile friendly.

2016-05-20 Thread Tomasz Janiszewski
> On May 20, 2016, 7:33 a.m., haosdent huang wrote: > > site/source/assets/css/main.css, lines 133-139 > > > > > > Thanks @janisz's keen eyesight, this make website navbar could not > > align vertically. He would

Re: Review Request 47641: Fix navbar alignment on large screen.

2016-05-20 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47641/#review134120 --- Ship it! Ship It! - haosdent huang On May 20, 2016, 8:16

Re: Review Request 47635: Removed /observe document.

2016-05-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47635/#review134125 --- Patch looks great! Reviews applied: [47635] Passed command:

Re: Review Request 47646: Updated the outdated website section in release-guide.md.

2016-05-20 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47646/#review134184 --- docs/release-guide.md (line 180)

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

2016-05-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47511/#review134145 --- Bad patch! Reviews applied: [47511] Failed command:

Review Request 47645: Updated the outdated website README.md.

2016-05-20 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47645/ --- Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and

Re: Review Request 47645: Updated the outdated website README.md.

2016-05-20 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47645/ --- (Updated May 20, 2016, 2:49 p.m.) Review request for mesos, Tomasz

Re: Review Request 47641: Fix navbar alignment on large screen.

2016-05-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47641/#review134130 --- Patch looks great! Reviews applied: [47641] Passed command:

Re: Review Request 47069: Added `user` field to `Task` protobuf message.

2016-05-20 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47069/#review134233 --- Do we not need to update other parts such as `bool

Re: Review Request 47633: Isolation/networking: check if IPv6 is loaded before trying to disable it

2016-05-20 Thread haosdent huang
> On May 20, 2016, 5:02 a.m., Cong Wang wrote: > > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp, line 3927 > > > > > > You need to move this check into the script rather than in the C++ > >

Re: Review Request 44839: Enabled mesos containerizer force_pull_image for appc.

2016-05-20 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44839/ --- (Updated 五月 21, 2016, 1:32 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 44839: Enabled mesos containerizer force_pull_image for appc.

2016-05-20 Thread Guangya Liu
> On 五月 20, 2016, 11:09 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/provisioner/appc/store.cpp, lines 223-224 > > > > > > The logic can be much clear if we dont have this log, but I guess we > > may

Re: Review Request 46498: Add runtime for Appc Spec ex: command, workingdir and environment.

2016-05-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46498/#review134229 --- Patch looks great! Reviews applied: [46498] Passed command:

Re: Review Request 46498: Add runtime for Appc Spec ex: command, workingdir and environment.

2016-05-20 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46498/ --- (Updated May 21, 2016, 12:24 a.m.) Review request for mesos, Gilbert Song, Jie

Review Request 47670: Windows: [1/2] Introduced `initialize()` for FlagsBase class.

2016-05-20 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47670/ --- Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joris

Re: Review Request 47671: Windows: [2/2] Used `initialize()` in FlagsBase's derived classes.

2016-05-20 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47671/ --- (Updated May 20, 2016, 10:14 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 47670: Windows: [1/2] Introduced `initialize()` for FlagsBase class.

2016-05-20 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47670/ --- (Updated May 20, 2016, 10:14 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 46613: Introduced filtering relevant actions and acls.

2016-05-20 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46613/ --- (Updated May 20, 2016, 9:03 p.m.) Review request for Adam B, Alexander Rojas

Re: Review Request 47633: Isolation/networking: check if IPv6 is loaded before trying to disable it

2016-05-20 Thread Cong Wang
> On May 20, 2016, 5:02 a.m., Cong Wang wrote: > > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp, line 3927 > > > > > > You need to move this check into the script rather than in the C++ > >

Re: Review Request 47386: Stout: Implemented `setHostname` on Windows.

2016-05-20 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47386/#review134202 --- Ship it! Ship It! - Joris Van Remoortere On May 14, 2016,

Re: Review Request 46613: Introduced filtering relevant actions and acls.

2016-05-20 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46613/ --- (Updated May 20, 2016, 9:05 p.m.) Review request for Adam B, Alexander Rojas

Re: Review Request 46874: Enhanced log message when launch mesos-containerizer.

2016-05-20 Thread Gilbert Song
> On May 20, 2016, 4:14 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 1189 > > > > > > Seems like the reporter in MESOS-5197 is requesting `LOG(INFO)`. Sorry > > for previous

Re: Review Request 47636: Fixed some coding error in mesos-ps.

2016-05-20 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47636/#review134219 --- Ship it! Ship It! - Vinod Kone On May 20, 2016, 6:07 a.m.,

Re: Review Request 46498: Add runtime for Appc Spec ex: command, workingdir and environment.

2016-05-20 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46498/ --- (Updated May 20, 2016, 10:59 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 47671: Windows: [2/2] Used `initialize()` in FlagsBase's derived classes.

2016-05-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47671/#review134216 --- Patch looks great! Reviews applied: [47473, 47492, 47486, 47474,

Re: Review Request 47645: Updated the outdated website README.md.

2016-05-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47645/#review134152 --- Patch looks great! Reviews applied: [47645] Passed command:

Review Request 47646: Updated the outdated website section in release-guide.md.

2016-05-20 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47646/ --- Review request for mesos, Tomasz Janiszewski, Kevin Klues, Neil Conway, and

Re: Review Request 47646: Updated the outdated website section in release-guide.md.

2016-05-20 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47646/ --- (Updated May 20, 2016, 3:34 p.m.) Review request for mesos, Tomasz

Re: Review Request 47646: Updated the outdated website section in release-guide.md.

2016-05-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47646/#review134159 --- Patch looks great! Reviews applied: [47646] Passed command: