Re: Review Request 47522: Added creator principal to persistent volume tests.

2016-05-23 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47522/#review134351 --- Ship it! Ship It! - Bernd Mathiske On May 18, 2016, 1:06

Re: Review Request 44154: Added appc_simple_discovery_uri_prefix to configuration.md.

2016-05-23 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44154/#review134372 --- Ship it! Ship It! - Jie Yu On May 23, 2016, 9:41 a.m.,

Re: Review Request 47719: Removed invalid gpu statistics columns in framework data tables.

2016-05-23 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47719/#review134374 --- I don't think we want to remove the headers. Instead, we want to

Re: Review Request 47520: Updated test helpers with creator principal.

2016-05-23 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47520/#review134348 --- Ship it! Ship It! - Bernd Mathiske On May 18, 2016, 1:04

Re: Review Request 47707: Refactored resource enumeration for containerizers and isolators.

2016-05-23 Thread Kevin Klues
> On May 23, 2016, 10:03 a.m., Guangya Liu wrote: > > Did not go to detail for now, but post one early comment: It is suggested > > that every patch should be atomic, which means that you should merge your > > patch https://reviews.apache.org/r/47708/ to this one to make sure the > > test

Re: Review Request 45377: Made "driver" as optional for DockerVolume.

2016-05-23 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45377/#review134401 --- include/mesos/mesos.proto (line 1624)

Re: Review Request 47719: Removed invalid gpu statistics columns in framework data tables.

2016-05-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47719/#review134406 --- Patch looks great! Reviews applied: [47719] Passed command:

Re: Review Request 47719: Removed invalid gpu statistics columns in framework data tables.

2016-05-23 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47719/ --- (Updated May 23, 2016, 4:56 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 47409: Libprocess: Implemented `HANDLE` versions of file descriptor functions.

2016-05-23 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47409/ --- (Updated May 23, 2016, 5:04 p.m.) Review request for mesos, Daniel Pravat,

Review Request 47732: Fixed a race in long lived executor.

2016-05-23 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47732/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 47719: Removed invalid gpu statistics columns in framework data tables.

2016-05-23 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47719/ --- (Updated May 23, 2016, 6:11 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 47719: Removed invalid gpu statistics columns in framework data tables.

2016-05-23 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47719/ --- (Updated May 23, 2016, 4:40 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 47719: Removed invalid gpu statistics columns in framework data tables.

2016-05-23 Thread haosdent huang
> On May 23, 2016, 4:16 p.m., Kevin Klues wrote: > > I don't think we want to remove the headers. Instead, we want to add > > column bodies with 0 values or "N/A" ass appropriate. > > haosdent huang wrote: > Got it, already updated. Let me upload the screenshots as well. Just update the

Re: Review Request 47608: Add Labels from TaskInfo into TaskStatus message.

2016-05-23 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47608/#review134388 --- Is there a use case or JIRA ticket for this change? Wanted to

Re: Review Request 47719: Removed invalid gpu statistics columns in framework data tables.

2016-05-23 Thread haosdent huang
> On May 23, 2016, 5:29 p.m., Kevin Klues wrote: > > Looks good. Just curous -- how did you upload the pictures to the testing > > section? Is there someway to make them smaller next time? LoL I upload it via jira and use `![](image_link)` to show it in reviewboard. Seems reviewboard don't

Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-23 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47695/#review134403 --- site/Rakefile (line 75)

Re: Review Request 47706: Provided defaults for all virtual functions in `mesos::slave::Isolator'.

2016-05-23 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47706/#review134415 --- Ship it! Ship It! - Benjamin Mahler On May 23, 2016, 7:06

Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-23 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47695/#review134408 --- site/README.md (line 9)

Re: Review Request 47719: Removed invalid gpu statistics columns in framework data tables.

2016-05-23 Thread haosdent huang
> On May 23, 2016, 4:16 p.m., Kevin Klues wrote: > > I don't think we want to remove the headers. Instead, we want to add > > column bodies with 0 values or "N/A" ass appropriate. Got it, already updated. Let me upload the screenshots as well. - haosdent

Re: Review Request 47389: Stout: Added support for correct path delimiters in Windows.

2016-05-23 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47389/ --- (Updated May 23, 2016, 5:03 p.m.) Review request for mesos, Daniel Pravat,

Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-23 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47695/#review134404 --- support/site-docker/Dockerfile (line 10)

Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-23 Thread haosdent huang
> On May 23, 2016, 7:50 a.m., Tomasz Janiszewski wrote: > > Hi, @janisz. Thank you very much for your detail reviews, may you help to review this patch again? Thank you in advance. - haosdent --- This is an automatically generated

Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-23 Thread haosdent huang
> On May 23, 2016, 7:50 a.m., Tomasz Janiszewski wrote: > > site/Dockerfile, line 1 > > > > > > Why not officail [Ruby image](https://hub.docker.com/_/ruby/) Yes, we could not use it because ruby images based on

Re: Review Request 47719: Removed invalid gpu statistics columns in framework data tables.

2016-05-23 Thread Kevin Klues
Can you also link the issue back to the review in JIRA: Workflow -> Post Review https://issues.apache.org/jira/browse/MESOS-5436 On Mon, May 23, 2016 at 11:02 AM, haosdent huang wrote: > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 47594: Skipped the bind mount of CNI net info root dir if possible.

2016-05-23 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47594/#review134380 --- Fix it, then Ship it!

Re: Review Request 47608: Add Labels from TaskInfo into TaskStatus message.

2016-05-23 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47608/#review134390 --- src/tests/slave_tests.cpp (line 3265)

Re: Review Request 47719: Removed invalid gpu statistics columns in framework data tables.

2016-05-23 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47719/#review134395 --- Ship it! Looks good. Just curous -- how did you upload the

Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-23 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47695/ --- (Updated May 23, 2016, 5:49 p.m.) Review request for mesos, Tomasz

Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-23 Thread haosdent huang
> On May 22, 2016, 5:46 p.m., Vinod Kone wrote: > > site/Rakefile, line 5 > > > > > > shouldn't the "build" task happen after "doxygen" and "javadoc"? According my test, there are not differences not matter we put it

Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-23 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47695/#review134400 --- site/Gemfile.lock (line 100)

Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-23 Thread Tomasz Janiszewski
> On May 23, 2016, 7:50 a.m., Tomasz Janiszewski wrote: > > > > haosdent huang wrote: > Hi, @janisz. Thank you very much for your detail reviews, may you help to > review this patch again? Thank you in advance. Tested. LGTM but I left some minor comments. - Tomasz

Re: Review Request 44837: Added force_pull_image to Image protobuf.

2016-05-23 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44837/#review134418 --- include/mesos/mesos.proto (line 1580)

Re: Review Request 47732: Fixed a race in long lived executor.

2016-05-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47732/#review134421 --- Patch looks great! Reviews applied: [47732] Passed command:

Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47695/#review134425 --- Patch looks great! Reviews applied: [47695] Passed command:

Re: Review Request 47707: Refactored resource enumeration for containerizers and isolators.

2016-05-23 Thread Kevin Klues
> On May 23, 2016, 7:56 p.m., Benjamin Mahler wrote: > > src/slave/containerizer/composing.cpp, lines 276-280 > > > > > > How about "managed" and "manage" instead of "enumerated" and > > "enumerate" here? It seems

Re: Review Request 46892: Postponed closing std streams of the docker task until after reaping.

2016-05-23 Thread Alexander Rukletsov
> On May 17, 2016, 7:24 p.m., Alexander Rukletsov wrote: > > src/docker/executor.cpp, line 358 > > > > > > Why this change? > > Martin Bydzovsky wrote: > Geeez, do I really have to repeat myself milion times?

Re: Review Request 47702: Added framework role & principal to the Web UI.

2016-05-23 Thread Deshna Jain
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47702/ --- (Updated May 23, 2016, 9:08 p.m.) Review request for mesos, haosdent huang and

Re: Review Request 47702: Added framework role & principal to the Web UI.

2016-05-23 Thread Deshna Jain
> On May 23, 2016, 1:03 a.m., haosdent huang wrote: > > Do you forget to update > > * `framework.html` > > https://github.com/apache/mesos/blob/master/src/webui/master/static/framework.html#L24 > > * `agent.html` > >

Re: Review Request 47732: Fixed a race in long lived executor.

2016-05-23 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47732/#review134419 --- Ship it! Ship It! - Vinod Kone On May 23, 2016, 5:29 p.m.,

Re: Review Request 44838: Enabled mesos containerizer force_pull_image for docker.

2016-05-23 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44838/#review134420 --- Fix it, then Ship it!

Re: Review Request 47707: Refactored resource enumeration for containerizers and isolators.

2016-05-23 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47707/#review134414 --- src/slave/containerizer/composing.cpp (lines 276 - 280)

Re: Review Request 47515: Enforced a constraint on `DiskInfo.Persistence.principal`.

2016-05-23 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47515/#review134345 --- Ship it! Ship It! - Bernd Mathiske On May 22, 2016, 9:37

Re: Review Request 47528: Updated validation tests with creator principal.

2016-05-23 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47528/#review134346 --- src/tests/master_validation_tests.cpp (line 451)

Re: Review Request 47519: Updated an example framework to specify its principal.

2016-05-23 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47519/#review134347 --- Ship it! Ship It! - Bernd Mathiske On May 18, 2016, 1:04

Re: Review Request 47374: Experimental: Separated mesos test helpers into a separate library.

2016-05-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47374/#review134512 --- Patch looks great! Reviews applied: [47374] Passed command:

Re: Review Request 47162: Libprocess: Made some of the tests work on Windows.

2016-05-23 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47162/#review134484 --- Fix it, then Ship it!

Re: Review Request 47528: Updated validation tests with creator principal.

2016-05-23 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47528/ --- (Updated May 24, 2016, 4:44 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 47528: Updated validation tests with creator principal.

2016-05-23 Thread Greg Mann
> On May 23, 2016, 2:06 p.m., Bernd Mathiske wrote: > > src/tests/master_validation_tests.cpp, line 454 > > > > > > Where are we setting the principal for DiskInfo.Persistence? > > > > How is this block of

Re: Review Request 47707: Refactored resource enumeration for containerizers and isolators.

2016-05-23 Thread Kevin Klues
> On May 23, 2016, 7:56 p.m., Benjamin Mahler wrote: > > src/slave/containerizer/containerizer.hpp, lines 64-68 > > > > > > Hm.. it seems more like the default set of resources would not include > > the flags. > >

Re: Review Request 46613: Introduced filtering relevant actions and acls.

2016-05-23 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46613/#review134515 --- include/mesos/authorizer/acls.proto (line 165)

Re: Review Request 47216: Wired up the new docker environment hook.

2016-05-23 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47216/#review134508 --- src/slave/containerizer/docker.cpp (line 1042)

Re: Review Request 47150: Implemented new asynchronous docker pre-launch hook.

2016-05-23 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47150/#review134505 --- include/mesos/hook.hpp (line 112)

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

2016-05-23 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47511/ --- (Updated May 24, 2016, 4:11 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 44839: Enabled mesos containerizer force_pull_image for appc.

2016-05-23 Thread Jie Yu
> On May 23, 2016, 9:15 p.m., Jie Yu wrote: > > Please make sure to a manual test. Why adding unit test is hard? - Jie --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44839/#review134437

Re: Review Request 44839: Enabled mesos containerizer force_pull_image for appc.

2016-05-23 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44839/#review134437 --- src/slave/containerizer/mesos/provisioner/appc/store.cpp (line

Re: Review Request 46435: Added the test "CniIsolatorTest.ROOT_VerifyCheckpointedInfo".

2016-05-23 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46435/#review134445 --- Ship it! Ship It! - Jie Yu On May 12, 2016, 8:12 a.m., Qian

Re: Review Request 46436: Added the test "CniIsolatorTest.ROOT_FailedPlugin".

2016-05-23 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46436/#review134446 --- Ship it! Ship It! - Jie Yu On May 12, 2016, 8:13 a.m., Qian

Re: Review Request 45952: Implemented support for passing agent default docker config.

2016-05-23 Thread Gilbert Song
> On April 11, 2016, 12:37 a.m., Guangya Liu wrote: > > src/uri/fetchers/docker.cpp, lines 323-325 > > > > > > Does there are any document change for this? Unfortunately, we dont have document for docker fetcher

Re: Review Request 47374: Experimental: Separated mesos test helpers into a separate library.

2016-05-23 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47374/#review134476 --- Looks ok to me, but I'd love for @jieyu or @karya or @tillt to

Re: Review Request 45668: Enable CMake build.

2016-05-23 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45668/#review134489 --- can you rebase this off the latest master branch and push an

Re: Review Request 47403: Stout: Set `_fmode` to binary in `protobuf.hpp`.

2016-05-23 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47403/#review134470 --- 3rdparty/stout/include/stout/protobuf.hpp (lines 122 - 124)

Re: Review Request 47411: Agent: Changed the names of symbols that are ambiguous on MSVC.

2016-05-23 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47411/#review134471 --- I'll update this to remove the bad merge. src/slave/slave.cpp

Re: Review Request 47389: Stout: Added support for correct path delimiters in Windows.

2016-05-23 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47389/#review134464 --- 3rdparty/stout/include/stout/os/mkdir.hpp (line 51)

Re: Review Request 45668: Enable CMake build.

2016-05-23 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45668/#review134488 --- Ship it! Ship It! - Vinod Kone On May 22, 2016, 8:15 p.m.,

Re: Review Request 47702: Added framework role & principal to the Web UI.

2016-05-23 Thread haosdent huang
> On May 23, 2016, 1:03 a.m., haosdent huang wrote: > > Do you forget to update > > * `framework.html` > > https://github.com/apache/mesos/blob/master/src/webui/master/static/framework.html#L24 > > * `agent.html` > >

Re: Review Request 47374: Experimental: Separated mesos test helpers into a separate library.

2016-05-23 Thread Joseph Wu
> On May 23, 2016, 5:09 p.m., Adam B wrote: > > src/Makefile.am, lines 1937-1938 > > > > > > Why does libmesos_tests_la_SOURCES need to include qos_controllers code? I don't remember the exact reason, but one of

Re: Review Request 44839: Enabled mesos containerizer do not cache image for appc.

2016-05-23 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44839/ --- (Updated 五月 24, 2016, 2:01 a.m.) Review request for mesos, Gilbert Song,

Re: Review Request 47374: Experimental: Separated mesos test helpers into a separate library.

2016-05-23 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47374/ --- (Updated May 23, 2016, 7:02 p.m.) Review request for mesos, Adam B, Artem

Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-23 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47695/ --- (Updated May 24, 2016, 2:38 a.m.) Review request for mesos, Tomasz

Review Request 47754: Enabled building stout tests without building 3rdparty first.

2016-05-23 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47754/ --- Review request for mesos, Joris Van Remoortere and Till Toenshoff. Bugs:

Review Request 47756: Stout: `make tests` now automatically builds dependencies.

2016-05-23 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47756/ --- Review request for mesos, Joris Van Remoortere and Till Toenshoff. Bugs:

Review Request 47755: Libprocess: `make tests` now automatically builds dependencies.

2016-05-23 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47755/ --- Review request for mesos, Joris Van Remoortere and Till Toenshoff. Bugs:

Review Request 47753: Enabled building libprocess without building 3rdparty first.

2016-05-23 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47753/ --- Review request for mesos, Joris Van Remoortere and Till Toenshoff. Bugs:

Re: Review Request 47752: Added build-stamp files for gmock/glog/http-parse/libev.

2016-05-23 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47752/ --- (Updated May 23, 2016, 10:50 p.m.) Review request for mesos, Joris Van

Re: Review Request 47212: Removed duplicate call to containerizer::executorEnvironment.

2016-05-23 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47212/#review134500 --- src/slave/containerizer/docker.cpp (line 1195)

Re: Review Request 47213: Added FlagsBase::toVector method as an alternative to stringify(flags).

2016-05-23 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47213/#review134502 --- Ship it! 3rdparty/stout/include/stout/flags/flags.hpp (line

Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-23 Thread haosdent huang
> On May 23, 2016, 6:31 p.m., Tomasz Janiszewski wrote: > > site/README.md, line 12 > > > > > > Running this command will end up with error: `unable to prepare > > context: unable to evaluate symlinks in context

Re: Review Request 47695: Updated the website generation and development workflows with docker.

2016-05-23 Thread haosdent huang
> On May 23, 2016, 6:31 p.m., Tomasz Janiszewski wrote: > > Hi, @janisz Really appreciate your favour to help test this! Just updated, may you help to review this again? Thank you in advance. - haosdent --- This is an automatically

Re: Review Request 47214: Replaced subprocess flag stringification with flags.toVector().

2016-05-23 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47214/#review134503 --- Ship it! Ship It! - Kapil Arya On May 16, 2016, 2:01 p.m.,

Re: Review Request 47374: Experimental: Separated mesos test helpers into a separate library.

2016-05-23 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47374/ --- (Updated May 23, 2016, 7 p.m.) Review request for mesos, Adam B, Artem

Re: Review Request 44839: Enabled mesos containerizer do not cache image for appc.

2016-05-23 Thread Guangya Liu
> On 五月 23, 2016, 9:15 p.m., Jie Yu wrote: > > > > Jie Yu wrote: > Please make sure to a manual test. Why adding unit test is hard? Yes, test manually. If adding a new unit test, I did not found a good way to check if the image was pulled from repo or just copied from local cache, any

Re: Review Request 47149: Split DockerContainerizerProcess::launch into two functions.

2016-05-23 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47149/#review134497 --- Ship it! - Kapil Arya On May 10, 2016, 10:13 p.m., Joseph Wu

Re: Review Request 44839: Enabled mesos containerizer do not cache image for appc.

2016-05-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44839/#review134498 --- Patch looks great! Reviews applied: [44837, 44838, 44839]

Re: Review Request 47205: Added optional environment variable argument to mesos-docker-executor.

2016-05-23 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47205/#review134499 --- src/docker/executor.hpp (lines 80 - 107)

Re: Review Request 47215: Changed the dockerized docker command executor CommandInfo usage.

2016-05-23 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47215/#review134504 --- Ship it! Ship It! - Kapil Arya On May 10, 2016, 10:13 p.m.,

Re: Review Request 46438: Added the test "CniIsolatorTest.ROOT_SlaveRecovery".

2016-05-23 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46438/ --- (Updated May 24, 2016, 11:20 a.m.) Review request for mesos, Avinash sridharan

Re: Review Request 46097: Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".

2016-05-23 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46097/#review134442 --- Ship it! Ship It! - Jie Yu On May 12, 2016, 8:11 a.m., Qian

Re: Review Request 45949: Implemented docker config get credential helper.

2016-05-23 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45949/ --- (Updated May 23, 2016, 2:51 p.m.) Review request for mesos, Guangya Liu, Artem

Re: Review Request 45952: Implemented support for passing agent default docker config.

2016-05-23 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45952/ --- (Updated May 23, 2016, 2:52 p.m.) Review request for mesos, Guangya Liu, Artem

Re: Review Request 47702: Added framework role & principal to the Web UI.

2016-05-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47702/#review134458 --- Patch looks great! Reviews applied: [47702] Passed command:

Re: Review Request 45949: Implemented docker config get credential helper.

2016-05-23 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45949/#review134469 --- src/docker/spec.cpp (line 162)

Re: Review Request 45951: Implemented http basic auth to get docker auth token.

2016-05-23 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45951/ --- (Updated May 23, 2016, 2:51 p.m.) Review request for mesos, Guangya Liu, Artem

Re: Review Request 45950: Added test for docker spec get credential helper.

2016-05-23 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45950/ --- (Updated May 23, 2016, 2:51 p.m.) Review request for mesos, Guangya Liu, Artem

Re: Review Request 47199: Implemented parsing docker labels in v1 spec.

2016-05-23 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47199/#review134454 --- Ship it! Ship It! - Jie Yu On May 13, 2016, 8:49 p.m.,

Re: Review Request 47200: Modified docker spec test for docker label support.

2016-05-23 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47200/#review134455 --- Ship it! Ship It! - Jie Yu On May 12, 2016, 3:56 a.m.,

Re: Review Request 45377: Made "driver" as optional for DockerVolume.

2016-05-23 Thread Guangya Liu
> On 五月 23, 2016, 5:55 p.m., Jie Yu wrote: > > include/mesos/mesos.proto, line 1627 > > > > > > Please do not change the tag number. Can you please show more detail for why do not change the tag number? This

Re: Review Request 47199: Implemented parsing docker labels in v1 spec.

2016-05-23 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47199/#review134466 --- src/docker/spec.cpp (lines 207 - 230)

Re: Review Request 47489: Windows: Symplified `os::exists`.

2016-05-23 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47489/ --- (Updated May 23, 2016, 9:36 p.m.) Review request for mesos, Alex Naparu, Artem

Re: Review Request 45950: Added test for docker spec get credential helper.

2016-05-23 Thread Gilbert Song
> On April 10, 2016, 10:20 p.m., Guangya Liu wrote: > > Good catch! Thanks!! - Gilbert --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45950/#review128042

Re: Review Request 45949: Implemented docker config get credential helper.

2016-05-23 Thread Gilbert Song
> On April 10, 2016, 10:19 p.m., Guangya Liu wrote: > > src/docker/spec.cpp, lines 172-175 > > > > > > I did not found any link which telling me that "many registry domain > > recorded in docker config file does

  1   2   >