Re: Review Request 52569: Updated the nested container launch to correctly determine the user.

2016-10-12 Thread Gilbert Song
> On Oct. 12, 2016, 11:46 a.m., Gilbert Song wrote: > > src/slave/http.cpp, lines 1964-1965 > > > > > > Would you mind removing this `TODO`? They are no longer valid. I will follow up with a patch. Sorry not

Re: Review Request 52569: Updated the nested container launch to correctly determine the user.

2016-10-12 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52569/#review151564 --- src/slave/http.cpp (lines 1964 - 1965)

Re: Review Request 52563: Minor clean ups in `health_check_tests.cpp` for consistency.

2016-10-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52563/#review152376 --- Patch looks great! Reviews applied: [52786, 52250, 52251, 52560,

Re: Review Request 52412: Supported logger with nested containers in Mesos Containerizer.

2016-10-12 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52412/ --- (Updated Oct. 12, 2016, 11:39 a.m.) Review request for mesos, Artem

Re: Review Request 52647: Fix new sign comparison errors produced by hardened flags

2016-10-12 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52647/#review152378 --- As mentioned elsewhere, can you split stout and libprocess

Re: Review Request 52740: Refactored some code into a separate function.

2016-10-12 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52740/ --- (Updated Oct. 12, 2016, 7:34 p.m.) Review request for mesos and Vinod Kone.

Review Request 52801: Changed description of TASK_GONE.

2016-10-12 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52801/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6332

Re: Review Request 52746: Changed agent to send TASK_DROPPED for task launch failures.

2016-10-12 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52746/ --- (Updated Oct. 12, 2016, 7:35 p.m.) Review request for mesos and Vinod Kone.

Review Request 52798: Windows: Implemented os::execvpe with _spawnvpe.

2016-10-12 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52798/ --- Review request for mesos, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, Jie

Re: Review Request 52798: Windows: Implemented os::execvpe with _spawnvpe.

2016-10-12 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52798/#review152382 --- Ship it! Ship It! - Jie Yu On Oct. 12, 2016, 7:20 p.m.,

Review Request 52802: Added a new slave metric, "tasks_gone".

2016-10-12 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52802/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6332

Review Request 52803: Changed agent to send TASK_GONE.

2016-10-12 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52803/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6332

Re: Review Request 40266: Libprocess Reinit: Cleanup SocketManager alongside ProcessManager.

2016-10-12 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40266/ --- (Updated Oct. 12, 2016, 1:48 p.m.) Review request for mesos, Greg Mann, Artem

Re: Review Request 51769: Implemented `delegate` method.

2016-10-12 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51769/ --- (Updated Oct. 12, 2016, 8:54 p.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 51486: Added `execute` method.

2016-10-12 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51486/ --- (Updated Oct. 12, 2016, 8:55 p.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 51617: Added the `remove` and `insert` methods.

2016-10-12 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51617/ --- (Updated Oct. 12, 2016, 8:55 p.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 52412: Supported logger with nested containers in Mesos Containerizer.

2016-10-12 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52412/ --- (Updated Oct. 12, 2016, 2:06 p.m.) Review request for mesos, Artem

Re: Review Request 40410: Libprocess Reinit: Move MetricsProcess instantiation into process.cpp.

2016-10-12 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40410/ --- (Updated Oct. 12, 2016, 2:25 p.m.) Review request for mesos, Greg Mann, Artem

Re: Review Request 40413: Libprocess Reinit: Move ReaperProcess instantiation into process.cpp.

2016-10-12 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40413/ --- (Updated Oct. 12, 2016, 2:25 p.m.) Review request for mesos, Greg Mann, Artem

Re: Review Request 51049: Libprocess Reinit: Removed authorizer callback leaks.

2016-10-12 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51049/ --- (Updated Oct. 12, 2016, 2:25 p.m.) Review request for mesos, Greg Mann, Artem

Re: Review Request 40512: Libprocess Reinit: Add a test-only method to reinitialize libprocess.

2016-10-12 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40512/ --- (Updated Oct. 12, 2016, 2:25 p.m.) Review request for mesos, Greg Mann, Artem

Re: Review Request 50621: Libprocess reinit: Moved HttpProxy finalization and destruction.

2016-10-12 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50621/ --- (Updated Oct. 12, 2016, 2:25 p.m.) Review request for mesos, Greg Mann, Artem

Re: Review Request 52470: Filled missing executor info in tasks when `LAUNCH_GROUP`.

2016-10-12 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52470/#review152404 --- src/master/validation.cpp (line 1115)

Re: Review Request 40411: Libprocess Reinit: Modify test to use PID.

2016-10-12 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40411/ --- (Updated Oct. 12, 2016, 2:25 p.m.) Review request for mesos, Greg Mann, Artem

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

2016-10-12 Thread Megha Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52058/ --- (Updated Oct. 12, 2016, 9:38 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52412: Supported logger with nested containers in Mesos Containerizer.

2016-10-12 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52412/#review152406 --- Ship it! Ship It! - Joseph Wu On Oct. 12, 2016, 2:06 p.m.,

Review Request 52771: Captured the `stderr` during execution of CNI plugin.

2016-10-12 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52771/ --- Review request for mesos, Jie Yu and Qian Zhang. Bugs: MESOS-6282

Review Request 52772: Added a filter for '_CNIPLUGINS_'.

2016-10-12 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52772/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6348

Re: Review Request 52756: Invoke the shutdown executor callback for checkpointed frameworks.

2016-10-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52756/#review152283 --- Patch looks great! Reviews applied: [52755, 52756] Passed

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

2016-10-12 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/#review152277 --- src/slave/containerizer/docker.cpp (lines 643 - 696)

Re: Review Request 52520: Exposed the executor's type in the endpoints.

2016-10-12 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52520/ --- (Updated Oct. 12, 2016, 9:29 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 52470: Filled missing executor info in tasks when `LAUNCH_GROUP`.

2016-10-12 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52470/ --- (Updated Oct. 12, 2016, 9:29 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 52471: Fixed the wrong sandbox directory of the tasks in Web UI.

2016-10-12 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52471/ --- (Updated Oct. 12, 2016, 9:29 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 52664: Moved the `decimalFloat` filter to app.js for consistency.

2016-10-12 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52664/ --- (Updated Oct. 12, 2016, 9:29 a.m.) Review request for mesos, Anand Mazumdar

Review Request 52779: Reimplement test macros without (non-standard) statement expressions.

2016-10-12 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52779/ --- Review request for mesos, Daniel Pravat and Joseph Wu. Repository: mesos

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

2016-10-12 Thread Guangya Liu
> On 十月 9, 2016, 10:37 a.m., Guangya Liu wrote: > > src/docker/docker.hpp, lines 95-120 > > > > > > What about moving this to https://reviews.apache.org/r/50125/ where > > this will be used. > > Yubo Li wrote: >

Re: Review Request 52556: Added the MESOS_RUNTIME_DIRECTORY executor env variable.

2016-10-12 Thread Alexander Rukletsov
> On Oct. 10, 2016, 3:32 p.m., Jiang Yan Xu wrote: > > src/launcher/executor.cpp, lines 903-910 > > > > > > You didn't start this but I wonder why we can't consistently use the > > flags, which can be provided

Re: Review Request 52471: Fixed the wrong sandbox directory of the tasks in Web UI.

2016-10-12 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52471/ --- (Updated Oct. 12, 2016, 9:32 a.m.) Review request for mesos, Anand Mazumdar

Review Request 52778: Added Windows support to Agent test environment harness.

2016-10-12 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52778/ --- Review request for mesos, Daniel Pravat and Joseph Wu. Repository: mesos

Re: Review Request 52639: Added test for `recovered` AgentID and `AGENT_ADDED` after reregister.

2016-10-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52639/#review152290 --- Patch looks great! Reviews applied: [52637, 52638, 52765, 52639]

Re: Review Request 52470: Filled missing executor info in tasks when `LAUNCH_GROUP`.

2016-10-12 Thread haosdent huang
> On Oct. 12, 2016, 12:08 a.m., Vinod Kone wrote: > > src/master/master.cpp, lines 3529-3555 > > > > > > I think we might want to mutate TaskInfo here so that authorization can > > use that information. > > >

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

2016-10-12 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/#review152287 --- src/docker/docker.hpp (lines 107 - 123)

Re: Review Request 52470: Filled missing executor info in tasks when `LAUNCH_GROUP`.

2016-10-12 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52470/ --- (Updated Oct. 12, 2016, 10:02 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 52288: Recover resources when offer is rescinded on DESTROY of shared volume.

2016-10-12 Thread Jiang Yan Xu
> On Oct. 12, 2016, 8:20 a.m., Jiang Yan Xu wrote: > > src/tests/persistent_volume_tests.cpp, lines 1125-1128 > > > > > > We have reduced the number of places that advance time to one, we can > > just pull the

Re: Review Request 52769: Removed ports ranges benchmark test from scalar benchmark test.

2016-10-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52769/#review152297 --- Patch looks great! Reviews applied: [52599, 50556, 50551, 51033,

Re: Review Request 52250: Added test cases for HTTP health check.

2016-10-12 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52250/ --- (Updated Oct. 12, 2016, 2:37 p.m.) Review request for mesos, Alexander

Re: Review Request 52561: Renamed `flags` to `agentFlags` in health check test cases.

2016-10-12 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52561/ --- (Updated Oct. 12, 2016, 2:38 p.m.) Review request for mesos, Alexander

Re: Review Request 52695: Harden libprocess

2016-10-12 Thread Aaron Wood
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52695/#review152315 --- 3rdparty/libprocess/Makefile.am (line 29)

Re: Review Request 52696: Harden stout

2016-10-12 Thread Aaron Wood
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52696/#review152316 --- 3rdparty/stout/Makefile.am (line 26)

Re: Review Request 51715: Added a parallel gtest runner.

2016-10-12 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51715/#review152322 --- Ship it! Ship It! - Kevin Klues On Oct. 11, 2016, 8:18

Re: Review Request 52707: Updated CLI bootstrap to search for local virtualenv installations.

2016-10-12 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52707/#review152321 --- Ship it! Ship It! - Kevin Klues On Oct. 10, 2016, 9:42

Review Request 52786: Add the health check test helper.

2016-10-12 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52786/ --- Review request for mesos, Alexander Rukletsov and Gastón Kleiman. Bugs:

Re: Review Request 52288: Recover resources when offer is rescinded on DESTROY of shared volume.

2016-10-12 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52288/#review152282 --- Ship it! Committing with these cleanups.

Re: Review Request 51715: Added a parallel gtest runner.

2016-10-12 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51715/ --- (Updated Oct. 12, 2016, 5:28 p.m.) Review request for mesos, Kevin Klues and

Re: Review Request 52741: Added capabilities support to mesos-execute.

2016-10-12 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52741/ --- (Updated Oct. 12, 2016, 4:31 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 52563: Minor clean ups in `health_check_tests.cpp` for consistency.

2016-10-12 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52563/ --- (Updated Oct. 12, 2016, 2:38 p.m.) Review request for mesos, Alexander

Re: Review Request 52251: Added test cases for TCP health check.

2016-10-12 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52251/ --- (Updated Oct. 12, 2016, 2:37 p.m.) Review request for mesos, Alexander

Re: Review Request 52288: Recover resources when offer is rescinded on DESTROY of shared volume.

2016-10-12 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52288/#review152323 --- src/tests/persistent_volume_tests.cpp (lines 1079 - 1086)

Re: Review Request 52560: Avoided temporary `MockDocker` pointers in health check test cases.

2016-10-12 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52560/ --- (Updated Oct. 12, 2016, 2:38 p.m.) Review request for mesos, Alexander

Re: Review Request 52741: Added capabilities support to mesos-execute.

2016-10-12 Thread Benjamin Bannier
> On Oct. 12, 2016, 7:43 a.m., Jie Yu wrote: > > src/cli/execute.cpp, line 298 > > > > > > Why string? Can this be `Option`? This requires I/O support for `v1::CapabilityInfo`. I added these in the preceeding rr

Re: Review Request 52741: Added capabilities support to mesos-execute.

2016-10-12 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52741/ --- (Updated Oct. 12, 2016, 2:49 p.m.) Review request for mesos and Jie Yu.

Review Request 52780: Added input and output functions for v1::CapabilityInfo.

2016-10-12 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52780/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 52774: Added a test for verifying nested container environment.

2016-10-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52774/#review152305 --- Patch looks great! Reviews applied: [52774] Passed command:

Review Request 52783: Added documentation for mesos-containerizer Linux capabilities support.

2016-10-12 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52783/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6376

Review Request 52784: Added MESOS-5275 to the CHANGELOG.

2016-10-12 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52784/ --- Review request for mesos. Bugs: MESOS-5275

Review Request 52773: Added a loopback test with CNI ptp plugin.

2016-10-12 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52773/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6348

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

2016-10-12 Thread Yubo Li
> On 十月 9, 2016, 10:16 a.m., Guangya Liu wrote: > > src/slave/containerizer/docker.hpp, line 76 > > > > > > This will cause build failed on Mac OS as `NvidiaGpuAllocator` was only > > defined in linux > >

Re: Review Request 50123: Added GPU scheduler for docker containerizer process.

2016-10-12 Thread Yubo Li
> On 十月 12, 2016, 5:52 a.m., Guangya Liu wrote: > > src/tests/mock_docker.hpp, line 40 > > > > > > include `components.hpp` is good enough. Thanks! I'll test in my mac soon. - Yubo

Re: Review Request 51716: Added configure option for Mesos test runner.

2016-10-12 Thread Till Toenshoff
> On Oct. 10, 2016, 3:28 p.m., Till Toenshoff wrote: > > configure.ac, lines 616-617 > > > > > > Not a biggy but maybe it is a good idea to make this better readable / > > parseable by creating a local temporary

Re: Review Request 52638: Populated `recovered_agents` field in `GetAgents` response.

2016-10-12 Thread Zhitao Li
> On Oct. 10, 2016, 6:53 p.m., Anand Mazumdar wrote: > > Would you be following up with the change to `/state` in a separate review? Done. r/52765 - Zhitao --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 51740: Added the 'name' and 'args' field to the 'delegate' plugin's CNI config.

2016-10-12 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51740/#review152343 --- Ship it! Ship It! - Jie Yu On Sept. 28, 2016, 7:29 p.m.,

Re: Review Request 51767: Added constants for CNI commands.

2016-10-12 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51767/#review152344 --- Ship it! Ship It! - Jie Yu On Sept. 28, 2016, 7:29 p.m.,

Re: Review Request 51009: Collect throttle related cpu.stat for Docker Containerizer.

2016-10-12 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51009/ --- (Updated Oct. 12, 2016, 5 p.m.) Review request for mesos, Xiaojian Huang,

Re: Review Request 52645: Harden Mesos

2016-10-12 Thread Aaron Wood
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52645/#review152381 --- src/Makefile.am (line 112)

Re: Review Request 52787: Set `runtime_dir` to a temporary folder in `mesos-local`.

2016-10-12 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52787/#review152408 --- Ship it! Ship It! - Kevin Klues On Oct. 12, 2016, 4:13

Review Request 52810: Added tests to test usernamespaces.

2016-10-12 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52810/ --- Review request for mesos, Gilbert Song and Jie Yu. Repository: mesos

Re: Review Request 52597: Added more detailed error message when failing in MountInfoTable::read.

2016-10-12 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52597/ --- (Updated Oct. 12, 2016, 11:05 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 45967: Added documentation for shareable resources.

2016-10-12 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45967/#review152236 --- High-level comments: 1. We should tailor this towards the

Re: Review Request 52703: Added test to test corner cases with sorted 'MountInfoTable::read()'.

2016-10-12 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52703/ --- (Updated Oct. 12, 2016, 11:11 p.m.) Review request for mesos and Jie Yu.

Review Request 52811: Updated 'MountInfoTableReadSorted' test to use a hashset.

2016-10-12 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52811/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6118

Re: Review Request 51052: Make mesos-docker-execute understand cgroups_enable_cfs.

2016-10-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51052/#review152415 --- Patch looks great! Reviews applied: [51052] Passed command:

Re: Review Request 52755: Made default executor handle shutdown events while disconnected.

2016-10-12 Thread Anand Mazumdar
> On Oct. 12, 2016, 10:52 p.m., Vinod Kone wrote: > > src/launcher/default_executor.cpp, line 700 > > > > > > can you add a comment on how this can happen when we are in `CONNECTED` > > state? it's not obvious to

Re: Review Request 52569: Updated the nested container launch to correctly determine the user.

2016-10-12 Thread Benjamin Mahler
> On Oct. 12, 2016, 6:46 p.m., Gilbert Song wrote: > > src/slave/http.cpp, lines 1964-1965 > > > > > > Would you mind removing this `TODO`? They are no longer valid. > > Gilbert Song wrote: > I will follow up

Re: Review Request 52756: Invoke the shutdown executor callback for checkpointed frameworks.

2016-10-12 Thread Anand Mazumdar
> On Oct. 12, 2016, 10:56 p.m., Vinod Kone wrote: > > src/executor/executor.cpp, line 734 > > > > > > I think this should call `_shutdown()` to ensure ShutdownProcess is > > spawned whenever we want to shutdown.

Re: Review Request 52756: Invoke the shutdown executor callback for checkpointed frameworks.

2016-10-12 Thread Vinod Kone
> On Oct. 12, 2016, 10:56 p.m., Vinod Kone wrote: > > src/executor/executor.cpp, line 734 > > > > > > I think this should call `_shutdown()` to ensure ShutdownProcess is > > spawned whenever we want to shutdown. >

Re: Review Request 52787: Set `runtime_dir` to a temporary folder in `mesos-local`.

2016-10-12 Thread Kevin Klues
> On Oct. 12, 2016, 10:10 p.m., Kevin Klues wrote: > > Ship It! Can you link this to the proper JIRA? - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52787/#review152408

Re: Review Request 52809: User Namespace implementation.

2016-10-12 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52809/ --- (Updated Oct. 12, 2016, 11:01 p.m.) Review request for mesos, Gilbert Song and

Review Request 52809: User Namespace implementation.

2016-10-12 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52809/ --- Review request for mesos, Gilbert Song and Jie Yu. Repository: mesos

Re: Review Request 52704: Refactored 'MountInfoTable::read()' into two separate functions.

2016-10-12 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52704/ --- (Updated Oct. 12, 2016, 11:10 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 52596: Added special case when sorting hierarchically in MountInfoTable::read.

2016-10-12 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52596/ --- (Updated Oct. 12, 2016, 11:09 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 52470: Filled missing executor info in tasks when `LAUNCH_GROUP`.

2016-10-12 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52470/#review152410 --- include/mesos/mesos.proto

Re: Review Request 52756: Invoke the shutdown executor callback for checkpointed frameworks.

2016-10-12 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52756/#review152414 --- src/executor/executor.cpp (line 731)

Re: Review Request 52755: Made default executor handle shutdown events while disconnected.

2016-10-12 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52755/#review152413 --- Fix it, then Ship it! src/launcher/default_executor.cpp (line

Re: Review Request 45962: Added a persistent volume test framework for shared volumes.

2016-10-12 Thread Anindya Sinha
> On Oct. 7, 2016, 5:20 p.m., Greg Mann wrote: > > Given how similar the code in the new example framework is to the existing > > persistent volumes framework, I think it could make sense to add shared > > volume features to the existing framework, which could be enabled/disabled > > via

Re: Review Request 52705: Added 'stout/wait.hpp' header.

2016-10-12 Thread Kevin Klues
> On Oct. 11, 2016, 8:48 p.m., Alex Clemmer wrote: > > 3rdparty/stout/include/stout/wait.hpp, line 28 > > > > > > I've been out of the game awhile-- are we wrapping comments at 70 > > characters these days? I

Re: Review Request 51620: Removed two std::move in MountInfoTable::read.

2016-10-12 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51620/#review152427 --- src/linux/fs.cpp (line 145)

Re: Review Request 45967: Added documentation for shareable resources.

2016-10-12 Thread Jiang Yan Xu
> On Oct. 12, 2016, 4:13 p.m., Jiang Yan Xu wrote: > > docs/shared-resources.md, line 175 > > > > > > We can add a section for things that aren't in the doc for regular > > persistent volumes. i.e., > > > >

Re: Review Request 52705: Added 'stout/wait.hpp' header.

2016-10-12 Thread Kevin Klues
> On Oct. 11, 2016, 8:48 p.m., Alex Clemmer wrote: > > 3rdparty/stout/include/stout/wait.hpp, line 17 > > > > > > How much work is it to do this now? If we're going to have a dedicated > > header, I would greatly

Re: Review Request 52706: Updated mesos containerizer to use new 'stout/wait.hpp' header.

2016-10-12 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52706/ --- (Updated Oct. 13, 2016, 12:08 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 52705: Added 'stout/wait.hpp' header.

2016-10-12 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52705/ --- (Updated Oct. 13, 2016, 12:08 a.m.) Review request for mesos and Jie Yu.

  1   2   >