Re: Review Request 60003: Reduced copying in defer, dispatch and Future.

2017-07-04 Thread Ilya Pronin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60003/#review179373 --- 3rdparty/libprocess/include/process/deferred.hpp Line 77

Re: Review Request 60439: Added scripts to automate website publishing.

2017-07-04 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60439/#review179310 --- This is a great start, but I would prefer if we wouldn't directly

Re: Review Request 60438: Updated endpoint help generator script to work inside Docker.

2017-07-04 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60438/#review179568 --- Ship it! Ship It! - Benjamin Bannier On June 29, 2017,

Re: Review Request 60440: Updated local development workflow of mesos website.

2017-07-04 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60440/#review179567 --- I am confused why we need this at all at this point. With

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

2017-07-04 Thread Qian Zhang
> On July 4, 2017, 1:22 a.m., Avinash sridharan wrote: > > docs/configuration.md > > Lines 1312 (patched) > > > > > > `ContainerInfo.docker.parameter` The field name is `parameters` rather than `parameter`. > On

Review Request 60639: Updated 'HierarchicalAllocator' to interpret updates to agent total.

2017-07-04 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60639/ --- Review request for mesos, Benjamin Mahler, Jie Yu, and Jan Schlicht. Bugs:

Review Request 60638: Adjusted allocator interfaces to allow passing new agent total.

2017-07-04 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60638/ --- Review request for mesos, Benjamin Mahler, Jie Yu, and Jan Schlicht. Bugs:

Review Request 60636: Added method that returns allocated resources for framework.

2017-07-04 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60636/ --- Review request for mesos, Benjamin Mahler and haosdent huang. Bugs: MESOS-6441

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

2017-07-04 Thread Andrei Budnik
> On July 3, 2017, 6:27 p.m., haosdent huang wrote: > > src/webui/master/static/js/controllers.js > > Lines 610 (patched) > > > > > > How about > > > > ``` > > $scope.agent.resource_reservations = > >

Re: Review Request 60546: Harden Mesos when building with cmake.

2017-07-04 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60546/#review179581 --- cmake/CompilationConfigure.cmake Lines 207-210 (patched)

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

2017-07-04 Thread haosdent huang
> On July 3, 2017, 6:27 p.m., haosdent huang wrote: > > src/webui/master/static/js/controllers.js > > Lines 610 (patched) > > > > > > How about > > > > ``` > > $scope.agent.resource_reservations = > >

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

2017-07-04 Thread Andrei Budnik
> On July 3, 2017, 6:27 p.m., haosdent huang wrote: > > src/webui/master/static/js/controllers.js > > Lines 610 (patched) > > > > > > How about > > > > ``` > > $scope.agent.resource_reservations = > >

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

2017-07-04 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60370/#review179587 --- Fix it, then Ship it! Ship It!

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

2017-07-04 Thread haosdent huang
> On July 3, 2017, 6:27 p.m., haosdent huang wrote: > > src/webui/master/static/js/controllers.js > > Lines 610 (patched) > > > > > > How about > > > > ``` > > $scope.agent.resource_reservations = > >

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

2017-07-04 Thread Andrei Budnik
> On July 3, 2017, 6:27 p.m., haosdent huang wrote: > > src/webui/master/static/js/controllers.js > > Lines 610 (patched) > > > > > > How about > > > > ``` > > $scope.agent.resource_reservations = > >

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

2017-07-04 Thread Qian Zhang
> On July 4, 2017, 1:22 a.m., Avinash sridharan wrote: > > docs/configuration.md > > Lines 1329 (patched) > > > > > > This is interesting. I think this example highlights a subtle > > difference between the