Re: Review Request 63094: Added resource version uuid for offer operations.

2017-10-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63094/ --- (Updated Oct. 29, 2017, 10:37 a.m.) Review request for mesos, Benjamin

Re: Review Request 63396: Added equality and hash function for OfferOperationID.

2017-10-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63396/ --- (Updated Oct. 29, 2017, 2:29 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

2017-10-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/ --- (Updated Oct. 29, 2017, 2:36 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63094: Added resource version uuid for offer operations.

2017-10-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63094/ --- (Updated Oct. 29, 2017, 3:15 p.m.) Review request for mesos, Benjamin Bannier,

Review Request 63398: Added a missing hash function for v1 resource provider ID.

2017-10-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63398/ --- Review request for mesos, Benjamin Bannier and Greg Mann. Repository: mesos

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

2017-10-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/ --- (Updated Oct. 29, 2017, 3:13 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63001: Updated protobuf definitions related to offer operations.

2017-10-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63001/ --- (Updated Oct. 29, 2017, 3:12 p.m.) Review request for mesos, Benjamin Bannier,

Review Request 63397: Added a map from OfferOperationID to internal operation UUID.

2017-10-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63397/ --- Review request for mesos and Greg Mann. Repository: mesos Description

Re: Review Request 63377: Added filesystem layout for storage resource providers.

2017-10-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63377/#review189517 --- src/Makefile.am Lines 1441-1442 (patched)

Review Request 63396: Added equality and hash function for OfferOperationID.

2017-10-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63396/ --- Review request for mesos and Greg Mann. Repository: mesos Description

Re: Review Request 63391: Fixed the flaky SlaveTest.HTTPSchedulerSlaveRestart.

2017-10-29 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63391/#review189533 --- PASS: Mesos patch 63391 was successfully built and tested.

Re: Review Request 63398: Added a missing hash function for v1 resource provider ID.

2017-10-29 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63398/#review189519 --- Bad patch! Reviews applied: [63398, 63397, 63396, 63356, 63312,

Re: Review Request 63355: Added validation for disk related new operations.

2017-10-29 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63355/#review189522 --- Patch looks great! Reviews applied: [63001, 62903, 63094, 63104,

Re: Review Request 63397: Added a map from OfferOperationID to internal operation UUID.

2017-10-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63397/ --- (Updated Oct. 29, 2017, 3:50 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 63396: Added equality and hash function for OfferOperationID.

2017-10-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63396/ --- (Updated Oct. 29, 2017, 3:50 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 63356: Implemented handling of storage related offer operations in master.

2017-10-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63356/ --- (Updated Oct. 29, 2017, 3:49 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63398: Added a missing hash function for v1 resource provider ID.

2017-10-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63398/ --- (Updated Oct. 29, 2017, 3:51 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 63358: Added the stub for OfferOperationStatusUpdate handler in the master.

2017-10-29 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63358/#review189524 --- Bad patch! Reviews applied: [63358, 63398, 63397, 63396, 63356,

Re: Review Request 63312: Updated Resources::apply for new operations.

2017-10-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63312/ --- (Updated Oct. 29, 2017, 3:48 p.m.) Review request for mesos, Benjamin Bannier,

Review Request 63399: Added stub handler in agent for ApplyOfferOperationMessage.

2017-10-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63399/ --- Review request for mesos, Benjamin Bannier, Gaston Kleiman, Greg Mann, and Jan

Re: Review Request 63314: Add support for Ubuntu 16.04 in docker build.

2017-10-29 Thread Tomasz Janiszewski
> On Oct. 26, 2017, 7:55 a.m., Vinod Kone wrote: > > support/docker-build.sh > > Lines 72 (patched) > > > > > > do we need to install `zlib1g-dev` explicitly in ubuntu 16.04 but not > > in other versions? > >

Re: Review Request 63095: Added the Getting Started landing page.

2017-10-29 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63095/#review189526 --- site/config.rb Line 46 (original)

Re: Review Request 63355: Added validation for disk related new operations.

2017-10-29 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63355/#review189537 --- PASS: Mesos patch 63355 was successfully built and tested.

Re: Review Request 63257: Added a few test helpers for creating disk resources.

2017-10-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63257/ --- (Updated Oct. 29, 2017, 3:47 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63255: Added a helper to test if a resource has resource provider.

2017-10-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63255/ --- (Updated Oct. 29, 2017, 3:45 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63355: Added validation for disk related new operations.

2017-10-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63355/ --- (Updated Oct. 29, 2017, 3:47 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63256: Added a master validation 'resource::validateSingleResourceProvider'.

2017-10-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63256/ --- (Updated Oct. 29, 2017, 3:46 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63358: Added the stub for OfferOperationStatusUpdate handler in the master.

2017-10-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63358/ --- (Updated Oct. 29, 2017, 3:55 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 62878: Sent CheckpointResourcesMessage only when reregister with an old master.

2017-10-29 Thread Jie Yu
> On Oct. 25, 2017, 12:43 a.m., Greg Mann wrote: > > src/master/master.cpp > > Lines 6321-6355 (patched) > > > > > > As discussed offline, I think it makes sense to put this block in > > `reconcileKnownAgent`, as

Re: Review Request 63254: Added a helper to test if a resource is a disk of a given type.

2017-10-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63254/ --- (Updated Oct. 29, 2017, 3:45 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 63390: WIP: Add unit tests for storage local resource provider.

2017-10-29 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63390/#review189528 --- FAIL: Failed to apply the dependent review: 63021. Failed

Re: Review Request 63400: Fix bad links.

2017-10-29 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63400/#review189534 --- Patch looks great! Reviews applied: [63400] Passed command:

Review Request 63400: Fix bad links.

2017-10-29 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63400/ --- Review request for mesos, Joerg Schad and Vinod Kone. Repository: mesos

Re: Review Request 63095: Added the Getting Started landing page.

2017-10-29 Thread Andrew Schwartzmeyer
> On Oct. 29, 2017, 1:31 p.m., Tomasz Janiszewski wrote: > > site/config.rb > > Line 46 (original) > > > > > > Why this line was removed? > > We have an issue with breoken links on offical page > >

Re: Review Request 63358: Added the stub for OfferOperationStatusUpdate handler in the master.

2017-10-29 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63358/#review189538 --- FAIL: Failed to apply the dependent review: 63312. Failed