Re: Review Request 64551: Integrated the status update manager into SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64551/#review193594 --- In the commit message: `s/and garbage collect/and garbage

Re: Review Request 64550: Made `update` return a future completed before `forwardCallback`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64550/#review193593 --- Fix it, then Ship it! In the commit message: `s/This is useful

Re: Review Request 64550: Made `update` return a future completed before `forwardCallback`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64550/#review193581 --- Ship it! Ship It! - Jie Yu On Dec. 12, 2017, 5:49 p.m.,

Re: Review Request 64505: Made the agent check for offer operation update retries.

> On Dec. 12, 2017, 1:08 a.m., Jie Yu wrote: > > src/slave/slave.cpp > > Lines 7296-7298 (patched) > > > > > > Wondering if we should do this check in `updateOfferOperation`? > > > > What's the equality

Re: Review Request 64550: Made `update` return a future completed before `forwardCallback`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64550/#review193586 --- FAIL: Some Mesos tests failed. Reviews applied: `['64517',

Review Request 64550: Made `update` return a future completed before `forwardCallback`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64550/ --- Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu. Repository:

Review Request 64548: Made the agent respond to reconciliation requests for default resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64548/ --- Review request for mesos, Benjamin Bannier, Gaston Kleiman, Jie Yu, and Jan

Review Request 64551: Integrated the status update manager into SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64551/ --- Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu. Repository:

Re: Review Request 64475: Initialized offer operation status update manager in SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64475/ --- (Updated Dec. 12, 2017, 5:51 p.m.) Review request for mesos, Gaston Kleiman,

Re: Review Request 64475: Initialized offer operation status update manager in SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64475/#review193587 --- src/resource_provider/storage/provider.cpp Line 362 (original),

Re: Review Request 64546: Fixed a flaky test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64546/#review193561 --- FAIL: Some Mesos tests failed. Reviews applied: `['64546']`

Re: Review Request 64548: Made the agent respond to reconciliation requests for default resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64548/ --- (Updated Dec. 12, 2017, 6:21 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 64548: Made the agent respond to reconciliation requests for default resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64548/#review193582 --- Ship it! Ship It! - Jie Yu On Dec. 12, 2017, 6:21 p.m.,

Re: Review Request 64551: Integrated the status update manager into SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64551/#review193596 --- FAIL: Some Mesos tests failed. Reviews applied: `['64517',

Re: Review Request 64548: Made the agent respond to reconciliation requests for default resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64548/#review193601 --- Ship it! Ship It! - Gaston Kleiman On Dec. 12, 2017, 10:21

Re: Review Request 64387: Windows: Ported docker health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64387/#review193640 --- FAIL: Some Mesos tests failed. Reviews applied: `['63859',

Re: Review Request 64561: Removed resource categories in UpdateSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64561/#review193641 --- FAIL: Some Mesos tests failed. Reviews applied: `['64557',

Re: Review Request 64551: Integrated the status update manager into SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64551/#review193645 --- FAIL: Some Mesos tests failed. Reviews applied: `['64521',

Re: Review Request 64558: Added a missing check for parent container has config recovered.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64558/#review193652 --- Fix it, then Ship it!

Re: Review Request 64558: Added a missing check for parent container has config recovered.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64558/#review193654 --- src/slave/containerizer/mesos/containerizer.cpp Line 1723

Re: Review Request 64548: Made the agent respond to reconciliation requests for default resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64548/#review193597 --- FAIL: Some Mesos tests failed. Reviews applied: `['64548']`

Re: Review Request 64522: WIP: try to make tests pass on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64522/#review193604 --- FAIL: Some Mesos tests failed. Reviews applied: `['64517',

Re: Review Request 64505: Made the agent check for offer operation update retries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64505/ --- (Updated Dec. 12, 2017, 9:22 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 64521: Made `StatusUpdateManagerProcess` fill-in the latest status update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64521/#review193598 --- src/status_update_manager/status_update_manager_process.hpp

Re: Review Request 64493: Added tests for quota enforcement with unallocated reservations.

> On Dec. 11, 2017, 6:07 p.m., Benjamin Mahler wrote: > > src/tests/hierarchical_allocator_tests.cpp > > Lines 1274-1280 (patched) > > > > > > Just curious, is it possible to template it by the > >

Re: Review Request 64493: Added tests for quota enforcement with unallocated reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64493/ --- (Updated Dec. 12, 2017, 1:45 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 64505: Made the agent check for offer operation update retries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64505/#review193613 --- FAIL: Some Mesos tests failed. Reviews applied: `['64504',

Review Request 64556: Made master acknowledge unknown operations during agent reconciliation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64556/ --- Review request for mesos, Benjamin Bannier, Gaston Kleiman, and Jie Yu.

Review Request 64557: Handled the RP disconnection case in the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64557/ --- Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and Greg Mann.

Re: Review Request 64522: WIP: try to make tests pass on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64522/#review193622 --- FAIL: Some Mesos tests failed. Reviews applied: `['64517',

Re: Review Request 64556: Made master acknowledge unknown operations during agent reconciliation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64556/#review193627 --- FAIL: Some Mesos tests failed. Reviews applied: `['64504',

Re: Review Request 64521: Made `StatusUpdateManagerProcess` fill in the latest status update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64521/ --- (Updated Dec. 12, 2017, 4:25 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 64521: Made `StatusUpdateManagerProcess` fill in the latest status update.

> On Dec. 12, 2017, 1:21 p.m., Greg Mann wrote: > > src/status_update_manager/status_update_manager_process.hpp > > Lines 513 (patched) > > > > > > AFAICT there's nothing preventing somebody from setting

Re: Review Request 64475: Initialized offer operation status update manager in SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64475/ --- (Updated Dec. 13, 2017, 12:31 a.m.) Review request for mesos, Gaston Kleiman,

Review Request 64559: Checkpointing `OfferOperation` in resource provider states.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64559/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Review Request 64558: Added a missing check for parent container has config recovered.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64558/ --- Review request for mesos, Gilbert Song and Greg Mann. Bugs: MESOS-8325

Review Request 64560: Fixed typo in agent.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64560/ --- Review request for mesos, Chun-Hung Hsiao and Greg Mann. Repository: mesos

Re: Review Request 64557: Handled the RP disconnection case in the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64557/#review193630 --- FAIL: Some Mesos tests failed. Reviews applied: `['64557']`

Review Request 64561: Removed resource categories in UpdateSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64561/ --- Review request for mesos, Benjamin Bannier and Jan Schlicht. Repository: mesos

Re: Review Request 64543: Exposed resource provider information in master 'GET_AGENTS' response.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64543/#review193631 --- Ship it! Ship It! - Jie Yu On Dec. 12, 2017, 2:38 p.m.,

Re: Review Request 64560: Fixed typo in agent.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64560/#review193632 --- Ship it! Ship It! - Greg Mann On Dec. 13, 2017, 12:41 a.m.,

Review Request 64562: Moved a comment a more relevant location.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64562/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 64562: Moved a comment a more relevant location.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64562/ --- (Updated Dec. 12, 2017, 5:19 p.m.) Review request for mesos and Benjamin

Re: Review Request 64386: Windows: Enabled docker health checks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64386/ --- (Updated Dec. 13, 2017, 1:43 a.m.) Review request for mesos, Andrew

Re: Review Request 64387: Windows: Ported docker health check tests.

> On Dec. 7, 2017, 10:30 p.m., Andrew Schwartzmeyer wrote: > > src/tests/health_check_tests.cpp > > Lines 102-111 (patched) > > > > > > Can we reuse those added to the other test file? Yeah. I can add the constant

Re: Review Request 64387: Windows: Ported docker health check tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64387/ --- (Updated Dec. 13, 2017, 1:48 a.m.) Review request for mesos, Andrew

Re: Review Request 64562: Moved a comment to a more relevant location.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64562/#review193635 --- Ship it! Ship It! - Benjamin Mahler On Dec. 13, 2017, 1:19

Review Request 64563: Moved a comment to a more relevant location.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64563/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 64559: Checkpointing `OfferOperation` in resource provider states.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64559/#review193636 --- FAIL: Some Mesos tests failed. Reviews applied: `['64521',

Re: Review Request 64475: Initialized offer operation status update manager in SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64475/ --- (Updated Dec. 13, 2017, 2:33 a.m.) Review request for mesos, Gaston Kleiman,

Re: Review Request 64558: Added a missing check for parent container has config recovered.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64558/#review193638 --- FAIL: Some Mesos tests failed. Reviews applied: `['64558']`

Re: Review Request 64475: Initialized offer operation status update manager in SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64475/#review193637 --- Ship it! Ship It! - Gaston Kleiman On Dec. 12, 2017, 6:33

Re: Review Request 64493: Added tests for quota enforcement with unallocated reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64493/ --- (Updated Dec. 12, 2017, 6:53 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 64551: Integrated the status update manager into SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64551/ --- (Updated Dec. 13, 2017, 2:59 a.m.) Review request for mesos, Gaston Kleiman,

Re: Review Request 64559: Checkpointing `OfferOperation` in resource provider states.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64559/ --- (Updated Dec. 13, 2017, 2:59 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 64467: Rewrote the quota headroom enforcement logic in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64467/ --- (Updated Dec. 12, 2017, 10:54 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 64098: Send status updates when agent re-registers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64098/ --- (Updated Dec. 12, 2017, 12:54 p.m.) Review request for mesos, Ilya Pronin,

Re: Review Request 64536: Removed race from SlaveRecoveryTest.ReconnectExecutor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64536/#review193535 --- FAIL: Some Mesos tests failed. Reviews applied: `['64536']`

Re: Review Request 64098: Send status updates when agent re-registers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64098/#review193536 --- FAIL: Failed to apply the current review. Failed command:

Review Request 64536: Removed race from SlaveRecoveryTest.ReconnectExecutor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64536/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Re: Review Request 64380: Stout: Used a namespace for UUID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64380/ --- (Updated Dec. 12, 2017, 2:56 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 64381: Mesos: Used a namespace for UUID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64381/ --- (Updated Dec. 12, 2017, 2:57 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 64168: Introduced a 'UUID' type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64168/ --- (Updated Dec. 12, 2017, 2:59 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 64168: Introduced a 'UUID' type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64168/ --- (Updated Dec. 12, 2017, 3:20 p.m.) Review request for mesos, Benjamin Bannier

Review Request 64543: Exposed resource provider information in master 'GET_AGENTS' response.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64543/ --- Review request for mesos, Jie Yu and Jan Schlicht. Repository: mesos

Re: Review Request 64168: Introduced a 'UUID' type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64168/#review193541 --- FAIL: Some Mesos tests failed. Reviews applied: `['64381',

Re: Review Request 64032: Promoted log level to warning for disconnected events in exec.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64032/#review193542 --- Ship it! Ship It! - Andrei Budnik On Dec. 4, 2017, 6:03

Review Request 64546: Fixed a flaky test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64546/ --- Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Jie Yu.

Re: Review Request 64543: Exposed resource provider information in master 'GET_AGENTS' response.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64543/#review193543 --- Ship it! Ship It! - Jan Schlicht On Dec. 12, 2017, 3:38

Re: Review Request 64098: Send status updates when agent re-registers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64098/#review193544 --- FAIL: Some Mesos tests failed. Reviews applied: `['64250',

Re: Review Request 64543: Exposed resource provider information in master 'GET_AGENTS' response.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64543/#review193545 --- FAIL: Some Mesos tests failed. Reviews applied: `['64543']`

Re: Review Request 64506: Correctly reset slave status when aborting a registration.

> On Dec. 11, 2017, 9:37 p.m., Vinod Kone wrote: > > src/master/master.cpp > > Lines 6433-6434 (patched) > > > > > > Instead of this, I would propose that we have a proper state machine > > and transition the

Re: Review Request 64098: Send status updates when agent re-registers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64098/#review193557 --- Ship it! Ship It! - Jiang Yan Xu On Dec. 12, 2017, 4:54