Re: Review Request 65344: Updated the docs for agent ping timeout flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65344/#review196313 --- FAIL: Some Mesos libprocess-tests failed. Reviews applied:

Review Request 65347: Added missing protobuf include.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65347/ --- Review request for mesos. Repository: mesos Description --- When using

Re: Review Request 65348: Fixed flakyness of MasterTest.UpdateSlaveMessageWithPendingOffers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65348/#review196339 --- PASS: Mesos patch 65348 was successfully built and tested.

Re: Review Request 65347: Added missing protobuf include.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65347/#review196330 --- PASS: Mesos patch 65347 was successfully built and tested.

***UNCHECKED*** Re: Review Request 65348: Fixed flakyness of MasterTest.UpdateSlaveMessageWithPendingOffers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65348/#review196332 --- src/tests/master_tests.cpp Lines 8615-8616 (original), 8615-8616

Re: Review Request 65348: Fixed flakyness of MasterTest.UpdateSlaveMessageWithPendingOffers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65348/ --- (Updated Jan. 26, 2018, 2:31 p.m.) Review request for mesos, Alexander

Review Request 65348: Fixed flakyness of MasterTest.UpdateSlaveMessageWithPendingOffers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65348/ --- Review request for mesos, Alexander Rukletsov and Benjamin Bannier. Bugs:

Re: Review Request 65347: Added missing protobuf include.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65347/#review196326 --- PASS: Mesos patch 65347 was successfully built and tested.

Review Request 65346: Updated Web UI to show quota guarantee and limit for roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65346/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-8486

Review Request 65351: Reordered roles in Web UI to display them alphabetically by default.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65351/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-8495

Re: Review Request 63369: Added new '/state' and '/statistics' endpoints to the MemoryProfiler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63369/ --- (Updated Jan. 26, 2018, 2:18 p.m.) Review request for mesos, Alexander

Review Request 65350: Modified `cgroups::prepare` to check nested cgroups support only once.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65350/ --- Review request for mesos, Alexander Rukletsov, Gilbert Song, and Jie Yu. Bugs:

Re: Review Request 65348: Fixed flakyness of MasterTest.UpdateSlaveMessageWithPendingOffers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65348/#review196343 --- PASS: Mesos patch 65348 was successfully built and tested.

Re: Review Request 65350: Modified `cgroups::prepare` to check nested cgroups support only once.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65350/#review196349 --- FAIL: Failed to get dependent review IDs for the current patch.

Re: Review Request 65346: Updated Web UI to show quota guarantee and limit for roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65346/#review196329 --- PASS: Mesos patch 65346 was successfully built and tested.

Re: Review Request 65294: Add revocable resources support to mesos-execute.

> On Jan. 25, 2018, 9:10 p.m., Anish Gupta wrote: > > src/cli/execute.cpp > > Lines 1077-1082 (patched) > > > > > > Why not unconditionally set it since resources are not revocable unless > > have RevocableInfo I

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review196340 --- 3rdparty/libprocess/Makefile.am Lines 213 (patched)

Re: Review Request 65351: Reordered roles in Web UI to display them alphabetically by default.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65351/#review196362 --- PASS: Mesos patch 65351 was successfully built and tested.

Re: Review Request 65350: Modified `cgroups::prepare` to check nested cgroups support only once.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65350/#review196354 --- PASS: Mesos patch 65350 was successfully built and tested.

Re: Review Request 65351: Reordered roles in Web UI to display them alphabetically by default.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65351/#review196357 --- PASS: Mesos patch 65351 was successfully built and tested.

Review Request 65354: Fix flakyness in MasterTest.RegistryGcByCount.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65354/ --- Review request for mesos. Repository: mesos Description --- The test

Re: Review Request 65354: Fix flakyness in MasterTest.RegistryGcByCount.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65354/ --- (Updated Jan. 26, 2018, 6:12 p.m.) Review request for mesos. Bugs:

Re: Review Request 65354: Fix flakyness in MasterTest.RegistryGcByCount.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65354/#review196364 --- PASS: Mesos patch 65354 was successfully built and tested.

Re: Review Request 65354: Fix flakyness in MasterTest.RegistryGcByCount.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65354/#review196366 --- PASS: Mesos patch 65354 was successfully built and tested.

Re: Review Request 65347: Added missing protobuf include.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65347/#review196368 --- Ship it! Note that the reason why this doesn't compile in

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64618/#review196375 --- PASS: Mesos patch 64618 was successfully built and tested.

Re: Review Request 65111: Added tests to verify the executor is shutdown if no task is delivered.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65111/ --- (Updated Jan. 26, 2018, 3:21 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 65300: Added master metrics for operation status acknowledgments handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65300/ --- (Updated Jan. 26, 2018, 1:45 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 65294: Add revocable resources support to mesos-execute.

> On Jan. 25, 2018, 9:10 p.m., Anish Gupta wrote: > > src/cli/execute.cpp > > Lines 1077-1082 (patched) > > > > > > Why not unconditionally set it since resources are not revocable unless > > have RevocableInfo >

Review Request 65358: Removed unnecesssary validations from `Master::receive()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65358/ --- Review request for mesos and Greg Mann. Bugs: MESOS-8184

Review Request 65361: Added special handling for devolving ACKNOWLEDGE_OPERATION_STATUS calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65361/ --- Review request for mesos and Greg Mann. Bugs: MESOS-8184

Re: Review Request 65300: Added master metrics for operation status acknowledgments handling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65300/ --- (Updated Jan. 26, 2018, 2:08 p.m.) Review request for mesos and Greg Mann.

Review Request 65359: Added an extra CHECK to `Master::acknowledge()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65359/ --- Review request for mesos and Greg Mann. Bugs: MESOS-8184

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65044/#review196370 --- API changes look good to me. I haven't reviewed the tests though.

Re: Review Request 65109: Fixed a bug relating to lingering executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65109/ --- (Updated Jan. 26, 2018, 3:13 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64618/#review196377 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 65357: Made devolving `v1::scheduler::Call::SUBSCRIBE` more robust.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65357/ --- Review request for mesos and Greg Mann. Bugs: MESOS-8184

Review Request 65360: Made `master::receive()` drop `ACKNOWLEDGE_OPERATION_STATUS` calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65360/ --- Review request for mesos and Greg Mann. Bugs: MESOS-8184

Review Request 65362: Added a method to increment invalid scheduler API call counters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65362/ --- Review request for mesos and Greg Mann. Bugs: MESOS-8184

Review Request 65363: Improved the validation of `ACKNOWLEDGE_OPERATION_STATUS` calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65363/ --- Review request for mesos and Greg Mann. Bugs: MESOS-8184

Re: Review Request 64618: Implemented the master's `ACKNOWLEDGE_OPERATION_STATUS` handler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64618/ --- (Updated Jan. 26, 2018, 2:09 p.m.) Review request for mesos and Greg Mann.

Review Request 65368: Updated maintenance schedule logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65368/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-7882

Review Request 65366: Added test for maintenance-related offer rescinding behavior.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65366/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-7882

Review Request 65367: Added equality operator for Unavailability protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65367/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-7882

Re: Review Request 65368: Updated maintenance schedule logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65368/#review196384 --- PASS: Mesos patch 65368 was successfully built and tested.

Re: Review Request 65316: Added test for delayed authorization during operator events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65316/#review196379 --- Fix it, then Ship it! src/tests/api_tests.cpp Lines 2630

Review Request 65369: Added test to ensure v1 executor is shutdown upon initial task all-kill.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65369/ --- Review request for mesos, Benjamin Mahler and Vinod Kone. Repository: mesos

Re: Review Request 65367: Added equality operator for Unavailability protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65367/#review196385 --- Fix it, then Ship it! include/mesos/type_utils.hpp Lines

Re: Review Request 65109: Fixed a bug relating to lingering executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65109/#review195957 --- It would for posterity to highlight the race in question, and to

Re: Review Request 65109: Fixed a bug relating to lingering executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65109/#review196381 --- src/slave/slave.cpp Line 4652 (original), 4659 (patched)

Re: Review Request 65346: Updated Web UI to show quota guarantee and limit for roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65346/#review196383 --- I wonder if we should split out the allocation / guarantee /

Re: Review Request 65315: Moved 'ObjectApproverAll' into a header for use in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65315/#review196380 --- src/tests/mesos.hpp Lines 3177 (patched)

Re: Review Request 65368: Updated maintenance schedule logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65368/#review196386 --- PASS: Mesos patch 65368 was successfully built and tested.

Re: Review Request 65351: Reordered roles in Web UI to display them alphabetically by default.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65351/#review196382 --- Isn't this just doing reverse alphabetical? z z/z z/b z/a b a