Re: Review Request 66437: Windows: Removed `FD_CRT` from `WindowsFD` abstraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66437/#review200500 --- 3rdparty/stout/include/stout/os/windows/close.hpp Lines 38

Re: Review Request 66424: Windows: Replaced `_wopen()` with `CreateFileW()` in `os::open()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66424/#review200505 --- Ship it! Ship It! - John Kordich On April 4, 2018, 5:47

Re: Review Request 66439: Windows: Made `protobuf::write()` use CRT file descriptor explicitly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66439/#review200523 --- 3rdparty/stout/include/stout/protobuf.hpp Line 83 (original), 87

Re: Review Request 66455: Windows: Fixed `os::ftruncate()` to use `SetEndOfFile()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66455/#review200524 --- Ship it!

Re: Review Request 66178: Added a test to verify that task launch order is enforced.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66178/#review200526 --- Ship it! Ship It! - Greg Mann On April 4, 2018, 3:24 a.m.,

Re: Review Request 66457: Made resource provider API aware of workloads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66457/#review200528 --- FAIL: Failed to apply the dependent review: 66398. Failed

Review Request 66458: Fixed handling of operations in `master::recoverFramework()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66458/ --- Review request for mesos and Greg Mann. Repository: mesos Description

Re: Review Request 66412: Fixed flaky agent test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66412/#review200529 --- Patch looks great! Reviews applied: [66118, 66119, 66120, 65679,

Review Request 66461: Added an evolve function for `v1::scheduler::Response`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66461/ --- Review request for mesos and Greg Mann. Repository: mesos Description

Re: Review Request 66428: Windows: Fixed `os::lseek()` to use `SetFilePointerEx()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66428/#review200508 --- Ship it! 3rdparty/stout/include/stout/os/windows/lseek.hpp

Re: Review Request 66429: Windows: Deleted dead code from `process::internal` namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66429/#review200509 --- Ship it! Ship It! - John Kordich On April 4, 2018, 7:17

Re: Review Request 66435: Added overloads for `int_fd` to `os::stat::isdir()` and `size()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66435/#review200518 --- Ship it! Ship It! - John Kordich On April 4, 2018, 5:52

Review Request 66457: Made resource provider API aware of workloads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66457/ --- Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. Bugs:

Review Request 66460: Added a `call()` method to the v1 scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66460/ --- Review request for mesos and Greg Mann. Repository: mesos Description

Review Request 66464: Implemented operation status reconciliation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66464/ --- Review request for mesos and Greg Mann. Repository: mesos Description

Re: Review Request 66459: Fixed bug in `Master::updateSlave()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66459/#review200532 --- PASS: Mesos patch 66459 was successfully built and tested.

Re: Review Request 66467: Added a test helper for creating `RECONCILE_OPERATIONS` v1 calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66467/#review200533 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66431: Windows: Fixed `os::read()` to use `ReadFile()`.

> On April 4, 2018, 3:28 p.m., John Kordich wrote: > > 3rdparty/stout/include/stout/os/windows/ftruncate.hpp > > Lines 36 (patched) > > > > > > I'm fine with a truncate function not writing null bytes to the part of

Re: Review Request 66434: Windows: Refactored `subprocess_windows.cpp` to use `os::open()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66434/#review200517 --- Ship it! Ship It! - John Kordich On April 4, 2018, 7:18

Re: Review Request 66457: Made resource provider API aware of workloads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66457/#review200531 --- Bad patch! Reviews applied: [66457, 66418, 66411, 66410, 66409,

Review Request 66465: Updated `using` statements in `tests/mesos.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66465/ --- Review request for mesos and Greg Mann. Repository: mesos Description

Re: Review Request 66442: Windows: Fixed `os::abort()` to use `WriteFile()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66442/ --- (Updated April 4, 2018, 7:06 p.m.) Review request for mesos, Akash Gupta, Eric

Re: Review Request 66423: Split `stout/os/open.hpp` into Windows and POSIX files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66423/#review200504 --- Ship it! Ship It! - John Kordich On April 4, 2018, 5:47

Re: Review Request 66430: Windows: Fixed `os::dup()` to use `DuplicateHandle()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66430/#review200511 --- Ship it! Ship It! - John Kordich On April 4, 2018, 5:50

Re: Review Request 66420: Windows: Extracted job object code into `os/windows/jobobject.hpp`.

> On April 4, 2018, 3:12 p.m., John Kordich wrote: > > 3rdparty/stout/include/stout/os/windows/jobobject.hpp > > Lines 139 (patched) > > > > > > This is interesting. I understand how you're using this template > >

Re: Review Request 66428: Windows: Fixed `os::lseek()` to use `SetFilePointerEx()`.

> On April 4, 2018, 3:21 p.m., John Kordich wrote: > > 3rdparty/stout/include/stout/os/windows/lseek.hpp > > Lines 36 (patched) > > > > > > That sounds like it would be user error here if this ever happens! I agree,

Re: Review Request 66145: Added a test to verify that task launch order is enforced.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66145/#review200525 --- Ship it! Ship It! - Greg Mann On April 3, 2018, 10:08 p.m.,

Re: Review Request 66323: Added tests for failed task launch on agent.

> On April 4, 2018, 12:17 a.m., Greg Mann wrote: > > src/tests/slave_tests.cpp > > Lines 5251-5252 (patched) > > > > > > Is this needed? > > Meng Zhu wrote: > To avoid uninteresting mock calls. The real

Re: Review Request 66467: Added a test helper for creating `RECONCILE_OPERATIONS` v1 calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66467/#review200534 --- Patch looks great! Reviews applied: [66458, 66459, 66460, 66461,

Re: Review Request 66420: Windows: Extracted job object code into `os/windows/jobobject.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66420/#review200502 --- Fix it, then Ship it! Oops. I just realized as I was getting

Re: Review Request 66420: Windows: Extracted job object code into `os/windows/jobobject.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66420/#review200503 --- Ship it! Ship It! - John Kordich On April 4, 2018, 5:46

Re: Review Request 66433: Windows: Made `net::download()` use CRT file descriptor explicitly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66433/#review200515 --- Ship it! Ship It! - John Kordich On April 4, 2018, 7:18

Review Request 66463: Added a master metric for operations reconciliation messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66463/ --- Review request for mesos and Greg Mann. Repository: mesos Description

Review Request 66462: Added new operation states to be used for status reconciliation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66462/ --- Review request for mesos and Greg Mann. Repository: mesos Description

Re: Review Request 66427: Split `stout/os/lseek.hpp` into Windows and POSIX files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66427/#review200507 --- Ship it! Ship It! - John Kordich On April 4, 2018, 5:48

Re: Review Request 66425: Windows: Replaced `WindowsFD` with `int_fd` typedef.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66425/#review200506 --- Ship it! Ship It! - John Kordich On April 4, 2018, 5:47

Re: Review Request 66431: Windows: Fixed `os::read()` to use `ReadFile()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66431/#review200513 --- Ship it!

Review Request 66459: Fixed bug in `Master::updateSlave()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66459/ --- Review request for mesos and Greg Mann. Repository: mesos Description

Review Request 66467: Added a test helper for creating `RECONCILE_OPERATIONS` v1 calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66467/ --- Review request for mesos and Greg Mann. Repository: mesos Description

Re: Review Request 66432: Windows: Fixed `os::write()` to use `WriteFile()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66432/#review200514 --- Ship it! Ship It! - John Kordich On April 4, 2018, 5:50

Review Request 66466: Updated `RESERVE()` helper to allow specifying an operation ID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66466/ --- Review request for mesos and Greg Mann. Repository: mesos Description

Re: Review Request 66437: Windows: Removed `FD_CRT` from `WindowsFD` abstraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66437/ --- (Updated April 4, 2018, 6:58 p.m.) Review request for mesos, Akash Gupta, Eric

Re: Review Request 66454: Updated the documented release schedule.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66454/#review200535 --- Ship it! Ship It! - Gilbert Song On April 4, 2018, 11:48

Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66314/#review200447 --- Patch looks great! Reviews applied: [66314] Passed command:

Review Request 66451: Added devolve function for 'ResourceProviderInfo'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66451/ --- Review request for mesos and Jan Schlicht. Repository: mesos Description

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

> On March 27, 2018, 4:35 p.m., James Peach wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > > Lines 368 (patched) > > > > > > Move this into the case statement block. So if I do that then I will

Re: Review Request 66165: Re-fixed many master allocator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66165/#review200448 --- Fix it, then Ship it! src/tests/master_allocator_tests.cpp

Review Request 66449: Fixed flaky `ROOT_IsolatorFlags` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66449/ --- Review request for mesos, Alexander Rukletsov, Gilbert Song, and Jie Yu. Bugs:

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

> On April 2, 2018, 8:30 p.m., Ilya Pronin wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > > Line 304 (original), 317-318 (patched) > > > > > > Keep `infos.contains(containerId)` check here.

Review Request 66450: Added missing gmock expectation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66450/ --- Review request for mesos and Jan Schlicht. Repository: mesos Description

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

> On March 27, 2018, 4:35 p.m., James Peach wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > > Line 362 (original), 414 (patched) > > > > > > `needed` is still the allocated quota so you don't need

Re: Review Request 66449: Fixed flaky `ROOT_IsolatorFlags` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66449/#review200449 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66450: Added missing gmock expectation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66450/#review200451 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66451: Added devolve function for 'ResourceProviderInfo'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66451/#review200452 --- PASS: Mesos patch 66451 was successfully built and tested.

Re: Review Request 66449: Fixed flaky `ROOT_IsolatorFlags` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66449/#review200453 --- Patch looks great! Reviews applied: [66449] Passed command:

Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66314/ --- (Updated April 4, 2018, 2:34 p.m.) Review request for mesos, Andrew

Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66314/#review200458 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66404: Removed check for nested cgroup support in `cgroups::prepare()`.

> On April 3, 2018, 7:13 p.m., Gilbert Song wrote: > > LGTM, before landing this patch, could we verify the nested cgroup is > > alwasy supportted after kernel 2.6.23? Nested freezer cgroup is supported since kernel **2.6.28** ``` freezer (since Linux 2.6.28; CONFIG_CGROUP_FREEZER)

Re: Review Request 66444: Windows: Made `signals.hpp` compile.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66444/#review200467 --- I think our other option is to just delete this file, and have

Re: Review Request 66431: Windows: Fixed `os::read()` to use `ReadFile()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66431/#review200469 --- 3rdparty/stout/include/stout/os/windows/ftruncate.hpp Lines

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/ --- (Updated April 4, 2018, 5:41 p.m.) Review request for mesos and James Peach.

Re: Review Request 66392: Find sasl2 on non-Windows platforms before trying to link it.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66392/#review200465 --- Ship it! Ship It! - Andrew Schwartzmeyer On April 3, 2018,

Re: Review Request 66173: Add test for new `disk/xfs` kill functionality.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66173/ --- (Updated April 4, 2018, 5:41 p.m.) Review request for mesos and James Peach.

Re: Review Request 66450: Added missing gmock expectation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66450/#review200463 --- Patch looks great! Reviews applied: [66450] Passed command:

Re: Review Request 66441: Fixed mismatched types in `process.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66441/#review200468 --- 3rdparty/libprocess/src/process.cpp Line 1387 (original), 1387

Re: Review Request 66001: MESOS-6575: Add soft limit and kill to disk/xfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66001/#review200471 --- src/slave/containerizer/mesos/isolators/xfs/disk.cpp Lines 398

Review Request 66454: Updated the documented release schedule.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66454/ --- Review request for mesos, Benjamin Mahler, Jie Yu, and Vinod Kone. Repository:

Re: Review Request 66451: Added devolve function for 'ResourceProviderInfo'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66451/#review200473 --- Patch looks great! Reviews applied: [66451] Passed command:

Re: Review Request 66173: Add test for new `disk/xfs` kill functionality.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66173/#review200474 --- PASS: Mesos patch 66173 was successfully built and tested.

Re: Review Request 66431: Windows: Fixed `os::read()` to use `ReadFile()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66431/ --- (Updated April 4, 2018, 12:13 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 66433: Windows: Made `net::download()` use CRT file descriptor explicitly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66433/ --- (Updated April 4, 2018, 12:18 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 66434: Windows: Refactored `subprocess_windows.cpp` to use `os::open()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66434/ --- (Updated April 4, 2018, 12:18 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 65679: Removed direct unmock calls and added missing mock call expectations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65679/ --- (Updated April 4, 2018, 12:20 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 66412: Fixed flaky agent test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66412/ --- (Updated April 4, 2018, 12:23 p.m.) Review request for mesos and Greg Mann.

Re: Review Request 66449: Fixed flaky `ROOT_IsolatorFlags` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66449/#review200472 --- src/tests/containerizer/linux_capabilities_isolator_tests.cpp

Re: Review Request 66429: Windows: Deleted dead code from `process::internal` namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66429/ --- (Updated April 4, 2018, 12:17 p.m.) Review request for mesos, Akash Gupta,

Review Request 66455: Windows: Fixed `os::ftruncate()` to use `SetEndOfFile()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66455/ --- Review request for mesos. Bugs: MESOS-8692

Re: Review Request 66438: Windows: Made `libevent` use CRT file descriptor explicitly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66438/ --- (Updated April 4, 2018, 12:19 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 66445: Windows: Cleaned up included CRT headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66445/ --- (Updated April 4, 2018, 12:26 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 66454: Updated the documented release schedule.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66454/#review200476 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66412: Fixed flaky agent test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66412/#review200477 --- FAIL: Failed to apply the dependent review: 66126. Failed

Re: Review Request 66449: Fixed flaky `ROOT_IsolatorFlags` test.

> On April 4, 2018, 11:23 a.m., Gilbert Song wrote: > > src/tests/containerizer/linux_capabilities_isolator_tests.cpp > > Lines 747 (patched) > > > > > > Should we call `slave.get()->terminate()` before `reset()`?

Re: Review Request 66449: Fixed flaky `ROOT_IsolatorFlags` test.

> On April 4, 2018, 6:23 p.m., Gilbert Song wrote: > > src/tests/containerizer/linux_capabilities_isolator_tests.cpp > > Lines 747 (patched) > > > > > > Should we call `slave.get()->terminate()` before `reset()`?

Re: Review Request 66421: Windows: Included used `jobobject.hpp` stout header in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66421/#review200487 --- Ship it! Ship It! - John Kordich On April 4, 2018, 5:47

Re: Review Request 66426: Windows: More constness in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66426/#review200489 --- Ship it! Ship It! - John Kordich On April 4, 2018, 5:48

Re: Review Request 66436: Removed use of `fstat()` from `http.cpp` and `http_proxy.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66436/#review200490 --- Ship it! Ship It! - John Kordich On April 4, 2018, 5:54

Re: Review Request 66438: Windows: Made `libevent` use CRT file descriptor explicitly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66438/#review200492 --- Ship it! Ship It! - John Kordich On April 4, 2018, 7:19

Re: Review Request 66440: Replaced `open()` with `os::open()` in `http_proxy.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66440/#review200493 --- Ship it! Ship It! - John Kordich On April 4, 2018, 5:57

Re: Review Request 66441: Fixed mismatched types in `process.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66441/#review200494 --- Ship it! Ship It! - John Kordich On April 4, 2018, 5:57

Re: Review Request 66442: Windows: Fixed `os::abort()` to use `WriteFile()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66442/#review200495 --- Ship it! Ship It! - John Kordich On April 4, 2018, 5:57

Re: Review Request 66444: Windows: Made `signals.hpp` compile.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66444/#review200497 --- Ship it! Ship It! - John Kordich On April 4, 2018, 5:58

Re: Review Request 66443: Fixed `Subprocess::ChildHook::CHDIR()` to use `os::chdir()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66443/#review200496 --- Ship it! Ship It! - John Kordich On April 4, 2018, 5:58

Re: Review Request 66445: Windows: Cleaned up included CRT headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66445/#review200498 --- Ship it! Ship It! - John Kordich On April 4, 2018, 7:26

Re: Review Request 66441: Fixed mismatched types in `process.cpp`.

> On April 4, 2018, 2:21 p.m., John Kordich wrote: > > Ship It! Actually, I think I can delete with a pending update to `WindowsFD`. - Andrew --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 66412: Fixed flaky agent test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66412/#review200501 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66433: Windows: Made `net::download()` use CRT file descriptor explicitly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66433/#review200430 --- This should maybe be moved to come after

Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66314/#review200431 --- PASS: Mesos patch 66314 was successfully built and tested.

Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.

> On März 28, 2018, 10:06 vorm., Benjamin Bannier wrote: > > 3rdparty/CMakeLists.txt > > Lines 58-63 (patched) > > > > > > Like discussed offline, I don't think there is a reason we need to bolt > > such logic on

Re: Review Request 66412: Fixed flaky agent test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66412/#review200433 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66314: Fix 3rdparty build commands for FreeBSD.

> On March 28, 2018, 8:06 a.m., Benjamin Bannier wrote: > > 3rdparty/CMakeLists.txt > > Lines 58-63 (patched) > > > > > > Like discussed offline, I don't think there is a reason we need to bolt > > such logic on the

  1   2   >