Re: Review Request 68978: Added TaskIO object to new CLI for `task exec` and `task attach`.

2018-10-18 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68978/#review209747 --- Ship it! Ship It! - Kevin Klues On Okt. 15, 2018, 11:06

Re: Review Request 69003: Added `task exec` to new CLI.

2018-10-18 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69003/#review209749 --- Ship it! Ship It! - Kevin Klues On Okt. 15, 2018, 6:53

Re: Review Request 69003: Added `task exec` to new CLI.

2018-10-18 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69003/#review209750 --- Ship it! Ship It! - Kevin Klues On Okt. 15, 2018, 6:53

Re: Review Request 69003: Added `task exec` to new CLI.

2018-10-18 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69003/#review209748 --- Ship it! Ship It! - Kevin Klues On Okt. 15, 2018, 6:53

Re: Review Request 68957: Add documentation for per-framework metrics flag.

2018-10-18 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/#review209770 --- PASS: Mesos patch 68957 was successfully built and tested.

Re: Review Request 69075: Updated docker image fetcher to enforce HTTP1.0.

2018-10-18 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69075/#review209769 --- PASS: Mesos patch 69075 was successfully built and tested.

Re: Review Request 69075: Updated docker image fetcher to enforce HTTP1.0.

2018-10-18 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69075/#review209768 --- src/uri/fetchers/docker.cpp Lines 104 (patched)

Re: Review Request 68956: Add a flag to toggle per-framework metrics.

2018-10-18 Thread Jacob Janco
> On Oct. 15, 2018, 8:23 p.m., Greg Mann wrote: > > src/master/master.hpp > > Line 2578 (original), 2578 (patched) > > > > > > My initial thought is that it would make more sense to change this > > member to an

Review Request 69075: Updated docker image fetcher to enforce HTTP1.1.

2018-10-18 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69075/ --- Review request for mesos, Alexander Rukletsov, Armand Grillet, Jie Yu, and

Re: Review Request 69075: Updated docker image fetcher to enforce HTTP1.1.

2018-10-18 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69075/ --- (Updated Oct. 18, 2018, 11:03 p.m.) Review request for mesos, Alexander

Re: Review Request 69075: Updated docker image fetcher to enforce HTTP1.0.

2018-10-18 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69075/ --- (Updated Oct. 18, 2018, 11:41 p.m.) Review request for mesos, Alexander

Re: Review Request 68953: Refactor allocator configuration into a struct.

2018-10-18 Thread Jacob Janco
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68953/ --- (Updated Oct. 18, 2018, 10:59 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68957: Add documentation for per-framework metrics flag.

2018-10-18 Thread Jacob Janco
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/ --- (Updated Oct. 18, 2018, 10:59 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68956: Add a flag to toggle per-framework metrics.

2018-10-18 Thread Jacob Janco
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68956/ --- (Updated Oct. 18, 2018, 10:59 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 69075: Updated docker image fetcher to enforce HTTP1.1.

2018-10-18 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69075/#review209766 --- Fix it, then Ship it! src/uri/fetchers/docker.cpp Lines 104

Re: Review Request 68706: Added master failover reregistration progress metrics.

2018-10-18 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68706/#review209722 --- src/master/master.hpp Lines 2346-2347 (patched)

Re: Review Request 68795: Added deduplication for read-only master requests.

2018-10-18 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68795/ --- (Updated Oct. 18, 2018, 6:43 p.m.) Review request for mesos and Alexander

Re: Review Request 69064: WIP: Added unit tests for Master HTTP endpoints.

2018-10-18 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69064/ --- (Updated Oct. 18, 2018, 6:43 p.m.) Review request for mesos and Alexander

Review Request 69071: Narrowed interface of `ReadOnlyHandler` members.

2018-10-18 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69071/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Re: Review Request 68706: Added master failover reregistration progress metrics.

2018-10-18 Thread Jiang Yan Xu
> On Oct. 18, 2018, 11:14 a.m., Jiang Yan Xu wrote: > > Sorry for the delay. Feel free to chat if it's not clear! - Jiang Yan --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 69064: WIP: Added unit tests for Master HTTP endpoints.

2018-10-18 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69064/#review209761 --- PASS: Mesos patch 69064 was successfully built and tested.

Re: Review Request 69032: Optimized resources filter operation.

2018-10-18 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69032/#review209773 --- PASS: Mesos patch 69032 was successfully built and tested.

Re: Review Request 69032: Optimized resources filter operation.

2018-10-18 Thread Meng Zhu
> On Oct. 16, 2018, 5:24 p.m., Benjamin Mahler wrote: > > Can you also post the filter benchmark results? > > > > https://github.com/apache/mesos/blob/1.7.0/src/tests/resources_tests.cpp#L3865-L3920 Done. > On Oct. 16, 2018, 5:24 p.m., Benjamin Mahler wrote: > > src/common/resources.cpp > >

Re: Review Request 69032: Optimized resources filter operation.

2018-10-18 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69032/ --- (Updated Oct. 18, 2018, 9:22 p.m.) Review request for mesos, Benjamin Mahler