Review Request 69945: Added a test to test memfd file clone.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69945/ --- Review request for mesos, Andrei Budnik, Gilbert Song, and James Peach.

Review Request 69943: Added Linux memfd support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69943/ --- Review request for mesos, Andrei Budnik, Gilbert Song, and James Peach.

Review Request 69948: Cleaned up command executor redundant command string.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69948/ --- Review request for mesos, Andrei Budnik, Jason Lai, Jie Yu, and James Peach.

Review Request 69947: Cloned a sealed file of launcher binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69947/ --- Review request for mesos, Andrei Budnik, Jason Lai, Jie Yu, and James Peach.

Re: Review Request 69946: Updated handleWhitelistFds() to avoid closing FDs with FD_CLOEXEC bit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69946/ --- (Updated Feb. 11, 2019, 11:33 a.m.) Review request for mesos, Andrei Budnik,

Review Request 69942: Added a test for MESOS-9554.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69942/ --- Review request for mesos, Benjamin Bannier and Meng Zhu. Bugs: MESOS-9554

Re: Review Request 69938: Add resource decorator hook to implicitly allocate mandatory resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69938/#review212704 --- Nice patch, thanks Clément. Just a few minor comments below and

Review Request 69946: Updated handleWhitelistFds() to avoid closing FDs with FD_CLOEXEC bit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69946/ --- Review request for mesos, Andrei Budnik, Jason Lai, Jie Yu, and James Peach.

Re: Review Request 69943: Added Linux memfd support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69943/#review212709 --- Ship it! Ship It! - Gilbert Song On Feb. 11, 2019, 11:13

Re: Review Request 69948: Cleaned up command executor redundant command string.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69948/#review212708 --- Ship it! Ship It! - Jie Yu On Feb. 11, 2019, 7:21 p.m.,

Re: Review Request 69945: Added a test to test memfd file clone.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69945/#review212711 --- Ship it! Ship It! - Gilbert Song On Feb. 11, 2019, 11:14

Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69890/#review212702 --- PASS: Mesos patch 69890 was successfully built and tested.

Re: Review Request 69944: Made the code more robust related to sendfile.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69944/#review212710 --- Ship it! Ship It! - Gilbert Song On Feb. 11, 2019, 11:14

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

> On Feb. 8, 2019, 10:05 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 1886-1888 (patched) > > > > > > Ditto the comment left below for the equivalent check in the second

Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources.

> On Feb. 8, 2019, 9:47 p.m., Benjamin Mahler wrote: > > src/tests/hierarchical_allocator_tests.cpp > > Lines 2357-2374 (patched) > > > > > > Both "empty set" and "NullResourcesAllocatable" don't seem to > >

Re: Review Request 69892: Made SLRP recover node-published volumes after reboot.

> On Feb. 5, 2019, 5:41 p.m., Benjamin Bannier wrote: > > src/csi/state.proto > > Lines 62-67 (original), 62-77 (patched) > > > > > > Any reason we cannot use a single field containing the `bootId` of the > > last

Review Request 69944: Made the code more robust related to sendfile.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69944/ --- Review request for mesos, Andrei Budnik, Gilbert Song, and James Peach.

Re: Review Request 69942: Added a test for MESOS-9554.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69942/#review212712 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69947: Cloned a sealed file of launcher binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69947/#review212707 --- Ship it! Ship It! - Jie Yu On Feb. 11, 2019, 7:21 p.m.,

Re: Review Request 69946: Updated handleWhitelistFds() to avoid closing FDs with FD_CLOEXEC bit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69946/#review212706 --- Fix it, then Ship it!

Re: Review Request 69938: Add resource decorator hook to implicitly allocate mandatory resources.

> On fév. 11, 2019, 6:58 après-midi, Benjamin Mahler wrote: > > include/mesos/hook.hpp > > Lines 56-62 (patched) > > > > > > It's not clear from here what the semantics are, can you add: > > > > ``` > >

Re: Review Request 69938: Add resource decorator hook to implicitly allocate mandatory resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69938/ --- (Updated fév. 11, 2019, 8:50 après-midi) Review request for mesos and Benjamin

Re: Review Request 69286: Allowed creating non-existing host paths for Mesos Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69286/ --- (Updated Feb. 11, 2019, 11:12 p.m.) Review request for mesos, Chun-Hung Hsiao,

Re: Review Request 69948: Cleaned up command executor redundant command string.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69948/#review212722 --- PASS: Mesos patch 69948 was successfully built and tested.

Re: Review Request 69286: Allowed creating non-existing host paths for Mesos Containerizer.

> On Nov. 8, 2018, 6:33 a.m., Gilbert Song wrote: > > Hi, @gilbert. I updated the patch a bit differently than you originally requested by creating a `PathValidator` that encapsulate the validation logic instead. Please check if this revision rings a bell to you. > On Nov. 8, 2018, 6:33

Re: Review Request 69938: Add resource decorator hook to implicitly allocate mandatory resources.

> On fév. 11, 2019, 6:58 après-midi, Benjamin Mahler wrote: > > Nice patch, thanks Clément. Just a few minor comments below and we should > > be good to go. > > > > Just as an aside, the current hook interfaces are rather inefficient > > (copies the entire task info). If you're interested in

Re: Review Request 69938: Add resource decorator hook to implicitly allocate mandatory resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69938/#review212723 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69938: Add resource decorator hook to implicitly allocate mandatory resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69938/ --- (Updated fév. 11, 2019, 10:27 après-midi) Review request for mesos and

Re: Review Request 69938: Add resource decorator hook to implicitly allocate mandatory resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69938/#review212725 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69891: Sent operation updates to schedulers when agents are removed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69891/#review212728 --- Patch looks great! Reviews applied: [69876, 69880, 69891]

Re: Review Request 69897: Made SLRP `PublishResourcesRecovery` test to check volume cleanup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69897/ --- (Updated Feb. 12, 2019, 5:24 a.m.) Review request for mesos and Benjamin

Re: Review Request 69898: Updated `CreateDestroyDisk*` SLRP tests to test pipelined operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69898/ --- (Updated Feb. 12, 2019, 5:26 a.m.) Review request for mesos and Benjamin

Re: Review Request 69866: Updated SLRP test `ProfileDisappeared` to request operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69866/ --- (Updated Feb. 12, 2019, 5:01 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 69892: Made SLRP recover node-published volumes after reboot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69892/ --- (Updated Feb. 12, 2019, 5:05 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 69893: Clean up persistent volumes on SLRP disks.

> On Feb. 5, 2019, 5:55 p.m., Benjamin Bannier wrote: > > src/resource_provider/storage/provider.cpp > > Lines 3244 (patched) > > > > > > Does this break seemless upgrades? Probably okay, but still something > >

Review Request 69954: Added a SLRP unit test for persistent block volume creation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69954/ --- Review request for mesos and Benjamin Bannier. Bugs: MESOS-9544

Review Request 69955: Added SLRP unit tests for destroying unpublished persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69955/ --- Review request for mesos and Benjamin Bannier. Bugs: MESOS-9544

Re: Review Request 69893: Clean up persistent volumes on SLRP disks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69893/ --- (Updated Feb. 12, 2019, 5:19 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 69904: Extracted common offer matching functions from SLRP tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69904/ --- (Updated Feb. 12, 2019, 5:26 a.m.) Review request for mesos and Benjamin

Re: Review Request 69895: Made SLRP `PublishResources` test to check persistent volume cleanup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69895/ --- (Updated Feb. 12, 2019, 5:20 a.m.) Review request for mesos and Benjamin

Re: Review Request 69896: Made SLRP `PublishResourcesReboot` test to check persistent volume cleanup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69896/ --- (Updated Feb. 12, 2019, 5:22 a.m.) Review request for mesos and Benjamin

Re: Review Request 69955: Added SLRP unit tests for destroying unpublished persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69955/#review212730 --- PASS: Mesos patch 69955 was successfully built and tested.

Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69890/ --- (Updated Feb. 11, 2019, 4:46 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69821/ --- (Updated Feb. 11, 2019, 4:46 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 69818: Added offer filters to static framework configuration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69818/ --- (Updated Feb. 11, 2019, 5:19 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 69889: Stored static framework offer filters in allocator framework class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69889/ --- (Updated Feb. 11, 2019, 5:19 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 69818: Added offer filters to static framework configuration.

> On Feb. 6, 2019, 6:01 p.m., James DeFelice wrote: > > include/mesos/mesos.proto > > Lines 1541 (patched) > > > > > > Each `ResourceQuantities` item here represents a "shape" that will be > > matched against a