Re: Review Request 70609: Added missing onDiscard handler in timeout case for `cgroups::destroy`.

> On May 8, 2019, 5:25 p.m., Gilbert Song wrote: > > src/linux/cgroups.cpp > > Lines 1605-1616 (original), 1605-1617 (patched) > > > > > > Seems like the commit description `onDiscarded` does not align with the >

Re: Review Request 70549: Added authorization for `UpdateQuota` call in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70549/#review215160 --- include/mesos/authorizer/authorizer.proto Lines 138-140

Re: Review Request 70591: Added `struct RoleInfo` to track role reservations and framework IDs.

> On May 6, 2019, 7:38 p.m., Meng Zhu wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Line 2119 (original), 2122 (patched) > > > > > > Shouldn't this be: > > > > ``` > > if

Re: Review Request 70589: Logged when `/__processes__` returns.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70589/ --- (Updated May 9, 2019, 1:09 p.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 70581: Add flag ignoring docker manifest config metadata.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70581/#review215172 --- docs/configuration/agent.md Lines 648 (patched)

Re: Review Request 70581: Add flag ignoring docker manifest config metadata.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70581/ --- (Updated May 9, 2019, 7 p.m.) Review request for mesos, Gilbert Song and James

Re: Review Request 70591: Added `struct RoleInfo` to track role reservations and framework IDs.

> On May 6, 2019, 12:38 p.m., Meng Zhu wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Line 2119 (original), 2122 (patched) > > > > > > Shouldn't this be: > > > > ``` > > if

Re: Review Request 70613: Randomized the agents in the second allocation stage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70613/#review215169 --- Fix it, then Ship it! Can you file a ticket for this?

Re: Review Request 70570: Logged headroom related info in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70570/#review215168 --- Fix it, then Ship it!

Re: Review Request 70581: Add flag ignoring docker manifest config metadata.

> On May 2, 2019, 10:16 p.m., James Peach wrote: > > The new flag should also be documented in the > > [upgrade](https://github.com/apache/mesos/blob/master/docs/upgrades.md) > > doc. You'll need to add a new 1.9.x section. Done. - Jacob

Re: Review Request 70583: Eliminated copying 'suppressedRoles' and changed its type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70583/#review215170 --- Fix it, then Ship it! The description links to itself? I

Re: Review Request 70531: Made using validateFrameworkSubscription() in UPDATE_FRAMEWORK possible.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70531/#review215171 --- Fix it, then Ship it! Looks like the description didn't run

Re: Review Request 70591: Added `struct RoleInfo` to track role reservations and framework IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70591/#review215166 --- src/master/allocator/mesos/hierarchical.hpp Lines 111-114

Review Request 70618: Encapsulate a framework sorter inside of a RoleInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70618/ --- Review request for mesos, Benjamin Mahler and Meng Zhu. Bugs: MESOS-9701

Re: Review Request 70596: Launched tasks with more memory in SLRP unit tests.

> On May 6, 2019, 11:55 a.m., Benjamin Bannier wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Line 1795 (original), 1795 (patched) > > > > > > Could we move this into a test class-specific

Review Request 70620: Made SLRP allow changes in volume context.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70620/ --- Review request for mesos, Benjamin Bannier and James DeFelice. Bugs:

Review Request 70622: Added a unit test to verify if SLRP allows changes in volume context.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70622/ --- Review request for mesos and Benjamin Bannier. Bugs: MESOS-9395

Re: Review Request 70579: Added a Task Scheduler to simplify testing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70579/#review215174 --- Thanks for your work on this test scheduler!

Review Request 70621: Used full paths as volume IDs for the test CSI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70621/ --- Review request for mesos and Benjamin Bannier. Bugs: MESOS-9395