Re: Review Request 70886: Override source address for executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70886/#review216400 --- Bad review! Reviews applied: [70886, 70993, 70933, 70797, 70992,

Re: Review Request 70884: Added optional 'host' string member to UPID.

> On July 3, 2019, 4:07 p.m., Benjamin Mahler wrote: > > Was the benchmark done with an optimized build? > > Can you expand on the performance implications of this change in the > > description? (e.g. compare the min, 25th percentile, median, 75th > > percentile, max of at least 10 runs).

Re: Review Request 70921: Added OpenSSL-related changes to CHANGELOG.

> On July 4, 2019, 3:12 p.m., Till Toenshoff wrote: > > docs/upgrades.md > > Lines 527 (patched) > > > > > > This is really hard to parse but right now I am unable to come up with > > something easier for the eye

Re: Review Request 70883: Added optional 'peer_hostname' argument to Socket::connect().

> On July 3, 2019, 3:38 p.m., Benjamin Mahler wrote: > > Can you discard this patch in favor of the agreed upon interface? > > > > This patch looks pretty small outside of the interface changes, so it > > should be easy to re-work into the new approach? We don't want to commit a > > confusing

Re: Review Request 70993: Added warnings about known problems with libevent epoll backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70993/ --- (Updated July 5, 2019, 1:54 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 70991: Added ability to pass custom SSL context to `Socket::connect()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70991/ --- (Updated July 5, 2019, 9:03 a.m.) Review request for mesos, Benjamin Mahler,

Review Request 71018: Fixed a race between status updates and acknowledgements in SLRP tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71018/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Greg Mann.

Re: Review Request 71018: Fixed a race between status updates and acknowledgements in SLRP tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71018/#review216405 --- Patch looks great! Reviews applied: [71018] Passed command: