Re: Review Request 71277: Guarded access to possibly destructed resource provider driver.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71277/#review217179 --- Patch looks great! Reviews applied: [71272, 71277] Passed

Re: Review Request 71272: Dispatched invocations of resource provider mock default actions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71272/#review217178 --- Ship it! Ship It! - Andrei Budnik On Авг. 13, 2019, 9:30

Re: Review Request 71263: Re-wrote the quota documentation to reflect quota limits.

> On Aug. 12, 2019, 6:51 p.m., Meng Zhu wrote: > > Thanks for adding this. I like the brevity of the doc! > > > > I think we should at least try to explain consumptions a bit. We mentioned > > this a few times in the doc, and it also shows up in the UI and endpoint > > response. > > Maybe a

Re: Review Request 71258: Tracked weight info in the Role struct in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71258/#review217186 --- Ship it! Ship It! - Benjamin Mahler On Aug. 8, 2019, 7:35

Re: Review Request 71269: Added a role tree class in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71269/ --- (Updated Aug. 13, 2019, 3:05 p.m.) Review request for mesos, Andrei Sekretenko

Re: Review Request 71275: Fixed agent draining when returning from unreachable state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71275/ --- (Updated Aug. 13, 2019, 2:13 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 71264: Cleared filters upon unsuppressing a role.

> On Aug. 12, 2019, 6:24 p.m., Meng Zhu wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Line 1343 (original), 1347 (patched) > > > > > > reviveRole might be a better function name? Yeah.. good point!

Re: Review Request 71275: Fixed agent draining when returning from unreachable state.

> On Aug. 13, 2019, 1:10 p.m., Benno Evers wrote: > > src/master/master.cpp > > Lines 7959 (patched) > > > > > > Can we already decide at this point if the agent is drained? E.g. > >

Re: Review Request 71255: Fixed and improved `Sorter::remove` function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71255/#review217185 --- Ship it! src/master/allocator/mesos/sorter/drf/sorter.cpp

Re: Review Request 71269: Added a role tree class in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71269/#review217192 --- Nice to see this, and looking forward to it tracking quota

Review Request 71283: Made sure we are tracking ephemeral quota before getting the usage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71283/ --- Review request for mesos, Andrei Budnik and Gilbert Song. Bugs: MESOS-9935

Re: Review Request 71269: Added a role tree class in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71269/#review217190 --- Bad review! Reviews applied: [71269, 71258, 71257, 71255, 71254]

Review Request 71284: Fixed a typo in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71284/ --- Review request for mesos and Meng Zhu. Repository: mesos Description ---

Re: Review Request 71275: Fixed agent draining when returning from unreachable state.

> On Aug. 13, 2019, 4:11 p.m., Greg Mann wrote: > > src/tests/api_tests.cpp > > Lines 5953 (patched) > > > > > > Is this necessary? Oh, good catch. This line doesn't add anything, since we don't expect any

Re: Review Request 71275: Fixed agent draining when returning from unreachable state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71275/#review217187 --- Fix it, then Ship it! src/tests/api_tests.cpp Lines 5953

Re: Review Request 71284: Fixed a typo in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71284/#review217191 --- Ship it! Ship It! - Meng Zhu On Aug. 13, 2019, 5:43 p.m.,

Review Request 71285: Fixed recovery of agent resources and operations after crash.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71285/ --- Review request for mesos, Gastón Kleiman, James Peach, and Joseph Wu. Bugs:

Re: Review Request 71283: Made sure we are tracking ephemeral quota before getting the usage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71283/#review217193 --- Patch looks great! Reviews applied: [71283] Passed command:

Re: Review Request 71283: Made sure we are tracking ephemeral quota before getting the usage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71283/#review217194 --- Ship it! Ship It! - Gilbert Song On Aug. 13, 2019, 3:59

Re: Review Request 71272: Dispatched invocations of resource provider mock default actions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71272/ --- (Updated Aug. 13, 2019, 11:30 a.m.) Review request for mesos, Andrei Budnik

Re: Review Request 71277: Guarded access to possibly destructed resource provider driver.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71277/#review217175 --- Patch looks great! Reviews applied: [71272, 71277] Passed

Re: Review Request 71272: Dispatched invocations of resource provider mock default actions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71272/ --- (Updated Aug. 13, 2019, 11:30 a.m.) Review request for mesos, Andrei Budnik

Review Request 71277: Guarded access to possibly destructed resource provider driver.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71277/ --- Review request for mesos, Andrei Budnik and Chun-Hung Hsiao. Bugs: MESOS-9560

Re: Review Request 71275: Fixed agent draining when returning from unreachable state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71275/#review217177 --- src/master/master.cpp Lines 7959 (patched)

Re: Review Request 71277: Guarded access to possibly destructed resource provider driver.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71277/#review217176 --- Ship it! Ship It! - Andrei Budnik On Авг. 13, 2019, 9:30