Review Request 71286: Added container transition times to the logs.

2019-08-14 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71286/ --- Review request for mesos and Gilbert Song. Repository: mesos Description

Re: Review Request 71284: Fixed a typo in the master.

2019-08-14 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71284/#review217195 --- Patch looks great! Reviews applied: [71284] Passed command:

Re: Review Request 71244: Included task group's resources in the ExecutorInfo.

2019-08-14 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71244/ --- (Updated Aug. 14, 2019, 3:52 p.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 71244: Included task group's resources in the ExecutorInfo.

2019-08-14 Thread Qian Zhang
> On Aug. 9, 2019, 1:23 a.m., Vinod Kone wrote: > > Can you add a test for this? Sure, I posted a test here: https://reviews.apache.org/r/71287/ - Qian --- This is an automatically generated e-mail. To reply, visit:

Review Request 71287: Added a test `SlaveTest.DefaultExecutorResources`.

2019-08-14 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71287/ --- Review request for mesos, Andrei Budnik and Gilbert Song. Bugs: MESOS-9925

Re: Review Request 71286: Added container transition times to the logs.

2019-08-14 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71286/#review217202 --- Bad patch! Reviews applied: [71286] Failed command: ['bash',

Re: Review Request 70096: Moved cpplint configuration into dedicated file.

2019-08-14 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70096/#review217201 --- Can you maybe clarify in the commit description what the

Re: Review Request 70096: Moved cpplint configuration into dedicated file.

2019-08-14 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70096/ --- (Updated Aug. 14, 2019, 1:25 p.m.) Review request for mesos and Benjamin

Re: Review Request 71205: Switch commit hooks to pre-commit.

2019-08-14 Thread Benjamin Bannier
> On Aug. 14, 2019, 1:04 p.m., Benno Evers wrote: > > bootstrap > > Line 55 (original), 55 (patched) > > > > > > Copying my comment from slack here so the discussion isn't split over > > too many places: > > >

Re: Review Request 71204: Added gitlint config.

2019-08-14 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71204/ --- (Updated Aug. 14, 2019, 1:24 p.m.) Review request for mesos and Till

Re: Review Request 71269: Added a role tree class in the allocator.

2019-08-14 Thread Meng Zhu
> On Aug. 13, 2019, 7:58 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.hpp > > Lines 198-199 (patched) > > > > > > The comment isn't adding value here IMO > > > > s/getR/r/ > >

Re: Review Request 71269: Added a role tree class in the allocator.

2019-08-14 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71269/ --- (Updated Aug. 14, 2019, 2:45 p.m.) Review request for mesos, Andrei Sekretenko

Re: Review Request 71285: Fixed recovery of agent resources and operations after crash.

2019-08-14 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71285/ --- (Updated Aug. 14, 2019, 10:35 p.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 71269: Added a role tree class in the allocator.

2019-08-14 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71269/#review217211 --- Bad review! Reviews applied: [71269, 71258, 71257, 71255, 71254]

Review Request 71291: Refactored (un)trackReservations() in the allocator.

2019-08-14 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71291/ --- Review request for mesos, Andrei Sekretenko and Benjamin Mahler. Repository:

Re: Review Request 71291: Refactored (un)trackReservations() in the allocator.

2019-08-14 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71291/#review217213 --- Bad review! Reviews applied: [71291, 71269, 71258, 71257, 71255,

Re: Review Request 71286: Added container transition times to the logs.

2019-08-14 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71286/#review217214 --- Patch looks great! Reviews applied: [71286] Passed command:

Re: Review Request 71285: Fixed recovery of agent resources and operations after crash.

2019-08-14 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71285/#review217215 --- src/slave/slave.cpp Lines 4430 (patched)

Re: Review Request 71285: Fixed recovery of agent resources and operations after crash.

2019-08-14 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71285/#review217198 --- Patch looks great! Reviews applied: [71285] Passed command:

Re: Review Request 71205: Switch commit hooks to pre-commit.

2019-08-14 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71205/#review217200 --- bootstrap Line 55 (original), 55 (patched)

Re: Review Request 71206: Removed old mesos-style and references.

2019-08-14 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71206/#review217199 --- After applying this series for testing purposes, I ran into a

Re: Review Request 71209: Enabled a number of additional pre-commit checks.

2019-08-14 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71209/#review217204 --- Patch looks great! Reviews applied: [70096, 71203, 71204, 71205,

[GitHub] [mesos] lava commented on a change in pull request #341: Remove unnecessary logging.

2019-08-14 Thread GitBox
lava commented on a change in pull request #341: Remove unnecessary logging. URL: https://github.com/apache/mesos/pull/341#discussion_r313886115 ## File path: src/slave/slave.cpp ## @@ -7157,11 +7157,6 @@ void Slave::_checkDiskUsage(const Future& usage) LOG(ERROR) <<

Review Request 71289: Fixed out-of-order processing of requests in composing containerizer.

2019-08-14 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71289/ --- Review request for mesos, Gilbert Song, Greg Mann, and Qian Zhang. Bugs:

Review Request 71137: Added a test to ensure composing containerizer preserves request order.

2019-08-14 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71137/ --- Review request for mesos, Gilbert Song, Greg Mann, and Qian Zhang. Summary

Re: Review Request 71284: Fixed a typo in the master.

2019-08-14 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71284/#review217206 --- Ship it! Ship It! - Joseph Wu On Aug. 13, 2019, 5:43 p.m.,

Re: Review Request 71137: Added a test to ensure composing containerizer preserves request order.

2019-08-14 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71137/#review217210 --- Patch looks great! Reviews applied: [71289, 71137] Passed

[GitHub] [mesos] bgalek commented on issue #341: Remove unnecessary logging.

2019-08-14 Thread GitBox
bgalek commented on issue #341: Remove unnecessary logging. URL: https://github.com/apache/mesos/pull/341#issuecomment-521279359 @vinodkone nope, just thought it was duplication of metric This is an automated message from the

[GitHub] [mesos] vinodkone commented on issue #341: Remove unnecessary logging.

2019-08-14 Thread GitBox
vinodkone commented on issue #341: Remove unnecessary logging. URL: https://github.com/apache/mesos/pull/341#issuecomment-521271763 This log line has been valuable to see disk usage over time from logs when we encountered disk full issues. A metric is not a substitute because we would

Re: Review Request 71287: Added a test `SlaveTest.DefaultExecutorResources`.

2019-08-14 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71287/#review217207 --- Patch looks great! Reviews applied: [71244, 71287] Passed