Re: Review Request 71150: Factored out storage provider method to update resources.

2019-08-15 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71150/ --- (Updated Aug. 15, 2019, 3:31 p.m.) Review request for mesos and Chun-Hung

Re: Review Request 71151: Performed periodic storage local provider reconciliations.

2019-08-15 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71151/ --- (Updated Aug. 15, 2019, 3:31 p.m.) Review request for mesos and Chun-Hung

Re: Review Request 71269: Added a role tree class in the allocator.

2019-08-15 Thread Benjamin Mahler
> On Aug. 14, 2019, 2:58 a.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.hpp > > Lines 212-215 (patched) > > > > > > Ditto here, it seems at the overall explanation of the RoleTree > >

Re: Review Request 71151: Performed periodic storage local provider reconciliations.

2019-08-15 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71151/#review217217 --- Patch looks great! Reviews applied: [71143, 71144, 71145, 71146,

Re: Review Request 71291: Refactored (un)trackReservations() in the allocator.

2019-08-15 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71291/#review217219 --- Ship it! - Benjamin Mahler On Aug. 14, 2019, 9:46 p.m., Meng

Re: Review Request 71287: Added a test `SlaveTest.DefaultExecutorResources`.

2019-08-15 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71287/#review217231 --- Ship it! Ship It! - Gilbert Song On Aug. 14, 2019, 12:54

Re: Review Request 71244: Included task group's resources in the ExecutorInfo.

2019-08-15 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71244/#review217230 --- Ship it! Ship It! - Gilbert Song On Aug. 14, 2019, 12:52

Re: Review Request 71201: Implemented `cleanup` method for `volume/secret` isolator.

2019-08-15 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71201/#review217224 --- Ship it! Ship It! - Gilbert Song On July 31, 2019, 12:04

Re: Review Request 71222: Added a test `VolumeSecretIsolatorCleanupTest.ROOT_FailInPreparing`.

2019-08-15 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71222/#review217227 --- Ship it! Ship It! - Gilbert Song On Aug. 1, 2019, 12:18

Re: Review Request 71286: Added container transition times to the logs.

2019-08-15 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71286/#review217228 --- Ship it! Ship It! - Gilbert Song On Aug. 13, 2019, 11:12

Re: Review Request 71221: Moved const string `.secret` to paths.hpp.

2019-08-15 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71221/#review217225 --- Ship it! Ship It! - Gilbert Song On Aug. 1, 2019, 12:16

Re: Review Request 71174: Recovered network info for nested/standalone containers in CNI isolator.

2019-08-15 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71174/#review217229 --- Is it possible to avoid adding container_info in state? This is

Re: Review Request 71291: Refactored (un)trackReservations() in the allocator.

2019-08-15 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71291/#review217233 --- Bad review! Reviews applied: [71291, 71269, 71258, 71257, 71255,

Re: Review Request 71269: Added a role tree class in the allocator.

2019-08-15 Thread Meng Zhu
> On Aug. 13, 2019, 7:58 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.hpp > > Lines 231 (patched) > > > > > > This can be `hashmap` which would avoid the > > potential leak of forgetting

Re: Review Request 71269: Added a role tree class in the allocator.

2019-08-15 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71269/ --- (Updated Aug. 15, 2019, 8:36 p.m.) Review request for mesos, Andrei Sekretenko