Re: Review Request 71299: Added separate script to install developer setup.

2019-08-19 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71299/ --- (Updated Aug. 19, 2019, 9:19 a.m.) Review request for mesos, Benno Evers and

Re: Review Request 71209: Enabled a number of additional pre-commit checks.

2019-08-19 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71209/ --- (Updated Aug. 19, 2019, 9:20 a.m.) Review request for mesos and Till

Re: Review Request 71203: Added check script to check for license headers.

2019-08-19 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71203/ --- (Updated Aug. 19, 2019, 9:20 a.m.) Review request for mesos and Till

Re: Review Request 71205: Switched commit hooks to pre-commit.

2019-08-19 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71205/ --- (Updated Aug. 19, 2019, 9:20 a.m.) Review request for mesos and Till

Review Request 71310: Stripped metadata and non-scalars from GET_ROLES resources.

2019-08-19 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71310/ --- Review request for mesos, Andrei Sekretenko and Meng Zhu. Bugs: MESOS-9758

Review Request 71312: Made RoleTree class default constructable.

2019-08-19 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71312/ --- Review request for mesos, Andrei Sekretenko and Benjamin Mahler. Repository:

Review Request 71311: Added method to dump role tree state for debugging.

2019-08-19 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71311/ --- Review request for mesos, Andrei Sekretenko and Benjamin Mahler. Repository:

Re: Review Request 71289: Fixed out-of-order processing of requests in composing containerizer.

2019-08-19 Thread Andrei Budnik
> On Авг. 19, 2019, 12:02 п.п., Qian Zhang wrote: > > src/slave/containerizer/composing.cpp > > Lines 662 (patched) > > > > > > Why do we need to call `wait` here? In this case (i.e., > > `finalAcknowledgement` is

Re: Review Request 71309: Added more details to the Bintray release guide.

2019-08-19 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71309/#review217297 --- Patch looks great! Reviews applied: [71309] Passed command:

Re: Review Request 71309: Added more details to the Bintray release guide.

2019-08-19 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71309/#review217294 --- Ship it! Ship It! - Vinod Kone On Aug. 19, 2019, 5:03 p.m.,

Re: Review Request 71269: Added a role tree class in the allocator.

2019-08-19 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71269/#review217292 --- Fix it, then Ship it! * I think another bug was introduced

Re: Review Request 71151: Performed periodic storage local provider reconciliations.

2019-08-19 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71151/#review217295 --- Patch looks great! Reviews applied: [71143, 71144, 71145, 71146,

Review Request 71309: Added more details to the Bintray release guide.

2019-08-19 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71309/ --- Review request for mesos, Greg Mann, Joseph Wu, Till Toenshoff, and Vinod Kone.

Re: Review Request 71303: Tracked frameworks in the role sorter.

2019-08-19 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71303/#review217293 --- What's the thinking on taking the allocator's framework struct?

Re: Review Request 71312: Made RoleTree class default constructable.

2019-08-19 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71312/#review217298 --- Ship it! src/master/allocator/mesos/hierarchical.hpp Lines

Review Request 71313: Added a test for RoleTree for basic add and remove operations.

2019-08-19 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71313/ --- Review request for mesos, Andrei Sekretenko and Benjamin Mahler. Repository:

Re: Review Request 71269: Added a role tree class in the allocator.

2019-08-19 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71269/ --- (Updated Aug. 19, 2019, 2:08 p.m.) Review request for mesos, Andrei Sekretenko

Re: Review Request 71303: Tracked frameworks in the role sorter.

2019-08-19 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71303/#review217301 --- Bad review! Reviews applied: [71303, 71301, 71269, 71258, 71257,

Review Request 71316: Added draining tests for empty agents.

2019-08-19 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71316/ --- Review request for mesos, Benno Evers and Greg Mann. Bugs: MESOS-9892

Re: Review Request 71313: Added a test for RoleTree for basic add and remove operations.

2019-08-19 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71313/#review217306 --- Fix it, then Ship it! Thanks! We could probably unit test the

Review Request 71318: Added agent reactivations to the existing agent draining tests.

2019-08-19 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71318/ --- Review request for mesos, Benno Evers and Greg Mann. Bugs: MESOS-9892

Review Request 71317: Added draining test for momentarily disconnected agents.

2019-08-19 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71317/ --- Review request for mesos, Benno Evers and Greg Mann. Bugs: MESOS-9892

Re: Review Request 71313: Added a test for RoleTree for basic add and remove operations.

2019-08-19 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71313/#review217299 --- src/tests/sorter_tests.cpp Lines 2188 (patched)

Re: Review Request 71311: Added method to dump role tree state for debugging.

2019-08-19 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71311/#review217300 --- Fix it, then Ship it!

Re: Review Request 71313: Added a test for RoleTree for basic add and remove operations.

2019-08-19 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71313/ --- (Updated Aug. 19, 2019, 3:34 p.m.) Review request for mesos, Andrei Sekretenko

Re: Review Request 71285: Fixed recovery of agent resources and operations after crash.

2019-08-19 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71285/ --- (Updated Aug. 19, 2019, 10:54 p.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 71313: Added a test for RoleTree for basic add and remove operations.

2019-08-19 Thread Meng Zhu
> On Aug. 19, 2019, 4:12 p.m., Benjamin Mahler wrote: > > Thanks! > > > > We could probably unit test the `empty()` function (for each case), then > > for role tracking, we could use one case (e.g. weights) to test more cases. > > Specifically, right now we are only testing the case wehre

Re: Review Request 71303: Tracked frameworks in the role sorter.

2019-08-19 Thread Meng Zhu
> On Aug. 19, 2019, 9:44 a.m., Benjamin Mahler wrote: > > What's the thinking on taking the allocator's framework struct? Why not > > just take the information we need so that we can keep the interface > > self-contained? One of the goals of this refactoring is to eliminate state duplication

Review Request 71315: Refactored master draining test setup.

2019-08-19 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71315/ --- Review request for mesos, Benno Evers and Greg Mann. Bugs: MESOS-9892

Review Request 71314: Moved master-side agent draining tests into a separate file.

2019-08-19 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71314/ --- Review request for mesos, Benno Evers and Greg Mann. Bugs: MESOS-9892

Re: Review Request 71285: Fixed recovery of agent resources and operations after crash.

2019-08-19 Thread Greg Mann
> On Aug. 15, 2019, 5:14 a.m., James Peach wrote: > > src/slave/state.cpp > > Lines 819 (patched) > > > > > > `state::read` can already return `None()`, so what do you think about > > letting it return `None()`

Re: Review Request 71301: Added a framework id field to the allocator Framework struct.

2019-08-19 Thread Meng Zhu
> On Aug. 19, 2019, 7 a.m., Andrei Sekretenko wrote: > > src/master/allocator/mesos/hierarchical.hpp > > Lines 83 (patched) > > > > > > What is wrong with `FrameworkInfo.id()`? Do we really need a separate > >

Re: Review Request 71150: Factored out storage provider method to update resources.

2019-08-19 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71150/#review217314 --- Ship it! Ship It! - Chun-Hung Hsiao On Aug. 19, 2019, 11:58

Re: Review Request 71310: Stripped metadata and non-scalars from GET_ROLES resources.

2019-08-19 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71310/#review217318 --- Bad patch! Reviews applied: [71310] Failed command: ['bash',

Re: Review Request 71151: Performed periodic storage local provider reconciliations.

2019-08-19 Thread Chun-Hung Hsiao
> On Aug. 9, 2019, 7:41 a.m., Chun-Hung Hsiao wrote: > > src/resource_provider/storage/provider.cpp > > Line 752 (original), 811 (patched) > > > > > > As commented in the previous patch, since we're having two

Re: Review Request 71150: Factored out storage provider method to update resources.

2019-08-19 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71150/#review217316 --- src/resource_provider/storage/provider.cpp Lines 722-723

Re: Review Request 71137: Added a test to ensure composing containerizer preserves request order.

2019-08-19 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71137/#review217311 --- Patch looks great! Reviews applied: [71289, 71137] Passed

Re: Review Request 71151: Performed periodic storage local provider reconciliations.

2019-08-19 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71151/#review217315 --- Fix it, then Ship it!

Re: Review Request 71206: Removed old mesos-style and references.

2019-08-19 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71206/#review217279 --- Fix it, then Ship it! docs/c++-style-guide.md Line 10

Re: Review Request 71203: Added check script to check for license headers.

2019-08-19 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71203/#review217281 --- Ship it! Ship It! - Benno Evers On Aug. 19, 2019, 7:20

Re: Review Request 70096: Moved cpplint configuration into dedicated file.

2019-08-19 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70096/#review217282 --- Ship it! Ship It! - Benno Evers On Aug. 14, 2019, 11:25

Re: Review Request 71297: Fixed a flaky operation reconciliation test.

2019-08-19 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71297/#review217291 --- Patch looks great! Reviews applied: [71297] Passed command:

Re: Review Request 71289: Fixed out-of-order processing of requests in composing containerizer.

2019-08-19 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71289/#review217272 --- src/slave/containerizer/composing.cpp Line 136 (original),

Re: Review Request 71204: Added gitlint config.

2019-08-19 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71204/#review217280 --- Ship it! Ship It! - Benno Evers On Aug. 14, 2019, 11:24

Re: Review Request 71207: Revert "Updated cpplint.py to be less verbose when there is no linting issue."

2019-08-19 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71207/#review217285 --- Ship it! Ship It! - Benno Evers On July 30, 2019, 9:01

Re: Review Request 71205: Switched commit hooks to pre-commit.

2019-08-19 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71205/#review217283 --- Ship it! Ship It! - Benno Evers On Aug. 19, 2019, 7:20

Re: Review Request 71209: Enabled a number of additional pre-commit checks.

2019-08-19 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71209/#review217284 --- Ship it! Ship It! - Benno Evers On Aug. 19, 2019, 7:20

Re: Review Request 71150: Factored out storage provider method to update resources.

2019-08-19 Thread Benjamin Bannier
> On Aug. 9, 2019, 9:22 a.m., Chun-Hung Hsiao wrote: > > src/resource_provider/storage/provider.cpp > > Lines 979-995 (patched) > > > > > > Sorry for not making my suggestion clear enough. I was actually > >

Re: Review Request 71151: Performed periodic storage local provider reconciliations.

2019-08-19 Thread Benjamin Bannier
> On Aug. 9, 2019, 9:41 a.m., Chun-Hung Hsiao wrote: > > src/resource_provider/storage/provider.cpp > > Line 752 (original), 811 (patched) > > > > > > As commented in the previous patch, since we're having two

Re: Review Request 71151: Performed periodic storage local provider reconciliations.

2019-08-19 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71151/ --- (Updated Aug. 19, 2019, 1:58 p.m.) Review request for mesos and Chun-Hung

Re: Review Request 71150: Factored out storage provider method to update resources.

2019-08-19 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71150/ --- (Updated Aug. 19, 2019, 1:58 p.m.) Review request for mesos and Chun-Hung

[GitHub] [mesos] bbannier opened a new pull request #342: Made `support/cpplint.py` executable.

2019-08-19 Thread GitBox
bbannier opened a new pull request #342: Made `support/cpplint.py` executable. URL: https://github.com/apache/mesos/pull/342 This allows invoking cpplint from outside the linter setup so that one can make use of our patched cpplint even when not using mesos-style.

Re: Review Request 71208: Revert "Updated cpplint to be compatible with Python 3."

2019-08-19 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71208/#review217286 --- Ship it! Ship It! - Benno Evers On July 30, 2019, 9:01

Re: Review Request 71297: Fixed a flaky operation reconciliation test.

2019-08-19 Thread Benno Evers
> On Aug. 16, 2019, 2:43 p.m., Andrei Sekretenko wrote: > > src/tests/operation_reconciliation_tests.cpp > > Lines 1842 (patched) > > > > > > We are restarting the master once, but the scheduler gets > >

Re: Review Request 71297: Fixed a flaky operation reconciliation test.

2019-08-19 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71297/ --- (Updated Aug. 19, 2019, 12:36 p.m.) Review request for mesos, Andrei

Re: Review Request 71301: Added a framework id field to the allocator Framework struct.

2019-08-19 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71301/#review217290 --- src/master/allocator/mesos/hierarchical.hpp Lines 83 (patched)

Re: Review Request 71300: Removed mesos-style transition script.

2019-08-19 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71300/#review217275 --- Patch looks great! Reviews applied: [70096, 71203, 71204, 71299,

Re: Review Request 71299: Added separate script to install developer setup.

2019-08-19 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71299/#review217278 --- Fix it, then Ship it! docs/advanced-contribution.md Line 69

[GitHub] [mesos] bbannier merged pull request #342: Made `support/cpplint.py` executable.

2019-08-19 Thread GitBox
bbannier merged pull request #342: Made `support/cpplint.py` executable. URL: https://github.com/apache/mesos/pull/342 This is an automated message from the Apache Git Service. To respond to the message, please log on to