Re: Review Request 71205: Switched commit hooks to pre-commit.

2019-09-10 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71205/ --- (Updated Sept. 10, 2019, 12:02 p.m.) Review request for mesos and Till

Re: Review Request 71455: Implemented an integration test for /containerizer/debug endpoint.

2019-09-10 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71455/#review217679 --- Bad patch! Reviews applied: [71454, 71455] Failed command:

Review Request 71464: Allowed setting quota the default "*" role.

2019-09-10 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71464/ --- Review request for mesos, Andrei Sekretenko and Benjamin Mahler. Bugs:

Re: Review Request 71457: Activated tests for `src/python/lib`.

2019-09-10 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71457/#review217672 --- Patch looks great! Reviews applied: [71457] Passed command:

Re: Review Request 71300: Removed mesos-style transition script.

2019-09-10 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71300/#review217674 --- Patch looks great! Reviews applied: [70096, 71203, 71204, 71299,

Re: Review Request 71464: Allowed setting quota the default "*" role.

2019-09-10 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71464/#review217684 --- Patch looks great! Reviews applied: [71464] Passed command:

Re: Review Request 71460: Tracked offered and allocated resources in the role tree.

2019-09-10 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71460/#review217681 --- Patch looks great! Reviews applied: [71459, 71460] Passed

Re: Review Request 71460: Tracked offered and allocated resources in the role tree.

2019-09-10 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71460/#review217673 --- src/master/allocator/mesos/hierarchical.cpp Lines 416-422

Re: Review Request 71460: Tracked offered and allocated resources in the role tree.

2019-09-10 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71460/#review217676 --- Patch looks great! Reviews applied: [71459, 71460] Passed

Re: Review Request 71460: Tracked offered and allocated resources in the role tree.

2019-09-10 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71460/ --- (Updated Sept. 10, 2019, 11 a.m.) Review request for mesos, Andrei Sekretenko

Re: Review Request 71460: Tracked offered and allocated resources in the role tree.

2019-09-10 Thread Meng Zhu
> On Sept. 10, 2019, 8:16 a.m., Andrei Sekretenko wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 416-422 (patched) > > > > > > Hmm... when `rolesConsumedQuota` was calculated using > >