Review Request 71725: Added end-to-end test for operator API reservation updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71725/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description

Re: Review Request 71729: Added authorization handling for reservations with `source`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71729/#review218527 --- Bad review! Reviews applied: [71729] Error: No reviewers

Re: Review Request 71687: Rejected scheduler calls that include reservation updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71687/#review218530 --- src/master/master.cpp Lines 4489 (patched)

Re: Review Request 71725: Added end-to-end test for operator API reservation updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71725/#review218531 --- Bad review! Reviews applied: [71725, 71729] Error: No reviewers

Re: Review Request 71690: Added function to compute a common reservation ancestor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71690/#review218533 --- src/common/resources.cpp Line 612 (original)

Review Request 71732: Fixed an incorrect resource mutation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71732/ --- Review request for mesos, Benno Evers and Greg Mann. Repository: mesos

Re: Review Request 71695: Updated 'Master::Http::_reserve' to pass along new 'source' field.

> On Nov. 6, 2019, 2:35 a.m., Greg Mann wrote: > > src/master/http.cpp > > Lines 1988 (patched) > > > > > > Should this be an Option? Since it isn't, it seems like we will set the > > `source` field to a

Re: Review Request 71695: Updated 'Master::Http::_reserve' to pass along new 'source' field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71695/#review218541 --- Ship it! Ship It! - Benjamin Bannier On Nov. 5, 2019, 2:25

Re: Review Request 71719: Updated 'getResourceConversion()' for reservation updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71719/#review218536 --- Ship it! Ship It! - Benjamin Bannier On Nov. 6, 2019, 12:06

Re: Review Request 71679: Added 'source' field to operator reservation API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71679/#review218528 --- Ship it! Ship It! - Benjamin Bannier On Oct. 29, 2019, 7:13

Re: Review Request 71686: Added 'source' field to scheduler reservation API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71686/#review218529 --- Ship it! Ship It! - Benjamin Bannier On Oct. 29, 2019, 7:15

Re: Review Request 71696: Updated validation of 'Reserve' call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71696/#review218534 --- Ship it! Ship It! - Benjamin Bannier On Nov. 5, 2019, 2:25

Re: Review Request 71700: Updated offer operation resource validation for reservation updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71700/#review218535 --- Ship it! Patch looks great! - Benjamin Bannier On Oct. 29,

Re: Review Request 71688: Reject operator API calls that include reservation updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71688/#review218532 --- Ship it! Ship It! - Benjamin Bannier On Nov. 1, 2019, 5:01

Re: Review Request 71725: Added end-to-end test for operator API reservation updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71725/#review218537 --- Fix it, then Ship it! Nice approach to make the "meat" of the

Review Request 71719: Updated 'getResourceConversion()' for reservation updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71719/ --- Review request for mesos. Repository: mesos Description --- Updated the

Re: Review Request 71695: Updated 'Master::Http::_reserve' to pass along new 'source' field.

> On Nov. 6, 2019, 1:35 a.m., Greg Mann wrote: > > src/master/http.cpp > > Lines 1988 (patched) > > > > > > Should this be an Option? Since it isn't, it seems like we will set the > > `source` field to a

Review Request 71729: Added authorization handling for reservations with `source`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71729/ --- Review request for mesos and Benno Evers. Bugs: MESOS-9991

Re: Review Request 71734: Revamped attribute handling in stout.

> On Nov. 6, 2019, 5:03 p.m., Benjamin Bannier wrote: > > 3rdparty/stout/include/stout/exit.hpp > > Line 65 (original), 65 (patched) > > > > > > nit: single line? > > Benno Evers wrote: > I thought about it, but

Re: Review Request 71734: Revamped attribute handling in stout.

> On Nov. 6, 2019, 5:03 p.m., Benjamin Bannier wrote: > > 3rdparty/stout/include/stout/attributes.hpp > > Lines 17 (patched) > > > > > > Did you want to export this macro? I am not sure it would be useful > >

Re: Review Request 71725: Added end-to-end test for operator API reservation updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71725/ --- (Updated Nov. 6, 2019, 3:54 p.m.) Review request for mesos and Benjamin

Re: Review Request 71734: Revamped attribute handling in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71734/#review218544 --- Fix it, then Ship it!

Re: Review Request 71734: Revamped attribute handling in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71734/ --- (Updated Nov. 6, 2019, 3:56 p.m.) Review request for mesos, Benjamin Bannier,

Review Request 71735: Added 'nodiscard' attribute to some Resources member functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71735/ --- Review request for mesos, Benjamin Bannier and Greg Mann. Repository: mesos

Review Request 71734: Revamped attribute handling in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71734/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Greg Mann.

Re: Review Request 71725: Added end-to-end test for operator API reservation updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71725/ --- (Updated Nov. 6, 2019, 3:53 p.m.) Review request for mesos and Benjamin

Re: Review Request 71732: Fixed an incorrect resource mutation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71732/#review218543 --- Patch looks great! Reviews applied: [71732] Passed command:

Re: Review Request 71687: Rejected scheduler calls that include reservation updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71687/ --- (Updated Nov. 6, 2019, 3:50 p.m.) Review request for mesos and Benjamin

Re: Review Request 71690: Added function to compute a common reservation ancestor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71690/ --- (Updated Nov. 6, 2019, 3:52 p.m.) Review request for mesos and Benjamin

Re: Review Request 71729: Added authorization handling for reservations with `source`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71729/#review218545 --- src/master/master.cpp Lines 3810 (patched)

Re: Review Request 71734: Revamped attribute handling in stout.

> On Nov. 6, 2019, 4:03 p.m., Benjamin Bannier wrote: > > 3rdparty/stout/include/stout/attributes.hpp > > Lines 17 (patched) > > > > > > Did you want to export this macro? I am not sure it would be useful > >

Re: Review Request 71735: Added 'nodiscard' attribute to some Resources member functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71735/#review218551 --- Bad patch! Reviews applied: [71734, 71735] Failed command:

Re: Review Request 71725: Added end-to-end test for operator API reservation updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71725/#review218553 --- Bad review! Reviews applied: [71725, 71729] Error: No reviewers