Review Request 72003: Used persisted information to decide if an executor is agent-generated.

2020-01-15 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72003/ --- Review request for mesos, Andrei Sekretenko and Benjamin Mahler. Bugs: MESOS-10

Review Request 72002: Added `ExecutorInfo` field to tag agent-generated executors.

2020-01-15 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72002/ --- Review request for mesos, Andrei Sekretenko and Benjamin Mahler. Bugs: MESOS-10

Re: Review Request 72003: Used persisted information to decide if an executor is agent-generated.

2020-01-15 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72003/#review219270 --- src/slave/slave.cpp Line 6583 (original), 6583 (patched)

Re: Review Request 71858: WIP: Set resource limits when launching executor container.

2020-01-15 Thread Qian Zhang
> On Jan. 8, 2020, 5:43 a.m., Greg Mann wrote: > > src/slave/slave.cpp > > Lines 3140-3201 (patched) > > > > > > I think maybe this logic could be easier to read if we do something > > like: > > > > ``` >

Re: Review Request 72003: Used persisted information to decide if an executor is agent-generated.

2020-01-15 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72003/#review219272 --- Patch looks great! Reviews applied: [72002, 72003] Passed comman

Re: Review Request 71944: Set container process's OOM score adjust.

2020-01-15 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71944/ --- (Updated Jan. 15, 2020, 10:20 p.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 71944: Set container process's OOM score adjust.

2020-01-15 Thread Qian Zhang
> On Jan. 8, 2020, 7:07 a.m., Greg Mann wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp > > Lines 199 (patched) > > > > > > Do we really want to do this? My concern is that this will

Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs` to check CFS quota.

2020-01-15 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71953/ --- (Updated Jan. 15, 2020, 10:24 p.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 71956: Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.

2020-01-15 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71956/ --- (Updated Jan. 15, 2020, 10:24 p.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 72003: Used persisted information to decide if an executor is agent-generated.

2020-01-15 Thread Benjamin Bannier
> On Jan. 15, 2020, 2:55 p.m., Andrei Sekretenko wrote: > > src/slave/slave.cpp > > Lines 6593 (patched) > > > > > > The logic "executor is generated by agent -> master receives no > > updates" is not covered by an

Re: Review Request 72003: Used persisted information to decide if an executor is agent-generated.

2020-01-15 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72003/ --- (Updated Jan. 15, 2020, 4:12 p.m.) Review request for mesos, Andrei Sekretenko

Re: Review Request 71966: Cgroups isolator: added support for nested cgroups during recovery.

2020-01-15 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71966/#review219275 --- Bad patch! Reviews applied: [71855, 71931, 71856, 71858, 71884, 7

Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.

2020-01-15 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71983/#review219276 --- Bad patch! Reviews applied: [71855, 71931, 71856, 71858, 71884, 7

Re: Review Request 72003: Used persisted information to decide if an executor is agent-generated.

2020-01-15 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72003/#review219277 --- Bad patch! Reviews applied: [72002, 72003] Failed command: ['bas

Re: Review Request 72003: Used persisted information to decide if an executor is agent-generated.

2020-01-15 Thread Benjamin Bannier
> On Jan. 15, 2020, 2:55 p.m., Andrei Sekretenko wrote: > > src/slave/slave.cpp > > Line 6583 (original), 6583 (patched) > > > > > > If we are not validating that `ExecutorInfo` of a task does not have > > `generat