[GitHub] [mesos] qianzhangxa commented on a change in pull request #355: Handle EBUSY when destroying a cgroup.

2020-04-10 Thread GitBox
qianzhangxa commented on a change in pull request #355: Handle EBUSY when destroying a cgroup. URL: https://github.com/apache/mesos/pull/355#discussion_r406738281 ## File path: src/linux/cgroups.cpp ## @@ -263,6 +265,70 @@ static Try cloneCpusetCpusMems( return

[GitHub] [mesos] qianzhangxa commented on a change in pull request #355: Handle EBUSY when destroying a cgroup.

2020-04-10 Thread GitBox
qianzhangxa commented on a change in pull request #355: Handle EBUSY when destroying a cgroup. URL: https://github.com/apache/mesos/pull/355#discussion_r406760777 ## File path: src/linux/cgroups.cpp ## @@ -263,6 +265,70 @@ static Try cloneCpusetCpusMems( return

[GitHub] [mesos] qianzhangxa commented on a change in pull request #355: Handle EBUSY when destroying a cgroup.

2020-04-10 Thread GitBox
qianzhangxa commented on a change in pull request #355: Handle EBUSY when destroying a cgroup. URL: https://github.com/apache/mesos/pull/355#discussion_r406744824 ## File path: src/linux/cgroups.cpp ## @@ -263,6 +265,70 @@ static Try cloneCpusetCpusMems( return

[GitHub] [mesos] qianzhangxa commented on a change in pull request #355: Handle EBUSY when destroying a cgroup.

2020-04-10 Thread GitBox
qianzhangxa commented on a change in pull request #355: Handle EBUSY when destroying a cgroup. URL: https://github.com/apache/mesos/pull/355#discussion_r406729204 ## File path: src/linux/cgroups.cpp ## @@ -263,6 +265,70 @@ static Try cloneCpusetCpusMems( return

[GitHub] [mesos] qianzhangxa commented on a change in pull request #355: Handle EBUSY when destroying a cgroup.

2020-04-10 Thread GitBox
qianzhangxa commented on a change in pull request #355: Handle EBUSY when destroying a cgroup. URL: https://github.com/apache/mesos/pull/355#discussion_r406727510 ## File path: src/linux/cgroups.cpp ## @@ -263,6 +265,70 @@ static Try cloneCpusetCpusMems( return

Re: Review Request 72349: Added logging of peer address in OpenSSLSocket accept failures.

2020-04-10 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72349/#review220286 --- Patch looks great! Reviews applied: [72348, 72349] Passed

[GitHub] [mesos] cf-natali commented on a change in pull request #355: Handle EBUSY when destroying a cgroup.

2020-04-10 Thread GitBox
cf-natali commented on a change in pull request #355: Handle EBUSY when destroying a cgroup. URL: https://github.com/apache/mesos/pull/355#discussion_r406854135 ## File path: src/linux/cgroups.cpp ## @@ -263,6 +265,70 @@ static Try cloneCpusetCpusMems( return

[GitHub] [mesos] cf-natali commented on a change in pull request #355: Handle EBUSY when destroying a cgroup.

2020-04-10 Thread GitBox
cf-natali commented on a change in pull request #355: Handle EBUSY when destroying a cgroup. URL: https://github.com/apache/mesos/pull/355#discussion_r406854300 ## File path: src/linux/cgroups.cpp ## @@ -263,6 +265,70 @@ static Try cloneCpusetCpusMems( return

[GitHub] [mesos] cf-natali commented on a change in pull request #355: Handle EBUSY when destroying a cgroup.

2020-04-10 Thread GitBox
cf-natali commented on a change in pull request #355: Handle EBUSY when destroying a cgroup. URL: https://github.com/apache/mesos/pull/355#discussion_r406855188 ## File path: src/linux/cgroups.cpp ## @@ -263,6 +265,70 @@ static Try cloneCpusetCpusMems( return

[GitHub] [mesos] cf-natali commented on a change in pull request #355: Handle EBUSY when destroying a cgroup.

2020-04-10 Thread GitBox
cf-natali commented on a change in pull request #355: Handle EBUSY when destroying a cgroup. URL: https://github.com/apache/mesos/pull/355#discussion_r406855125 ## File path: src/linux/cgroups.cpp ## @@ -263,6 +265,70 @@ static Try cloneCpusetCpusMems( return

[GitHub] [mesos] cf-natali commented on issue #355: Handle EBUSY when destroying a cgroup.

2020-04-10 Thread GitBox
cf-natali commented on issue #355: Handle EBUSY when destroying a cgroup. URL: https://github.com/apache/mesos/pull/355#issuecomment-612129236 > It seems the existing method `cgroups::remove` is not used anywhere except in the unit test codes, so do we still need it? Or we want to change

[GitHub] [mesos] cf-natali commented on a change in pull request #355: Handle EBUSY when destroying a cgroup.

2020-04-10 Thread GitBox
cf-natali commented on a change in pull request #355: Handle EBUSY when destroying a cgroup. URL: https://github.com/apache/mesos/pull/355#discussion_r406855260 ## File path: src/linux/cgroups.cpp ## @@ -263,6 +265,70 @@ static Try cloneCpusetCpusMems( return

Review Request 72349: Added logging of peer address in OpenSSLSocket accept failures.

2020-04-10 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72349/ --- Review request for mesos and Greg Mann. Bugs: MESOS-10112

Review Request 72348: Added logging of peer address in LibeventSSLSocket accept failures.

2020-04-10 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72348/ --- Review request for mesos and Greg Mann. Bugs: MESOS-10112

Review Request 72354: Fixed libevent SSL socket shutdown race condition.

2020-04-10 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72354/ --- Review request for mesos, Andrei Sekretenko and Benjamin Mahler. Bugs:

Review Request 72355: WIP: Tested fix for race condition in the libevent SSL socket.

2020-04-10 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72355/ --- Review request for mesos, Andrei Sekretenko and Benjamin Mahler. Bugs: