[GitHub] [mesos] asekretenko commented on a change in pull request #363: CMake enable install module dependencies.

asekretenko commented on a change in pull request #363: URL: https://github.com/apache/mesos/pull/363#discussion_r429774545 ## File path: 3rdparty/CMakeLists.txt ## @@ -459,6 +459,11 @@ install( DIRECTORY ${GLOG_INSTALL_DIR}/lib/ DESTINATION ${MESOS_INSTALL_LIBRARIES})

[GitHub] [mesos] asekretenko commented on a change in pull request #363: CMake enable install module dependencies.

asekretenko commented on a change in pull request #363: URL: https://github.com/apache/mesos/pull/363#discussion_r429774545 ## File path: 3rdparty/CMakeLists.txt ## @@ -459,6 +459,11 @@ install( DIRECTORY ${GLOG_INSTALL_DIR}/lib/ DESTINATION ${MESOS_INSTALL_LIBRARIES})

[GitHub] [mesos] asekretenko commented on a change in pull request #363: CMake enable install module dependencies.

asekretenko commented on a change in pull request #363: URL: https://github.com/apache/mesos/pull/363#discussion_r429766695 ## File path: src/CMakeLists.txt ## @@ -675,6 +675,13 @@ install( RUNTIME DESTINATION ${MESOS_INSTALL_RUNTIME} ARCHIVE DESTINATION

Re: Review Request 72516: Erased `Info` struct before unmouting volumes in Docker volume isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72516/#review220856 ---

Re: Review Request 72516: Erased `Info` struct before unmouting volumes in Docker volume isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72516/ --- (Updated May 26, 2020, 9:41 a.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 72516: Erased `Info` struct before unmouting volumes in Docker volume isolator.

> On May 26, 2020, 1:57 a.m., Andrei Budnik wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp > > Lines 666 (patched) > > > > > > Since the isolator doesn’t remove the checkpoint

Re: Review Request 72523: Added a test `ROOT_CommandTaskNoRootfsWithUnmountVolumeFailure`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72523/#review220859 --- Patch looks great! Reviews applied: [72516, 72523] Passed