Re: Review Request 72709: Fixed the tests warning messages.

2020-07-27 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72709/#review221380 --- Patch looks great! Reviews applied: [72709] Passed command:

Re: Review Request 72707: Added interface for the CSI server.

2020-07-27 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72707/#review221375 --- Fix it, then Ship it! src/slave/csi_server.hpp Line 42

Re: Review Request 72707: Added interface for the CSI server.

2020-07-27 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72707/#review221374 --- Bad patch! Reviews applied: [72660, 72661, 72672, 72707] Failed

Review Request 72709: Fixed the tests warning messages.

2020-07-27 Thread Dong Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72709/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 72709: Fixed the tests warning messages.

2020-07-27 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72709/#review221383 --- Hm.. it seems this was done to support running the tests from an

Re: Review Request 72600: Remove credential text format support.

2020-07-27 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72600/#review221384 --- Ship it! Ship It! - Benjamin Mahler On July 24, 2020, 9:46

Re: Review Request 72709: Fixed the tests warning messages.

2020-07-27 Thread Dong Zhu
> On July 28, 2020, 1:12 a.m., Benjamin Mahler wrote: > > Hm.. it seems this was done to support running the tests from an > > installation? > > > > https://github.com/apache/mesos/commit/6cca8c8071e4b863d951a1631141f861c47826d1 Yes. But this issue exists even from an installation without