Review Request 48268: Implemented SET_QUOTA Call in v1 master API.

2016-06-06 Thread Abhishek Dasgupta
nvironment tear-down [==] 2 tests from 1 test case ran. (236 ms total) [ PASSED ] 2 tests. Thanks, Abhishek Dasgupta

Re: Review Request 48268: Implemented SET_QUOTA Call in v1 master API.

2016-06-07 Thread Abhishek Dasgupta
is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48268/#review136444 --- On June 6, 2016, 9:55 a.m., Abhishek Dasgupta wrote: > > --- >

Re: Review Request 48268: Implemented SET_QUOTA Call in v1 master API.

2016-06-07 Thread Abhishek Dasgupta
andler::set(` like? - Abhishek --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48268/#review136444 --- On June 6, 2016, 9

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

2016-06-10 Thread Abhishek Dasgupta
src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 Diff: https://reviews.apache.org/r/48094/diff/ Testing (updated) --- On Ubuntu 16.04: sudo GTEST_FILTER="*MasterAPITest.*" make -j2 check Thanks, Abhishek Dasgupta

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

2016-06-10 Thread Abhishek Dasgupta
2c45dab291a153b42809ab12e4252bf58559feeb src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 Diff: https://reviews.apache.org/r/48094/diff/ Testing --- On Ubuntu 16.04: sudo GTEST_FILTER="MasterAPITest.*" make -j2 check Thanks, Abhishek Dasgupta

Review Request 48504: Updated libprocess to support GET_METRICS.

2016-06-09 Thread Abhishek Dasgupta
be03406c58439b7ab7c1ba12c19dd9f30aff109e Diff: https://reviews.apache.org/r/48504/diff/ Testing --- Thanks, Abhishek Dasgupta

Re: Review Request 48504: Updated libprocess to support GET_METRICS.

2016-06-09 Thread Abhishek Dasgupta
25e8fcaeb9c71eaa43096165745e79c8198c139a 3rdparty/libprocess/src/metrics/metrics.cpp be03406c58439b7ab7c1ba12c19dd9f30aff109e Diff: https://reviews.apache.org/r/48504/diff/ Testing --- Thanks, Abhishek Dasgupta

Review Request 48705: Implemented LIST_FILES Call in v1 agent API.

2016-06-14 Thread Abhishek Dasgupta
src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 Diff: https://reviews.apache.org/r/48705/diff/ Testing --- Ubuntu 16.04: sudo GTEST_FILTER="*AgentAPITest.ListFiles*" make -j4 check Thanks, Abhishek Dasgupta

Review Request 48704: Updated FilesProcess to support List_Files Call in Operator API v1.

2016-06-14 Thread Abhishek Dasgupta
20bc6fa0c22ab017c4e23a745c313a3caf0aec36 Diff: https://reviews.apache.org/r/48704/diff/ Testing --- Ubuntu 16.04: sudo GTEST_FILTER="*AgentAPITest.ListFiles*" make -j4 check Thanks, Abhishek Dasgupta

Re: Review Request 48704: Updated FilesProcess to support List_Files Call in Operator API v1.

2016-06-14 Thread Abhishek Dasgupta
/files/files.cpp 20bc6fa0c22ab017c4e23a745c313a3caf0aec36 Diff: https://reviews.apache.org/r/48704/diff/ Testing (updated) --- Ubuntu 16.04: sudo GTEST_FILTER="FilesTest.BrowseTest" make -j4 check Thanks, Abhishek Dasgupta

Re: Review Request 48268: Implemented SET_QUOTA Call in v1 master API.

2016-06-13 Thread Abhishek Dasgupta
ontentType/MasterAPITest.SetQuota/1 (98 ms) [--] 2 tests from ContentType/MasterAPITest (227 ms total) [--] Global test environment tear-down [==] 2 tests from 1 test case ran. (236 ms total) [ PASSED ] 2 tests. Thanks, Abhishek Dasgupta

Review Request 48049: Implemented GET_LEADING_MASTER Call in v1 master API.

2016-05-30 Thread Abhishek Dasgupta
eeeccdfdfd296c2a484764e887564f2e065cfd14 src/tests/api_tests.cpp 1d7a3a9df395805c250148bf6232b00d712c7a05 Diff: https://reviews.apache.org/r/48049/diff/ Testing --- On Ubuntu 16.04: sudo GTEST_FILTER="*MasterAPITest*.*" make -j2 check Thanks, Abhishek Dasgupta

Re: Review Request 48049: Implemented GET_LEADING_MASTER Call in v1 master API.

2016-05-31 Thread Abhishek Dasgupta
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48049/#review135563 --- On May 31, 2016, 6:32 a.m., Abhishek Dasgupta wrote: > > -

Re: Review Request 48049: Implemented GET_LEADING_MASTER Call in v1 master API.

2016-05-31 Thread Abhishek Dasgupta
0fdda31 src/internal/evolve.cpp 4f25f1a src/master/http.cpp c8d2f46 src/master/master.hpp eeeccdf src/tests/api_tests.cpp 0b6bfad Diff: https://reviews.apache.org/r/48049/diff/ Testing --- On Ubuntu 16.04: sudo GTEST_FILTER="*MasterAPITest*.*" make -j2 check Thanks,

Review Request 48094: Implemented GET_ROLES Call in v1 master API.

2016-05-31 Thread Abhishek Dasgupta
="MasterAPITest.*" make -j2 check Thanks, Abhishek Dasgupta

Re: Review Request 48049: Implemented GET_LEADING_MASTER Call in v1 master API.

2016-05-30 Thread Abhishek Dasgupta
0fdda31 src/internal/evolve.cpp 4f25f1a src/master/http.cpp c8d2f46 src/master/master.hpp eeeccdf src/tests/api_tests.cpp 0b6bfad Diff: https://reviews.apache.org/r/48049/diff/ Testing --- On Ubuntu 16.04: sudo GTEST_FILTER="*MasterAPITest*.*" make -j2 check Thanks,

Re: Review Request 48049: Implemented GET_LEADING_MASTER Call in v1 master API.

2016-05-30 Thread Abhishek Dasgupta
/internal/evolve.cpp 4f25f1a src/master/http.cpp c8d2f46 src/master/master.hpp eeeccdf src/tests/api_tests.cpp 0b6bfad Diff: https://reviews.apache.org/r/48049/diff/ Testing --- On Ubuntu 16.04: sudo GTEST_FILTER="*MasterAPITest*.*" make -j2 check Thanks, Abhishek Dasgupta

Re: Review Request 48049: Implemented GET_LEADING_MASTER Call in v1 master API.

2016-05-30 Thread Abhishek Dasgupta
volve, it is converted from object to response. That's why came the misunderstanding. - Abhishek --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48049/#review135535 --

Re: Review Request 48049: Implemented GET_LEADING_MASTER Call in v1 master API.

2016-05-30 Thread Abhishek Dasgupta
0fdda31 src/internal/evolve.cpp 4f25f1a src/master/http.cpp c8d2f46 src/master/master.hpp eeeccdf src/tests/api_tests.cpp 0b6bfad Diff: https://reviews.apache.org/r/48049/diff/ Testing --- On Ubuntu 16.04: sudo GTEST_FILTER="*MasterAPITest*.*" make -j2 check Thanks,

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

2016-06-16 Thread Abhishek Dasgupta
a0944ddccd3a4b33458cd2489bb5fcdbbdc55720 src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 Diff: https://reviews.apache.org/r/48094/diff/ Testing --- On Ubuntu 16.04: sudo GTEST_FILTER="*MasterAPITest.*" make -j2 check Thanks, Abhishek Dasgupta

Re: Review Request 48268: Implemented SET_QUOTA Call in v1 master API.

2016-06-16 Thread Abhishek Dasgupta
] 2 tests. Thanks, Abhishek Dasgupta

Re: Review Request 48268: Implemented SET_QUOTA Call in v1 master API.

2016-06-21 Thread Abhishek Dasgupta
7 ms total) [--] Global test environment tear-down [==] 2 tests from 1 test case ran. (236 ms total) [ PASSED ] 2 tests. Thanks, Abhishek Dasgupta

Re: Review Request 48268: Implemented SET_QUOTA Call in v1 master API.

2016-06-21 Thread Abhishek Dasgupta
------ On June 21, 2016, 5:42 p.m., Abhishek Dasgupta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48268/ > ---

Re: Review Request 48268: Implemented SET_QUOTA Call in v1 master API.

2016-06-19 Thread Abhishek Dasgupta
7 ms total) [--] Global test environment tear-down [==] 2 tests from 1 test case ran. (236 ms total) [ PASSED ] 2 tests. Thanks, Abhishek Dasgupta

Re: Review Request 48268: Implemented SET_QUOTA Call in v1 master API.

2016-06-19 Thread Abhishek Dasgupta
7 ms total) [--] Global test environment tear-down [==] 2 tests from 1 test case ran. (236 ms total) [ PASSED ] 2 tests. Thanks, Abhishek Dasgupta

Re: Review Request 48268: Implemented SET_QUOTA Call in v1 master API.

2016-06-19 Thread Abhishek Dasgupta
ng rebasing..my bad. - Abhishek --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48268/#review138519 --- On June 20, 2016, 5

Re: Review Request 48705: Implemented LIST_FILES Call in v1 agent API.

2016-06-19 Thread Abhishek Dasgupta
58ff2bfac6918d989ab36b67cf6ba2f3657c8356 src/tests/api_tests.cpp 5d10533858cf1c512e00dbe6d5fab1f6401687bf Diff: https://reviews.apache.org/r/48705/diff/ Testing --- Ubuntu 16.04: sudo GTEST_FILTER="*AgentAPITest.ListFiles*" make -j4 check Thanks, Abhishek Dasgupta

Review Request 48931: Implemented LIST_FILES Call in v1 master API.

2016-06-19 Thread Abhishek Dasgupta
check sudo GTEST_FILTER="*MasterAPITest.ListFiles*" make -j4 check Thanks, Abhishek Dasgupta

Re: Review Request 48705: Implemented LIST_FILES Call in v1 agent API.

2016-06-19 Thread Abhishek Dasgupta
/slave/http.cpp 77834111bf51b58ba5e12f262b725202f7d3a7bf src/slave/slave.hpp 58ff2bfac6918d989ab36b67cf6ba2f3657c8356 Diff: https://reviews.apache.org/r/48705/diff/ Testing (updated) --- Thanks, Abhishek Dasgupta

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

2016-06-18 Thread Abhishek Dasgupta
; make -j2 check Thanks, Abhishek Dasgupta

Re: Review Request 48268: Implemented SET_QUOTA Call in v1 master API.

2016-06-20 Thread Abhishek Dasgupta
7 ms total) [--] Global test environment tear-down [==] 2 tests from 1 test case ran. (236 ms total) [ PASSED ] 2 tests. Thanks, Abhishek Dasgupta

Review Request 48942: Remove unnecessary inclusion of allocator proto header from makefile.

2016-06-20 Thread Abhishek Dasgupta
://reviews.apache.org/r/48942/diff/ Testing --- Thanks, Abhishek Dasgupta

Re: Review Request 48268: Implemented SET_QUOTA Call in v1 master API.

2016-06-20 Thread Abhishek Dasgupta
7 ms total) [--] Global test environment tear-down [==] 2 tests from 1 test case ran. (236 ms total) [ PASSED ] 2 tests. Thanks, Abhishek Dasgupta

Re: Review Request 48976: Remove default values for the `Roles` protobuf.

2016-06-20 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48976/#review138759 --- Ship it! Ship It! - Abhishek Dasgupta On June 20, 2016, 11

Review Request 49206: Implemented GET_QUOTA Call in v1 master API.

2016-06-24 Thread Abhishek Dasgupta
src/master/quota_handler.cpp 4fa7533cb6a109fd060050c7814de440bd34c8ed src/tests/api_tests.cpp 7f16f43c3968cd56cf93951489079032093beaeb Diff: https://reviews.apache.org/r/49206/diff/ Testing --- sudo GTEST_FILTER="*MasterAPITest.GetQuota*" make -j4 check Thanks, Abhishek Dasgupta

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

2016-06-18 Thread Abhishek Dasgupta
o reply, visit: https://reviews.apache.org/r/48094/#review138412 --- On June 18, 2016, 4:21 p.m., Abhishek Dasgupta wrote: > > --- > This is an automatically generated e-mail. To r

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

2016-06-18 Thread Abhishek Dasgupta
Abhishek Dasgupta On June 18, 2016, 4:21 p.m., Abhishek Dasgupta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

2016-06-18 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48094/#review138412 --- On June 18, 2016, 4:21 p.m., Abhishek Dasgupta wrote: > > --

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

2016-06-18 Thread Abhishek Dasgupta
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48094/#review138405 --- On June 18, 2016, 11:23 a.m., Abhishek Dasgupta wrote: > > -

Re: Review Request 48268: Implemented SET_QUOTA Call in v1 master API.

2016-06-18 Thread Abhishek Dasgupta
ted e-mail. To reply, visit: https://reviews.apache.org/r/48268/#review138170 --- On June 18, 2016, 2:53 p.m., Abhishek Dasgupta wrote: > > --- > This is an automatically

Re: Review Request 48268: Implemented SET_QUOTA Call in v1 master API.

2016-06-18 Thread Abhishek Dasgupta
[ OK ] ContentType/MasterAPITest.SetQuota/1 (98 ms) [--] 2 tests from ContentType/MasterAPITest (227 ms total) [--] Global test environment tear-down [==] 2 tests from 1 test case ran. (236 ms total) [ PASSED ] 2 tests. Thanks, Abhishek Dasgupta

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

2016-06-18 Thread Abhishek Dasgupta
; make -j2 check Thanks, Abhishek Dasgupta

Review Request 49296: Added validation check on resources for reserve/unreserve call.

2016-06-28 Thread Abhishek Dasgupta
--- On Ubuntu 16.04: sudo GTEST_FILTER="*MasterAPITest.UnreserveResources*:*MasterAPITest.ReserveResources*" make -j4 check Thanks, Abhishek Dasgupta

Re: Review Request 49226: Implemented UNRESERVE_RESOURCES Call in v1 master API.

2016-06-27 Thread Abhishek Dasgupta
648f1a217cc7bbb154a9d7a2a8b2c5d02087af03 src/tests/api_tests.cpp 7f16f43c3968cd56cf93951489079032093beaeb Diff: https://reviews.apache.org/r/49226/diff/ Testing --- Thanks, Abhishek Dasgupta

Re: Review Request 49227: Updated proto files with comments.

2016-06-27 Thread Abhishek Dasgupta
/master.proto 11dfab318eb073908a9e302afa33b274fec63a16 Diff: https://reviews.apache.org/r/49227/diff/ Testing --- On Ubuntu 16.04: sudo GTEST_FILTER="*MasterAPITest.ReserveResources*" make -j4 check sudo GTEST_FILTER="*MasterAPITest.UnreserveResources*" make -j4 check Thanks, Abhishek Dasgupta

Re: Review Request 49225: Implemented RESERVE_RESOURCES Call in v1 master API.

2016-06-27 Thread Abhishek Dasgupta
648f1a217cc7bbb154a9d7a2a8b2c5d02087af03 src/tests/api_tests.cpp 7f16f43c3968cd56cf93951489079032093beaeb Diff: https://reviews.apache.org/r/49225/diff/ Testing --- Thanks, Abhishek Dasgupta

Re: Review Request 49226: Implemented UNRESERVE_RESOURCES Call in v1 master API.

2016-06-27 Thread Abhishek Dasgupta
sues.apache.org/jira/browse/MESOS-5725 - Abhishek --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49226/#review139510 --- O

Re: Review Request 49225: Implemented RESERVE_RESOURCES Call in v1 master API.

2016-06-27 Thread Abhishek Dasgupta
648f1a217cc7bbb154a9d7a2a8b2c5d02087af03 src/tests/api_tests.cpp 7f16f43c3968cd56cf93951489079032093beaeb Diff: https://reviews.apache.org/r/49225/diff/ Testing --- Thanks, Abhishek Dasgupta

Re: Review Request 49226: Implemented UNRESERVE_RESOURCES Call in v1 master API.

2016-06-27 Thread Abhishek Dasgupta
648f1a217cc7bbb154a9d7a2a8b2c5d02087af03 src/tests/api_tests.cpp 7f16f43c3968cd56cf93951489079032093beaeb Diff: https://reviews.apache.org/r/49226/diff/ Testing --- Thanks, Abhishek Dasgupta

Review Request 49225: Implemented RESERVE_RESOURCES Call in v1 master API.

2016-06-25 Thread Abhishek Dasgupta
/diff/ Testing --- Thanks, Abhishek Dasgupta

Re: Review Request 49225: Implemented RESERVE_RESOURCES Call in v1 master API.

2016-06-25 Thread Abhishek Dasgupta
e983d1ba6ebcdaf2ace419201659e53edaa2a0aa src/tests/api_tests.cpp 7f16f43c3968cd56cf93951489079032093beaeb Diff: https://reviews.apache.org/r/49225/diff/ Testing --- Thanks, Abhishek Dasgupta

Review Request 49227: Updated proto files with comments.

2016-06-25 Thread Abhishek Dasgupta
Diff: https://reviews.apache.org/r/49227/diff/ Testing --- On Ubuntu 16.04: sudo GTEST_FILTER="*MasterAPITest.ReserveResources*" make -j4 check sudo GTEST_FILTER="*MasterAPITest.UnreserveResources*" make -j4 check Thanks, Abhishek Dasgupta

Review Request 49226: Implemented UNRESERVE_RESOURCES Call in v1 master API.

2016-06-25 Thread Abhishek Dasgupta
/tests/api_tests.cpp 7f16f43c3968cd56cf93951489079032093beaeb Diff: https://reviews.apache.org/r/49226/diff/ Testing --- Thanks, Abhishek Dasgupta

Re: Review Request 49206: Implemented Get_Quota.

2016-06-25 Thread Abhishek Dasgupta
4fa7533cb6a109fd060050c7814de440bd34c8ed src/tests/api_tests.cpp 7f16f43c3968cd56cf93951489079032093beaeb Diff: https://reviews.apache.org/r/49206/diff/ Testing (updated) --- On Ubuntu 16.04 : sudo GTEST_FILTER="*MasterAPITest.GetQuota*" make -j4 check Thanks, Abhishek Dasgupta

Re: Review Request 49206: Implemented GET_QUOTA Call in v1 master API.

2016-06-25 Thread Abhishek Dasgupta
/api_tests.cpp 7f16f43c3968cd56cf93951489079032093beaeb Diff: https://reviews.apache.org/r/49206/diff/ Testing --- On Ubuntu 16.04 : sudo GTEST_FILTER="*MasterAPITest.GetQuota*" make -j4 check Thanks, Abhishek Dasgupta

Re: Review Request 49206: Implemented GET_QUOTA Call in v1 master API.

2016-06-25 Thread Abhishek Dasgupta
4fa7533cb6a109fd060050c7814de440bd34c8ed src/tests/api_tests.cpp 7f16f43c3968cd56cf93951489079032093beaeb Diff: https://reviews.apache.org/r/49206/diff/ Testing --- On Ubuntu 16.04 : sudo GTEST_FILTER="*MasterAPITest.GetQuota*" make -j4 check Thanks, Abhishek Dasgupta

Review Request 49247: Implemented REMOVE_QUOTA Call in v1 master API.

2016-06-27 Thread Abhishek Dasgupta
k Thanks, Abhishek Dasgupta

Re: Review Request 49225: Implemented RESERVE_RESOURCES Call in v1 master API.

2016-06-27 Thread Abhishek Dasgupta
//reviews.apache.org/r/49225/#review139506 --- On June 25, 2016, 6:52 a.m., Abhishek Dasgupta wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

2016-06-17 Thread Abhishek Dasgupta
eviews.apache.org/r/48094/#review138169 --- On June 17, 2016, 8:30 a.m., Abhishek Dasgupta wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

2016-06-17 Thread Abhishek Dasgupta
72c60ef74ce57119a97cf8305182340a13c58c42 src/tests/api_tests.cpp 03e46cc5e0af8250ba36281e1293a1dc89f8e266 Diff: https://reviews.apache.org/r/48094/diff/ Testing --- On Ubuntu 16.04: sudo GTEST_FILTER="*MasterAPITest.*" make -j2 check Thanks, Abhishek Dasgupta

Re: Review Request 48268: Implemented SET_QUOTA Call in v1 master API.

2016-06-16 Thread Abhishek Dasgupta
. Thanks, Abhishek Dasgupta

Review Request 43328: Title for documentation webpages.

2016-02-08 Thread Abhishek Dasgupta
are coming in the live site. Thanks, Abhishek Dasgupta

Re: Review Request 43328: Title for documentation webpages.

2016-02-08 Thread Abhishek Dasgupta
eviews.apache.org/r/43328/#review118243 --- On Feb. 8, 2016, 3:28 p.m., Abhishek Dasgupta wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

2016-02-04 Thread Abhishek Dasgupta
cases in docker_tests have been changed: DockerTest.ROOT_DOCKER_interface is updated to check labels are passed to docker run command through arguments. Thanks, Abhishek Dasgupta

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

2016-02-04 Thread Abhishek Dasgupta
d any hard bound to upgrade to docker higher version. If you suggest we must use validateVersion, I can make the necessary changes.What do you say?? - Abhishek --- This is an automatically generated e-mail. To reply, visit: https://revi

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

2016-02-04 Thread Abhishek Dasgupta
fo labels are ignored to set as docker" > ><< "labels."; > > } else { > > } > > Abhishek Dasgupta wrote: > It looked like it was designed for other purpose where docker version > upgradation is a must, bu

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

2016-02-05 Thread Abhishek Dasgupta
d so I increased it to 30. - Abhishek --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43032/#review117998 --- On Feb. 5, 2

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

2016-02-05 Thread Abhishek Dasgupta
enough to get > > version, start container and inspect. > > Abhishek Dasgupta wrote: > If Labels are tested , then docker version may need another some time to > connect to docker. Anyway, while testing, I found 15 seconds are two less > time for downloading image, inspe

Re: Review Request 43328: Title for documentation webpages.

2016-02-10 Thread Abhishek Dasgupta
or the necessary changes for support/generate-endpoints-help.py, i would do it in separate RR. I think that sounds okay? - Abhishek --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43328/#review118513

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

2016-02-04 Thread Abhishek Dasgupta
have been changed: DockerTest.ROOT_DOCKER_interface is updated to check labels are passed to docker run command through arguments. Thanks, Abhishek Dasgupta

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

2016-02-04 Thread Abhishek Dasgupta
.apache.org/r/43032/#review117608 --- On Feb. 4, 2016, 6:18 p.m., Abhishek Dasgupta wrote: > > --- > This is an automatically generated e-mail. To reply, v

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

2016-02-05 Thread Abhishek Dasgupta
cases in docker_tests have been changed: DockerTest.ROOT_DOCKER_interface is updated to check labels are passed to docker run command through arguments. Thanks, Abhishek Dasgupta

Re: Review Request 42794: URL query string order is defined.

2016-01-29 Thread Abhishek Dasgupta
. URLTest.Stringification to check generated query strings in URL to be according alphabatic order. Thanks, Abhishek Dasgupta

Review Request 42794: URL query string order is defined.

2016-01-26 Thread Abhishek Dasgupta
in URL to be according alphabatic order. Thanks, Abhishek Dasgupta

Re: Review Request 42794: URL query string order is defined.

2016-01-27 Thread Abhishek Dasgupta
alphabatic order. Thanks, Abhishek Dasgupta

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

2016-02-01 Thread Abhishek Dasgupta
ttps://reviews.apache.org/r/43032/#review117147 --- On Jan. 31, 2016, 3:22 p.m., Abhishek Dasgupta wrote: > > --- > This is an automatically generated e-mail. To reply, v

Re: Review Request 42794: URL query string order is defined.

2016-01-30 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42794/#review117103 --- Ship it! Ship It! - Abhishek Dasgupta On Jan. 30, 2016, 11

Re: Review Request 42794: URL query string order is defined.

2016-01-30 Thread Abhishek Dasgupta
alphabatic order. Thanks, Abhishek Dasgupta

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

2016-02-02 Thread Abhishek Dasgupta
: DockerTest.ROOT_DOCKER_interface is updated to check labels are passed to docker run command through arguments. Thanks, Abhishek Dasgupta

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

2016-02-03 Thread Abhishek Dasgupta
changed: DockerTest.ROOT_DOCKER_interface is updated to check labels are passed to docker run command through arguments. Thanks, Abhishek Dasgupta

Review Request 43032: Set Docker labels based on TaskInfo labels.

2016-01-31 Thread Abhishek Dasgupta
to check labels are passed to docker run command through arguments. Thanks, Abhishek Dasgupta

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

2016-02-24 Thread Abhishek Dasgupta
: https://reviews.apache.org/r/43032/diff/ Testing --- The following test cases in docker_tests have been changed: DockerTest.ROOT_DOCKER_interface is updated to check labels are passed to docker run command through arguments. Thanks, Abhishek Dasgupta

Re: Review Request 43716: Endpoint documents with title.

2016-02-24 Thread Abhishek Dasgupta
Diff: https://reviews.apache.org/r/43716/diff/ Testing --- This patch includes all the endpoint documents with title generated from generated-endpoint-help.py file. Tested on live site using "rake" Thanks, Abhishek Dasgupta

Re: Review Request 43715: Updated support/generate-endpoint-help.py to include title in generated markdown files.

2016-02-24 Thread Abhishek Dasgupta
. Thanks, Abhishek Dasgupta

Re: Review Request 43328: Added a title to all documentation markdown files.

2016-02-24 Thread Abhishek Dasgupta
4f30d725c6ed28c09a1c5528fd4193c3f06b2d93 docs/versioning.md cc31fd53d5bd33168fed0a7c3408616f7c1e9858 Diff: https://reviews.apache.org/r/43328/diff/ Testing --- Tested with rake dev to see if the effects are coming in the live site. Thanks, Abhishek Dasgupta

Re: Review Request 43715: Title for endpoint documentation.

2016-02-24 Thread Abhishek Dasgupta
://reviews.apache.org/r/43715/diff/ Testing --- This is the patch for support/generate-endpoint-help.py to include the generated files with titles. Tested using "rake dev" on a live site. Thanks, Abhishek Dasgupta

Re: Review Request 43328: Added a title to all documentation markdown files.

2016-02-24 Thread Abhishek Dasgupta
4f30d725c6ed28c09a1c5528fd4193c3f06b2d93 docs/versioning.md cc31fd53d5bd33168fed0a7c3408616f7c1e9858 Diff: https://reviews.apache.org/r/43328/diff/ Testing --- Tested with rake dev to see if the effects are coming in the live site. Thanks, Abhishek Dasgupta

Re: Review Request 43716: Added title to every endpoint markdown file.

2016-02-24 Thread Abhishek Dasgupta
a5fb58f35c602c8b03ed911eb374d26f98449585 docs/endpoints/version.md 07a9f6c7c2e0239b428dcadabc9e81f7fce05d67 Diff: https://reviews.apache.org/r/43716/diff/ Testing --- This patch includes all the endpoint documents with title generated from generated-endpoint-help.py file. Tested on live site using "rake" Thanks,

Re: Review Request 43328: Title for documentation webpages.

2016-02-24 Thread Abhishek Dasgupta
cc31fd53d5bd33168fed0a7c3408616f7c1e9858 Diff: https://reviews.apache.org/r/43328/diff/ Testing --- Tested with rake dev to see if the effects are coming in the live site. Thanks, Abhishek Dasgupta

Re: Review Request 43328: Added a title to all documentation markdown files.

2016-02-24 Thread Abhishek Dasgupta
site. Thanks, Abhishek Dasgupta

Review Request 43827: Introducing TASK_KILLING state on WebUI.

2016-02-22 Thread Abhishek Dasgupta
TASK_KILLING state on WebUI. Diffs - src/webui/master/static/home.html ad3f092a8c7ae2965f2718078c8407e19ae70f10 Diff: https://reviews.apache.org/r/43827/diff/ Testing --- Thanks, Abhishek Dasgupta

Re: Review Request 43827: Introducing TASK_KILLING state on WebUI.

2016-02-22 Thread Abhishek Dasgupta
/43827/diff/ Testing --- Thanks, Abhishek Dasgupta

Re: Review Request 43827: Introducing TASK_KILLING state on WebUI.

2016-02-22 Thread Abhishek Dasgupta
/43827/diff/ Testing --- Thanks, Abhishek Dasgupta

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

2016-02-23 Thread Abhishek Dasgupta
erted back to Try again. - Abhishek --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43032/#review120283 --- On Feb. 23, 2016, 8:44 a.m., A

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

2016-02-23 Thread Abhishek Dasgupta
: https://reviews.apache.org/r/43032/diff/ Testing --- The following test cases in docker_tests have been changed: DockerTest.ROOT_DOCKER_interface is updated to check labels are passed to docker run command through arguments. Thanks, Abhishek Dasgupta

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

2016-02-23 Thread Abhishek Dasgupta
ase. How about let's capture the docker version and save it in the Docker > > class, so we can re-use it and don't have to compute it every time? > > Abhishek Dasgupta wrote: > How about we store the docker version in docker class inside > validateVersion() method? >

Re: Review Request 43715: Updated support/generate-endpoint-help.py to include title.

2016-02-24 Thread Abhishek Dasgupta
-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541 Diff: https://reviews.apache.org/r/43715/diff/ Testing --- This is the patch for support/generate-endpoint-help.py to include the generated files with titles. Tested using "rake dev" on a live site. Thanks, Abhishek Dasgupta

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

2016-02-24 Thread Abhishek Dasgupta
urn Error("Failed to get docker version: " + version.failure()); > > } > > > > // Get the docker version. > > version = version_; > > > > I think that the logic of `validateVersion` may also need some udpate > > by re

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

2016-02-25 Thread Abhishek Dasgupta
can't save dockerVersion inside create() - Abhishek --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43032/#review120689 --- On Fe

Re: Review Request 43032: Set Docker labels based on TaskInfo labels.

2016-02-25 Thread Abhishek Dasgupta
/r/43032/diff/ > > > Testing > --- > > The following test cases in docker_tests have been changed: > DockerTest.ROOT_DOCKER_interface is updated to check labels are passed to > docker run command through arguments. > > > Thanks, > > Abhishek Dasgupta > >

  1   2   3   4   >