Re: Review Request 39852: Windows: Replaced global `GetMessage` macro with inline function.

2015-12-15 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39852/#review110539 --- Ship it! Ship It! - Alex Naparu On Nov. 16, 2015, 9:15 a.m

Re: Review Request 39888: Windows: Added compatibility code for `grp.h` and `pwd.h`.

2015-12-15 Thread Alex Naparu
/grp.hpp (line 37) <https://reviews.apache.org/r/39888/#comment170464> Returning NULL without setting errno is probably not a good idea. We might want to standardize on '0' for group/user IDs on Windows. - Alex Naparu On Nov. 16, 2015, 9:15 a.m., Alex Clemmer

Re: Review Request 39888: Windows: Added compatibility code for `grp.h` and `pwd.h`.

2015-12-15 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39888/#review110538 --- Ship it! Ship It! - Alex Naparu On Nov. 16, 2015, 9:15 a.m

Re: Review Request 39850: Process: Added headers to make `process/mime.hpp` standalone.

2015-12-15 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39850/#review110542 --- Ship it! Ship It! - Alex Naparu On Nov. 16, 2015, 9:14 a.m

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

2015-12-14 Thread Alex Naparu
/rmdir.hpp (line 62) <https://reviews.apache.org/r/39584/#comment170217> Nit: You're not reusing these, so might as well inline the calls. - Alex Naparu On Nov. 16, 2015, 9:13 a.m., Alex Clemmer wrote: > > --- > This is a

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

2015-12-14 Thread Alex Naparu
S for all FS-related ops. That will be true in the vast majority of cases these days. - Alex Naparu On Nov. 17, 2015, 7:06 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

2015-12-14 Thread Alex Naparu
ng ::RemoveDirectory here, which will delete the directory when the last handle is closed. Unless that's not the desired behavior... - Alex Naparu On Nov. 16, 2015, 9:13 a.m., Alex Clemmer wrote: > > --- > This is

Re: Review Request 39804: Windows: Moved `os::find` to its own file, `stout/os/find.hpp`.

2016-01-04 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39804/#review112620 --- Ship it! Ship It! - Alex Naparu On Jan. 4, 2016, 6:35 p.m

Re: Review Request 39805: Moved filesystems tests to their own file.

2016-01-04 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39805/#review112621 --- Ship it! Ship It! - Alex Naparu On Jan. 4, 2016, 6:39 p.m

Re: Review Request 39802: Windows: Implemented `stout/os/windows/ls.hpp`.

2016-01-04 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39802/#review112619 --- Ship it! Ship It! - Alex Naparu On Jan. 4, 2016, 11:20 a.m

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

2016-01-04 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/#review112618 --- Ship it! Ship It! - Alex Naparu On Jan. 4, 2016, 12:02 p.m

Re: Review Request 39834: Made `path_tests.cpp` standalone.

2016-01-04 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39834/#review112622 --- Ship it! Ship It! - Alex Naparu On Nov. 16, 2015, 9:14 a.m

Re: Review Request 41604: CMake: Added missing protobuf files to CMake build.

2016-01-04 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41604/#review112623 --- Ship it! Ship It! - Alex Naparu On Dec. 23, 2015, 6:52 a.m

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

2015-12-22 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39019/#review111725 --- Ship it! Ship It! - Alex Naparu On Dec. 23, 2015, 2:15 a.m

Re: Review Request 42035: Windows: Removed the `--switch_user` flag in Windows.

2016-01-12 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42035/#review114114 --- Ship it! Ship It! - Alex Naparu On Jan. 7, 2016, 9:47 p.m

Re: Review Request 43905: Windows: Removed `user` launcher flag, preventing `su`.

2016-02-26 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43905/#review120957 --- Ship it! Ship It! - Alex Naparu On Feb. 25, 2016, 7:17 p.m

Re: Review Request 43904: Windows: Removed `rootfs` launcher flag, preventing `chroot`.

2016-02-26 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43904/#review120958 --- Ship it! Ship It! - Alex Naparu On Feb. 25, 2016, 7:17 p.m

Re: Review Request 43907: Stout:[1/2] Fix error reporting bug in `os::rmdir`.

2016-02-26 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43907/#review120964 --- Ship it! Ship It! - Alex Naparu On Feb. 25, 2016, 7:41 p.m

Re: Review Request 43906: CMake: Added files to be built as part of libmesos.

2016-02-26 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43906/#review120968 --- Ship it! Ship It! - Alex Naparu On Feb. 25, 2016, 7:17 p.m

Re: Review Request 43903: Stout: Add `WindowsError` constructor to `Result`.

2016-02-26 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43903/#review120956 --- Ship it! Ship It! - Alex Naparu On Feb. 25, 2016, 7:13 p.m

Re: Review Request 43908: Stout:[2/2] Added significant test coverage of `os::rmdir`.

2016-02-26 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43908/#review120966 --- Ship it! Ship It! - Alex Naparu On Feb. 25, 2016, 7:40 p.m

Re: Review Request 43407: CMake: Force GMock and libevent to build and link statically.

2016-02-19 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43407/#review119925 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 12:59 a.m

Re: Review Request 43409: Windows: Added `src/resource_estimator.cpp` to build.

2016-02-19 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43409/#review119926 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 12:59 a.m

Re: Review Request 43411: Windows: Added dynamic library loading tests to build.

2016-02-19 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43411/#review119929 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 12:59 a.m

Re: Review Request 43415: CMake: Moved Windows build to version of glog that builds with CMake.

2016-02-19 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43415/#review119930 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 2:08 a.m

Re: Review Request 43413: CMake:[1/2] Allow downloading third-party dependencies from mirror.

2016-02-19 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43413/#review119931 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 12:59 a.m

Re: Review Request 43414: CMake:[2/2] Canonicalize location of third-party dependencies.

2016-02-19 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43414/#review119932 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 12:59 a.m

Re: Review Request 43415: CMake: Moved Windows build to version of glog that builds with CMake.

2016-02-19 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43415/#review119933 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 2:08 a.m

Re: Review Request 43416: Windows: Removed ambiguous call to `::write`.

2016-02-19 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43416/#review119935 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 12:59 a.m

Re: Review Request 43417: Windows: Marked functions in headers `inline` to avoid linker errors.

2016-02-19 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43417/#review119936 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 12:59 a.m

Re: Review Request 43691: CMake:[2/2] Fixed http-parser library directory for Windows builds.

2016-02-19 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43691/#review119940 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 2:24 a.m

Re: Review Request 43418: Windows: Added slave/status_update_manager.cpp and other files.

2016-02-19 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43418/#review119938 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 1:01 a.m

Re: Review Request 43692: CMake:[1/4] Transitioned to 64-bit build of ZK on Windows.

2016-02-19 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43692/#review119941 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 2:26 a.m

Re: Review Request 43693: CMake:[2/4] Transitioned ZK build to be 64-bit and static.

2016-02-19 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43693/#review119942 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 2:27 a.m

Re: Review Request 43694: Windows:[3/4] Transitioned to static-everything builds on Windows.

2016-02-19 Thread Alex Naparu
tps://reviews.apache.org/r/43694/#comment181329> Maybe remove it altogether? - Alex Naparu On Feb. 18, 2016, 2:28 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 43694: Windows:[3/4] Transitioned to static-everything builds on Windows.

2016-02-19 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43694/#review119944 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 2:28 a.m

Re: Review Request 43695: Windows:[4/4] Included Socket library for 64-bit builds.

2016-02-19 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43695/#review119945 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 2:28 a.m

Re: Review Request 43700: CMake: Fixed Find* scripts to not explode if invoked twice.

2016-02-19 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43700/#review119947 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 2:31 a.m

Re: Review Request 43689: CMake: Begin to require 64-bit builds.

2016-02-19 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43689/#review119946 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 2:29 a.m

Re: Review Request 43697: CMake:[1/3] Move Stout configuration to its own file.

2016-02-19 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43697/#review119948 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 5:49 a.m

Re: Review Request 43698: CMake:[2/3] Use new Stout config script in libprocess 3rdparty build.

2016-02-19 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43698/#review119949 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 4:34 a.m

Re: Review Request 43699: CMake:[3/3] Used Stout config script in agent build.

2016-02-19 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43699/#review119950 --- Ship it! Ship It! - Alex Naparu On Feb. 18, 2016, 4:35 a.m

Re: Review Request 45987: Fixed `rmdir.hpp` Windows build breaks.

2016-04-12 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45987/#review128564 --- Ship it! Ship It! - Alex Naparu On April 10, 2016, 10:34

Re: Review Request 46008: Stout: Initialize Windows socket stack in Stout tests.

2016-04-12 Thread Alex Naparu
? What about mesos? > > I'm guessing we'll want to have something like: > > ``` > > Try winsock_initialize = winsock_initialize(); > > ... > > ``` > > > > and do this in `libprocess::initialize()` > > > > Thoughts? > > Alex Naparu wrote: >

Re: Review Request 44123: Stout: [1/2] Implemented assorted `os::` functions on Windows.

2016-04-12 Thread Alex Naparu
if you wrote it as "if (!::GetEnvironmentVariable..." - Alex Naparu On April 11, 2016, 4:20 a.m., Daniel Pravat wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 46008: Stout: Initialize Windows socket stack in Stout tests.

2016-04-12 Thread Alex Naparu
-- On April 11, 2016, 8:28 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46008/ > ---

Re: Review Request 45614: Windows: Implemented os::close for Windows.

2016-04-12 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45614/#review128556 --- Ship it! Ship It! - Alex Naparu On April 2, 2016, 6:35 a.m

Re: Review Request 45614: Windows: Implemented os::close for Windows.

2016-04-12 Thread Alex Naparu
/close.hpp (line 29) <https://reviews.apache.org/r/45614/#comment191990> `return ErrnoError()` if this fails? Same for ::closesocket(). - Alex Naparu On April 2, 2016, 6:35 a.m., Daniel Pravat wrote: > > --- > This is a

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

2016-04-12 Thread Alex Naparu
hink these can be negative, consider using ULARGE_INTEGER instead. 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp (line 429) <https://reviews.apache.org/r/46013/#comment192008> Do you need system_time and use

Re: Review Request 46008: Stout: Initialize Windows socket stack in Stout tests.

2016-04-12 Thread Alex Naparu
) <https://reviews.apache.org/r/46008/#comment191974> We must also call WSACleanup on successful WSAStartup, per MSDN. - Alex Naparu On April 11, 2016, 8:28 a.m., Alex Clemmer wrote: > > --- > This is an automatically g

Re: Review Request 46008: Stout: Initialize Windows socket stack in Stout tests.

2016-04-12 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46008/#review128543 --- Ship it! Ship It! - Alex Naparu On April 11, 2016, 8:28 a.m

Re: Review Request 44131: Libprocess: [2/2] Implemented assorted `os::` functions on Windows.

2016-04-12 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44131/#review128553 --- Ship it! Ship It! - Alex Naparu On April 11, 2016, 4:21 a.m

Re: Review Request 44123: Stout: [1/2] Implemented assorted `os::` functions on Windows.

2016-04-12 Thread Alex Naparu
mplemented" error? 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp (line 228) <https://reviews.apache.org/r/44123/#comment192054> We don't have a X_OK flag in Windows, so we might want to mask that out before calling `::access`. - Alex Naparu On April 11, 2016, 4:

Re: Review Request 44760: Windows: Fixed non-blocking connect.

2016-03-19 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44760/#review124144 --- Ship it! Ship It! - Alex Naparu On March 17, 2016, 6:54 p.m

Re: Review Request 47489: Windows: Symplified `os::exists`.

2016-05-17 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47489/#review133614 --- Ship it! Ship It! - Alex Naparu On May 17, 2016, 7:55 p.m

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

2016-04-13 Thread Alex Naparu
> On April 12, 2016, 11:10 p.m., Alex Naparu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp, line 383 > > <https://reviews.apache.org/r/46013/diff/2/?file=1339790#file1339790line383> > > > > Can you document this flag a bit

Re: Review Request 46013: Stout: Implemented `os::processes` on Windows.

2016-04-13 Thread Alex Naparu
(line 310) <https://reviews.apache.org/r/46013/#comment192236> `break` is not needed after `return` - Alex Naparu On April 13, 2016, 10:06 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail.