Re: Review Request 33452: Fixed the python bindings to use implicit acknoweldgements by default.

2015-04-23 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33452/#review81282 --- Ship it! Ship It! - Alexander Rojas On April 22, 2015, 11:53

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

2015-04-28 Thread Alexander Rojas
--- On April 22, 2015, 4:35 p.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33295

Review Request 33730: Fixes template style issue in common/parse.hpp

2015-04-30 Thread Alexander Rojas
/ Testing (updated) --- make check Thanks, Alexander Rojas

Re: Review Request 33296: Added a flag which controls libprocess firewall initialzation.

2015-04-30 Thread Alexander Rojas
On April 23, 2015, 7:20 p.m., Michael Park wrote: src/common/parse.hpp, line 46 https://reviews.apache.org/r/33296/diff/2/?file=939522#file939522line46 nit: `s/template/template /` Alexander Rojas wrote: I was checking and all the entries in this file have the from

Re: Review Request 33730: Fixes template style issue in common/parse.hpp

2015-04-30 Thread Alexander Rojas
Hindman, Michael Park, and Till Toenshoff. Repository: mesos Description --- Fixes all versions of `template` to `template ` in order to accommodate to the guidelines. Diffs - Diff: https://reviews.apache.org/r/33730/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 33531: Made master/slave usage flags newline behaviour consistent.

2015-05-04 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33531/#review82416 --- Ship it! Ship It! - Alexander Rojas On April 27, 2015, 6:50 a.m

Re: Review Request 33296: Added a flag which controls libprocess firewall initialzation.

2015-04-30 Thread Alexander Rojas
/33296/diff/ Testing --- make check and manual tests. Thanks, Alexander Rojas

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

2015-05-01 Thread Alexander Rojas
, visit: https://reviews.apache.org/r/33295/#review80582 --- On May 1, 2015, 7:12 p.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

2015-05-01 Thread Alexander Rojas
/powered-by-mesos.md 8a0fefd07ed430f2fc81f1f3b350d451b7fafca5 Diff: https://reviews.apache.org/r/33295/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 33296: Added a flag which controls libprocess firewall initialzation.

2015-04-30 Thread Alexander Rojas
On April 23, 2015, 7:20 p.m., Michael Park wrote: src/common/parse.hpp, line 46 https://reviews.apache.org/r/33296/diff/2/?file=939522#file939522line46 nit: `s/template/template /` Alexander Rojas wrote: I was checking and all the entries in this file have the from

Re: Review Request 33296: Added a flag which controls libprocess firewall initialzation.

2015-04-30 Thread Alexander Rojas
: https://reviews.apache.org/r/33296/diff/ Testing --- make check and manual tests. Thanks, Alexander Rojas

Review Request 33733: Fixed style error with template definitions withing common/parse.hpp

2015-04-30 Thread Alexander Rojas
check Thanks, Alexander Rojas

Re: Review Request 33296: Added a flag which controls libprocess firewall initialzation.

2015-04-30 Thread Alexander Rojas
On April 23, 2015, 7:27 p.m., Benjamin Hindman wrote: src/common/parse.hpp, line 46 https://reviews.apache.org/r/33296/diff/2/?file=939522#file939522line46 s/template/template / (Here and everywhere else please!) Alexander Rojas wrote: Now in review [33730

Re: Review Request 32163: Added a function which checks if a json object is contained within another.

2015-05-01 Thread Alexander Rojas
334c898906018be6e663f53815abbe047806b95c 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp f60d1bbe60f2e2b6460c06bba98e8b85ebb6a3f9 Diff: https://reviews.apache.org/r/32163/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 32198: Added a not equal operator for json objects.

2015-05-01 Thread Alexander Rojas
://reviews.apache.org/r/32198/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

2015-05-01 Thread Alexander Rojas
d42a6f321c88ec5d0418264bdda39d083ff54a7e src/tests/master_tests.cpp bdfccb2427cba938dbbaa8e832255153172b0501 Diff: https://reviews.apache.org/r/30612/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 32198: Added a not equal operator for json objects.

2015-04-29 Thread Alexander Rojas
On April 20, 2015, 5:18 p.m., Niklas Nielsen wrote: 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp, line 258 https://reviews.apache.org/r/32198/diff/3/?file=903041#file903041line258 How about also checking for a larger array? Alexander Rojas wrote: What can

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

2015-04-30 Thread Alexander Rojas
Diff: https://reviews.apache.org/r/33295/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 32163: Added a function which checks if a json object is contained within another.

2015-05-07 Thread Alexander Rojas
/libprocess/3rdparty/stout/tests/json_tests.cpp f60d1bbe60f2e2b6460c06bba98e8b85ebb6a3f9 Diff: https://reviews.apache.org/r/32163/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 32198: Added a not equal operator for json objects.

2015-05-07 Thread Alexander Rojas
fa53bbd416dffc3987f8ec28bd9a8ce2b32d6831 Diff: https://reviews.apache.org/r/32198/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 33733: Fixed style error with template definitions withing common/parse.hpp

2015-05-07 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33733/#review82585 --- On May 1, 2015, 12:45 a.m., Alexander Rojas wrote

Re: Review Request 32198: Added a not equal operator for json objects.

2015-05-07 Thread Alexander Rojas
/32198/diff/ Testing --- make check Thanks, Alexander Rojas

Review Request 33825: Added executor implementation for the new HTTP API

2015-05-04 Thread Alexander Rojas
--- make check Thanks, Alexander Rojas

Re: Review Request 32163: Added a function which checks if a json object is contained within another.

2015-05-05 Thread Alexander Rojas
/json.hpp 334c898906018be6e663f53815abbe047806b95c 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp f60d1bbe60f2e2b6460c06bba98e8b85ebb6a3f9 Diff: https://reviews.apache.org/r/32163/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 32163: Added a function which checks if a json object is contained within another.

2015-05-05 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32163/#review82410 --- On May 5, 2015, 6:26 p.m., Alexander Rojas wrote

Re: Review Request 33733: Fixed style error with template definitions within common/parse.hpp

2015-05-08 Thread Alexander Rojas
- src/common/parse.hpp 547b32041f39f0ff0c38179b66a32b2239134abc Diff: https://reviews.apache.org/r/33733/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 33358: Moved implementation of StatusUpdateStream to a compilation unit.

2015-05-08 Thread Alexander Rojas
(updated) - src/slave/status_update_manager.hpp b4d91b22b515195fdb69c89af9c2864e469e7e54 src/slave/status_update_manager.cpp fab8c22d46b8ab0a3c3745541ddc650b574bfbd4 Diff: https://reviews.apache.org/r/33358/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

2015-05-18 Thread Alexander Rojas
/master/master.cpp eaea79df2c693d15087d70b3c9b988e57c894f8e src/tests/master_tests.cpp ba3858fb3026f2cc7af0523bd1a0c541eeafc34b Diff: https://reviews.apache.org/r/30612/diff/ Testing --- make check Thanks, Alexander Rojas

Review Request 34353: Added right ammount of spacing between structs

2015-05-18 Thread Alexander Rojas
--- Added right ammount of spacing between structs Diffs - 3rdparty/libprocess/include/process/http.hpp 058fa02eeecdf31023db731734257a924d770079 Diff: https://reviews.apache.org/r/34353/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-05-18 Thread Alexander Rojas
--- On April 20, 2015, 1:58 p.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30032/ --- (Updated April 20, 2015

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-05-18 Thread Alexander Rojas
On March 26, 2015, 5:59 p.m., Benjamin Hindman wrote: 3rdparty/libprocess/src/process.cpp, line 2854 https://reviews.apache.org/r/30032/diff/4/?file=834184#file834184line2854 ResultTime time = Path(response.path).mtime(); Alexander Rojas wrote: This cannot be implemented

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-05-18 Thread Alexander Rojas
://reviews.apache.org/r/30032/diff/ Testing --- make check Thanks, Alexander Rojas

Review Request 34392: Added a method to Path which returns the modification time of the represented path.

2015-05-18 Thread Alexander Rojas
://reviews.apache.org/r/34392/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-05-18 Thread Alexander Rojas
On March 26, 2015, 5:59 p.m., Benjamin Hindman wrote: 3rdparty/libprocess/src/process.cpp, line 2854 https://reviews.apache.org/r/30032/diff/4/?file=834184#file834184line2854 ResultTime time = Path(response.path).mtime(); Alexander Rojas wrote: This cannot be implemented

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

2015-05-19 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30612/#review83122 --- On May 19, 2015, 10:42 a.m., Alexander Rojas wrote

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

2015-05-19 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30612/#review82935 --- On May 19, 2015, 10:42 a.m., Alexander Rojas wrote

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

2015-05-19 Thread Alexander Rojas
eaea79df2c693d15087d70b3c9b988e57c894f8e src/tests/master_tests.cpp ba3858fb3026f2cc7af0523bd1a0c541eeafc34b Diff: https://reviews.apache.org/r/30612/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 33792: Extend hashmap to support custom equality and hash

2015-05-19 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33792/#review84457 --- Ship it! Ship It! - Alexander Rojas On May 20, 2015, 4:06 a.m

Re: Review Request 34068: The test case of extend hashmap to support custom equality and hash

2015-05-19 Thread Alexander Rojas
https://reviews.apache.org/r/34068/#comment135760 +1 In general avoid printing anything to the console. Nobody actually looks at it unless the test fails and in that case we go to the code. - Alexander Rojas On May 12, 2015, 2:56 a.m., haosdent huang wrote

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

2015-05-20 Thread Alexander Rojas
Diff: https://reviews.apache.org/r/33295/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 33823: Protocol file with the HTTP API messages between executor and slave

2015-05-20 Thread Alexander Rojas
have a #pragma? what?) Alexander Rojas wrote: 1. It is a warning. 2. The purpose of this header is to be a reflection of `include/mesos/scheduler/scheduler.hpp`, and so they both have the same comments, in fact they look mostly identical which follows the maxim of being

Re: Review Request 33823: Protocol file with the HTTP API messages between executor and slave

2015-05-20 Thread Alexander Rojas
34755cf795391c9b8051a5e4acc6caf844984496 Diff: https://reviews.apache.org/r/33823/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 33823: Protocol file with the HTTP API messages between executor and slave

2015-05-20 Thread Alexander Rojas
On May 5, 2015, 10:42 p.m., Vinod Kone wrote: include/mesos/executor/executor.proto, line 117 https://reviews.apache.org/r/33823/diff/1/?file=949198#file949198line117 No corresponding Type for this? Also, how and when is this used? Alexander Rojas wrote: I had

Re: Review Request 33823: Protocol file with the HTTP API messages between executor and slave

2015-05-19 Thread Alexander Rojas
34755cf795391c9b8051a5e4acc6caf844984496 Diff: https://reviews.apache.org/r/33823/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 33823: Protocol file with the HTTP API messages between executor and slave

2015-05-19 Thread Alexander Rojas
for a name? - Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33823/#review82545 --- On May 5, 2015, 12:21 a.m., Alexander Rojas wrote

Re: Review Request 33823: Protocol file with the HTTP API messages between executor and slave

2015-05-19 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33823/#review83125 --- On May 5, 2015, 12:21 a.m., Alexander Rojas wrote

Re: Review Request 34378: Fixed the dependency between 'summarize' and 'model'.

2015-05-20 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34378/#review84494 --- Ship it! Ship It! - Alexander Rojas On May 19, 2015, 1:23 a.m

Re: Review Request 34375: Removed use of namespace aliases.

2015-05-20 Thread Alexander Rojas
the scope of a whole file, but I have found useful to do it inside functions: ```c++ int foo() { namespace http = process::http; return http::bar; } ``` I would be open to discuss their usage in this circumstance. - Alexander Rojas On May 19, 2015, 1:13 a.m., Michael Park wrote

Re: Review Request 34361: converted hard-coded strings to consts

2015-05-20 Thread Alexander Rojas
usage. src/tests/slave_tests.cpp https://reviews.apache.org/r/34361/#comment135813 ditto. - Alexander Rojas On May 18, 2015, 7:01 p.m., Colin Williams wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

2015-05-20 Thread Alexander Rojas
: https://reviews.apache.org/r/33295/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

2015-05-20 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33295/#review84473 --- On May 20, 2015, 9:46 a.m., Alexander Rojas wrote: --- This is an automatically generated

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-05-20 Thread Alexander Rojas
--- On May 19, 2015, 6:20 a.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30032

Re: Review Request 34260: Replaced os::dirname and os::basename with Path::dirname and Path::basename.

2015-05-20 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34260/#review84507 --- Ship it! Ship It! - Alexander Rojas On May 18, 2015, 12:42 a.m

Re: Review Request 34362: Include ExecutorInfos in master/state.json

2015-05-20 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34362/#review84501 --- Ship it! Ship It! - Alexander Rojas On May 18, 2015, 7:41 p.m

Re: Review Request 34260: Replaced os::dirname and os::basename with Path::dirname and Path::basename.

2015-05-20 Thread Alexander Rojas
On May 19, 2015, 10:13 p.m., Vinod Kone wrote: src/cli/mesos.cpp, line 31 https://reviews.apache.org/r/34260/diff/6/?file=962331#file962331line31 So basename can never return an error? When did ::basename() return NULL? I checked in the `::basename` docs (`man 3 basename`) and

Re: Review Request 33276: Fix capture by reference of temporaries in Libprocess.

2015-05-20 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33276/#review84508 --- Ship it! Ship It! - Alexander Rojas On April 22, 2015, 8:11 p.m

Re: Review Request 34319: Refactored os::getenv() to return an option and updated its callers in stout.

2015-05-20 Thread Alexander Rojas
/#comment135819 Ditto. - Alexander Rojas On May 17, 2015, 3:40 p.m., Greg Mann wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34319

Re: Review Request 34259: Replaced os::dirname and os::basename with Path::dirname and Path::basename.

2015-05-20 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34259/#review84505 --- Ship it! Ship It! - Alexander Rojas On May 17, 2015, 9:47 p.m

Re: Review Request 33274: Fix capture by reference of temporary strings in Libprocess.

2015-05-20 Thread Alexander Rojas
On May 12, 2015, 11:28 p.m., Michael Park wrote: Looks good overall! I think found one more: `src/process.cpp` ```cpp 2717: const string name = tokens.size() 1 ? tokens[1] : ; ``` I didn't even know you could capture by reference in this case! - Alexander

Re: Review Request 34256: Added Path::dirname() and Path::basename().

2015-05-20 Thread Alexander Rojas
://reviews.apache.org/r/34256/#comment135821 +1 - Alexander Rojas On May 17, 2015, 9:46 p.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34256

Re: Review Request 33276: Fix capture by reference of temporaries in Libprocess.

2015-05-20 Thread Alexander Rojas
On May 7, 2015, 8:55 p.m., Joerg Schad wrote: Maybe we could use benchmark to ensure the overall change does not cause a noticable performance penalty (don't think so, but numbers are always good to verify) While nice to have benchmarks, I don't think this changes are optional

Re: Review Request 33275: Fix capture by reference of temporaries in Stout.

2015-05-20 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33275/#review84511 --- Ship it! Ship It! - Alexander Rojas On April 22, 2015, 8:11 p.m

Re: Review Request 34068: The test case of extend hashmap to support custom equality and hash

2015-05-21 Thread Alexander Rojas
/hashmap_tests.cpp https://reviews.apache.org/r/34068/#comment136018 how about `foreach (const char c, key)` - Alexander Rojas On May 20, 2015, 9:10 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 35043: WIP: Adding ability to decode JSON from ZK

2015-06-08 Thread Alexander Rojas
A line break here would look better. - Alexander Rojas On June 4, 2015, 6:27 a.m., Marco Massenzio wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35043

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

2015-06-08 Thread Alexander Rojas
7b9ba9e70e1fe7a22b26444b3bd928208fecd491 Diff: https://reviews.apache.org/r/33295/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 33296: Added a flag which controls libprocess firewall initialzation.

2015-06-08 Thread Alexander Rojas
and manual tests. Thanks, Alexander Rojas

Re: Review Request 33730: Fixes template style issue in common/parse.hpp

2015-06-08 Thread Alexander Rojas
, Michael Park, and Till Toenshoff. Repository: mesos Description --- Fixes all versions of `template` to `template ` in order to accommodate to the guidelines. Diffs - Diff: https://reviews.apache.org/r/33730/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-06-08 Thread Alexander Rojas
/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 34703: Added stream manipulators for the Time object.

2015-06-08 Thread Alexander Rojas
) - 3rdparty/libprocess/include/process/time.hpp c5ab2a3cfa83590eb6612152ae365dd67f51cea9 3rdparty/libprocess/src/tests/time_tests.cpp be314182c65c05d439b81aa5248a71d93f6f0a0b Diff: https://reviews.apache.org/r/34703/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 33824: Stub for the new HTTP API in the slave

2015-06-03 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33824/#review86351 --- On June 2, 2015, 4:03 p.m., Alexander Rojas wrote

Review Request 35874: Added template parameters and constructors to hashset which reflex the state of hashmap

2015-06-25 Thread Alexander Rojas
/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 35714: Added a new HTTP response type: PreconditionFailed.

2015-06-25 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35714/#review89339 --- Ship it! Ship It! - Alexander Rojas On June 22, 2015, 7:08 a.m

Re: Review Request 35353: Smaller fixes on libprocess firewall

2015-06-24 Thread Alexander Rojas
, Alexander Rojas

Re: Review Request 35354: Smaller fixes in libprocess firewall initialization

2015-06-24 Thread Alexander Rojas
c379243e01919a5ab30bb9dea1b738665ba4e746 Diff: https://reviews.apache.org/r/35354/diff/ Testing --- Manual checks make check Thanks, Alexander Rojas

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

2015-06-24 Thread Alexander Rojas
--- On June 8, 2015, 12:09 p.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33295/ --- (Updated June 8

Re: Review Request 35553: Rename libprocess User Guide to Developer Guide.

2015-06-19 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35553/#review88521 --- Ship it! Ship It! - Alexander Rojas On June 17, 2015, 11:22 a.m

Re: Review Request 35364: Consistent code examples in doxygen style.

2015-06-19 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35364/#review88516 --- Ship it! Ship It! - Alexander Rojas On June 11, 2015, 10:39 p.m

Re: Review Request 35509: Doxygen Style Guide Improvements.

2015-06-19 Thread Alexander Rojas
://reviews.apache.org/r/35509/#comment141097 Just out of curiosity, why was this deleted? - Alexander Rojas On June 16, 2015, 8:11 p.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org

Re: Review Request 35510: Introduced General and Markdown Documentation Style Guides.

2015-06-19 Thread Alexander Rojas
is stating? You can use `~~~{.txt}` - Alexander Rojas On June 17, 2015, 10:22 a.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35510

Re: Review Request 35554: Rename Stout User Guide to Stout Developer Guide.

2015-06-19 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35554/#review88522 --- Ship it! Ship It! - Alexander Rojas On June 17, 2015, 11:21 a.m

Re: Review Request 35919: Firewall rule's apply method returns an HTTP response instead of an error message.

2015-06-26 Thread Alexander Rojas
f71d6541e48e2481c69f401b388977b153503962 3rdparty/libprocess/src/process.cpp 52649fb90cdbefb495b68d0beb8c7f7e5ef6888e Diff: https://reviews.apache.org/r/35919/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 35353: Smaller fixes on libprocess firewall

2015-06-24 Thread Alexander Rojas
6a0b21d67912a40e0ec3220fdb250930be1979b2 3rdparty/libprocess/src/process.cpp a67a3afdb30d23eb1b265b04ae662f64e874b6c6 3rdparty/libprocess/src/tests/process_tests.cpp f4633aac70321a935fc6867da6450c02f0fb0406 Diff: https://reviews.apache.org/r/35353/diff/ Testing --- make check Thanks, Alexander Rojas

Review Request 35919: Firewall rule's apply method returns an HTTP response instead of an error message.

2015-06-26 Thread Alexander Rojas
: https://reviews.apache.org/r/35919/diff/ Testing --- make check Thanks, Alexander Rojas

Review Request 35350: Fixes markdown of the Doxygen Styleguide to provide better rendering.

2015-06-11 Thread Alexander Rojas
. Repository: mesos Description --- See summary. Diffs - docs/mesos-doxygen-style-guide.md 93decf9984a8ebf5c713b968da53fc38caabeab0 Diff: https://reviews.apache.org/r/35350/diff/ Testing --- Thanks, Alexander Rojas

Re: Review Request 34703: Added stream manipulators for the Time object.

2015-06-16 Thread Alexander Rojas
., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34703/ --- (Updated June 16, 2015, 2:24 p.m.) Review

Re: Review Request 34703: Added stream manipulators for the Time object.

2015-06-16 Thread Alexander Rojas
-CREATION Diff: https://reviews.apache.org/r/34703/diff/ Testing --- make check Thanks, Alexander Rojas

Review Request 35508: Improve readability in post-review

2015-06-16 Thread Alexander Rojas
-reviews.py ba016f5a12f438e4748ded48d5c0b96facf173cf Diff: https://reviews.apache.org/r/35508/diff/ Testing --- Thanks, Alexander Rojas

Re: Review Request 34392: Added a method to Path which returns the modification time of the represented path.

2015-06-15 Thread Alexander Rojas
/stout/path.hpp d4df6502d1297ea3ad8e2a1e3bb16ea9d7c7913c Diff: https://reviews.apache.org/r/34392/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 35354: Smaller fixes in libprocess firewall initialization

2015-06-15 Thread Alexander Rojas
c379243e01919a5ab30bb9dea1b738665ba4e746 Diff: https://reviews.apache.org/r/35354/diff/ Testing --- Manual checks make check Thanks, Alexander Rojas

Re: Review Request 35353: Smaller fixes on libprocess firewall

2015-06-15 Thread Alexander Rojas
6a0b21d67912a40e0ec3220fdb250930be1979b2 3rdparty/libprocess/src/process.cpp f919b997287435381dbe34cb5bfdf73641ebeb23 3rdparty/libprocess/src/tests/process_tests.cpp 660af45e7fd45bdf5d43ad9aa54477fd94f87058 Diff: https://reviews.apache.org/r/35353/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 34703: Added stream manipulators for the Time object.

2015-06-15 Thread Alexander Rojas
/time_tests.cpp be314182c65c05d439b81aa5248a71d93f6f0a0b 3rdparty/libprocess/src/time.cpp PRE-CREATION Diff: https://reviews.apache.org/r/34703/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-06-15 Thread Alexander Rojas
660af45e7fd45bdf5d43ad9aa54477fd94f87058 Diff: https://reviews.apache.org/r/30032/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 35353: Smaller fixes on libprocess firewall

2015-06-15 Thread Alexander Rojas
6a0b21d67912a40e0ec3220fdb250930be1979b2 3rdparty/libprocess/src/process.cpp f919b997287435381dbe34cb5bfdf73641ebeb23 3rdparty/libprocess/src/tests/process_tests.cpp 660af45e7fd45bdf5d43ad9aa54477fd94f87058 Diff: https://reviews.apache.org/r/35353/diff/ Testing --- make check Thanks, Alexander

Re: Review Request 35508: Improve readability in post-review

2015-06-16 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35508/#review88082 --- On June 16, 2015, 2:43 p.m., Alexander Rojas wrote

Re: Review Request 35353: Smaller fixes on libprocess firewall

2015-06-18 Thread Alexander Rojas
/port_mapping_tests.cpp 6caab134fdbf3894f9fae801daf9491a13888c7d Diff: https://reviews.apache.org/r/35353/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 35363: Improvements on libprocess/README.md.

2015-06-17 Thread Alexander Rojas
, I think it would be nice to mention a little bit more about the threading model, for example, which thread executes a `then` callback? - Alexander Rojas On June 11, 2015, 10:40 p.m., Joerg Schad wrote: --- This is an automatically

Re: Review Request 35363: Improvements on libprocess/README.md.

2015-06-17 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35363/#review88226 --- Ship it! Ship It! - Alexander Rojas On June 11, 2015, 10:40 p.m

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-06-17 Thread Alexander Rojas
/r/30032/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-06-16 Thread Alexander Rojas
Diff: https://reviews.apache.org/r/30032/diff/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 34703: Added stream manipulators for the Time object.

2015-06-17 Thread Alexander Rojas
/time.cpp PRE-CREATION Diff: https://reviews.apache.org/r/34703/diff/ Testing --- make check Thanks, Alexander Rojas

  1   2   3   4   5   6   7   8   9   10   >