Review Request 48200: Merge function "socket_send_data" logical judgment.

2016-06-03 Thread Andy Pang
Description --- Function "socket_send_data" last logical judgment maybe merge beeter. Diffs - 3rdparty/libprocess/src/poll_socket.cpp d14dd1a Diff: https://reviews.apache.org/r/48200/diff/ Testing --- make check Thanks, Andy Pang

Review Request 42288: Docker container REST API /monitor/statistics.json output have no timestamp field

2016-01-13 Thread Andy Pang
--- make check Thanks, Andy Pang

Re: Review Request 43183: Support routing_tests run in aarch64 cpu.

2016-02-04 Thread Andy Pang
://reviews.apache.org/r/43183/diff/ Testing --- make test ok Thanks, Andy Pang

Review Request 43182: Support libprocess build run in aarch64 cpu.

2016-02-04 Thread Andy Pang
://reviews.apache.org/r/43182/diff/ Testing --- test run ok in AArch64. Thanks, Andy Pang

Review Request 43183: Support routing_tests run in aarch64 cpu.

2016-02-04 Thread Andy Pang
. Repository: mesos Description --- Support routing_tests run in aarch64 cpu. Diffs - src/tests/containerizer/routing_tests.cpp 4ebb01213ce20f954c2633df95e898cf66a2d9e9 Diff: https://reviews.apache.org/r/43183/diff/ Testing --- make test ok Thanks, Andy Pang

Review Request 43135: Support libprocess build run in aarch64 cpu.

2016-02-03 Thread Andy Pang
ut/include/stout/os/linux.hpp f8a4d5a Diff: https://reviews.apache.org/r/43135/diff/ Testing --- test run ok in AArch64 Thanks, Andy Pang

Review Request 43136: Support libprocess build run in aarch64 cpu.

2016-02-03 Thread Andy Pang
ut/include/stout/os/linux.hpp f8a4d5a Diff: https://reviews.apache.org/r/43136/diff/ Testing --- test run ok in AArch64. Thanks, Andy Pang

Re: Review Request 43136: Support libprocess build run in aarch64 cpu.

2016-02-03 Thread Andy Pang
LD, NULL); > > ``` Add routing_tests.cpp support aarch64 cpu. - Andy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43136/#review117595 ------

Re: Review Request 43136: Support libprocess build run in aarch64 cpu.

2016-02-03 Thread Andy Pang
/libprocess/3rdparty/stout/include/stout/os/linux.hpp f8a4d5ae12cfc2d2bd4a24226e200e1aabe0b8a8 src/tests/containerizer/routing_tests.cpp 4ebb01213ce20f954c2633df95e898cf66a2d9e9 Diff: https://reviews.apache.org/r/43136/diff/ Testing --- test run ok in AArch64. Thanks, Andy Pang

Re: Review Request 43136: Support libprocess build run in aarch64 cpu.

2016-02-04 Thread Andy Pang
) - 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp f8a4d5ae12cfc2d2bd4a24226e200e1aabe0b8a8 src/tests/containerizer/routing_tests.cpp 4ebb01213ce20f954c2633df95e898cf66a2d9e9 Diff: https://reviews.apache.org/r/43136/diff/ Testing --- test run ok in AArch64. Thanks, Andy Pang

Re: Review Request 43136: Support libprocess build run in aarch64 cpu.

2016-02-04 Thread Andy Pang
ed e-mail. To reply, visit: https://reviews.apache.org/r/43136/#review117771 --- On 二月 4, 2016, 8:56 a.m., Andy Pang wrote: > > --- > This is an automatically generate

Re: Review Request 42288: Add timestamp to DockerContainerizer's ResourceStatistics.

2016-01-20 Thread Andy Pang
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42288/#review115570 --- On 一月 21, 2016, 6:18 a.m., Andy Pang wrote: > > --- >

Re: Review Request 42288: Add timestamp to DockerContainerizer's ResourceStatistics

2016-01-20 Thread Andy Pang
REST API /monitor/statistics.json output have no timestamp field Diffs - src/slave/containerizer/docker.cpp da19975 Diff: https://reviews.apache.org/r/42288/diff/ Testing --- make check Thanks, Andy Pang

Re: Review Request 42288: Add timestamp to DockerContainerizer's ResourceStatistics

2016-01-20 Thread Andy Pang
/containerizer/docker.cpp 40f6f0b Diff: https://reviews.apache.org/r/42288/diff/ Testing --- make check Thanks, Andy Pang

Re: Review Request 42288: Add timestamp to DockerContainerizer's ResourceStatistics

2016-01-20 Thread Andy Pang
t, modify the summary as "Add timestamp to DockerContainerizer's ResourceStatistics" - Andy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42288/#review114443

Re: Review Request 42288: Add timestamp to DockerContainerizer's ResourceStatistics.

2016-01-25 Thread Andy Pang
the timestamp value set. Diffs (updated) - src/slave/containerizer/docker.cpp d2b77e3 Diff: https://reviews.apache.org/r/42288/diff/ Testing --- make check Thanks, Andy Pang

Review Request 44254: Add curl_easy_cleanup when fopen is failed.

2016-03-01 Thread Andy Pang
Description --- When fopen is failed,we should curl_easy_cleanup curl_handle. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 3c80910 Diff: https://reviews.apache.org/r/44254/diff/ Testing --- make check Thanks, Andy Pang

Re: Review Request 44254: Add curl_easy_cleanup when fopen is failed.

2016-03-01 Thread Andy Pang
Thanks, Andy Pang

Review Request 46550: Fixed slave to initialize libprocess before modules.

2016-04-21 Thread Andy Pang
iff: https://reviews.apache.org/r/46550/diff/ Testing --- make check Thanks, Andy Pang

Review Request 46249: Support hook/module process operation before main process initialize.

2016-04-14 Thread Andy Pang
TP request process "delegate" will be wrong, http request will not be response. Diffs - src/master/main.cpp ea7f0fc Diff: https://reviews.apache.org/r/46249/diff/ Testing --- make check Thanks, Andy Pang

Re: Review Request 46249: hook/module process operation before main process initialize.

2016-04-15 Thread Andy Pang
che.org/r/46249/diff/ Testing --- make check Thanks, Andy Pang

Re: Review Request 46249: Hook and module process operation before main process initialize.

2016-04-18 Thread Andy Pang
::initialize("master") will not be called. So the HTTP request process "delegate" will be wrong, http request will not be response. Diffs (updated) - src/master/main.cpp 7bbc982 Diff: https://reviews.apache.org/r/46249/diff/ Testing --- make check Thanks, Andy Pang

Re: Review Request 46249: hook/module process operation before main process initialize.

2016-04-17 Thread Andy Pang
aster") will not be called. So the HTTP request process "delegate" will be wrong, http request will not be response. Diffs (updated) - src/master/main.cpp ea7f0fc Diff: https://reviews.apache.org/r/46249/diff/ Testing --- make check Thanks, Andy Pang

Re: Review Request 46249: Hook and module process operation before main process initialize.

2016-04-17 Thread Andy Pang
s.apache.org/r/46249/diff/ Testing --- make check Thanks, Andy Pang

Re: Review Request 52185: Do not need to erase task if it not in pendingTasks.

2016-09-22 Thread Andy Pang
, Andy Pang

Review Request 52185: Do not need to erase task if it not in pendingTasks.

2016-09-22 Thread Andy Pang
Description --- If task has not been in hashmap pendingTasks, indicate it has been erase, so don't need to erase twice. Diffs - src/master/master.cpp 66a672f Diff: https://reviews.apache.org/r/52185/diff/ Testing --- make check Thanks, Andy Pang

Review Request 52142: Adjust indentation alignment.

2016-09-22 Thread Andy Pang
Description --- Adjust the _accept() indentation alignment. Diffs - src/master/master.hpp 35db198 Diff: https://reviews.apache.org/r/52142/diff/ Testing --- make check Thanks, Andy Pang

Re: Review Request 55042: Let MesosContainerizer support ramdisk.

2016-12-26 Thread Andy Pang
/slave.cpp f8f2ccf Diff: https://reviews.apache.org/r/55042/diff/ Testing --- make check Thanks, Andy Pang

Review Request 55042: Let MesosContainerizer support ramdisk.

2016-12-26 Thread Andy Pang
/55042/diff/ Testing --- make check Thanks, Andy Pang

Re: Review Request 58287: Print corresponding address when socket shutdown.

2017-04-11 Thread Andy Pang
: https://reviews.apache.org/r/58287/diff/2/ Changes: https://reviews.apache.org/r/58287/diff/1-2/ Testing --- make check Thanks, Andy Pang

Review Request 58287: Print corresponding address when socket shutdown.

2017-04-10 Thread Andy Pang
, Andy Pang

Re: Review Request 58287: Print corresponding address when socket shutdown.

2017-04-13 Thread Andy Pang
/3/ Changes: https://reviews.apache.org/r/58287/diff/2-3/ Testing --- make check File Attachments (updated) process.patch https://reviews.apache.org/media/uploaded/files/2017/04/13/d5736720-1262-484a-8efd-6e1eeada944d__process.patch Thanks, Andy Pang

Re: Review Request 58287: Print corresponding address when socket shutdown.

2017-04-20 Thread Andy Pang
/5/ Changes: https://reviews.apache.org/r/58287/diff/4-5/ Testing --- make check File Attachments process.patch https://reviews.apache.org/media/uploaded/files/2017/04/13/d5736720-1262-484a-8efd-6e1eeada944d__process.patch Thanks, Andy Pang

Review Request 58557: Print failure reason when socket accept failed.

2017-04-20 Thread Andy Pang
Description --- Print failure reason when socket accept failed. Diffs - 3rdparty/libprocess/src/process.cpp 92efa91 Diff: https://reviews.apache.org/r/58557/diff/1/ Testing --- make check Thanks, Andy Pang

Re: Review Request 58287: Print corresponding address when socket shutdown.

2017-04-20 Thread Andy Pang
/ Changes: https://reviews.apache.org/r/58287/diff/3-4/ Testing --- make check File Attachments process.patch https://reviews.apache.org/media/uploaded/files/2017/04/13/d5736720-1262-484a-8efd-6e1eeada944d__process.patch Thanks, Andy Pang

Re: Review Request 58557: Print failure reason when socket accept failed.

2017-04-24 Thread Andy Pang
check Thanks, Andy Pang

Review Request 58987: Add failure print when socket recv data.

2017-05-04 Thread Andy Pang
Description --- Add failure print when socket recv data. Diffs - 3rdparty/libprocess/src/process.cpp 96ce7db Diff: https://reviews.apache.org/r/58987/diff/1/ Testing --- make check Thanks, Andy Pang

Review Request 61808: Add task env overwriting executor env glog print

2017-08-21 Thread Andy Pang
Description --- When user assign environment by `CommandInfo` environment, it will overwrite the same name environment get by before. Diffs - src/slave/containerizer/docker.cpp b84c392 Diff: https://reviews.apache.org/r/61808/diff/1/ Testing --- make check Thanks, Andy Pang

Review Request 63437: Slave heartbeat add message sender distinguish.

2017-10-30 Thread Andy Pang
Description --- Slave ping-pong message add master from judge. Diffs - src/slave/slave.cpp 337083d Diff: https://reviews.apache.org/r/63437/diff/1/ Testing --- make check Thanks, Andy Pang

Re: Review Request 63437: Slave heartbeat add message sender distinguish.

2018-01-01 Thread Andy Pang
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63437/#review190074 --- On 十月 31, 2017, 3:45 a.m., Andy Pang wrote: > >