, visit:
https://reviews.apache.org/r/33558/#review81769
---
On April 28, 2015, 5:33 p.m., Benjamin Hindman wrote:
---
This is an automatically generated e-mail. To reply, visit
...) {
...;
}
...;
}
--
But for now, let's just s/recoverCache/recover/ since the fact that the
fetcher has a cache is an implementation detail.
- Benjamin Hindman
On April 29, 2015, 8:42 p.m., Bernd Mathiske wrote:
---
This is an automatically
-guide.md fe98f90ad0b0f5dd38af97e85062e90cee8de99e
Diff: https://reviews.apache.org/r/33558/diff/
Testing
---
N/A
Thanks,
Benjamin Hindman
On April 30, 2015, 9:45 p.m., Ben Mahler wrote:
src/slave/state.hpp, lines 214-227
https://reviews.apache.org/r/32837/diff/1/?file=914977#file914977line214
It seems a bit odd to put the top-level state in the middle, before one
can see the tree structure through the order they're
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32837/#review82328
---
Ship it!
Ship It!
- Benjamin Hindman
On April 30, 2015, 11:43
:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33505/
---
(Updated May 5, 2015, 9:51 p.m.)
Review request for mesos and Benjamin Hindman.
Repository: mesos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34371/#review84220
---
Ship it!
Ship It!
- Benjamin Hindman
On May 18, 2015, 8:57 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34018/#review84222
---
Ship it!
Ship It!
- Benjamin Hindman
On May 17, 2015, 10:11 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34017/#review84221
---
Ship it!
Ship It!
- Benjamin Hindman
On May 17, 2015, 10:11 a.m
`!?
- Benjamin Hindman
On May 20, 2015, 2:55 a.m., Joris Van Remoortere wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34442
line please.
src/tests/common/parse_tests.cpp
https://reviews.apache.org/r/34687/#comment138123
ASSERT_ERROR
src/tests/common/parse_tests.cpp
https://reviews.apache.org/r/34687/#comment138122
ASSERT_ERROR
- Benjamin Hindman
On May 31, 2015, 2:58 a.m., Marco Massenzio wrote
/#comment138125
What about this case:
T t(Hello)'
const T tprime = t.Member();
- Benjamin Hindman
On June 2, 2015, 9:34 a.m., Joris Van Remoortere wrote:
---
This is an automatically generated e-mail. To reply
://reviews.apache.org/r/33159/#comment138859
CHECK_EQ
- Benjamin Hindman
On June 5, 2015, 8:53 a.m., Joris Van Remoortere wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33159
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34943/#review86225
---
On June 2, 2015, 2:43 p.m., Benjamin Hindman wrote
/diff/
Testing
---
make check
Thanks,
Benjamin Hindman
---
See summary.
Diffs
-
3rdparty/libprocess/src/subprocess.cpp
f41f5e2a34788e31749eb996c8ab38ea45989068
Diff: https://reviews.apache.org/r/35127/diff/
Testing
---
make check
Thanks,
Benjamin Hindman
---
See summary.
Diffs
-
src/master/http.cpp f8ac30934352db859e73819e0656a70047bb0dc5
src/slave/http.cpp bc25bdd33277dbfa30410ad081ea09f0fc39c598
Diff: https://reviews.apache.org/r/35128/diff/
Testing
---
make check
Thanks,
Benjamin Hindman
/libprocess/3rdparty/stout/tests/flags_tests.cpp
80450185f60c5b273face490e0bb9e695b0cb984
3rdparty/libprocess/3rdparty/stout/tests/subcommand_tests.cpp
c40bba4f1e7eef7cb04f79b567e32684648b2004
Diff: https://reviews.apache.org/r/35126/diff/
Testing
---
make check
Thanks,
Benjamin Hindman
: https://reviews.apache.org/r/35125/diff/
Testing
---
make check
Thanks,
Benjamin Hindman
/#comment139468
This looks like it's the same thing that Niklas added in
https://reviews.apache.org/r/35037? And this link doesn't work, 'documentation'
is spelled wrong. I'm just going to kill this part for now since we're already
linking to this from what Niklas added.
- Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35206/#review87153
---
Ship it!
Ship It!
- Benjamin Hindman
On June 8, 2015, 8:51 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34645/#review87149
---
Ship it!
Ship It!
- Benjamin Hindman
On June 1, 2015, 5:26 p.m
On June 5, 2015, 6:42 p.m., Vinod Kone wrote:
I made some minor comments below but I think a better way to do this is to
*not* write custom masterinfo json - protobuf converters. I prefer we
just add a new optional field (say ipAddress of type string). Then you can
just leverage the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33754/#review86597
---
Ship it!
Ship It!
- Benjamin Hindman
On May 1, 2015, 4:02 p.m
On May 18, 2015, 6:24 p.m., haosdent huang wrote:
3rdparty/libprocess/configure.ac, line 745
https://reviews.apache.org/r/33754/diff/1/?file=947259#file947259line745
Maybe we could search the whole project and replace acx_pthread.m4 -
ax_pthread.m4
I fixed this for you before
On June 4, 2015, 2:44 p.m., Benjamin Hindman wrote:
Ship It!
Like another patch you submitted you went from +2 to +4 indentation here,
please be on the look out for that in the future. Thanks!
- Benjamin
:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33849/
---
(Updated May 5, 2015, 5:52 p.m.)
Review request for mesos, Benjamin Hindman, Cody Maloney
/33850/#comment138676
I think you meant != here. ;-) How did this pass for you!?
- Benjamin Hindman
On May 15, 2015, 4:24 p.m., James Peach wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
On May 18, 2015, 6:20 p.m., haosdent huang wrote:
configure.ac, line 650
https://reviews.apache.org/r/33753/diff/1/?file=947255#file947255line650
Should we change acx_pthread.m4 to ax_pthread.m4 here?
James Peach wrote:
Updated the patch to alter the comments too.
I think
On June 4, 2015, 1:47 p.m., Benjamin Hindman wrote:
Ship It!
Note that I also had to update stout/Makefile.am to remove the usage of the
'm4' directory. I'm not sure how this didn't break running 'bootstrap' for you?
- Benjamin
On June 4, 2015, 2:04 p.m., Benjamin Hindman wrote:
3rdparty/libprocess/configure.ac, line 694
https://reviews.apache.org/r/33850/diff/2/?file=950418#file950418line694
s/Mesos/libprocess/
I took care of this fix for you James before committing. Thanks!
- Benjamin
On June 4, 2015, 2:04 p.m., Benjamin Hindman wrote:
Just a heads up, you went from the +2 indentation in this file to +4 when you
moved stuff around. I fixed it for you, but please keep the style consistent in
the future, thanks!
- Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33753/#review86598
---
Ship it!
Ship It!
- Benjamin Hindman
On May 1, 2015, 4:02 p.m
://reviews.apache.org/r/33850/#comment138661
s/Mesos/libprocess/
- Benjamin Hindman
On May 15, 2015, 4:24 p.m., James Peach wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33850
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32364/#review86570
---
Ship it!
Ship It!
- Benjamin Hindman
On June 3, 2015, 5:19 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32358/#review86565
---
Ship it!
Ship It!
- Benjamin Hindman
On June 3, 2015, 5:16 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32361/#review86567
---
Ship it!
Ship It!
- Benjamin Hindman
On June 3, 2015, 5:16 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32356/#review86564
---
Ship it!
Ship It!
- Benjamin Hindman
On June 3, 2015, 5:11 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32362/#review86568
---
Ship it!
Ship It!
- Benjamin Hindman
On June 3, 2015, 5:17 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32360/#review86566
---
Ship it!
Ship It!
- Benjamin Hindman
On June 3, 2015, 5:16 p.m
---
make check
Thanks,
Benjamin Hindman
this been:
```
char* argv[] = { (char*) /path/to/program,
(char*) --name1=billy joel };
```
Benjamin Hindman wrote:
I just copied this code. Let me give this a test and if so I'll cleanup
the others too.
This is definitely cleaner and we should do
/
Testing
---
make check
Thanks,
Benjamin Hindman
---
On June 2, 2015, 2:46 p.m., Benjamin Hindman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34944
---
On June 15, 2015, 5:52 p.m., Benjamin Hindman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34943
://reviews.apache.org/r/35405/diff/
Testing
---
NOT YET
Thanks,
Benjamin Hindman
-mail. To reply, visit:
https://reviews.apache.org/r/34943/#review87996
---
On June 15, 2015, 5:52 p.m., Benjamin Hindman wrote:
---
This is an automatically generated e-mail
protocol buffer: +
masterInfo.error());
- Benjamin Hindman
On June 18, 2015, 2:27 a.m., Marco Massenzio wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35571
., Benjamin Hindman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35566/
---
(Updated June 17, 2015, 2:28 p.m.)
Review request
this on your own now.
;-)
src/tests/fetcher_cache_tests.cpp (line 563)
https://reviews.apache.org/r/35438/#comment140845
EXPECT_SOME will print the error for you automagically, no need to do it
yourself! Please fix all spots in this review, thanks!
- Benjamin Hindman
On June 15, 2015, 2
80450185f60c5b273face490e0bb9e695b0cb984
Diff: https://reviews.apache.org/r/34943/diff/
Testing
---
make check
Thanks,
Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35622/#review88995
---
Ship it!
Ship It!
- Benjamin Hindman
On June 23, 2015, 3:57 p.m
On June 18, 2015, 11:09 a.m., Benjamin Hindman wrote:
src/master/detector.cpp, lines 468-469
https://reviews.apache.org/r/35571/diff/5/?file=986674#file986674line468
You should always know this is an error because you're in the 'else'
branch, so you can just do:
LOG
/
Testing
---
make check and generated doxygen documentation.
Thanks,
Benjamin Hindman
and generated doxygen documentation.
Thanks,
Benjamin Hindman
before commit.
- Benjamin Hindman
On June 24, 2015, 7:57 p.m., Artem Harutyunyan wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35843
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35908/#review89468
---
Ship it!
Ship It!
- Benjamin Hindman
On June 26, 2015, 3:55 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35854/#review89470
---
Ship it!
Ship It!
- Benjamin Hindman
On June 26, 2015, 3:55 a.m
://reviews.apache.org/r/35567/diff/
Testing
---
make check
Thanks,
Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35694/#review88661
---
On June 24, 2015, 10 p.m., Benjamin Hindman wrote:
---
This is an automatically
., Benjamin Hindman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35567/
---
(Updated June 24, 2015, 10:01 p.m.)
Review
4f90d3dcd880b95f22ea13c56a61c7f981eea57d
3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp
6a26d93a9a68ab18b7c9b25039a96b663a73a309
Diff: https://reviews.apache.org/r/35694/diff/
Testing
---
make check
Thanks,
Benjamin Hindman
of ``` so that it renders
correctly when generated via doxygen. I'll make that minor modification and
commit this, thanks Alex!
- Benjamin Hindman
On June 18, 2015, 3:56 p.m., Alexander Rukletsov wrote:
---
This is an automatically
this return path
differs.
- Benjamin Hindman
On June 18, 2015, 5:05 p.m., Michael Park wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35433
On June 17, 2015, 8:23 p.m., Till Toenshoff wrote:
3rdparty/libprocess/src/subprocess.cpp, line 332
https://reviews.apache.org/r/35561/diff/1/?file=986458#file986458line332
Aren't we leaking this one in the parent process?
Benjamin Hindman wrote:
We'll be exec'ing, so
/diff/
Testing
---
make check
Thanks,
Benjamin Hindman
f41f5e2a34788e31749eb996c8ab38ea45989068
3rdparty/libprocess/src/tests/subprocess_tests.cpp
b5cfc8d3daff489b332b6bfef2872cef9abecefe
Diff: https://reviews.apache.org/r/35561/diff/
Testing
---
make check
Thanks,
Benjamin Hindman
/35694/diff/
Testing
---
make check
Thanks,
Benjamin Hindman
/os_tests.cpp
62987e0df28f28816c59d7cbad89fa2af41ade04
Diff: https://reviews.apache.org/r/35565/diff/
Testing
---
make check
Thanks,
Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35433/#review88568
---
Ship it!
Ship It!
- Benjamin Hindman
On June 19, 2015, 2:31 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35638/#review88573
---
Ship it!
Ship It!
- Benjamin Hindman
On June 19, 2015, 11:53
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35129/#review88563
---
Ship it!
Ship It!
- Benjamin Hindman
On June 19, 2015, 6:38 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35635/#review88571
---
Ship it!
Ship It!
- Benjamin Hindman
On June 19, 2015, 12:39
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35962/#review89599
---
Ship it!
Ship It!
- Benjamin Hindman
On June 27, 2015, 1:18 a.m
this 'endif' closes!
- Benjamin Hindman
On June 27, 2015, 1:18 a.m., Joris Van Remoortere wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35889
/routing_tests.cpp 4be9967d38177d9f7def5c0da98d4c4266e7f0b5
src/tests/script.cpp bcc1fab912410237dfe903d7a36cad9323d625a0
Diff: https://reviews.apache.org/r/34943/diff/
Testing
---
make check
Thanks,
Benjamin Hindman
our code guarantees. If
instead we were waiting for some kind of an ack from the slave that it received
the dynamic reservation before it send the task launch then a CHECK would make
sense.
- Benjamin Hindman
On June 13, 2015, 9:43 p.m., Michael Park wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35253/#review87856
---
Ship it!
Ship It!
- Benjamin Hindman
On June 13, 2015, 2:32 p.m
13, 2015, 9:23 a.m.)
Review request for mesos, Benjamin Hindman and Michael Park.
Bugs: MESOS-1913
https://issues.apache.org/jira/browse/MESOS-1913
Repository: mesos
Description
---
Requires:
configure --enable-libevent --enable-libevent-socket --enable-ssl
New
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35431/#review87855
---
Ship it!
Ship It!
- Benjamin Hindman
On June 13, 2015, 8:57 p.m
://reviews.apache.org/r/34943/diff/
Testing
---
make check
Thanks,
Benjamin Hindman
://reviews.apache.org/r/33208/
---
(Updated April 15, 2015, 5:23 a.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, Niklas Nielsen, and
Vinod Kone.
Bugs: MESOS-1634
https://issues.apache.org/jira/browse/MESOS-1634
---
NOT YET
Thanks,
Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35095/#review87821
---
Ship it!
Ship It!
- Benjamin Hindman
On June 4, 2015, 10:54 p.m
, basically, we can
still use synchronized! I'll fix and commit.
- Benjamin Hindman
On June 4, 2015, 10:54 p.m., Joris Van Remoortere wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35097/#review87823
---
Ship it!
Ship It!
- Benjamin Hindman
On June 4, 2015, 11:07 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35102/#review87830
---
Ship it!
Ship It!
- Benjamin Hindman
On June 5, 2015, 7:42 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35426/#review87832
---
Ship it!
Ship It!
- Benjamin Hindman
On June 13, 2015, 2:07 p.m
, I'll adjust and commit.
- Benjamin Hindman
On June 4, 2015, 10:54 p.m., Joris Van Remoortere wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35096
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35098/#review87824
---
Ship it!
Ship It!
- Benjamin Hindman
On June 4, 2015, 10:54 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35099/#review87826
---
Ship it!
Ship It!
- Benjamin Hindman
On June 4, 2015, 10:55 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35089/#review87813
---
Ship it!
Ship It!
- Benjamin Hindman
On June 4, 2015, 10:53 p.m
()'! I'll do that for you
now! AWESOME!
- Benjamin Hindman
On June 4, 2015, 10:54 p.m., Joris Van Remoortere wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35091
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35100/#review87828
---
Ship it!
Ship It!
- Benjamin Hindman
On June 4, 2015, 10:55 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35101/#review87829
---
Ship it!
Ship It!
- Benjamin Hindman
On June 4, 2015, 10:55 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35425/#review87831
---
Ship it!
Ship It!
- Benjamin Hindman
On June 13, 2015, 2:06 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35439/#review87869
---
Ship it!
Ship It!
- Benjamin Hindman
On June 14, 2015, 3:30 p.m
/35000/#review86577
---
On June 3, 2015, 1:45 p.m., Benjamin Hindman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35000
8c102fb7d1f79ee768cb06de3a976ea12f958712
src/tests/containerizer.cpp 80b910515694c81cf5b1eace1d79a5178cf35426
Diff: https://reviews.apache.org/r/35566/diff/
Testing
---
make check
Thanks,
Benjamin Hindman
93690cfa9dbf2658ce642829299f4adf08bb1062
src/tests/containerizer.cpp 80b910515694c81cf5b1eace1d79a5178cf35426
Diff: https://reviews.apache.org/r/35567/diff/
Testing
---
make check
Thanks,
Benjamin Hindman
1 - 100 of 602 matches
Mail list logo