Re: Review Request 61495: Add documentation for possible task reasons.

2017-08-10 Thread Benno Evers
, Benno Evers

Review Request 61558: Move duplicate comment closer to implementation.

2017-08-10 Thread Benno Evers
Diff: https://reviews.apache.org/r/61558/diff/1/ Testing --- Thanks, Benno Evers

Re: Review Request 61495: Removed table from markdown and added cross-links.

2017-08-09 Thread Benno Evers
66386a84bc21989d1c1237e629d5d04662a368fa src/master/master.cpp 43cb6977ca58dce1808e4bdb2d109d549622beb9 Diff: https://reviews.apache.org/r/61495/diff/2/ Changes: https://reviews.apache.org/r/61495/diff/1-2/ Testing --- None Thanks, Benno Evers

Re: Review Request 61495: Removed table from markdown and added cross-links.

2017-08-10 Thread Benno Evers
/ Testing (updated) --- Built website with site/build.sh and verified it renders ok. HTML preview: http://htmlpreview.github.io/?https://github.com/lava/mesos/blob/bennoe/task-reasons/site/publish/documentation/latest/task-reasons/index.html Thanks, Benno Evers

Re: Review Request 61495: Add documentation for possible task reasons.

2017-08-10 Thread Benno Evers
://github.com/lava/mesos/blob/bennoe/task-reasons/site/publish/documentation/latest/task-reasons/index.html Thanks, Benno Evers

Re: Review Request 61495: Add documentation for possible task reasons.

2017-08-10 Thread Benno Evers
nerated e-mail. To reply, visit: https://reviews.apache.org/r/61495/#review182549 ------- On Aug. 10, 2017, 10:43 a.m., Benno Evers wrote: > > --- > This i

Re: Review Request 61137: Cleaned up style in example frameworks.

2017-08-09 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61137/#review182475 --- Ship it! - Benno Evers On Aug. 7, 2017, 1:53 p.m., Armand

Re: Review Request 61111: Extracted strings into constants in example frameworks.

2017-08-08 Thread Benno Evers
guide? - Benno Evers On Aug. 7, 2017, 12:50 p.m., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 61110: Added name flag to balloon and disk full frameworks.

2017-08-08 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61110/#review182392 --- Ship it! - Benno Evers On Aug. 1, 2017, 10:20 a.m., Armand

Re: Review Request 61664: Libprocess: Added a timeout for send socket operation.

2017-08-17 Thread Benno Evers
O` socket options to enforce this timeout at the OS level. - Benno Evers On Aug. 15, 2017, 3:45 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request 62212: Send TASK_STARTING from the built-in executors.

2017-09-13 Thread Benno Evers
/r/62212/diff/2/ Changes: https://reviews.apache.org/r/62212/diff/1-2/ Testing --- Thanks, Benno Evers

Re: Review Request 62162: Revert usage of `-isystem` flag.

2017-09-14 Thread Benno Evers
(updated) Updated boost tarball https://reviews.apache.org/media/uploaded/files/2017/09/14/3e6f3c0d-5b93-408d-9fce-ff4fb1f21d43__boost-1.65.0.tar.gz Thanks, Benno Evers

Re: Review Request 62161: Update boost version.

2017-09-21 Thread Benno Evers
0b62ae96817ade616f8dfc52cf8df995f8fd8927 3rdparty/versions.am cbab26d3e303180c3f210f0c5f45613a5c8c96ba Diff: https://reviews.apache.org/r/62161/diff/3/ Changes: https://reviews.apache.org/r/62161/diff/2-3/ Testing --- Thanks, Benno Evers

Re: Review Request 62445: Remove duplicate block in configure.ac.

2017-09-21 Thread Benno Evers
/62445/diff/1-2/ Testing --- Thanks, Benno Evers

Re: Review Request 62447: Revert usage of `-isystem` flag.

2017-09-21 Thread Benno Evers
, Benno Evers

Review Request 62444: Add UNREACHABLE() macro to __cxa_pure_virtual.

2017-09-20 Thread Benno Evers
/62444/diff/1/ Testing --- Thanks, Benno Evers

Re: Review Request 62160: Fix stout build with newer boost versions.

2017-09-20 Thread Benno Evers
/libprocess, but technically `stout` is an independent library so I think we should not break API compatibility for such a small improvement. - Benno --- This is an automatically generated e-mail. To reply, visit: https:

Review Request 62446: Additional check when building with java bindings enabled.

2017-09-20 Thread Benno Evers
/1/ Testing --- Thanks, Benno Evers

Review Request 62445: Remove duplicate block in configure.ac.

2017-09-20 Thread Benno Evers
seems to have been copy/pasted from another place. Diffs - configure.ac 92bc1aa5f9604e3b2b678225a57622cd2eb8679a Diff: https://reviews.apache.org/r/62445/diff/1/ Testing --- Thanks, Benno Evers

Review Request 62447: Revert usage of `-isystem` flag.

2017-09-20 Thread Benno Evers
92bc1aa5f9604e3b2b678225a57622cd2eb8679a Diff: https://reviews.apache.org/r/62447/diff/1/ Testing --- Thanks, Benno Evers

Re: Review Request 62447: Revert usage of `-isystem` flag.

2017-09-21 Thread Benno Evers
d e-mail. To reply, visit: https://reviews.apache.org/r/62447/#review185855 ------- On Sept. 20, 2017, 5:08 p.m., Benno Evers wrote: > > --- > This is an a

Re: Review Request 62616: Binary packaging for Centos 7.

2017-10-06 Thread Benno Evers
omment applies for the other files under `packaging/common/`) support/packaging/common/mesos-slave Lines 1 (patched) <https://reviews.apache.org/r/62616/#comment264207> Should this be `ZK` instead of `MASTER`? And do we need a check here if mesos was compiled with support for zookee

Re: Review Request 62161: Update boost version.

2017-10-06 Thread Benno Evers
-dc046e24dca5__0001-Update-boost-version.patch Thanks, Benno Evers

Re: Review Request 62213: Fix unit tests that were broken by the additional TASK_STARTING update.

2017-10-13 Thread Benno Evers
/diff/6/ Changes: https://reviews.apache.org/r/62213/diff/5-6/ Testing --- Thanks, Benno Evers

Re: Review Request 62212: Send TASK_STARTING from the built-in executors.

2017-10-12 Thread Benno Evers
cluster and successfully completed the tweeter tutorial - Installed in local DC/OS cluster and successfully ran a periodic sleep task using chronos. Thanks, Benno Evers

Re: Review Request 61558: Move duplicate comment closer to implementation.

2017-09-07 Thread Benno Evers
14d94cfa0e96881f77dd6e0c3449fdc0613e36ce Diff: https://reviews.apache.org/r/61558/diff/2/ Changes: https://reviews.apache.org/r/61558/diff/1-2/ Testing --- Thanks, Benno Evers

Review Request 62213: Send TASK_STARTING from the built-in executors. [2/2]

2017-09-11 Thread Benno Evers
://reviews.apache.org/r/62213/diff/1/ Testing --- Thanks, Benno Evers

Review Request 62212: Send TASK_STARTING from the built-in executors. [1/2]

2017-09-11 Thread Benno Evers
951597b576b4912541dd87d52dcb981393e58082 Diff: https://reviews.apache.org/r/62212/diff/1/ Testing --- Thanks, Benno Evers

Review Request 62115: Fix stout build with newer boost versions.

2017-09-06 Thread Benno Evers
--- Thanks, Benno Evers

Review Request 62114: Revert usage of `-isystem` flag.

2017-09-06 Thread Benno Evers
92bc1aa5f9604e3b2b678225a57622cd2eb8679a Diff: https://reviews.apache.org/r/62114/diff/1/ Testing --- Thanks, Benno Evers

Re: Review Request 61495: Add documentation for possible task reasons.

2017-09-06 Thread Benno Evers
, Benno Evers

Re: Review Request 62115: Fix stout build with newer boost versions.

2017-09-06 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62115/ --- (Updated Sept. 6, 2017, 10:08 a.m.) Review request for mesos and Benno Evers

Re: Review Request 62115: Fix stout build with newer boost versions.

2017-09-06 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62115/ --- (Updated Sept. 6, 2017, 10:08 a.m.) Review request for mesos and Benno Evers

Review Request 62162: Revert usage of `-isystem` flag.

2017-09-07 Thread Benno Evers
92bc1aa5f9604e3b2b678225a57622cd2eb8679a src/logging/logging.cpp 70d66a5c396f709e8f27ad0d51315ed6d257f73b Diff: https://reviews.apache.org/r/62162/diff/1/ Testing --- Thanks, Benno Evers

Review Request 62161: Update boost version.

2017-09-07 Thread Benno Evers
boost version. Diffs - 3rdparty/boost-1.53.0.tar.gz 175f373c330ff69bdb0d44fc75a29982e68554ab 3rdparty/boost-1.65.0.tar.gz PRE-CREATION 3rdparty/versions.am cbab26d3e303180c3f210f0c5f45613a5c8c96ba Diff: https://reviews.apache.org/r/62161/diff/1/ Testing --- Thanks, Benno Evers

Review Request 62160: Fix stout build with newer boost versions.

2017-09-07 Thread Benno Evers
--- Thanks, Benno Evers

Re: Review Request 62212: Send TASK_STARTING from the built-in executors. [1/2]

2017-09-12 Thread Benno Evers
----- On Sept. 11, 2017, 9:16 a.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62212/ >

Re: Review Request 62213: Fix unit tests that were broken by the additional TASK_STARTING update.

2017-09-12 Thread Benno Evers
/ Changes: https://reviews.apache.org/r/62213/diff/1-2/ Testing --- Thanks, Benno Evers

Re: Review Request 62212: Send TASK_STARTING from the built-in executors. [1/2]

2017-09-12 Thread Benno Evers
> and helps differentiating between tasks stuck in TASK_STAGING > and tasks stuck in TASK_STARTING. > > > Diffs > - > > docs/high-availability-framework-guide.md > 73743aba31f9d0ca827d318e2ecb4752a91b1be0 > src/docker/executor.cpp e9949f652cd8527991ebfdfbf14e68b4c958fe79 > src/launcher/default_executor.cpp 106b7f2e0244d211c66b237b5d1c51f43fc6e529 > src/launcher/executor.cpp 951597b576b4912541dd87d52dcb981393e58082 > > > Diff: https://reviews.apache.org/r/62212/diff/1/ > > > Testing > --- > > > Thanks, > > Benno Evers > >

Review Request 62123: Send additional TASK_STARTING update from built-in executors.

2017-09-06 Thread Benno Evers
1bdadce4c50cbff958f2be2a4261e130b414acfd src/tests/teardown_tests.cpp 8834333bbcdb6a04a95a6ed9632ad4ead0791f76 Diff: https://reviews.apache.org/r/62123/diff/1/ Testing --- Thanks, Benno Evers

Re: Review Request 62212: Send TASK_STARTING from the built-in executors.

2017-09-29 Thread Benno Evers
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62212/#review185478 ------- On Sept. 13, 2017, 2:52 p.m., Benno Evers wrote: > > --- > This is

Re: Review Request 62212: Send TASK_STARTING from the built-in executors.

2017-09-29 Thread Benno Evers
generated e-mail. To reply, visit: https://reviews.apache.org/r/62212/#review185310 --- On Sept. 13, 2017, 2:52 p.m., Benno Evers wrote: > > --- > Thi

Re: Review Request 62213: Fix unit tests that were broken by the additional TASK_STARTING update.

2017-09-29 Thread Benno Evers
/teardown_tests.cpp 5eada4f4392b7c721f5efbd537b0e817d40c7a27 Diff: https://reviews.apache.org/r/62213/diff/4/ Changes: https://reviews.apache.org/r/62213/diff/3-4/ Testing --- Thanks, Benno Evers

Re: Review Request 62212: Send TASK_STARTING from the built-in executors.

2017-09-29 Thread Benno Evers
136c000917b2c4fdaf68fd460764c3a15fdf3bf0 src/launcher/executor.cpp 0131577d5b9018e7094815f1377b2ee59a4493d4 Diff: https://reviews.apache.org/r/62212/diff/3/ Changes: https://reviews.apache.org/r/62212/diff/2-3/ Testing --- Thanks, Benno Evers

Re: Review Request 61495: Add documentation for possible task reasons.

2017-09-04 Thread Benno Evers
website with site/build.sh and verified it renders ok. HTML preview: http://htmlpreview.github.io/?https://github.com/lava/mesos/blob/bennoe/task-reasons/site/publish/documentation/latest/task-state-reasons/index.html Thanks, Benno Evers

Re: Review Request 61495: Add documentation for possible task reasons.

2017-09-04 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61495/#review184244 --- On Sept. 4, 2017, 10:47 a.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > h

Re: Review Request 62212: Send TASK_STARTING from the built-in executors.

2017-10-11 Thread Benno Evers
tutorial * Installed in local DC/OS cluster and successfully ran a periodic sleep task using chronos. Thanks, Benno Evers

Re: Review Request 62897: Add MESOS-7941 to changelog and to upgrade guidelines.

2017-10-11 Thread Benno Evers
) - CHANGELOG acbb9992bce8ede95c9f725811ab1c19f91e69f0 docs/upgrades.md febe0c15283c283a24cbb63690b44fe48d08f17b Diff: https://reviews.apache.org/r/62897/diff/3/ Changes: https://reviews.apache.org/r/62897/diff/2-3/ Testing --- Thanks, Benno Evers

Re: Review Request 62212: Send TASK_STARTING from the built-in executors.

2017-10-11 Thread Benno Evers
cluster and successfully completed the tweeter tutorial - Installed in local DC/OS cluster and successfully ran a periodic sleep task using chronos. Thanks, Benno Evers

Re: Review Request 62212: Send TASK_STARTING from the built-in executors.

2017-10-11 Thread Benno Evers
tutorial - Installed in local DC/OS cluster and successfully ran a periodic sleep task using chronos. Thanks, Benno Evers

Re: Review Request 62897: Add MESOS-7941 to changelog and to upgrading documentation.

2017-10-11 Thread Benno Evers
febe0c15283c283a24cbb63690b44fe48d08f17b Diff: https://reviews.apache.org/r/62897/diff/2/ Testing --- Thanks, Benno Evers

Re: Review Request 62897: Add MESOS-7941 to changelog and to upgrading documentation.

2017-10-11 Thread Benno Evers
docs/upgrades.md febe0c15283c283a24cbb63690b44fe48d08f17b Diff: https://reviews.apache.org/r/62897/diff/2/ Changes: https://reviews.apache.org/r/62897/diff/1-2/ Testing --- Thanks, Benno Evers

Re: Review Request 62213: Fix unit tests that were broken by the additional TASK_STARTING update.

2017-10-11 Thread Benno Evers
Diff: https://reviews.apache.org/r/62213/diff/5/ Testing --- Thanks, Benno Evers

Re: Review Request 62212: Send TASK_STARTING from the built-in executors.

2017-10-11 Thread Benno Evers
and successfully ran a periodic sleep task using chronos. Thanks, Benno Evers

Review Request 62893: Expand description of the --recovery_timeout flag.

2017-10-11 Thread Benno Evers
Description --- Expand description of the --recovery_timeout flag. Diffs - src/slave/flags.cpp d424ade99bccde0c4c4fb591c8a443ccb8fd58ed Diff: https://reviews.apache.org/r/62893/diff/1/ Testing --- Thanks, Benno Evers

Review Request 62897: Add MESOS-7941 to changelog.

2017-10-11 Thread Benno Evers
Description --- Add MESOS-7941 to changelog. Diffs - CHANGELOG acbb9992bce8ede95c9f725811ab1c19f91e69f0 Diff: https://reviews.apache.org/r/62897/diff/1/ Testing --- Thanks, Benno Evers

Re: Review Request 62213: Fix unit tests that were broken by the additional TASK_STARTING update.

2017-10-17 Thread Benno Evers
/teardown_tests.cpp 5eada4f4392b7c721f5efbd537b0e817d40c7a27 Diff: https://reviews.apache.org/r/62213/diff/7/ Changes: https://reviews.apache.org/r/62213/diff/6-7/ Testing --- Thanks, Benno Evers

Re: Review Request 62213: Fix unit tests that were broken by the additional TASK_STARTING update.

2017-10-18 Thread Benno Evers
91d97d195acd695ae9c469651596511eafb50557 src/tests/teardown_tests.cpp 5eada4f4392b7c721f5efbd537b0e817d40c7a27 Diff: https://reviews.apache.org/r/62213/diff/8/ Changes: https://reviews.apache.org/r/62213/diff/7-8/ Testing --- Thanks, Benno Evers

Review Request 63113: Fix flakyness in 'SlaveTest.ExecutorShutdownGracePeriod'.

2017-10-18 Thread Benno Evers
-tests --gtest_filter="*ExecutorShutdownGracePeriod*" --gtest_repeat=5000 --gtest_break_on_failure Thanks, Benno Evers

Review Request 63214: Fixed GPU tests.

2017-10-23 Thread Benno Evers
--- Thanks, Benno Evers

Re: Review Request 62161: Update boost version.

2017-11-10 Thread Benno Evers
mail. To reply, visit: https://reviews.apache.org/r/62161/#review190302 ------- On Oct. 6, 2017, 2:02 p.m., Benno Evers wrote: > > --- > This is an automatically generated e

Re: Review Request 63846: Updated test PortMappingMesosTest.CGROUPS_ROOT_CleanUpOrphan.

2017-11-15 Thread Benno Evers
://reviews.apache.org/r/63846/diff/1/ Testing (updated) --- make check on various linux distros Thanks, Benno Evers

Review Request 63846: Updated test PortMappingMesosTest.CGROUPS_ROOT_CleanUpOrphan.

2017-11-15 Thread Benno Evers
/ Testing --- https://jenkins.mesosphere.com/service/jenkins/view/Mesos/job/mesos/job/Mesos_CI-build/2159/ Thanks, Benno Evers

Re: Review Request 64006: Moved registry operations into separate header.

2017-11-27 Thread Benno Evers
/ Changes: https://reviews.apache.org/r/64006/diff/3-4/ Testing --- Thanks, Benno Evers

Re: Review Request 64007: Added infrastructure to support master capabilities.

2017-11-27 Thread Benno Evers
10084125deb839a9846a4f64d2e433ff02754c02 src/master/master.cpp 2ddd67ada3731803b00883b6a1f32b20c1bb238f src/tests/master_tests.cpp 9c450b9f592d9e09a468f537d9b500e97acc636b Diff: https://reviews.apache.org/r/64007/diff/3/ Changes: https://reviews.apache.org/r/64007/diff/2-3/ Testing --- Thanks, Benno

Re: Review Request 64009: Added new UpdateSlave registry operation.

2017-11-27 Thread Benno Evers
--- Thanks, Benno Evers

Re: Review Request 64010: Added an optional SlaveInfo parameter to Allocator::updateSlave().

2017-11-27 Thread Benno Evers
f0f95ba4f667bf8ea54e985d8cde913a4170d8ff Diff: https://reviews.apache.org/r/64010/diff/3/ Changes: https://reviews.apache.org/r/64010/diff/2-3/ Testing --- Thanks, Benno Evers

Review Request 64012: Added new --configuration_compatibility slave flag and implementation.

2017-11-22 Thread Benno Evers
/ Testing --- Thanks, Benno Evers

Review Request 64011: Updated master behaviour to update agent state on reregistration.

2017-11-22 Thread Benno Evers
2ddd67ada3731803b00883b6a1f32b20c1bb238f src/tests/master_tests.cpp 9c450b9f592d9e09a468f537d9b500e97acc636b Diff: https://reviews.apache.org/r/64011/diff/1/ Testing --- Thanks, Benno Evers

Re: Review Request 64007: Added infrastructure to support master capabilities.

2017-11-29 Thread Benno Evers
10084125deb839a9846a4f64d2e433ff02754c02 src/master/master.cpp 700e12433b0b66efc3f5dd296711c0f203a13144 src/tests/master_tests.cpp 01f45a9bb6378c5fded31bf58fbcad93fe7ed719 Diff: https://reviews.apache.org/r/64007/diff/4/ Changes: https://reviews.apache.org/r/64007/diff/3-4/ Testing --- Thanks, Benno Evers

Re: Review Request 64009: Added new UpdateSlave registry operation.

2017-11-29 Thread Benno Evers
/64009/diff/3-4/ Testing --- Thanks, Benno Evers

Re: Review Request 64011: Updated master behaviour to update agent state on reregistration.

2017-11-29 Thread Benno Evers
src/master/master.cpp 700e12433b0b66efc3f5dd296711c0f203a13144 Diff: https://reviews.apache.org/r/64011/diff/4/ Changes: https://reviews.apache.org/r/64011/diff/3-4/ Testing --- Thanks, Benno Evers

Re: Review Request 64011: Updated master behaviour to update agent state on reregistration.

2017-11-29 Thread Benno Evers
he.org/jira/browse/MESOS-8273 - Benno --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64011/#review191767 --- On Nov.

Re: Review Request 64012: Added new --reconfiguration_compatibility slave flag and implementation.

2017-11-29 Thread Benno Evers
/slave_compatibility_tests.cpp PRE-CREATION src/tests/slave_tests.cpp aeaa923f36af134b61ad9df93c95651a8d9bc23c Diff: https://reviews.apache.org/r/64012/diff/4/ Changes: https://reviews.apache.org/r/64012/diff/3-4/ Testing --- Thanks, Benno Evers

Re: Review Request 64008: Activated AGENT_UPDATE master capability.

2017-11-29 Thread Benno Evers
://reviews.apache.org/r/64008/diff/4-5/ Testing --- Thanks, Benno Evers

Re: Review Request 64101: Skip registry update if SlaveInfo didn't change.

2017-11-29 Thread Benno Evers
--- Thanks, Benno Evers

Re: Review Request 64009: Added new UpdateSlave registry operation.

2017-11-30 Thread Benno Evers
e-mail. To reply, visit: https://reviews.apache.org/r/64009/#review192128 --- On Nov. 29, 2017, 6:06 p.m., Benno Evers wrote: > > --- > This is an automatically generated

Review Request 64101: Skip registry update if SlaveInfo didn't change.

2017-11-27 Thread Benno Evers
--- Skip registry update if SlaveInfo didn't change. Diffs - src/master/master.cpp 2ddd67ada3731803b00883b6a1f32b20c1bb238f Diff: https://reviews.apache.org/r/64101/diff/1/ Testing --- Thanks, Benno Evers

Re: Review Request 64012: Added new --configuration_compatibility slave flag and implementation.

2017-11-27 Thread Benno Evers
Diff: https://reviews.apache.org/r/64012/diff/3/ Changes: https://reviews.apache.org/r/64012/diff/2-3/ Testing --- Thanks, Benno Evers

Re: Review Request 64011: Updated master behaviour to update agent state on reregistration.

2017-11-27 Thread Benno Evers
src/master/master.cpp 2ddd67ada3731803b00883b6a1f32b20c1bb238f src/tests/master_tests.cpp 9c450b9f592d9e09a468f537d9b500e97acc636b Diff: https://reviews.apache.org/r/64011/diff/3/ Changes: https://reviews.apache.org/r/64011/diff/2-3/ Testing --- Thanks, Benno Evers

Re: Review Request 64008: Activated AGENT_UPDATE master capability.

2017-11-27 Thread Benno Evers
://reviews.apache.org/r/64008/diff/3-4/ Testing --- Thanks, Benno Evers

Re: Review Request 64012: Added new --configuration_compatibility slave flag and implementation.

2017-11-27 Thread Benno Evers
Diff: https://reviews.apache.org/r/64012/diff/2/ Changes: https://reviews.apache.org/r/64012/diff/1-2/ Testing --- Thanks, Benno Evers

Re: Review Request 64011: Updated master behaviour to update agent state on reregistration.

2017-11-27 Thread Benno Evers
src/master/master.cpp 2ddd67ada3731803b00883b6a1f32b20c1bb238f src/tests/master_tests.cpp 9c450b9f592d9e09a468f537d9b500e97acc636b Diff: https://reviews.apache.org/r/64011/diff/2/ Changes: https://reviews.apache.org/r/64011/diff/1-2/ Testing --- Thanks, Benno Evers

Re: Review Request 64008: Activated AGENT_UPDATE master capability.

2017-11-27 Thread Benno Evers
://reviews.apache.org/r/64008/diff/2-3/ Testing --- Thanks, Benno Evers

Re: Review Request 64006: Moved registry operations into separate header.

2017-11-29 Thread Benno Evers
/ Changes: https://reviews.apache.org/r/64006/diff/4-5/ Testing --- Thanks, Benno Evers

Re: Review Request 64011: Updated master behaviour to update agent state on reregistration.

2017-11-29 Thread Benno Evers
ps://reviews.apache.org/r/64011/#review191767 ------- On Nov. 29, 2017, 6:27 p.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail.

Review Request 64169: Add checks for slave gone.

2017-11-29 Thread Benno Evers
for slave gone. Diffs - src/master/master.cpp 700e12433b0b66efc3f5dd296711c0f203a13144 Diff: https://reviews.apache.org/r/64169/diff/1/ Testing --- Thanks, Benno Evers

Re: Review Request 64010: Added additional parameters to Allocator::updateSlave().

2017-11-29 Thread Benno Evers
f0f95ba4f667bf8ea54e985d8cde913a4170d8ff Diff: https://reviews.apache.org/r/64010/diff/4/ Changes: https://reviews.apache.org/r/64010/diff/3-4/ Testing --- Thanks, Benno Evers

Re: Review Request 64010: Added `SlaveInfo` parameter to Allocator::updateSlave().

2017-12-04 Thread Benno Evers
/ Testing --- `make check` https://jenkins.mesosphere.com/service/jenkins/view/Mesos/job/mesos/job/Mesos_CI-build/2299/ Thanks, Benno Evers

Re: Review Request 64011: Updated master behaviour to update agent state on reregistration.

2017-12-04 Thread Benno Evers
://reviews.apache.org/r/64011/diff/6-7/ Testing --- Thanks, Benno Evers

Re: Review Request 64011: Updated master behaviour to update agent state on reregistration.

2017-12-04 Thread Benno Evers
ps://reviews.apache.org/r/64011/#review192773 ------- On Dec. 4, 2017, 4:30 p.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail.

Review Request 64307: Rename reconfiguration_compatibility to reconfiguration_policy.

2017-12-04 Thread Benno Evers
src/tests/slave_recovery_tests.cpp 7674e607ee5bb7efbceb81c3e7291bc558d69935 src/tests/slave_tests.cpp a7f6658fa467914cd74691b5631d26d85ba7c1eb Diff: https://reviews.apache.org/r/64307/diff/1/ Testing --- Thanks, Benno Evers

Re: Review Request 64010: Added additional parameters to Allocator::updateSlave().

2017-12-01 Thread Benno Evers
/4-5/ Testing --- Thanks, Benno Evers

Re: Review Request 64011: Updated master behaviour to update agent state on reregistration.

2017-12-01 Thread Benno Evers
src/master/master.cpp dfe60ef670edcaefa0c1241df2e2870f650fcf9e Diff: https://reviews.apache.org/r/64011/diff/5/ Changes: https://reviews.apache.org/r/64011/diff/4-5/ Testing --- Thanks, Benno Evers

Review Request 64252: Convert resource format of messages entering master.

2017-12-01 Thread Benno Evers
, Benno Evers

Re: Review Request 64012: Added new --reconfiguration_compatibility slave flag and implementation.

2017-12-01 Thread Benno Evers
Diff: https://reviews.apache.org/r/64012/diff/5/ Changes: https://reviews.apache.org/r/64012/diff/4-5/ Testing --- Thanks, Benno Evers

Re: Review Request 64008: Activated AGENT_UPDATE master capability.

2017-12-01 Thread Benno Evers
/ Changes: https://reviews.apache.org/r/64008/diff/5-6/ Testing --- Thanks, Benno Evers

Re: Review Request 64009: Added new UpdateSlave registry operation.

2017-12-01 Thread Benno Evers
1e1eadb539482113e8ca8cb0542e5aaf34a38b41 src/tests/registrar_tests.cpp 21d78e90e57c145aa9f4b26f1a2f0278390b98d4 Diff: https://reviews.apache.org/r/64009/diff/5/ Changes: https://reviews.apache.org/r/64009/diff/4-5/ Testing --- Thanks, Benno Evers

Re: Review Request 64506: Correctly reset slave status when aborting a registration.

2017-12-14 Thread Benno Evers
7b087675200fe0ca69319b715997700a91d9f6b2 Diff: https://reviews.apache.org/r/64506/diff/2/ Changes: https://reviews.apache.org/r/64506/diff/1-2/ Testing --- `make check` Thanks, Benno Evers

Re: Review Request 64507: Added a master flag to disallow agents without domain.

2017-12-13 Thread Benno Evers
/ Testing --- `make check` Thanks, Benno Evers

  1   2   3   4   5   6   7   8   >