Re: Review Request 32108: Added manual make for readability training source code.

2015-04-28 Thread Bernd Mathiske
this as well. Thanks, Bernd Mathiske

Re: Review Request 32108: Added manual make for readability training source code

2015-04-28 Thread Bernd Mathiske
-mail. To reply, visit: https://reviews.apache.org/r/32108/#review81783 --- On April 27, 2015, 6:44 p.m., Bernd Mathiske wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 29889: Recover Docker containers when mesos slave is in a container

2015-04-28 Thread Bernd Mathiske
/executor.cpp https://reviews.apache.org/r/29889/#comment132412 Out of the 3 vars launched, dockerRun, killed you only need 2. src/docker/executor.cpp https://reviews.apache.org/r/29889/#comment132413 This is also virtual in the CommandExecutor, but why? - Bernd Mathiske On April 22, 2015, 3:50

Re: Review Request 30774: Fetcher Cache

2015-04-29 Thread Bernd Mathiske
and eviction disabling. - Eviction gets disabled for URIs that are currently in use, i.e. the related cache files are. We use reference counting for this, since there may be concurrent fetch attempts using the same cache files. Thanks, Bernd Mathiske

Re: Review Request 29889: Recover Docker containers when mesos slave is in a container

2015-05-01 Thread Bernd Mathiske
There is extra text on this in the docs. Please determine how much of it pull up here as well. - Bernd Mathiske On May 1, 2015, 2:43 p.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 30609: Added a function that reports file size, not following links.

2015-04-30 Thread Bernd Mathiske
--- On March 11, 2015, 10:06 a.m., Bernd Mathiske wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30609/ --- (Updated March 11

Re: Review Request 30774: Fetcher Cache

2015-05-03 Thread Bernd Mathiske
(_fetch in this case) in tests to block, but Bernd wanted to introduce a specific empty method for tests. I told him this is not a pattern we use in Mesos, but like to see what you think. Bernd Mathiske wrote: Of course I will stick to the prevalent patterns unless you start liking

Re: Review Request 30774: Fetcher Cache

2015-05-03 Thread Bernd Mathiske
and the FetcherInfo::Item. If The FetcherInfo encapsulates the FetcherInfo::Item I would also suggest switching the order of the parameters to signify that. Bernd Mathiske wrote: The main purpose here is to fetch this one particular item, not everything FetcherInfo carries. FetcherInfo

Re: Review Request 32108: Added manual make for readability training source code.

2015-04-30 Thread Bernd Mathiske
/32108/diff/ Testing --- cd build/readability; make Also observed that the pre-commit hook does this as well. Thanks, Bernd Mathiske

Re: Review Request 30609: Added a function that reports file size, not following links.

2015-04-30 Thread Bernd Mathiske
343f95be7f316170b37c9358627f3c2090f0e29e Diff: https://reviews.apache.org/r/30609/diff/ Testing --- Wrote a simple test that creates a file and tests its size, and also checks if a non-existing file yields an error. Thanks, Bernd Mathiske

Re: Review Request 30774: Fetcher Cache

2015-05-01 Thread Bernd Mathiske
explicitly whether or not the cache_filename was set! Same for the cache_directory below as well. Bernd Mathiske wrote: What if somebody else uses mesos-fetcher? Adding a comment why this is not a check. - Bernd

Re: Review Request 30774: Fetcher Cache

2015-05-01 Thread Bernd Mathiske
there may be concurrent fetch attempts using the same cache files. Thanks, Bernd Mathiske

Re: Review Request 30774: Fetcher Cache

2015-04-30 Thread Bernd Mathiske
--- On April 29, 2015, 1:42 p.m., Bernd Mathiske wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/ --- (Updated

Re: Review Request 30774: Fetcher Cache

2015-04-30 Thread Bernd Mathiske
. Thanks, Bernd Mathiske

Re: Review Request 30609: Added a function that reports file size, not following links.

2015-05-05 Thread Bernd Mathiske
that is simple to reason about. Bernd Mathiske wrote: Yes, adding followSymlinks to existing functions could be a bit of a mess, because we would end up with different defaults, since stat and lstat are not being used consistently at the moment. But adding the two wrapper functions

Re: Review Request 30774: Fetcher Cache

2015-05-04 Thread Bernd Mathiske
for undoing things like space reservations and eviction disabling. - Eviction gets disabled for URIs that are currently in use, i.e. the related cache files are. We use reference counting for this, since there may be concurrent fetch attempts using the same cache files. Thanks, Bernd Mathiske

Re: Review Request 30774: Fetcher Cache

2015-05-04 Thread Bernd Mathiske
-mail. To reply, visit: https://reviews.apache.org/r/30774/#review82260 --- On April 30, 2015, 7:40 p.m., Bernd Mathiske wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 29889: Recover Docker containers when mesos slave is in a container

2015-05-11 Thread Bernd Mathiske
that we don't need this test any more? - Bernd Mathiske On May 8, 2015, 2:40 p.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29889

Re: Review Request 30609: Added a function that reports file size, not following links.

2015-05-05 Thread Bernd Mathiske
that is simple to reason about. Bernd Mathiske wrote: Yes, adding followSymlinks to existing functions could be a bit of a mess, because we would end up with different defaults, since stat and lstat are not being used consistently at the moment. But adding the two wrapper functions

Re: Review Request 30609: Added a function that reports file size, not following links.

2015-05-07 Thread Bernd Mathiske
://reviews.apache.org/r/30609/#comment133684 bool-enum - Bernd Mathiske On April 30, 2015, 1:38 p.m., Bernd Mathiske wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30609

Re: Review Request 30609: Added a function that reports file size, not following links.

2015-05-12 Thread Bernd Mathiske
343f95be7f316170b37c9358627f3c2090f0e29e Diff: https://reviews.apache.org/r/30609/diff/ Testing --- Wrote a simple test that creates a file and tests its size, and also checks if a non-existing file yields an error. Thanks, Bernd Mathiske

Re: Review Request 30774: Fetcher Cache

2015-05-13 Thread Bernd Mathiske
://reviews.apache.org/r/30774/#review82017 --- On May 12, 2015, 3:43 p.m., Bernd Mathiske wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774

Re: Review Request 30774: Fetcher Cache

2015-05-13 Thread Bernd Mathiske
counting for this, since there may be concurrent fetch attempts using the same cache files. Thanks, Bernd Mathiske

Re: Review Request 32982: [WIP] Added reservation user guide.

2015-05-13 Thread Bernd Mathiske
. - Bernd Mathiske On May 13, 2015, 3:15 p.m., Michael Park wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32982/ --- (Updated

Re: Review Request 33058: Updated test-frameworks to support principal only credential.

2015-05-13 Thread Bernd Mathiske
/33058/#comment134716 line 80 chars - Bernd Mathiske On April 10, 2015, 12:25 a.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33058

Re: Review Request 30774: Fetcher Cache

2015-05-12 Thread Bernd Mathiske
for undoing things like space reservations and eviction disabling. - Eviction gets disabled for URIs that are currently in use, i.e. the related cache files are. We use reference counting for this, since there may be concurrent fetch attempts using the same cache files. Thanks, Bernd Mathiske

Re: Review Request 30774: Fetcher Cache

2015-05-15 Thread Bernd Mathiske
/30774/#comment135003 AWAIT_READY, not AWAIT_READY_FOR, coz the default is 15 and that works fine, too. - Bernd Mathiske On May 13, 2015, 3:07 p.m., Bernd Mathiske wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 30774: Fetcher Cache

2015-05-15 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/#review83946 --- - Bernd Mathiske On May 13, 2015, 3:07 p.m., Bernd Mathiske wrote

Re: Review Request 30774: Fetcher Cache

2015-05-15 Thread Bernd Mathiske
/30774/#comment135004 This needs to be a pointer. Or use a simple struct. Name: FetcherCacheTest::Task - Bernd Mathiske On May 13, 2015, 3:07 p.m., Bernd Mathiske wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 30774: Fetcher Cache

2015-05-15 Thread Bernd Mathiske
, commandFilename).executable(); Bernd Mathiske wrote: Should we wait with this until Path has been fleshed out? This would be a separate review. I added a TODO and this will lead to a separate JIRA ticket to enhance Path. - Bernd

Re: Review Request 30609: Added a function that reports file size, not following links.

2015-05-20 Thread Bernd Mathiske
343f95be7f316170b37c9358627f3c2090f0e29e Diff: https://reviews.apache.org/r/30609/diff/ Testing --- Wrote a simple test that creates a file and tests its size, and also checks if a non-existing file yields an error. Thanks, Bernd Mathiske

Review Request 35247: Fixed race between EXPECT_CALL(resourceOffers, _) and driver.start() in fetcher_cache_tests.cpp.

2015-06-09 Thread Bernd Mathiske
/diff/ Testing --- make check Thanks, Bernd Mathiske

Re: Review Request 35247: Fixed race between EXPECT_CALL(resourceOffers, _) and driver.start() in fetcher_cache_tests.cpp.

2015-06-09 Thread Bernd Mathiske
cbd44b98d19953d174fac977f509d4900a37481f Diff: https://reviews.apache.org/r/35247/diff/ Testing --- make check Thanks, Bernd Mathiske

Re: Review Request 35206: Added mainpage to doxygen documentation.

2015-06-08 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35206/#review87045 --- Ship it! Ship It! - Bernd Mathiske On June 8, 2015, 9:22 a.m

Re: Review Request 30774: Fetcher Cache

2015-06-09 Thread Bernd Mathiske
. - Bernd --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/#review86871 --- On May 21, 2015, 9:05 a.m., Bernd Mathiske wrote

Re: Review Request 35247: Fixed race between EXPECT_CALL(resourceOffers, _) and driver.start() in fetcher_cache_tests.cpp.

2015-06-09 Thread Bernd Mathiske
/fetcher_cache_tests.cpp cbd44b98d19953d174fac977f509d4900a37481f Diff: https://reviews.apache.org/r/35247/diff/ Testing --- make check Thanks, Bernd Mathiske

Re: Review Request 35000: Doxygen'ized Subprocess.

2015-06-04 Thread Bernd Mathiske
, as for example 'WIFEXITED(status)'. - Bernd Mathiske On June 3, 2015, 6:45 a.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35000

Re: Review Request 35247: Fixed race between EXPECT_CALL(resourceOffers, _) and driver.start() in fetcher_cache_tests.cpp.

2015-06-09 Thread Bernd Mathiske
(starting slave, starting master, constructing scheduler but not starting it, setting some expectations) and there is no documentation for it! Bernd Mathiske wrote: Long term I am working on developing up stress tests for the fetcher. These are still relatively basic functionality

Re: Review Request 35438: Fixed fetcher cache test race for resource offers when starting tasks and changed corresponding CHECK to EXPECT.

2015-06-22 Thread Bernd Mathiske
8bd5dd847fb189d0eeeaa760d3ec8ce3af1c2392 Diff: https://reviews.apache.org/r/35438/diff/ Testing --- make check Thanks, Bernd Mathiske

Re: Review Request 35438: Fixed fetcher cache test race for resource offers when starting tasks and changed corresponding CHECK to EXPECT.

2015-06-22 Thread Bernd Mathiske
check Thanks, Bernd Mathiske

Re: Review Request 33263: Extended SlaveTest.ShutdownUnregisteredExecutor test with a reason check.

2015-06-23 Thread Bernd Mathiske
/ --- (Updated April 16, 2015, 7:31 a.m.) Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till Toenshoff. Bugs: MESOS-2625 https://issues.apache.org/jira/browse/MESOS-2625 Repository: mesos Description

Re: Review Request 33263: Extended SlaveTest.ShutdownUnregisteredExecutor test with a reason check.

2015-06-23 Thread Bernd Mathiske
::REASON_COMMAND_EXECUTOR_FAILED Which is: 0 ``` Bernd Mathiske wrote: For me, too. This fails as indicated above every time. This needs a bit of work. Maybe the code reporting the status has changed meanwhile. @adyatlov, please investigate. - Bernd

Re: Review Request 35510: Introduced General and Markdown Documentation Style Guides.

2015-06-23 Thread Bernd Mathiske
://reviews.apache.org/r/35510/#comment141574 Is this blank line necessary? - Bernd Mathiske On June 23, 2015, 5:53 a.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35510

Re: Review Request 35553: Rename libprocess User Guide to Developer Guide.

2015-06-23 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35553/#review88960 --- Ship it! Ship It! - Bernd Mathiske On June 17, 2015, 2:22 a.m

Re: Review Request 35510: Introduced General and Markdown Documentation Style Guides.

2015-06-23 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35510/#review88968 --- Ship it! Ship It! - Bernd Mathiske On June 23, 2015, 6:30 a.m

Re: Review Request 34835: Add constexpr to C++ whitelist

2015-06-25 Thread Bernd Mathiske
On June 18, 2015, 2:46 a.m., Bernd Mathiske wrote: docs/mesos-c++-style-guide.md, line 540 https://reviews.apache.org/r/34835/diff/2/?file=984763#file984763line540 s/,/. Combining these two sentences deemphasizes the general demand of the first one. I don't see this addressed

Re: Review Request 34835: Add constexpr to C++ whitelist

2015-06-25 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34835/#review89338 --- Ship it! Ship It! - Bernd Mathiske On June 24, 2015, 2:14 p.m

Re: Review Request 35611: Added initial doxygen documentation for stout flags.

2015-06-25 Thread Bernd Mathiske
://reviews.apache.org/r/35611/#comment141953 lambdas - closures ? - Bernd Mathiske On June 20, 2015, 8:19 a.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35611

Review Request 35917: Disabled DISABLED_HttpCachedRecovery.

2015-06-26 Thread Bernd Mathiske
://reviews.apache.org/r/35917/diff/ Testing --- Thanks, Bernd Mathiske

Re: Review Request 35917: Disabled DISABLED_HttpCachedRecovery.

2015-06-26 Thread Bernd Mathiske
/fetcher_cache_tests.cpp f29f31993f53c7f5a44267753aa6ea4574c80c82 Diff: https://reviews.apache.org/r/35917/diff/ Testing (updated) --- make check. Observed that the test is no longer active. Thanks, Bernd Mathiske

Re: Review Request 35799: Support mounting relative paths with docker.

2015-06-24 Thread Bernd Mathiske
either fix now, or leave a TODO and a tech debt ticket. - Bernd Mathiske On June 23, 2015, 12:18 p.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35799

Re: Review Request 35568: Remove html from libprocess Developer Guide.

2015-06-24 Thread Bernd Mathiske
of this interation is merely to get rid of most of the HTML. - Bernd Mathiske On June 24, 2015, 7:56 a.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35568

Re: Review Request 34943: Added validation to flags.

2015-06-18 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34943/#review88386 --- Ship it! Ship It! - Bernd Mathiske On June 18, 2015, 8:34 a.m

Re: Review Request 35438: Fixed fetcher cache test race for resource offers when starting tasks and changed corresponding CHECK to EXPECT.

2015-06-22 Thread Bernd Mathiske
/fetcher_cache_tests.cpp 8bd5dd847fb189d0eeeaa760d3ec8ce3af1c2392 Diff: https://reviews.apache.org/r/35438/diff/ Testing --- make check Thanks, Bernd Mathiske

Re: Review Request 35438: Fixed fetcher cache test race for resource offers when starting tasks and changed corresponding CHECK to EXPECT.

2015-06-15 Thread Bernd Mathiske
/tests/fetcher_cache_tests.cpp 8bd5dd847fb189d0eeeaa760d3ec8ce3af1c2392 Diff: https://reviews.apache.org/r/35438/diff/ Testing --- make check Thanks, Bernd Mathiske

Re: Review Request 35438: Fixed fetcher cache test race for resource offers when starting tasks and changed corresponding CHECK to EXPECT.

2015-06-15 Thread Bernd Mathiske
8bd5dd847fb189d0eeeaa760d3ec8ce3af1c2392 Diff: https://reviews.apache.org/r/35438/diff/ Testing --- make check Thanks, Bernd Mathiske

Re: Review Request 35247: Fixed race between EXPECT_CALL(resourceOffers, _) and driver.start() in fetcher_cache_tests.cpp.

2015-06-14 Thread Bernd Mathiske
) and there is no documentation for it! On June 9th, 2015, 8:07 p.m. UTC, Bernd Mathiske wrote: Long term I am working on developing up stress tests for the fetcher. These are still relatively basic functionality tests so far. Yes, SetUp() and TearDown() do a lot here. Would you prefer

Review Request 35438: Fixed fetcher cache test race for resource offers when starting tasks and changed corresponding CHECK to EXPECT.

2015-06-14 Thread Bernd Mathiske
Thanks, Bernd Mathiske

Re: Review Request 34703: Added stream manipulators for the Time object.

2015-06-17 Thread Bernd Mathiske
://reviews.apache.org/r/34703/#comment140598 Nice. Can we also test Time::epoch(), please? - Bernd Mathiske On June 16, 2015, 5:24 a.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 34392: Added a method to Path which returns the modification time of the represented path.

2015-06-17 Thread Bernd Mathiske
) https://reviews.apache.org/r/34392/#comment140601 Please document what this function does, in particular that it does not follow symlinks and under what conditions it returns an error. - Bernd Mathiske On June 15, 2015, 4:34 a.m., Alexander Rojas wrote

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-06-17 Thread Bernd Mathiske
See above. - Bernd Mathiske On June 16, 2015, 7:08 p.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30032

Re: Review Request 35364: Consistent code examples in doxygen style.

2015-06-16 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35364/#review88045 --- Ship it! Ship It! - Bernd Mathiske On June 11, 2015, 1:39 p.m

Re: Review Request 34703: Added stream manipulators for the Time object.

2015-06-16 Thread Bernd Mathiske
. Alternatively add a blank line between 84 and 85. - Bernd Mathiske On June 15, 2015, 8:26 a.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34703

Re: Review Request 34892: Reintroduced chown stdout stderr in FetcherProcess::run().

2015-06-01 Thread Bernd Mathiske
/mesos.cpp 830d362c81e98092ae671d5d5f69bb865d33ba3a Diff: https://reviews.apache.org/r/34892/diff/ Testing --- Thanks, Bernd Mathiske

Re: Review Request 35799: Support mounting relative paths with docker.

2015-06-29 Thread Bernd Mathiske
On June 24, 2015, 3:13 a.m., Bernd Mathiske wrote: src/tests/docker_tests.cpp, line 374 https://reviews.apache.org/r/35799/diff/1/?file=990751#file990751line374 Use Flags::docker_sandbox_directory (or a constant that the flag also uses for its default value) instead. Not only

Re: Review Request 35985: Consistent capitalization of NOTE in documentation

2015-06-29 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35985/#review89726 --- Ship it! Ship It! - Bernd Mathiske On June 28, 2015, 3:45 a.m

Review Request 36197: Documented how to become a committer.

2015-07-06 Thread Bernd Mathiske
docs/committers.md ca8a6995c5272f3534ab63f95332565dfcaaf5b9 Diff: https://reviews.apache.org/r/36197/diff/ Testing --- The rendered files can be viewed here: https://gist.github.com/bernd-mesos/00de63ae13efec4331be Thanks, Bernd Mathiske

Re: Review Request 36197: Documented how to become a committer.

2015-07-06 Thread Bernd Mathiske
generated e-mail. To reply, visit: https://reviews.apache.org/r/36197/#review90473 --- On July 6, 2015, 5:32 a.m., Bernd Mathiske wrote: --- This is an automatically generated e

Re: Review Request 36197: Documented how to become a committer.

2015-07-06 Thread Bernd Mathiske
/36197/diff/ Testing --- The rendered files can be viewed here: https://gist.github.com/bernd-mesos/00de63ae13efec4331be Thanks, Bernd Mathiske

Re: Review Request 36152: Updated CHANGELOG for 0.23.0.

2015-07-03 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36152/#review90319 --- Ship it! Ship It! - Bernd Mathiske On July 2, 2015, 4:47 p.m

Re: Review Request 34276: Use special constructor for OptionT from SomeT.

2015-05-26 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34276/#review85165 --- Ship it! Ship It! - Bernd Mathiske On May 21, 2015, 4:45 p.m

Re: Review Request 30774: Fetcher Cache

2015-05-21 Thread Bernd Mathiske
reservations and eviction disabling. - Eviction gets disabled for URIs that are currently in use, i.e. the related cache files are. We use reference counting for this, since there may be concurrent fetch attempts using the same cache files. Thanks, Bernd Mathiske

Re: Review Request 34545: Updated the allocator related docs.

2015-05-22 Thread Bernd Mathiske
://reviews.apache.org/r/34545/#comment136350 Examples: either use singular here or add a second example. - Bernd Mathiske On May 21, 2015, 7:58 a.m., Alexander Rukletsov wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-05-22 Thread Bernd Mathiske
line of which it applies to. irst pass - Bernd Mathiske On May 18, 2015, 9:20 p.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30032

Re: Review Request 30774: Fetcher Cache

2015-05-21 Thread Bernd Mathiske
using the same cache files. Thanks, Bernd Mathiske

Re: Review Request 30774: Fetcher Cache

2015-05-19 Thread Bernd Mathiske
reservations and eviction disabling. - Eviction gets disabled for URIs that are currently in use, i.e. the related cache files are. We use reference counting for this, since there may be concurrent fetch attempts using the same cache files. Thanks, Bernd Mathiske

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-05-26 Thread Bernd Mathiske
://reviews.apache.org/r/30032/#comment136712 This function can fail. Error handling, please. - Bernd Mathiske On May 26, 2015, 7:41 a.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 34545: Updated the allocator related docs.

2015-05-26 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34545/#review85190 --- Ship it! Ship It! - Bernd Mathiske On May 26, 2015, 3:37 a.m

Re: Review Request 36205: Added AWAIT_EXPECT_TRUE and AWAIT_EXPECT_FALSE macros.

2015-07-07 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36205/#review90674 --- Ship it! Ship It! - Bernd Mathiske On July 7, 2015, 1:20 a.m

Re: Review Request 34703: Added stream manipulators for the Time object.

2015-07-07 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34703/#review90669 --- Ship it! Ship It! - Bernd Mathiske On June 17, 2015, 8:42 a.m

Re: Review Request 36214: Fix running docker executor tests.

2015-07-07 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36214/#review90663 --- Ship it! Ship It! - Bernd Mathiske On July 6, 2015, 1:40 p.m

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-07-07 Thread Bernd Mathiske
: // TODO(arojas): Use Path.mtime() once it is available. - Bernd Mathiske On June 17, 2015, 8:42 a.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30032

Re: Review Request 36216: Only run netcat tests when nc is available.

2015-07-07 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36216/#review90662 --- Ship it! Ship It! - Bernd Mathiske On July 6, 2015, 3:58 p.m

Re: Review Request 36049: Added support for modularized Authorizer

2015-08-03 Thread Bernd Mathiske
://reviews.apache.org/r/36049/#comment148335 See above. src/master/main.cpp (line 305) https://reviews.apache.org/r/36049/#comment148336 See above. - Bernd Mathiske On Aug. 3, 2015, 2:47 a.m., Alexander Rojas wrote

Re: Review Request 36908: Added QuotaInfo Protobuf.

2015-08-03 Thread Bernd Mathiske
/36908/#comment148340 s/guaranteed/guarantees include/mesos/master/quota.proto (line 38) https://reviews.apache.org/r/36908/#comment148341 limit, bound - plural - Bernd Mathiske On July 29, 2015, 9:59 a.m., Joerg Schad wrote

Re: Review Request 36049: Added support for modularized Authorizer

2015-08-13 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36049/#review95250 --- Ship it! Ship It! - Bernd Mathiske On Aug. 12, 2015, 6:52 a.m

Re: Review Request 36050: Added test authorizer module.

2015-08-13 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36050/#review95251 --- Ship it! Ship It! - Bernd Mathiske On Aug. 12, 2015, 6:52 a.m

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-08-13 Thread Bernd Mathiske
that this is not the eventual intended shape of authz, but it is a self-contained, consistent step in the right direction.) include/mesos/authorizer/authorizer.hpp (line 61) https://reviews.apache.org/r/36048/#comment150104 s/is/if - Bernd Mathiske On Aug. 13, 2015, 1:57 a.m., Alexander Rojas wrote

Review Request 35915: Disabled DISABLED_HttpCachedRecovery.

2015-06-29 Thread Bernd Mathiske
to debug its flakiness (MESOS-2871). Diffs - src/tests/fetcher_cache_tests.cpp f29f31993f53c7f5a44267753aa6ea4574c80c82 Diff: https://reviews.apache.org/r/35915/diff/ Testing --- Thanks, Bernd Mathiske

Re: Review Request 35920: Change EXPECT to ASSERT when relying in the assertion afterwards.

2015-06-26 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35920/#review89484 --- Ship it! Ship It! - Bernd Mathiske On June 26, 2015, 4:27 a.m

Re: Review Request 36197: Documented how to become a committer.

2015-07-28 Thread Bernd Mathiske
/00de63ae13efec4331be Thanks, Bernd Mathiske

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-08-04 Thread Bernd Mathiske
: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/ --- (Updated Aug. 4, 2015, 2:52 a.m.) Review request for mesos, Alexander Rukletsov and Bernd Mathiske. Bugs: MESOS-3073 https

Re: Review Request 36847: Added HTTP Delete Method.

2015-08-04 Thread Bernd Mathiske
/#comment148548 Because of this concatenation we should explain at the function delcaration in http.hpp that it is expected that `path` starts with /. Or is it not? - Bernd Mathiske On Aug. 3, 2015, 11:45 a.m., Joerg Schad wrote

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-08-04 Thread Bernd Mathiske
, this LGTM. - Bernd Mathiske On Aug. 4, 2015, 3:40 a.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-08-04 Thread Bernd Mathiske
/authorize inside src/master? Bernd Mathiske wrote: It's not intended to stay just for master. We are working on generalizing how all this works for all kinds of endpoints in all kinds of Mesos components: https://docs.google.com/document/d/1kM3_f7DSqXcE2MuERrLTGp_XMC6ss2wmpkNYDCY5rOM

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-08-04 Thread Bernd Mathiske
: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated Aug. 3, 2015, 2:47 a.m.) Review request for mesos, Adam B, Alexander Rukletsov, Bernd Mathiske

Review Request 37075: Protobuf definitions instructing the fetcher cache about checksums and their validation.

2015-08-04 Thread Bernd Mathiske
in the ticket). There are references to docs in this patch, but updating docs will be in the last patch. Diffs - include/mesos/mesos.proto a6748d1cd82238f005c6a49c70d22d095462f1ba Diff: https://reviews.apache.org/r/37075/diff/ Testing --- Thanks, Bernd Mathiske

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-08-04 Thread Bernd Mathiske
: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/ --- (Updated Aug. 3, 2015, 11:09 a.m.) Review request for mesos, Alexander Rukletsov and Bernd Mathiske. Bugs: MESOS-3073 https

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-08-04 Thread Bernd Mathiske
/36913/#comment148540 See my previous review. This is correct syntax IMHO. - Bernd Mathiske On Aug. 4, 2015, 2:52 a.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r

Re: Review Request 36946: Factored out the pattern for URL generation in a fetcher test.

2015-07-31 Thread Bernd Mathiske
/r/36946/#comment148115 This change seems to eliminate the essence of the test, namely the leading white space. - Bernd Mathiske On July 30, 2015, 9:37 a.m., Artem Harutyunyan wrote: --- This is an automatically generated e-mail

  1   2   3   4   5   >