this as well.
Thanks,
Bernd Mathiske
/executor.cpp
https://reviews.apache.org/r/29889/#comment132412
Out of the 3 vars launched, dockerRun, killed you only need 2.
src/docker/executor.cpp
https://reviews.apache.org/r/29889/#comment132413
This is also virtual in the CommandExecutor, but why?
- Bernd Mathiske
On April 22, 2015, 3:50
There is extra text on this in the docs. Please determine how much of it
pull up here as well.
- Bernd Mathiske
On May 1, 2015, 2:43 p.m., Timothy Chen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
(_fetch in this case) in tests to
block, but Bernd wanted to introduce a specific empty method for tests. I
told him this is not a pattern we use in Mesos, but like to see what you
think.
Bernd Mathiske wrote:
Of course I will stick to the prevalent patterns unless you start liking
and the FetcherInfo::Item. If The
FetcherInfo encapsulates the FetcherInfo::Item I would also suggest
switching the order of the parameters to signify that.
Bernd Mathiske wrote:
The main purpose here is to fetch this one particular item, not
everything FetcherInfo carries. FetcherInfo
explicitly whether or not the
cache_filename was set!
Same for the cache_directory below as well.
Bernd Mathiske wrote:
What if somebody else uses mesos-fetcher?
Adding a comment why this is not a check.
- Bernd
---
On April 29, 2015, 1:42 p.m., Bernd Mathiske wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30774/
---
(Updated
.
Thanks,
Bernd Mathiske
for undoing things like space
reservations and eviction disabling.
- Eviction gets disabled for URIs that are currently in use, i.e. the related
cache files are. We use reference counting for this, since there may be
concurrent fetch attempts using the same cache files.
Thanks,
Bernd Mathiske
that we don't need this test any more?
- Bernd Mathiske
On May 8, 2015, 2:40 p.m., Timothy Chen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29889
343f95be7f316170b37c9358627f3c2090f0e29e
Diff: https://reviews.apache.org/r/30609/diff/
Testing
---
Wrote a simple test that creates a file and tests its size, and also checks if
a non-existing file yields an error.
Thanks,
Bernd Mathiske
://reviews.apache.org/r/30774/#review82017
---
On May 12, 2015, 3:43 p.m., Bernd Mathiske wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30774
counting for this, since there may be
concurrent fetch attempts using the same cache files.
Thanks,
Bernd Mathiske
.
- Bernd Mathiske
On May 13, 2015, 3:15 p.m., Michael Park wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/
---
(Updated
/33058/#comment134716
line 80 chars
- Bernd Mathiske
On April 10, 2015, 12:25 a.m., Till Toenshoff wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33058
/30774/#comment135003
AWAIT_READY, not AWAIT_READY_FOR, coz the default is 15 and that works
fine, too.
- Bernd Mathiske
On May 13, 2015, 3:07 p.m., Bernd Mathiske wrote:
---
This is an automatically generated e-mail. To reply, visit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30774/#review83946
---
- Bernd Mathiske
On May 13, 2015, 3:07 p.m., Bernd Mathiske wrote
cbd44b98d19953d174fac977f509d4900a37481f
Diff: https://reviews.apache.org/r/35247/diff/
Testing
---
make check
Thanks,
Bernd Mathiske
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35206/#review87045
---
Ship it!
Ship It!
- Bernd Mathiske
On June 8, 2015, 9:22 a.m
/fetcher_cache_tests.cpp cbd44b98d19953d174fac977f509d4900a37481f
Diff: https://reviews.apache.org/r/35247/diff/
Testing
---
make check
Thanks,
Bernd Mathiske
, as for example 'WIFEXITED(status)'.
- Bernd Mathiske
On June 3, 2015, 6:45 a.m., Benjamin Hindman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35000
(starting slave, starting master,
constructing scheduler but not starting it, setting some expectations) and
there is no documentation for it!
Bernd Mathiske wrote:
Long term I am working on developing up stress tests for the fetcher.
These are still relatively basic functionality
8bd5dd847fb189d0eeeaa760d3ec8ce3af1c2392
Diff: https://reviews.apache.org/r/35438/diff/
Testing
---
make check
Thanks,
Bernd Mathiske
check
Thanks,
Bernd Mathiske
/
---
(Updated April 16, 2015, 7:31 a.m.)
Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till
Toenshoff.
Bugs: MESOS-2625
https://issues.apache.org/jira/browse/MESOS-2625
Repository: mesos
Description
::REASON_COMMAND_EXECUTOR_FAILED
Which is: 0
```
Bernd Mathiske wrote:
For me, too. This fails as indicated above every time. This needs a bit
of work.
Maybe the code reporting the status has changed meanwhile. @adyatlov, please
investigate.
- Bernd
://reviews.apache.org/r/35510/#comment141574
Is this blank line necessary?
- Bernd Mathiske
On June 23, 2015, 5:53 a.m., Joerg Schad wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35510
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35553/#review88960
---
Ship it!
Ship It!
- Bernd Mathiske
On June 17, 2015, 2:22 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35510/#review88968
---
Ship it!
Ship It!
- Bernd Mathiske
On June 23, 2015, 6:30 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34835/#review89338
---
Ship it!
Ship It!
- Bernd Mathiske
On June 24, 2015, 2:14 p.m
://reviews.apache.org/r/35611/#comment141953
lambdas - closures ?
- Bernd Mathiske
On June 20, 2015, 8:19 a.m., Benjamin Hindman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35611
://reviews.apache.org/r/35917/diff/
Testing
---
Thanks,
Bernd Mathiske
/fetcher_cache_tests.cpp f29f31993f53c7f5a44267753aa6ea4574c80c82
Diff: https://reviews.apache.org/r/35917/diff/
Testing (updated)
---
make check. Observed that the test is no longer active.
Thanks,
Bernd Mathiske
either fix now, or leave a TODO and a tech debt ticket.
- Bernd Mathiske
On June 23, 2015, 12:18 p.m., Timothy Chen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35799
of this interation is merely to
get rid of most of the HTML.
- Bernd Mathiske
On June 24, 2015, 7:56 a.m., Joerg Schad wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35568
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34943/#review88386
---
Ship it!
Ship It!
- Bernd Mathiske
On June 18, 2015, 8:34 a.m
/tests/fetcher_cache_tests.cpp 8bd5dd847fb189d0eeeaa760d3ec8ce3af1c2392
Diff: https://reviews.apache.org/r/35438/diff/
Testing
---
make check
Thanks,
Bernd Mathiske
8bd5dd847fb189d0eeeaa760d3ec8ce3af1c2392
Diff: https://reviews.apache.org/r/35438/diff/
Testing
---
make check
Thanks,
Bernd Mathiske
) and
there is no documentation for it!
On June 9th, 2015, 8:07 p.m. UTC, Bernd Mathiske wrote:
Long term I am working on developing up stress tests for the fetcher. These
are still relatively basic functionality tests so far.
Yes, SetUp() and TearDown() do a lot here. Would you prefer
Thanks,
Bernd Mathiske
)
https://reviews.apache.org/r/34392/#comment140601
Please document what this function does, in particular that it does not
follow symlinks and under what conditions it returns an error.
- Bernd Mathiske
On June 15, 2015, 4:34 a.m., Alexander Rojas wrote
See above.
- Bernd Mathiske
On June 16, 2015, 7:08 p.m., Alexander Rojas wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30032
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35364/#review88045
---
Ship it!
Ship It!
- Bernd Mathiske
On June 11, 2015, 1:39 p.m
. Alternatively add a
blank line between 84 and 85.
- Bernd Mathiske
On June 15, 2015, 8:26 a.m., Alexander Rojas wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34703
/mesos.cpp 830d362c81e98092ae671d5d5f69bb865d33ba3a
Diff: https://reviews.apache.org/r/34892/diff/
Testing
---
Thanks,
Bernd Mathiske
On June 24, 2015, 3:13 a.m., Bernd Mathiske wrote:
src/tests/docker_tests.cpp, line 374
https://reviews.apache.org/r/35799/diff/1/?file=990751#file990751line374
Use Flags::docker_sandbox_directory (or a constant that the flag also
uses for its default value) instead. Not only
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35985/#review89726
---
Ship it!
Ship It!
- Bernd Mathiske
On June 28, 2015, 3:45 a.m
docs/committers.md ca8a6995c5272f3534ab63f95332565dfcaaf5b9
Diff: https://reviews.apache.org/r/36197/diff/
Testing
---
The rendered files can be viewed here:
https://gist.github.com/bernd-mesos/00de63ae13efec4331be
Thanks,
Bernd Mathiske
generated e-mail. To reply, visit:
https://reviews.apache.org/r/36197/#review90473
---
On July 6, 2015, 5:32 a.m., Bernd Mathiske wrote:
---
This is an automatically generated e
/36197/diff/
Testing
---
The rendered files can be viewed here:
https://gist.github.com/bernd-mesos/00de63ae13efec4331be
Thanks,
Bernd Mathiske
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36152/#review90319
---
Ship it!
Ship It!
- Bernd Mathiske
On July 2, 2015, 4:47 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34276/#review85165
---
Ship it!
Ship It!
- Bernd Mathiske
On May 21, 2015, 4:45 p.m
reservations and eviction disabling.
- Eviction gets disabled for URIs that are currently in use, i.e. the related
cache files are. We use reference counting for this, since there may be
concurrent fetch attempts using the same cache files.
Thanks,
Bernd Mathiske
://reviews.apache.org/r/34545/#comment136350
Examples: either use singular here or add a second example.
- Bernd Mathiske
On May 21, 2015, 7:58 a.m., Alexander Rukletsov wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
line of which it applies to.
irst pass
- Bernd Mathiske
On May 18, 2015, 9:20 p.m., Alexander Rojas wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30032
using the same cache files.
Thanks,
Bernd Mathiske
reservations and eviction disabling.
- Eviction gets disabled for URIs that are currently in use, i.e. the related
cache files are. We use reference counting for this, since there may be
concurrent fetch attempts using the same cache files.
Thanks,
Bernd Mathiske
://reviews.apache.org/r/30032/#comment136712
This function can fail. Error handling, please.
- Bernd Mathiske
On May 26, 2015, 7:41 a.m., Alexander Rojas wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34545/#review85190
---
Ship it!
Ship It!
- Bernd Mathiske
On May 26, 2015, 3:37 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36214/#review90663
---
Ship it!
Ship It!
- Bernd Mathiske
On July 6, 2015, 1:40 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36216/#review90662
---
Ship it!
Ship It!
- Bernd Mathiske
On July 6, 2015, 3:58 p.m
://reviews.apache.org/r/36049/#comment148335
See above.
src/master/main.cpp (line 305)
https://reviews.apache.org/r/36049/#comment148336
See above.
- Bernd Mathiske
On Aug. 3, 2015, 2:47 a.m., Alexander Rojas wrote
/36908/#comment148340
s/guaranteed/guarantees
include/mesos/master/quota.proto (line 38)
https://reviews.apache.org/r/36908/#comment148341
limit, bound - plural
- Bernd Mathiske
On July 29, 2015, 9:59 a.m., Joerg Schad wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36050/#review95251
---
Ship it!
Ship It!
- Bernd Mathiske
On Aug. 12, 2015, 6:52 a.m
that this is not the eventual intended shape of authz, but it is a
self-contained, consistent step in the right direction.)
include/mesos/authorizer/authorizer.hpp (line 61)
https://reviews.apache.org/r/36048/#comment150104
s/is/if
- Bernd Mathiske
On Aug. 13, 2015, 1:57 a.m., Alexander Rojas wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35920/#review89484
---
Ship it!
Ship It!
- Bernd Mathiske
On June 26, 2015, 4:27 a.m
:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/
---
(Updated Aug. 4, 2015, 2:52 a.m.)
Review request for mesos, Alexander Rukletsov and Bernd Mathiske.
Bugs: MESOS-3073
https
/#comment148548
Because of this concatenation we should explain at the function delcaration
in http.hpp that it is expected that `path` starts with /.
Or is it not?
- Bernd Mathiske
On Aug. 3, 2015, 11:45 a.m., Joerg Schad wrote
, this LGTM.
- Bernd Mathiske
On Aug. 4, 2015, 3:40 a.m., Joerg Schad wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913
/authorize inside src/master?
Bernd Mathiske wrote:
It's not intended to stay just for master. We are working on generalizing
how all this works for all kinds of endpoints in all kinds of Mesos
components:
https://docs.google.com/document/d/1kM3_f7DSqXcE2MuERrLTGp_XMC6ss2wmpkNYDCY5rOM
:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36048/
---
(Updated Aug. 3, 2015, 2:47 a.m.)
Review request for mesos, Adam B, Alexander Rukletsov, Bernd Mathiske
in the ticket). There are references to docs in this patch, but
updating docs will be in the last patch.
Diffs
-
include/mesos/mesos.proto a6748d1cd82238f005c6a49c70d22d095462f1ba
Diff: https://reviews.apache.org/r/37075/diff/
Testing
---
Thanks,
Bernd Mathiske
:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/
---
(Updated Aug. 3, 2015, 11:09 a.m.)
Review request for mesos, Alexander Rukletsov and Bernd Mathiske.
Bugs: MESOS-3073
https
/36913/#comment148540
See my previous review. This is correct syntax IMHO.
- Bernd Mathiske
On Aug. 4, 2015, 2:52 a.m., Joerg Schad wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
/r/36946/#comment148115
This change seems to eliminate the essence of the test, namely the leading
white space.
- Bernd Mathiske
On July 30, 2015, 9:37 a.m., Artem Harutyunyan wrote:
---
This is an automatically generated e-mail
-mesos/00de63ae13efec4331be
Thanks,
Bernd Mathiske
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36197/#review93265
---
On July 28, 2015, 1:11 a.m., Bernd Mathiske wrote:
---
This is an automatically
.)
Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Bernd
Mathiske, Ben Mahler, Dave Lester, Ian Downes, Joerg Schad, Joris Van
Remoortere, Michael Park, Till Toenshoff, and Vinod Kone.
Bugs: MESOS-2784
https://issues.apache.org/jira/browse/MESOS-2784
Repository
/
Testing
---
Thanks,
Bernd Mathiske
9dca331400bf9eb522295f9261cbb349be6b533b
Diff: https://reviews.apache.org/r/37123/diff/
Testing (updated)
---
Built the web site, patched the md file in question, ran `rake dev`, looked at
http://localhost:4567/documentation/latest/mesos-c++-style-guide/.
Thanks,
Bernd Mathiske
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37081/#review94213
---
Ship it!
Ship It!
- Bernd Mathiske
On Aug. 4, 2015, 9:21 p.m
://reviews.apache.org/r/37075/diff/
Testing
---
Thanks,
Bernd Mathiske
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37012/#review94228
---
Ship it!
Ship It!
- Bernd Mathiske
On Aug. 4, 2015, 10:43 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37011/#review94229
---
Ship it!
Ship It!
- Bernd Mathiske
On Aug. 5, 2015, 4:51 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36946/#review93878
---
Ship it!
Ship It!
- Bernd Mathiske
On July 31, 2015, 8:23 a.m
over superficially consistent naming across the API.
2c
- Bernd Mathiske
On July 29, 2015, 6:39 a.m., Joerg Schad wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36847
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36773/#review93889
---
Ship it!
Ship It!
- Bernd Mathiske
On Aug. 3, 2015, 1:43 a.m
as before. Less probability of mistakes (even though
I don't see any in the present code).
- Bernd Mathiske
On Aug. 3, 2015, 2:47 a.m., Alexander Rojas wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
spaces.
src/tests/fetcher_cache_tests.cpp (line 1474)
https://reviews.apache.org/r/36773/#comment147814
const Path
- Bernd Mathiske
On July 29, 2015, 5:59 a.m., Jan Schlicht wrote:
---
This is an automatically generated e-mail
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36889/#review93444
---
Ship it!
Ship It!
- Bernd Mathiske
On July 29, 2015, 6:11 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36847/#review95410
---
Ship it!
Ship It!
- Bernd Mathiske
On Aug. 13, 2015, 9:19 a.m
point about underscore, the problem here is that
wherever you put it, you end up violating a style rule and/or doing something
ugly - a real conumdrum!
Bernd Mathiske wrote:
There is NO consistent way to add the method and it MUST be added.
Therefore I prefer a way that is, halas
On Aug. 12, 2015, 6:04 a.m., Bernd Mathiske wrote:
include/mesos/authorizer/authorizer.hpp, line 49
https://reviews.apache.org/r/36048/diff/15/?file=1036353#file1036353line49
If this is only relevant for the default implementation, then this
method should be declared
. To reply, visit:
https://reviews.apache.org/r/36847/
---
(Updated Aug. 4, 2015, 3:57 a.m.)
Review request for mesos, Alexander Rukletsov and Bernd Mathiske.
Bugs: MESOS-3152
https://issues.apache.org/jira/browse/MESOS-3152
?
include/mesos/authorizer/authorizer.hpp (line 78)
https://reviews.apache.org/r/36048/#comment149897
How does mere repetition lead to success here?
include/mesos/authorizer/authorizer.hpp (line 84)
https://reviews.apache.org/r/36048/#comment149898
s/launch/run
- Bernd Mathiske
On Aug
.
- Bernd Mathiske
On Aug. 13, 2015, 1:20 p.m., James DeFelice wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37443/
---
(Updated
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36732/#review92888
---
Ship it!
Ship It!
- Bernd Mathiske
On July 23, 2015, 10:33 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36197/#review91232
---
On July 10, 2015, 2:14 a.m., Bernd Mathiske wrote
On July 20, 2015, 9:42 a.m., haosdent huang wrote:
haosdent huang wrote:
Its a bit difficult to follow the mesos style guide at first. Maybe the
committer could help you reformat it when summit @klausma1982 . :-)
Klaus Ma wrote:
Thanks very much for your patience; yes, it
://reviews.apache.org/r/36501/#comment147177
It would be slightly better to separate these declarations more obviously
by putting a new line here (between line 294 and 295).
If you don't get to them first, I will fix the remaining little style
suggestions when committing.
- Bernd Mathiske
On July 24
1 - 100 of 362 matches
Mail list logo
