Re: Review Request 32660: Report network isolator statistics on a per container basis (MESOS-2332)

2015-04-24 Thread Chi Zhang
/#comment132014 i am trying to see if we can flatten this to right inside this message and not use a new message type and a string id we can talk about this offline. - Chi Zhang On April 24, 2015, 7:42 p.m., Paul Brett wrote

Review Request 33644: MemoryTestHelper: Changed to do memset before mlock.

2015-04-28 Thread Chi Zhang
cdf769b32036c746ec4aa90841ea45c9a4159b51 Diff: https://reviews.apache.org/r/33644/diff/ Testing --- Thanks, Chi Zhang

Re: Review Request 33746: Improve logging of clone flags for linux_launcher.

2015-04-30 Thread Chi Zhang
/33746/#comment132932 add some comment for this function? - Chi Zhang On May 1, 2015, 5:27 a.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33746

Review Request 33990: Changed BalloonExecutor to do memset before mlock.

2015-05-08 Thread Chi Zhang
ad1d861aa6b5396f66e703326802926c7a99773c Diff: https://reviews.apache.org/r/33990/diff/ Testing --- Thanks, Chi Zhang

Re: Review Request 34142: AppC provisioner.

2015-05-18 Thread Chi Zhang
Is it possible to tweak the store{process}'s constructors to hide the implemention detail of there existing a StoreProcess? - Chi Zhang On May 13, 2015, 12:48 a.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 34140: Appc image store

2015-05-18 Thread Chi Zhang
://reviews.apache.org/r/34140/#comment135392 Looks like this is a global store for all images. Would it make sense to make sure at most one StoreProcess can be instantiated? - Chi Zhang On May 13, 2015, 12:48 a.m., Ian Downes wrote

Re: Review Request 34141: AppC provsioning backend.

2015-05-18 Thread Chi Zhang
/containerizer/provisioners/appc/backend.cpp https://reviews.apache.org/r/34141/#comment135399 put a nothing into the list before the for loop? - Chi Zhang On May 13, 2015, 12:48 a.m., Ian Downes wrote: --- This is an automatically

Re: Review Request 34139: AppC image discovery.

2015-05-18 Thread Chi Zhang
introduce all avaiable options to users here? Ditto to other flags introduced? - Chi Zhang On May 13, 2015, 12:47 a.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34139

Re: Review Request 34138: AppC hash computation.

2015-05-18 Thread Chi Zhang
to use devel packages for hashing in the future? - Chi Zhang On May 13, 2015, 12:47 a.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34138

Re: Review Request 34438: Removed unnecessary freeaddrinfo in hostname if getaddrinfo returns error.

2015-05-19 Thread Chi Zhang
/r/34438/#review84399 --- On May 19, 2015, 9:44 p.m., Chi Zhang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34438

Review Request 34438: Removed unnecessary freeaddrinfo in hostname if getaddrinfo returns error.

2015-05-19 Thread Chi Zhang
Diff: https://reviews.apache.org/r/34438/diff/ Testing --- Thanks, Chi Zhang

Re: Review Request 32757: [5/5] Added a memory statistics test for writeback.

2015-06-03 Thread Chi Zhang
11712d7f378d9426f160d53b0387c698a28a4207 src/tests/memory_test_helper.cpp 8093e66c45cacc4bf0295a3448c128a1aa7c751a Diff: https://reviews.apache.org/r/32757/diff/ Testing --- Thanks, Chi Zhang

Re: Review Request 32755: [3/5] Added a memory statistics test for memory-mapped file.

2015-06-03 Thread Chi Zhang
/memory_test_helper.hpp 11712d7f378d9426f160d53b0387c698a28a4207 src/tests/memory_test_helper.cpp 8093e66c45cacc4bf0295a3448c128a1aa7c751a Diff: https://reviews.apache.org/r/32755/diff/ Testing --- Thanks, Chi Zhang

Re: Review Request 32755: [3/5] Added a memory statistics test for memory-mapped file.

2015-06-03 Thread Chi Zhang
:15 p.m., Chi Zhang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32755/ --- (Updated April 1, 2015, 11:15 p.m.) Review

Re: Review Request 32754: [2/5] Added a memory statistics test for page cache.

2015-06-03 Thread Chi Zhang
/32754/diff/ Testing --- Thanks, Chi Zhang

Re: Review Request 31012: [1/5] Added memory statisics test fixure and a test for RSS.

2015-06-03 Thread Chi Zhang
: https://reviews.apache.org/r/31012/diff/ Testing --- Thanks, Chi Zhang

Re: Review Request 32757: [5/5] Added a memory statistics test for writeback.

2015-06-03 Thread Chi Zhang
is tmpfs? - Chi --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32757/#review79394 --- On June 3, 2015, 11:05 p.m., Chi Zhang wrote

Re: Review Request 32756: [4/5] Added a memory statistics test for active anonymous memory.

2015-06-03 Thread Chi Zhang
/memory_test_helper.hpp 11712d7f378d9426f160d53b0387c698a28a4207 src/tests/memory_test_helper.cpp 8093e66c45cacc4bf0295a3448c128a1aa7c751a Diff: https://reviews.apache.org/r/32756/diff/ Testing --- Thanks, Chi Zhang

Re: Review Request 32756: [4/5] Added a memory statistics test for active anonymous memory.

2015-06-03 Thread Chi Zhang
/#review79390 --- On June 3, 2015, 11:01 p.m., Chi Zhang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32756

Re: Review Request 31444: Support chrooting in MesosContainerizer launch helper.

2015-06-04 Thread Chi Zhang
/#comment138749 nit: Construct and Use LGTM - Chi Zhang On June 1, 2015, 9:50 p.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31444

Re: Review Request 35150: Add output stream operation for handle to use in port_mapping.cpp

2015-06-05 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35150/#review86845 --- Ship it! Ship It! - Chi Zhang On June 5, 2015, 8:30 p.m., Paul

Re: Review Request 35152: Document and consolidate qdisc handles

2015-06-05 Thread Chi Zhang
container's outbound traffic is given a separate flow, and also the catch-all flow for traffic originated from host and everything else, etc - Chi Zhang On June 5, 2015, 10:35 p.m., Paul Brett wrote: --- This is an automatically generated e

Re: Review Request 35744: Cleaned up the unknown orphans after all known orphans are recovered.

2015-06-22 Thread Chi Zhang
1881 - 1884) https://reviews.apache.org/r/35744/#comment141441 If we have 0 known orphans, 3 unknown orphans, we'd try to delete ICMP and ARP 3 times in the new loop? - Chi Zhang On June 22, 2015, 9:25 p.m., Jie Yu wrote

Re: Review Request 35744: Cleaned up the unknown orphans after all known orphans are recovered.

2015-06-22 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35744/#review88855 --- Ship it! Ship It! - Chi Zhang On June 22, 2015, 9:58 p.m., Jie

Re: Review Request 35749: Fixed a memory bug in port mapping recovery logic.

2015-06-22 Thread Chi Zhang
, there is 7 'delete info' in this file right now... :( - Chi Zhang On June 22, 2015, 11:29 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35749

Re: Review Request 35750: Added a test to verify recovering mixed known and unknown orphans for port mapping isolator.

2015-06-22 Thread Chi Zhang
implementation details IMO, but looks like this is not the first time we test based on this. - Chi Zhang On June 22, 2015, 11:09 p.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r

Re: Review Request 35738: Add slave metric to count container launch failures.

2015-06-22 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35738/#review88868 --- Ship it! Ship It! - Chi Zhang On June 22, 2015, 7:26 p.m., Paul

Re: Review Request 35749: Fixed a memory bug in port mapping recovery logic.

2015-06-22 Thread Chi Zhang
1905 - 1909) https://reviews.apache.org/r/35749/#comment141456 Do we need another for loop here to clean up unknownOrphans like you did above? - Chi Zhang On June 22, 2015, 11:08 p.m., Jie Yu wrote: --- This is an automatically

Re: Review Request 31915: MemIsolator: Improved some statistics naming. (MESOS-2104)

2015-06-11 Thread Chi Zhang
/containerizer/isolators/cgroups/mem.cpp 9647e79fd27ed08f1d86d13ea1e2ab98de3367c7 Diff: https://reviews.apache.org/r/31915/diff/ Testing --- Thanks, Chi Zhang

Re: Review Request 34830: Fix routing ingress/fq_codel search returning wrong qdisc.

2015-06-01 Thread Chi Zhang
On June 1, 2015, 5:59 p.m., Chi Zhang wrote: src/linux/routing/queueing/fq_codel.cpp, line 102 https://reviews.apache.org/r/34830/diff/2/?file=975051#file975051line102 ignore if you have done in a different patch: egress::ROOT? (You had ingress::ROOT) feel free to drop

Re: Review Request 34894: Add new message for Traffic Control statistics

2015-06-01 Thread Chi Zhang
/#comment137881 two? lines in between :) include/mesos/mesos.proto https://reviews.apache.org/r/34894/#comment137883 Maybe some comments for the three names? (kinda the reason you are not using 'repeated' of TrafficControlStatistics in ResourceStatistics?) - Chi Zhang On June 1, 2015, 4

Re: Review Request 34426: Report per-container metrics for network bandwidth throttling

2015-06-01 Thread Chi Zhang
://reviews.apache.org/r/34426/#comment137872 Return None to be consistent with the other APIs? (Try - Result) src/linux/routing/queueing/internal.hpp https://reviews.apache.org/r/34426/#comment137876 Here we can just return the result if it's not some. - Chi Zhang On May 31, 2015, 7:53

Re: Review Request 34830: Fix routing ingress/fq_codel search returning wrong qdisc.

2015-06-01 Thread Chi Zhang
this introdue consistency, use another patch to do it all? src/linux/routing/queueing/internal.hpp https://reviews.apache.org/r/34830/#comment137844 Fix the space before This - Chi Zhang On May 30, 2015, 9 p.m., Paul Brett wrote

Re: Review Request 34782: Convert Non-POD static variables in fq_codel and ingress to constexpr

2015-05-29 Thread Chi Zhang
for, if it is cleared in the codebase. - Chi Zhang On May 29, 2015, 4:37 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34782

Re: Review Request 31505: Add flow classifiers for fq_codel on egress

2015-06-01 Thread Chi Zhang
On June 2, 2015, 12:57 a.m., Chi Zhang wrote: Cong, is this the patch the requires code from 3.2.26 for the first time? If so, should we add a compile-time flag to config.ac? That way Paul can safely back off the code for the stat string conversion from the other patch you commented

Re: Review Request 31505: Add flow classifiers for fq_codel on egress

2015-06-01 Thread Chi Zhang
time? If so, should we add a compile-time flag to config.ac? That way Paul can safely back off the code for the stat string conversion from the other patch you commented on. - Chi Zhang On June 1, 2015, 10:45 p.m., Cong Wang wrote

Re: Review Request 36114: perf: added another extract function to support the new perf format after v3.12.

2015-07-03 Thread Chi Zhang
--- On July 2, 2015, 11:40 p.m., Chi Zhang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36114

Re: Review Request 36114: perf: added another extract function to support the new perf format after v3.12.

2015-07-02 Thread Chi Zhang
. - Chi --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36114/#review90180 --- On July 1, 2015, 10:44 p.m., Chi Zhang wrote

Re: Review Request 36115: perf: changed 'parse' interface to allow testing and added tests.

2015-07-02 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36115/#review90177 --- On July 2, 2015, 11:42 p.m., Chi Zhang wrote

Re: Review Request 36114: perf: added another extract function to support the new perf format after v3.12.

2015-07-02 Thread Chi Zhang
. - Chi --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36114/#review90170 --- On July 1, 2015, 10:44 p.m., Chi Zhang wrote

Re: Review Request 36114: perf: added another extract function to support the new perf format after v3.12.

2015-07-02 Thread Chi Zhang
697b75e846a43d4f106ad8f39a18882836d7dc02 Diff: https://reviews.apache.org/r/36114/diff/ Testing --- Thanks, Chi Zhang

Review Request 36151: stout: relaxed Version to allow default and copy constructors

2015-07-02 Thread Chi Zhang
://reviews.apache.org/r/36151/diff/ Testing --- Thanks, Chi Zhang

Re: Review Request 36115: perf: changed 'parse' interface to allow testing and added tests.

2015-07-02 Thread Chi Zhang
/linux/perf.cpp 697b75e846a43d4f106ad8f39a18882836d7dc02 src/tests/perf_tests.cpp 281eed0094faead67dc7f84df6407686aae88b01 Diff: https://reviews.apache.org/r/36115/diff/ Testing --- Thanks, Chi Zhang

Re: Review Request 36113: perf: refactored parse to allow determining an output parsing function based on the runtime version.

2015-07-02 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36113/#review90161 --- On July 2, 2015, 11:32 p.m., Chi Zhang wrote

Re: Review Request 36113: perf: refactored parse to allow determining an output parsing function based on the runtime version.

2015-07-02 Thread Chi Zhang
697b75e846a43d4f106ad8f39a18882836d7dc02 Diff: https://reviews.apache.org/r/36113/diff/ Testing --- Thanks, Chi Zhang

Re: Review Request 36115: perf: changed 'parse' interface to allow testing and added tests.

2015-07-02 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36115/#review90164 --- On July 2, 2015, 11:42 p.m., Chi Zhang wrote

Review Request 36114: perf: added another extract function to support the new perf format after v3.12.

2015-07-01 Thread Chi Zhang
/diff/ Testing --- Thanks, Chi Zhang

Review Request 36113: perf: refactored parse to allow determining an output parsing function based on the runtime version.

2015-07-01 Thread Chi Zhang
://reviews.apache.org/r/36113/diff/ Testing --- Thanks, Chi Zhang

Review Request 36115: perf: changed 'parse' interface to allow testing and added tests.

2015-07-01 Thread Chi Zhang
697b75e846a43d4f106ad8f39a18882836d7dc02 src/tests/perf_tests.cpp 281eed0094faead67dc7f84df6407686aae88b01 Diff: https://reviews.apache.org/r/36115/diff/ Testing --- Thanks, Chi Zhang

Review Request 36112: perf: extracted out a 'version' function.

2015-07-01 Thread Chi Zhang
-2834 https://issues.apache.org/jira/browse/MESOS-2834 Repository: mesos Description --- perf: extracted out a 'version' function. Diffs - src/linux/perf.cpp 697b75e846a43d4f106ad8f39a18882836d7dc02 Diff: https://reviews.apache.org/r/36112/diff/ Testing --- Thanks, Chi

Re: Review Request 34135: Add filesystem/ isolators for persistent volumes.

2015-05-26 Thread Chi Zhang
flags.sandbox_diretory is introduced in r/34137 - Chi Zhang On May 13, 2015, 12:47 a.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34135

Re: Review Request 31505: Add flow classifiers for fq_codel on egress

2015-05-26 Thread Chi Zhang
://reviews.apache.org/r/31505/#comment136803 this could also happen if we are recovering a container not using this feature right? - Chi Zhang On May 26, 2015, 8:41 p.m., Cong Wang wrote: --- This is an automatically generated e

Re: Review Request 34321: Merge class Handle which is duplicated between filter/handle and queueing/handle.

2015-05-26 Thread Chi Zhang
/r/34321/#comment136816 maybe change both to use the ingress:: namespace? - Chi Zhang On May 26, 2015, 9:59 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34321

Re: Review Request 34432: Remove duplicate constant string references to mesos-containerizer

2015-05-26 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34432/#review85295 --- Ship it! Modulo Vinod's comment - Chi Zhang On May 22, 2015, 5

Re: Review Request 34431: Add htb queueing discipline

2015-05-26 Thread Chi Zhang
should probably be abstracted a bit instead of being used everywhere. - Chi Zhang On May 22, 2015, 5:10 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34431

Re: Review Request 36930: Forced the network isolator to use the mount namespace.

2015-07-30 Thread Chi Zhang
mount namespace itself, i.e., the make-share outside and the make-slave inside on /var/run/netns are noops when it's disabled, but doing so avoids the race in MESOS-1558 when it is enabled, in case when it is required by other components of mesos? - Chi Zhang On July 30, 2015, 12:19 a.m., Jie

Re: Review Request 37106: PortMappingIsolatorProcess shell script can silently fail.

2015-08-05 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37106/#review94260 --- Ship it! Ship It! - Chi Zhang On Aug. 5, 2015, 12:58 a.m., Paul

Re: Review Request 39193: Fixed leakage of fts_open.

2015-10-12 Thread Chi Zhang
) --- make check Thanks, Chi Zhang

Re: Review Request 39192: Fixed leakage of fts_open.

2015-10-12 Thread Chi Zhang
://reviews.apache.org/r/39192/diff/ Testing (updated) --- make check Thanks, Chi Zhang

Review Request 39192: Fixed leakage of fts_open.

2015-10-09 Thread Chi Zhang
, Chi Zhang

Review Request 39193: Fixed leakage of fts_open.

2015-10-09 Thread Chi Zhang
://issues.apache.org/jira/browse/mesos-3519 Repository: mesos Description --- Fixed leakage of fts_open. Diffs - src/linux/cgroups.cpp 53c568bd9559bbe46adb90265445f466245a0722 Diff: https://reviews.apache.org/r/39193/diff/ Testing --- Thanks, Chi Zhang

Review Request 39186: added a FileDescriptor to manage the life cycle of fds.

2015-10-09 Thread Chi Zhang
PRE-CREATION Diff: https://reviews.apache.org/r/39186/diff/ Testing --- Thanks, Chi Zhang

Review Request 39187: added FileDescriptor tests in libprocess Makefile.

2015-10-09 Thread Chi Zhang
--- Thanks, Chi Zhang

Re: Review Request 36380: Test cases for performance monitor support of multiple output versions depending on kernel version.

2015-07-09 Thread Chi Zhang
/36380/#comment144560 un-used. src/tests/perf_tests.cpp (line 76) https://reviews.apache.org/r/36380/#comment144559 looks like this is 'covered' by the new declartion in the for loop. here and everywhere. - Chi Zhang On July 9, 2015, 11:11 p.m., Paul Brett wrote

Re: Review Request 36378: Refactor Linux Performance monitor to handle changing 'perf stat' output versions depending on kernel version.

2015-07-09 Thread Chi Zhang
/#comment144558 I think using a hashmap as an intermediate type is more flexisible. Right now, the operation after 'extract' is the same for all versions, but we can make it version-dependent too in the future to support e.g. unit, running time, etc. - Chi Zhang On July 9, 2015, 11:08 p.m

Re: Review Request 38233: os: add swap information to memory().

2015-11-18 Thread Chi Zhang
eviews.apache.org/r/38233/#review106917 ------- On Sept. 10, 2015, 5:57 p.m., Chi Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38233/ > -

Re: Review Request 37929: Changed provisioner Store API and implementation so it works as a read-through cache.

2015-08-31 Thread Chi Zhang
e more explicit on what kind of ordering we provie. BFS, first order traversal or sth else? - Chi Zhang On Aug. 31, 2015, 5:45 p.m., Jiang Yan Xu wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 37929: Changed provisioner Store API and implementation so it works as a read-through cache.

2015-08-31 Thread Chi Zhang
) <https://reviews.apache.org/r/37929/#comment152994> I guess I wasn't clear if C, B, D, A and C, D, B, A are both acceptable in your example, afte reading the comment? - Chi Zhang On Aug. 31, 2015, 5:45 p.m., Jiang Yan Xu

Re: Review Request 37929: Changed provisioner Store API and implementation so it works as a read-through cache.

2015-08-31 Thread Chi Zhang
> On Aug. 31, 2015, 9:42 p.m., Chi Zhang wrote: > > src/slave/containerizer/provisioners/appc/store.hpp, lines 76-81 > > <https://reviews.apache.org/r/37929/diff/1/?file=1059937#file1059937line76> > > > > Maybe not yet the guarantee on ordering since

Re: Review Request 37880: Changed the Appc provisioner directory to identify a rootfs by a rootfs_id (UUID).

2015-09-03 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37880/#review97701 --- Ship it! Ship It! - Chi Zhang On Aug. 31, 2015, 5:44 p.m

Re: Review Request 37929: Changed provisioner Store API and implementation so it works as a read-through cache.

2015-09-03 Thread Chi Zhang
> On Aug. 31, 2015, 9:42 p.m., Chi Zhang wrote: > > src/slave/containerizer/provisioners/appc/store.hpp, lines 76-81 > > <https://reviews.apache.org/r/37929/diff/1/?file=1059937#file1059937line76> > > > > Maybe not yet the guarantee on ordering since

Re: Review Request 38233: os: add swap information to memory().

2015-09-10 Thread Chi Zhang
/3rdparty/stout/include/stout/posix/os.hpp 5d2f39d9a9d963225bf463572cb8fe99dd9aa6f5 Diff: https://reviews.apache.org/r/38233/diff/ Testing --- Thanks, Chi Zhang

Re: Review Request 38284: Layers from Appc store should be the rootfs dir, not the top level dir.

2015-09-10 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38284/#review98525 --- Ship it! Ship It! - Chi Zhang On Sept. 11, 2015, 1:12 a.m., Jie

Review Request 38809: socket: refactor to use Option and fix file descriptor leaks.

2015-09-28 Thread Chi Zhang
5879423bd92c5805353a962cbd822a993b0568c5 Diff: https://reviews.apache.org/r/38809/diff/ Testing --- Thanks, Chi Zhang

Review Request 38810: poll_socket: fix a file descriptor leak under error condition.

2015-09-28 Thread Chi Zhang
--- Thanks, Chi Zhang

Re: Review Request 38823: io: fixed a file descriptor leak in io::redirect.

2015-09-28 Thread Chi Zhang
/ Testing --- Thanks, Chi Zhang

Re: Review Request 38823: io: fixed a file descriptor leak in io::redirect.

2015-09-28 Thread Chi Zhang
/ Testing (updated) --- make check Thanks, Chi Zhang

Re: Review Request 38774: state: fix file descriptor leak

2015-09-28 Thread Chi Zhang
--- make check Thanks, Chi Zhang

Re: Review Request 38809: socket: refactor to use Option and fix file descriptor leaks.

2015-09-28 Thread Chi Zhang
3rdparty/libprocess/src/socket.cpp 5879423bd92c5805353a962cbd822a993b0568c5 Diff: https://reviews.apache.org/r/38809/diff/ Testing (updated) --- make check Thanks, Chi Zhang

Re: Review Request 38809: socket: refactor to use Option and fix file descriptor leaks.

2015-09-28 Thread Chi Zhang
.apache.org/r/38809/#review100831 --- On Sept. 28, 2015, 9:07 p.m., Chi Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, v

Review Request 38823: io: fixed a file descriptor leak in io::redirect.

2015-09-28 Thread Chi Zhang
a file descriptor leak in io::redirect. Diffs - 3rdparty/libprocess/src/io.cpp d17ccf7713debc43f5c2ca1aeb9a1ca7ed03b4a6 Diff: https://reviews.apache.org/r/38823/diff/ Testing --- Thanks, Chi Zhang

Re: Review Request 38809: socket: refactor to use Option and fix file descriptor leaks.

2015-09-29 Thread Chi Zhang
.apache.org/r/38809/#review101028 --- On Sept. 29, 2015, 8:30 p.m., Chi Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, v

Re: Review Request 38809: socket: refactor to use Option and fix file descriptor leaks.

2015-09-29 Thread Chi Zhang
5879423 Diff: https://reviews.apache.org/r/38809/diff/ Testing --- make check Thanks, Chi Zhang

Review Request 38828: docker: containerizer: fixed double-closing of STDIN in error handling.

2015-09-28 Thread Chi Zhang
efa37266368ee12fea9134b35ebc5047a2820f94 Diff: https://reviews.apache.org/r/38828/diff/ Testing --- make check Thanks, Chi Zhang

Re: Review Request 38809: socket: refactor to use Option and fix file descriptor leaks.

2015-09-29 Thread Chi Zhang
ould > > consider doing the same thing that is done in os/posix/open.hpp with > > O_CLOEXEC: > > > > > > https://github.com/apache/mesos/blob/5aa050bfaa7338b010b1a522406bde0f15015259/3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/open.hpp#L33 &

Re: Review Request 38809: socket: refactor to use Option and fix file descriptor leaks.

2015-09-29 Thread Chi Zhang
5879423 Diff: https://reviews.apache.org/r/38809/diff/ Testing --- make check Thanks, Chi Zhang

Re: Review Request 38809: socket: refactor to use Option and fix file descriptor leaks.

2015-09-29 Thread Chi Zhang
dding one above it right? - Chi --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38809/#review100999 --- On Sept. 29,

Re: Review Request 38828: docker: containerizer: fixed double-closing of STDIN in error handling.

2015-09-28 Thread Chi Zhang
the failure, but I will pull Tim in. - Chi --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38828/#review100908 ------- O

Re: Review Request 38828: docker: containerizer: fixed double-closing of STDIN in error handling.

2015-09-28 Thread Chi Zhang
haps a > > killtree with SIGTERM would be more appropriate to replace these with.. > > thoughts? Perhaps reach out to tim chen for this code. > > Chi Zhang wrote: > Yeah, I checked the mesos containerizer code, which in case just returns > a failure and waits for the

Review Request 38234: Check if swap is enabled before running memory pressure related tests.

2015-09-09 Thread Chi Zhang
/ Testing --- Thanks, Chi Zhang

Review Request 38233: os: add swap information to memory().

2015-09-09 Thread Chi Zhang
5d2f39d9a9d963225bf463572cb8fe99dd9aa6f5 Diff: https://reviews.apache.org/r/38233/diff/ Testing --- Thanks, Chi Zhang

Review Request 38743: files: fix potential fd leaks under error conditions.

2015-09-24 Thread Chi Zhang
potential fd leaks under error conditions. Diffs - src/files/files.cpp 1d4b1e6d2fcd99321084515f538aa357f8d9b305 Diff: https://reviews.apache.org/r/38743/diff/ Testing --- make check Thanks, Chi Zhang

Re: Review Request 38774: state: fix file descriptor leak

2015-09-25 Thread Chi Zhang
Thanks, Chi Zhang

Re: Review Request 38743: files: fix potential fd leaks under error conditions.

2015-09-25 Thread Chi Zhang
--- make check Thanks, Chi Zhang

Re: Review Request 38770: routing: fixed a file descriptor leak.

2015-09-25 Thread Chi Zhang
/38770/diff/ Testing --- make check Thanks, Chi Zhang

Review Request 38774: state: fix file descriptor leak

2015-09-25 Thread Chi Zhang
/browse/mesos-3519 Repository: mesos Description --- state: fix file descriptor leak Diffs - src/slave/state.cpp 47c66dc80d57db86981769d404c2c8c7c972fec0 Diff: https://reviews.apache.org/r/38774/diff/ Testing --- Thanks, Chi Zhang

Re: Review Request 38770: routing: fixed a file descriptor leak.

2015-09-25 Thread Chi Zhang
Yu, and Cong Wang. Repository: mesos Description --- routing: fixed a file descriptor leak. Diffs - src/linux/routing/link/link.cpp 552e2d76a6f7d2ffc366a65957d0ac849b504b2e Diff: https://reviews.apache.org/r/38770/diff/ Testing (updated) --- make check Thanks, Chi Zhang

Review Request 38770: routing: fixed a file descriptor leak.

2015-09-25 Thread Chi Zhang
Description --- routing: fixed a file descriptor leak. Diffs - src/linux/routing/link/link.cpp 552e2d76a6f7d2ffc366a65957d0ac849b504b2e Diff: https://reviews.apache.org/r/38770/diff/ Testing --- Thanks, Chi Zhang

Review Request 38780: io: fixed a file descriptor leak in peek()

2015-09-25 Thread Chi Zhang
/browse/mesos-3519 Repository: mesos Description --- io: fixed a file descriptor leak in peek() Diffs - 3rdparty/libprocess/src/io.cpp 88c37ba4d9ada073e9ff3ee18be89f4c7ab0b26d Diff: https://reviews.apache.org/r/38780/diff/ Testing --- Thanks, Chi Zhang

Review Request 38701: Use os::close everywhere.

2015-09-23 Thread Chi Zhang
://issues.apache.org/jira/browse/mesos-2768 Repository: mesos Description --- Use os::close everywhere. Diffs - src/slave/containerizer/linux_launcher.cpp 459af1b98ba577863d88d521f3ba8792959f42b4 Diff: https://reviews.apache.org/r/38701/diff/ Testing --- Thanks, Chi Zhang

  1   2   >