cdf769b32036c746ec4aa90841ea45c9a4159b51
Diff: https://reviews.apache.org/r/33644/diff/
Testing
---
Thanks,
Chi Zhang
/33746/#comment132932
add some comment for this function?
- Chi Zhang
On May 1, 2015, 5:27 a.m., Ian Downes wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33746
Is it possible to tweak the store{process}'s constructors to hide the
implemention detail of there existing a StoreProcess?
- Chi Zhang
On May 13, 2015, 12:48 a.m., Ian Downes wrote:
---
This is an automatically generated e-mail. To reply
://reviews.apache.org/r/34140/#comment135392
Looks like this is a global store for all images. Would it make sense to
make sure at most one StoreProcess can be instantiated?
- Chi Zhang
On May 13, 2015, 12:48 a.m., Ian Downes wrote
/containerizer/provisioners/appc/backend.cpp
https://reviews.apache.org/r/34141/#comment135399
put a nothing into the list before the for loop?
- Chi Zhang
On May 13, 2015, 12:48 a.m., Ian Downes wrote:
---
This is an automatically
introduce all avaiable options to users here? Ditto to other flags
introduced?
- Chi Zhang
On May 13, 2015, 12:47 a.m., Ian Downes wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34139
to use devel packages for hashing in the future?
- Chi Zhang
On May 13, 2015, 12:47 a.m., Ian Downes wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34138
Diff: https://reviews.apache.org/r/34438/diff/
Testing
---
Thanks,
Chi Zhang
11712d7f378d9426f160d53b0387c698a28a4207
src/tests/memory_test_helper.cpp 8093e66c45cacc4bf0295a3448c128a1aa7c751a
Diff: https://reviews.apache.org/r/32757/diff/
Testing
---
Thanks,
Chi Zhang
/memory_test_helper.hpp 11712d7f378d9426f160d53b0387c698a28a4207
src/tests/memory_test_helper.cpp 8093e66c45cacc4bf0295a3448c128a1aa7c751a
Diff: https://reviews.apache.org/r/32755/diff/
Testing
---
Thanks,
Chi Zhang
:15 p.m., Chi Zhang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32755/
---
(Updated April 1, 2015, 11:15 p.m.)
Review
/32754/diff/
Testing
---
Thanks,
Chi Zhang
is tmpfs?
- Chi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32757/#review79394
---
On June 3, 2015, 11:05 p.m., Chi Zhang wrote
/#review79390
---
On June 3, 2015, 11:01 p.m., Chi Zhang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32756
/#comment138749
nit: Construct and Use
LGTM
- Chi Zhang
On June 1, 2015, 9:50 p.m., Ian Downes wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31444
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35150/#review86845
---
Ship it!
Ship It!
- Chi Zhang
On June 5, 2015, 8:30 p.m., Paul
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35744/#review88855
---
Ship it!
Ship It!
- Chi Zhang
On June 22, 2015, 9:58 p.m., Jie
, there is 7 'delete info'
in this file right now... :(
- Chi Zhang
On June 22, 2015, 11:29 p.m., Jie Yu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35749
implementation details IMO, but
looks like this is not the first time we test based on this.
- Chi Zhang
On June 22, 2015, 11:09 p.m., Jie Yu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35738/#review88868
---
Ship it!
Ship It!
- Chi Zhang
On June 22, 2015, 7:26 p.m., Paul
1905 - 1909)
https://reviews.apache.org/r/35749/#comment141456
Do we need another for loop here to clean up unknownOrphans like you did
above?
- Chi Zhang
On June 22, 2015, 11:08 p.m., Jie Yu wrote:
---
This is an automatically
/containerizer/isolators/cgroups/mem.cpp
9647e79fd27ed08f1d86d13ea1e2ab98de3367c7
Diff: https://reviews.apache.org/r/31915/diff/
Testing
---
Thanks,
Chi Zhang
On June 1, 2015, 5:59 p.m., Chi Zhang wrote:
src/linux/routing/queueing/fq_codel.cpp, line 102
https://reviews.apache.org/r/34830/diff/2/?file=975051#file975051line102
ignore if you have done in a different patch:
egress::ROOT? (You had ingress::ROOT)
feel free to drop
/#comment137881
two? lines in between :)
include/mesos/mesos.proto
https://reviews.apache.org/r/34894/#comment137883
Maybe some comments for the three names? (kinda the reason you are not
using 'repeated' of TrafficControlStatistics in ResourceStatistics?)
- Chi Zhang
On June 1, 2015, 4
this introdue consistency, use another patch to do it all?
src/linux/routing/queueing/internal.hpp
https://reviews.apache.org/r/34830/#comment137844
Fix the space before This
- Chi Zhang
On May 30, 2015, 9 p.m., Paul Brett wrote
for, if it is cleared in the
codebase.
- Chi Zhang
On May 29, 2015, 4:37 p.m., Paul Brett wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34782
time? If
so, should we add a compile-time flag to config.ac? That way Paul can safely
back off the code for the stat string conversion from the other patch you
commented on.
- Chi Zhang
On June 1, 2015, 10:45 p.m., Cong Wang wrote
---
On July 2, 2015, 11:40 p.m., Chi Zhang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36114
.
- Chi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36114/#review90180
---
On July 1, 2015, 10:44 p.m., Chi Zhang wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36115/#review90177
---
On July 2, 2015, 11:42 p.m., Chi Zhang wrote
697b75e846a43d4f106ad8f39a18882836d7dc02
Diff: https://reviews.apache.org/r/36114/diff/
Testing
---
Thanks,
Chi Zhang
://reviews.apache.org/r/36151/diff/
Testing
---
Thanks,
Chi Zhang
/linux/perf.cpp 697b75e846a43d4f106ad8f39a18882836d7dc02
src/tests/perf_tests.cpp 281eed0094faead67dc7f84df6407686aae88b01
Diff: https://reviews.apache.org/r/36115/diff/
Testing
---
Thanks,
Chi Zhang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36113/#review90161
---
On July 2, 2015, 11:32 p.m., Chi Zhang wrote
697b75e846a43d4f106ad8f39a18882836d7dc02
Diff: https://reviews.apache.org/r/36113/diff/
Testing
---
Thanks,
Chi Zhang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36115/#review90164
---
On July 2, 2015, 11:42 p.m., Chi Zhang wrote
/diff/
Testing
---
Thanks,
Chi Zhang
://reviews.apache.org/r/36113/diff/
Testing
---
Thanks,
Chi Zhang
697b75e846a43d4f106ad8f39a18882836d7dc02
src/tests/perf_tests.cpp 281eed0094faead67dc7f84df6407686aae88b01
Diff: https://reviews.apache.org/r/36115/diff/
Testing
---
Thanks,
Chi Zhang
-2834
https://issues.apache.org/jira/browse/MESOS-2834
Repository: mesos
Description
---
perf: extracted out a 'version' function.
Diffs
-
src/linux/perf.cpp 697b75e846a43d4f106ad8f39a18882836d7dc02
Diff: https://reviews.apache.org/r/36112/diff/
Testing
---
Thanks,
Chi
flags.sandbox_diretory is introduced in r/34137
- Chi Zhang
On May 13, 2015, 12:47 a.m., Ian Downes wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34135
://reviews.apache.org/r/31505/#comment136803
this could also happen if we are recovering a container not using this
feature right?
- Chi Zhang
On May 26, 2015, 8:41 p.m., Cong Wang wrote:
---
This is an automatically generated e
/r/34321/#comment136816
maybe change both to use the ingress:: namespace?
- Chi Zhang
On May 26, 2015, 9:59 p.m., Paul Brett wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34321
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34432/#review85295
---
Ship it!
Modulo Vinod's comment
- Chi Zhang
On May 22, 2015, 5
mount namespace itself,
i.e., the make-share outside and the make-slave inside on /var/run/netns are
noops when it's disabled, but doing so avoids the race in MESOS-1558 when it is
enabled, in case when it is required by other components of mesos?
- Chi Zhang
On July 30, 2015, 12:19 a.m., Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37106/#review94260
---
Ship it!
Ship It!
- Chi Zhang
On Aug. 5, 2015, 12:58 a.m., Paul
)
---
make check
Thanks,
Chi Zhang
://reviews.apache.org/r/39192/diff/
Testing (updated)
---
make check
Thanks,
Chi Zhang
,
Chi Zhang
://issues.apache.org/jira/browse/mesos-3519
Repository: mesos
Description
---
Fixed leakage of fts_open.
Diffs
-
src/linux/cgroups.cpp 53c568bd9559bbe46adb90265445f466245a0722
Diff: https://reviews.apache.org/r/39193/diff/
Testing
---
Thanks,
Chi Zhang
PRE-CREATION
Diff: https://reviews.apache.org/r/39186/diff/
Testing
---
Thanks,
Chi Zhang
---
Thanks,
Chi Zhang
/36380/#comment144560
un-used.
src/tests/perf_tests.cpp (line 76)
https://reviews.apache.org/r/36380/#comment144559
looks like this is 'covered' by the new declartion in the for loop.
here and everywhere.
- Chi Zhang
On July 9, 2015, 11:11 p.m., Paul Brett wrote
eviews.apache.org/r/38233/#review106917
-------
On Sept. 10, 2015, 5:57 p.m., Chi Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38233/
> -
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37880/#review97701
---
Ship it!
Ship It!
- Chi Zhang
On Aug. 31, 2015, 5:44 p.m
> On Aug. 31, 2015, 9:42 p.m., Chi Zhang wrote:
> > src/slave/containerizer/provisioners/appc/store.hpp, lines 76-81
> > <https://reviews.apache.org/r/37929/diff/1/?file=1059937#file1059937line76>
> >
> > Maybe not yet the guarantee on ordering since
/3rdparty/stout/include/stout/posix/os.hpp
5d2f39d9a9d963225bf463572cb8fe99dd9aa6f5
Diff: https://reviews.apache.org/r/38233/diff/
Testing
---
Thanks,
Chi Zhang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38284/#review98525
---
Ship it!
Ship It!
- Chi Zhang
On Sept. 11, 2015, 1:12 a.m., Jie
5879423bd92c5805353a962cbd822a993b0568c5
Diff: https://reviews.apache.org/r/38809/diff/
Testing
---
Thanks,
Chi Zhang
---
Thanks,
Chi Zhang
/
Testing
---
Thanks,
Chi Zhang
/
Testing (updated)
---
make check
Thanks,
Chi Zhang
---
make check
Thanks,
Chi Zhang
3rdparty/libprocess/src/socket.cpp 5879423bd92c5805353a962cbd822a993b0568c5
Diff: https://reviews.apache.org/r/38809/diff/
Testing (updated)
---
make check
Thanks,
Chi Zhang
a file descriptor leak in io::redirect.
Diffs
-
3rdparty/libprocess/src/io.cpp d17ccf7713debc43f5c2ca1aeb9a1ca7ed03b4a6
Diff: https://reviews.apache.org/r/38823/diff/
Testing
---
Thanks,
Chi Zhang
.apache.org/r/38809/#review101028
---
On Sept. 29, 2015, 8:30 p.m., Chi Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, v
5879423
Diff: https://reviews.apache.org/r/38809/diff/
Testing
---
make check
Thanks,
Chi Zhang
efa37266368ee12fea9134b35ebc5047a2820f94
Diff: https://reviews.apache.org/r/38828/diff/
Testing
---
make check
Thanks,
Chi Zhang
ould
> > consider doing the same thing that is done in os/posix/open.hpp with
> > O_CLOEXEC:
> >
> >
> > https://github.com/apache/mesos/blob/5aa050bfaa7338b010b1a522406bde0f15015259/3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/open.hpp#L33
&
5879423
Diff: https://reviews.apache.org/r/38809/diff/
Testing
---
make check
Thanks,
Chi Zhang
dding one above it right?
- Chi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38809/#review100999
---
On Sept. 29,
the failure, but
I will pull Tim in.
- Chi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38828/#review100908
-------
O
haps a
> > killtree with SIGTERM would be more appropriate to replace these with..
> > thoughts? Perhaps reach out to tim chen for this code.
>
> Chi Zhang wrote:
> Yeah, I checked the mesos containerizer code, which in case just returns
> a failure and waits for the
/
Testing
---
Thanks,
Chi Zhang
potential fd leaks under error conditions.
Diffs
-
src/files/files.cpp 1d4b1e6d2fcd99321084515f538aa357f8d9b305
Diff: https://reviews.apache.org/r/38743/diff/
Testing
---
make check
Thanks,
Chi Zhang
Thanks,
Chi Zhang
---
make check
Thanks,
Chi Zhang
/38770/diff/
Testing
---
make check
Thanks,
Chi Zhang
/browse/mesos-3519
Repository: mesos
Description
---
state: fix file descriptor leak
Diffs
-
src/slave/state.cpp 47c66dc80d57db86981769d404c2c8c7c972fec0
Diff: https://reviews.apache.org/r/38774/diff/
Testing
---
Thanks,
Chi Zhang
Yu, and Cong Wang.
Repository: mesos
Description
---
routing: fixed a file descriptor leak.
Diffs
-
src/linux/routing/link/link.cpp 552e2d76a6f7d2ffc366a65957d0ac849b504b2e
Diff: https://reviews.apache.org/r/38770/diff/
Testing (updated)
---
make check
Thanks,
Chi Zhang
Description
---
routing: fixed a file descriptor leak.
Diffs
-
src/linux/routing/link/link.cpp 552e2d76a6f7d2ffc366a65957d0ac849b504b2e
Diff: https://reviews.apache.org/r/38770/diff/
Testing
---
Thanks,
Chi Zhang
/browse/mesos-3519
Repository: mesos
Description
---
io: fixed a file descriptor leak in peek()
Diffs
-
3rdparty/libprocess/src/io.cpp 88c37ba4d9ada073e9ff3ee18be89f4c7ab0b26d
Diff: https://reviews.apache.org/r/38780/diff/
Testing
---
Thanks,
Chi Zhang
://issues.apache.org/jira/browse/mesos-2768
Repository: mesos
Description
---
Use os::close everywhere.
Diffs
-
src/slave/containerizer/linux_launcher.cpp
459af1b98ba577863d88d521f3ba8792959f42b4
Diff: https://reviews.apache.org/r/38701/diff/
Testing
---
Thanks,
Chi Zhang
---
Thanks,
Chi Zhang
://issues.apache.org/jira/browse/mesos-2768
Repository: mesos
Description
---
libprocess: use os::close everywhere.
Diffs
-
3rdparty/libprocess/src/subprocess.cpp
d6ea62ed1c914d34e0e189395831c86fff8aac22
Diff: https://reviews.apache.org/r/38700/diff/
Testing
---
Thanks,
Chi Zhang
t; 32), the extra 16MB will
be eaten by swap and not cause a OOM if swap is enabled.
- Chi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38234/#review106919
-----
86 matches
Mail list logo
