Review Request 34361: converted hard-coded strings to consts

2015-05-18 Thread Colin Williams
ba3858fb3026f2cc7af0523bd1a0c541eeafc34b src/tests/slave_tests.cpp acae49731ff17103b529cdf828a63d9d55668549 Diff: https://reviews.apache.org/r/34361/diff/ Testing --- Thanks, Colin Williams

Re: Review Request 34361: converted hard-coded strings to consts

2015-05-18 Thread Colin Williams
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34361/#review84172 --- On May 18, 2015, 5:01 p.m., Colin Williams wrote

Re: Review Request 34361: converted hard-coded strings to consts

2015-05-20 Thread Colin Williams
commute tomorrow. - Colin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34361/#review84498 --- On May 18, 2015, 5:01 p.m., Colin Williams

Re: Review Request 34361: converted hard-coded strings to consts

2015-05-21 Thread Colin Williams
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34361/#review84498 --- On May 18, 2015, 5:01 p.m., Colin Williams wrote

Re: Review Request 34361: converted hard-coded strings to consts

2015-06-09 Thread Colin Williams
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34361/#review87248 --- On June 8, 2015, 7:05 p.m., Colin Williams wrote

Re: Review Request 34361: converted hard-coded strings to consts

2015-06-09 Thread Colin Williams
of inlining the string constants, can we add them to an appropiate header as 'const char[]'? @Vinod: Would it make sense to add this to src/tests/mesos.hpp and src/tests/mesos.cpp, as the label tests are in module, master and slave tests? Colin Williams wrote: It made sense to me

Re: Review Request 34361: converted hard-coded strings to consts

2015-06-15 Thread Colin Williams
these tests. Very straightforward to read. Colin Williams wrote: I think the issue with the changes remaining is that the test depends on the same value occurring in several places. By consolidating to a variable it's no longer possible for these values to get out of sync. Niklas

Re: Review Request 34361: converted hard-coded strings to consts

2015-05-25 Thread Colin Williams
://reviews.apache.org/r/34361/diff/ Testing --- Thanks, Colin Williams

Re: Review Request 34361: converted hard-coded strings to consts

2015-05-23 Thread Colin Williams
) - src/examples/test_hook_module.cpp d61cd55 src/tests/hook_tests.cpp 3ffde6d src/tests/master_tests.cpp ba3858f src/tests/slave_tests.cpp acae497 Diff: https://reviews.apache.org/r/34361/diff/ Testing --- Thanks, Colin Williams

Re: Review Request 34361: converted hard-coded strings to consts

2015-05-21 Thread Colin Williams
itself or at least as static attributes of the TestHook class? Colin Williams wrote: There's a mitigating circumstance for these declarations, there's a comment a few lines up from the change instructing that these should be kept in sync with the values in src/tests/hook_tests.cpp

Re: Review Request 34361: converted hard-coded strings to consts

2015-07-16 Thread Colin Williams
these tests. Very straightforward to read. Colin Williams wrote: I think the issue with the changes remaining is that the test depends on the same value occurring in several places. By consolidating to a variable it's no longer possible for these values to get out of sync. Niklas