Re: Review Request 40114: Windows: Began adding Windows support to `process/future.hpp`

2015-12-01 Thread Daniel Pravat
arty/libprocess/include/process/windows/future.hpp PRE-CREATION Diff: https://reviews.apache.org/r/40114/diff/ Testing --- OSX make check, Windows 10 make, Ubuntu 15.1 make check Thanks, Daniel Pravat

Re: Review Request 40115: Windows: Added support for `slave/gc.cpp'.

2015-12-01 Thread Daniel Pravat
://reviews.apache.org/r/40115/diff/ Testing --- Windows 10: make.bat OSX: make check Ubuntu: 15.1 make check Thanks, Daniel Pravat

Re: Review Request 40620: Windows: Added suppport for `slave/monitor.cpp'.

2015-12-01 Thread Daniel Pravat
--- OSX: make Windows: make Thanks, Daniel Pravat

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

2016-01-04 Thread Daniel Pravat
/reparsepoint.hpp (line 30) <https://reviews.apache.org/r/39803/#comment173171> This well documented here: https://msdn.microsoft.com/en-us/library/cc232007.aspx - Daniel Pravat On Jan. 4, 2016, 11:46 a.m., Alex Clemmer

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

2016-01-04 Thread Daniel Pravat
u use _rmdir() instead to avoid another deprecation warning ? - Daniel Pravat On Jan. 4, 2016, 12:02 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 39803: Windows: Implemented stout/os/stat.hpp`.

2016-01-04 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39803/#review112685 --- Ship it! Ship It! - Daniel Pravat On Jan. 4, 2016, 11:46 a.m

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

2016-01-04 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/#review112669 --- Ship it! Ship It! - Daniel Pravat On Jan. 4, 2016, 12:02 p.m

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

2016-01-07 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39019/#review113368 --- Ship it! Ship It! - Daniel Pravat On Dec. 23, 2015, 6:44 a.m

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

2016-01-07 Thread Daniel Pravat
> On Dec. 23, 2015, 5:28 a.m., Daniel Pravat wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/dirent.hpp, > > line 104 > > <https://reviews.apache.org/r/39019/diff/9/?file=1174985#file1174985line104> > > > > Can you check

Re: Review Request 39019: Windows: Added dirent compat code for non-Unix systems.

2015-12-22 Thread Daniel Pravat
che.org/r/39019/#comment171962> Can you check the semnatic of opendir() function? I'm under the imression that the first file is found after a susequential readdir() call. Is the intent to change the behaviour on Windows? - Daniel Pravat On Dec. 23, 2015, 2:15 a.m., Alex C

Review Request 41673: Windows: Forked signal handling in `signalhandler.hpp`.

2015-12-22 Thread Daniel Pravat
/stout/os/signalhandler.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/signalhandler.hpp PRE-CREATION Diff: https://reviews.apache.org/r/41673/diff/ Testing --- OSX: make check Windows: build Thanks, Daniel Pravat

Re: Review Request 41604: CMake: Added missing protobuf files to CMake build.

2015-12-28 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41604/#review112019 --- Ship it! Ship It! - Daniel Pravat On Dec. 23, 2015, 6:52 a.m

Re: Review Request 41459: Invoked `_Deferred`'s `operator F()` explicitly.

2015-12-28 Thread Daniel Pravat
tps://reviews.apache.org/r/41459/#comment172397> Other similar constructs will be converted when the code using them will compile on Windows. - Daniel Pravat On Dec. 28, 2015, 3:42 p.m., Michael Park

Re: Review Request 40936: Windows: Unified POSIX and Windows implementation of shell.hpp

2015-12-21 Thread Daniel Pravat
Diff: https://reviews.apache.org/r/40936/diff/ Testing --- Thanks, Daniel Pravat

Re: Review Request 40115: Windows: Added support for `slave/gc.cpp'.

2015-12-21 Thread Daniel Pravat
--- Windows 10: make.bat OSX: make check Ubuntu: 15.1 make check Thanks, Daniel Pravat

Re: Review Request 40939: Windows: Unified POSIX and Windows implementation of su

2015-12-22 Thread Daniel Pravat
3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 42733d429814bf0512540188264830aeaabcabbe Diff: https://reviews.apache.org/r/40939/diff/ Testing --- OSX: make check Windows: make.bat Thanks, Daniel Pravat

Re: Review Request 40936: Windows: Unified POSIX and Windows implementation of shell.hpp

2015-12-22 Thread Daniel Pravat
/stout/include/stout/os/windows/shell.hpp bf737c87b8a337cc46e6c16d6fec2eef61e6ea05 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 42733d429814bf0512540188264830aeaabcabbe Diff: https://reviews.apache.org/r/40936/diff/ Testing --- Thanks, Daniel Pravat

Re: Review Request 40620: Windows: Added suppport for `slave/monitor.cpp'.

2015-12-22 Thread Daniel Pravat
Clemmer. Repository: mesos Description --- Windows: Added suppport for `slave/monitor.cpp'. Diffs (updated) - src/CMakeLists.txt 0d46043dd06007f2cba56626c82e8edd251cb8fb Diff: https://reviews.apache.org/r/40620/diff/ Testing --- OSX: make Windows: make Thanks, Daniel

Re: Review Request 40940: Windows: Modified `launch.cpp`

2015-12-22 Thread Daniel Pravat
://reviews.apache.org/r/40940/diff/ Testing --- OSX: make check Windows: make.bat Thanks, Daniel Pravat

Re: Review Request 40115: Windows: Added support for `slave/gc.cpp'.

2015-12-22 Thread Daniel Pravat
--- Windows 10: make.bat OSX: make check Ubuntu: 15.1 make check Thanks, Daniel Pravat

Re: Review Request 40114: Windows: Began adding Windows support to `process/future.hpp`

2015-11-24 Thread Daniel Pravat
0114/diff/ Testing --- OSX make check, Windows 10 make, Ubuntu 15.1 make check Thanks, Daniel Pravat

Re: Review Request 40115: Windows: Added support for `slave/gc.cpp'.

2015-11-24 Thread Daniel Pravat
://reviews.apache.org/r/40115/diff/ Testing --- Windows 10: make.bat OSX: make check Ubuntu: 15.1 make check Thanks, Daniel Pravat

Re: Review Request 40620: Windows: Added suppport for `slave/monitor.cpp'.

2015-11-27 Thread Daniel Pravat
/ Testing --- OSX: make Windows: make Thanks, Daniel Pravat

Re: Review Request 40115: Windows: Added support for `slave/gc.cpp'.

2015-11-27 Thread Daniel Pravat
src/slave/gc.cpp 6042277f893a54ada612b2080d35061236f4176a Diff: https://reviews.apache.org/r/40115/diff/ Testing --- Windows 10: make.bat OSX: make check Ubuntu: 15.1 make check Thanks, Daniel Pravat

Re: Review Request 40114: Windows: Began adding Windows support to `process/future.hpp`

2015-11-20 Thread Daniel Pravat
heck, Windows 10 Thanks, Daniel Pravat

Re: Review Request 40114: Windows: Began adding Windows support to `process/future.hpp`

2015-11-20 Thread Daniel Pravat
heck, Windows 10 make, Ubuntu 15.1 make check Thanks, Daniel Pravat

Re: Review Request 40115: Windows: [2/2] Changed gc.cpp to compile on Windows.

2015-11-23 Thread Daniel Pravat
/diff/ Testing --- Thanks, Daniel Pravat

Re: Review Request 41459: Invoked `_Deferred`'s `operator F()` explicitly.

2016-01-11 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41459/#review113852 --- Ship it! Ship It! - Daniel Pravat On Jan. 5, 2016, 11:58 p.m

Re: Review Request 42035: Windows: Removed the `--switch_user` flag in Windows.

2016-01-13 Thread Daniel Pravat
g/r/42035/#comment175048> There is a reason why this change is so extensive. This block should be replaced with a reasonable default for switch_user in Windows and it should be enough. - Daniel Pravat On Jan. 7, 2016, 9:47 p.m., Alex Clemmer

Review Request 47873: Windows: Used specific buffer size for `setvbuf`.

2016-05-25 Thread Daniel Pravat
Thanks, Daniel Pravat

Re: Review Request 46418: Refactored the `os::access` function between POSIX and Windows.

2016-05-25 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46418/#review134713 --- Ship it! Ship It! - Daniel Pravat On May 24, 2016, 9:36 p.m

Re: Review Request 47873: Windows: Used specific buffer size for `setvbuf`.

2016-05-30 Thread Daniel Pravat
/diff/ Testing --- Windows: build/test Thanks, Daniel Pravat

Review Request 48056: Windows: Added build and run instructions.

2016-05-30 Thread Daniel Pravat
Van Remoortere, and Michael Park. Repository: mesos Description --- Windows: Added build and run instructions. Diffs - docs/getting-started.md d613512d50bcf76508bac82a612be968112d2e94 Diff: https://reviews.apache.org/r/48056/diff/ Testing --- Thanks, Daniel Pravat

Re: Review Request 47874: Windows: Added support for `--ip_discovery_command` parameter.

2016-05-25 Thread Daniel Pravat
://reviews.apache.org/r/47874/diff/ Testing (updated) --- Windows: build/run Thanks, Daniel Pravat

Review Request 47874: Windows: Added support for `--ip_discovery_command` parameter.

2016-05-25 Thread Daniel Pravat
/ Testing --- Thanks, Daniel Pravat

Re: Review Request 47844: Agent: Added support for `slave/main.cpp`.

2016-05-25 Thread Daniel Pravat
To reply, visit: > https://reviews.apache.org/r/47844/ > --- > > (Updated May 25, 2016, 6:48 p.m.) > > > Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van > Remoortere, and Michael Park. > > > Bugs: MESOS-3614 > https://issues.apache.org

Re: Review Request 47486: Windows: Escaped command line arguments.

2016-05-29 Thread Daniel Pravat
- 3rdparty/libprocess/include/process/windows/subprocess.hpp 551770b9ec24b880c13441f413c5d1871fbf5c3a Diff: https://reviews.apache.org/r/47486/diff/ Testing --- Windows: build/run Thanks, Daniel Pravat

Re: Review Request 49041: Removed `launcher` from the Windows build.

2016-06-22 Thread Daniel Pravat
txx > > > > > > -- Generating done > > ``` CMake caching. - Daniel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49041/#review138982

Re: Review Request 48056: Windows: Added build and run instructions.

2016-06-22 Thread Daniel Pravat
/ Testing --- Thanks, Daniel Pravat

Re: Review Request 48056: Windows: Added build and run instructions.

2016-06-15 Thread Daniel Pravat
/ Testing --- Thanks, Daniel Pravat

Re: Review Request 49041: Removed `launcher` from the Windows build.

2016-06-21 Thread Daniel Pravat
Remoortere. Repository: mesos Description --- Removed `launcher` from the Windows build. Diffs (updated) - src/launcher/CMakeLists.txt e6ba509bd03ee9c2a18b216ade948f74a7335df7 Diff: https://reviews.apache.org/r/49041/diff/ Testing --- Windows: build Thanks, Daniel Pravat

Re: Review Request 49037: Removed mesos-Containerizer-memory_test in Windows.

2016-06-21 Thread Daniel Pravat
Remoortere. Repository: mesos Description --- Removed mesos-Containerizer-memory_test in Windows. Diffs (updated) - src/CMakeLists.txt d66186217c1319d4497640614ed4beee28602c38 Diff: https://reviews.apache.org/r/49037/diff/ Testing --- Windows: build Thanks, Daniel Pravat

Review Request 49041: Removed `launcher` from the Windows build.

2016-06-21 Thread Daniel Pravat
Description --- Removed `launcher` from the Windows build. Diffs - src/launcher/CMakeLists.txt e6ba509bd03ee9c2a18b216ade948f74a7335df7 Diff: https://reviews.apache.org/r/49041/diff/ Testing --- Windows: build Thanks, Daniel Pravat

Review Request 49038: Fixed store.cpp break.

2016-06-21 Thread Daniel Pravat
Description --- Fixed store.cpp break. Diffs - src/slave/containerizer/mesos/provisioner/docker/store.cpp a4fccb31cbbd5638eb9341b346dccf191ef4b1b8 Diff: https://reviews.apache.org/r/49038/diff/ Testing --- Windows: build Thanks, Daniel Pravat

Review Request 49039: Fixed executor.hpp break.

2016-06-21 Thread Daniel Pravat
Description --- Fixed executor.hpp break. Diffs - src/launcher/windows/executor.hpp 0635a2ac6e07b14efbe86a4c3aac214fd615ad19 Diff: https://reviews.apache.org/r/49039/diff/ Testing --- Windows: build Thanks, Daniel Pravat

Review Request 49037: Removed mesos-Containerizer-memory_test in Windows.

2016-06-21 Thread Daniel Pravat
Description --- Removed mesos-Containerizer-memory_test in Windows. Diffs - src/CMakeLists.txt d66186217c1319d4497640614ed4beee28602c38 Diff: https://reviews.apache.org/r/49037/diff/ Testing --- Windows: build Thanks, Daniel Pravat

Review Request 48807: Agent: Use proper case for variable name.

2016-06-16 Thread Daniel Pravat
: mesos Description --- Agent: Use proper case for variable name. Diffs - src/launcher/executor.cpp 1e107eadee609f856ba6f1f5c83df365e20b40e6 Diff: https://reviews.apache.org/r/48807/diff/ Testing --- Thanks, Daniel Pravat

Re: Review Request 40936: Windows: Unified POSIX and Windows implementation of shell.hpp

2016-01-13 Thread Daniel Pravat
/stout/include/stout/os/windows/shell.hpp bf737c87b8a337cc46e6c16d6fec2eef61e6ea05 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 4cf693fb7e8c6bb3ad1920ebe90d61f0adb5dc99 Diff: https://reviews.apache.org/r/40936/diff/ Testing --- Thanks, Daniel Pravat

Re: Review Request 40936: Windows: Unified POSIX and Windows implementation of shell.hpp

2016-01-13 Thread Daniel Pravat
earch of the codebase reveals that calls to `exec*("sh", "sh", > > ...)` are not that numerous. By my count, there are a few in fork.hpp, > > launch.cpp, executor.cpp, and here in shell.hpp, on line 144. It seems like > > it's worth just tra

Re: Review Request 40620: Windows: Added suppport for `slave/monitor.cpp`.

2016-01-13 Thread Daniel Pravat
://reviews.apache.org/r/40620/diff/ Testing --- OSX: make Windows: make Thanks, Daniel Pravat

Re: Review Request 40115: Windows: Added support for `slave/gc.cpp`.

2016-01-13 Thread Daniel Pravat
7a8c69b4410df46ca8fd6ac009cc14e8fe5ff6d3 Diff: https://reviews.apache.org/r/40115/diff/ Testing --- Windows 10: make.bat OSX: make check Ubuntu: 15.1 make check Thanks, Daniel Pravat

Re: Review Request 40620: Windows: Added suppport for `slave/monitor.cpp'.

2016-01-13 Thread Daniel Pravat
Thanks, Daniel Pravat

Re: Review Request 40620: Windows: Added suppport for `slave/monitor.cpp'.

2016-01-13 Thread Daniel Pravat
Thanks, Daniel Pravat

Re: Review Request 42035: Windows: Removed the `--switch_user` flag in Windows.

2016-01-13 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42035/#review114347 --- Ship it! Ship It! - Daniel Pravat On Jan. 7, 2016, 9:47 p.m

Re: Review Request 40940: Windows: Modified `launch.cpp`

2016-01-13 Thread Daniel Pravat
/launch.cpp 0cfdc0ca1a7e8c6107f8ea46e7a4c6e52811d7ac Diff: https://reviews.apache.org/r/40940/diff/ Testing --- OSX: make check Windows: make.bat Thanks, Daniel Pravat

Re: Review Request 40936: Windows: Unified POSIX and Windows implementation of shell.hpp

2016-01-14 Thread Daniel Pravat
27edf1b4f8647a2720f2962eafa110d694b3baed Diff: https://reviews.apache.org/r/40936/diff/ Testing --- OSX: make check Windows: Build Thanks, Daniel Pravat

Re: Review Request 40936: Windows: Unified POSIX and Windows implementation of `shell.hpp`.

2016-01-28 Thread Daniel Pravat
74af0077a39ef4cfa636b0b9e0c6b93eabc04bc8 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 061bb4a9b9efe4ddd364f589175446b07152c315 Diff: https://reviews.apache.org/r/40936/diff/ Testing --- OSX: make check Windows: Build Thanks, Daniel Pravat

Re: Review Request 44078: Windows: Added Socket compatibility `#define`s to windows.hpp.

2016-02-27 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44078/#review121101 --- Ship it! Ship It! - Daniel Pravat On Feb. 26, 2016, 4:11

Re: Review Request 43905: Windows: Removed `user` launcher flag, preventing `su`.

2016-02-27 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43905/#review121104 --- Ship it! Ship It! - Daniel Pravat On Feb. 25, 2016, 7:17

Re: Review Request 43903: Stout: Add `WindowsError` constructor to `Result`.

2016-02-27 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43903/#review121105 --- Ship it! Ship It! - Daniel Pravat On Feb. 25, 2016, 7:13

Re: Review Request 43904: Windows: Removed `rootfs` launcher flag, preventing `chroot`.

2016-02-27 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43904/#review121103 --- Ship it! Ship It! - Daniel Pravat On Feb. 25, 2016, 7:17

Re: Review Request 43907: Stout:[1/2] Fix error reporting bug in `os::rmdir`.

2016-02-27 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43907/#review121100 --- Ship it! Ship It! - Daniel Pravat On Feb. 25, 2016, 7:41

Re: Review Request 43709: Windows:[3/3] Enabled zlib compression tests.

2016-02-27 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43709/#review121106 --- Ship it! Ship It! - Daniel Pravat On Feb. 18, 2016, 5:25

Re: Review Request 43906: CMake: Added files to be built as part of libmesos.

2016-02-27 Thread Daniel Pravat
g/r/43906/#comment182693> Please lift the values used by the build.cpp and passed as BUILD* defines into their ows CMAKE macros to get dynamic values into a subsequential commit. - Daniel Pravat On Feb. 25, 2016, 7:17 p.m., Alex Clemmer

Re: Review Request 43906: CMake: Added files to be built as part of libmesos.

2016-02-27 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43906/#review121099 --- Ship it! Ship It! - Daniel Pravat On Feb. 25, 2016, 7:17

Re: Review Request 44077: Windows:[3/3] Transitioned Windows `system` to use `os::execlp`.

2016-02-27 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44077/#review121117 --- Ship it! Ship It! - Daniel Pravat On Feb. 26, 2016, 4:11

Re: Review Request 44042: Windows: Fixed `UUID::random` and added utime/touch to stout/os.hpp.

2016-02-27 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44042/#review121122 --- Ship it! Ship It! - Daniel Pravat On Feb. 25, 2016, 9:16

Re: Review Request 44046: Windows: Used `evutil_socket_t` typedef for sockets.

2016-02-27 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44046/#review121120 --- Ship it! Ship It! - Daniel Pravat On Feb. 26, 2016, 4:09

Re: Review Request 44075: Windows: [1/3] Add platform-dependent `os::execlp`.

2016-02-27 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44075/#review121119 --- Ship it! Ship It! - Daniel Pravat On Feb. 26, 2016, 4:11

Re: Review Request 44045: Style fixes to `stout/include/Makefile.am`.

2016-02-27 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44045/#review121121 --- Ship it! Ship It! - Daniel Pravat On Feb. 25, 2016, 10:28

Re: Review Request 44076: Windows: [2/3] Used `os::execlp` in launch.cpp.

2016-02-27 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44076/#review121118 --- Ship it! Ship It! - Daniel Pravat On Feb. 26, 2016, 4:11

Re: Review Request 43691: CMake:[2/2] Fixed http-parser library directory for Windows builds.

2016-02-19 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43691/#review120003 --- Ship it! Ship It! - Daniel Pravat On Feb. 18, 2016, 2:24

Re: Review Request 43417: Windows: Marked functions in headers `inline` to avoid linker errors.

2016-02-19 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43417/#review120004 --- Ship it! Ship It! - Daniel Pravat On Feb. 18, 2016, 12:59

Re: Review Request 43411: Windows: Added dynamic library loading tests to build.

2016-02-11 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43411/#review118889 --- Ship it! Ship It! - Daniel Pravat On Feb. 10, 2016, 6:47

Re: Review Request 43411: Windows: Added dynamic library loading tests to build.

2016-02-11 Thread Daniel Pravat
> On Feb. 11, 2016, 6 p.m., Daniel Pravat wrote: > > Ship It! RB diff is showing a more complicated picture. - Daniel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43411/#rev

Re: Review Request 40620: Windows: Added suppport for `slave/monitor.cpp`.

2016-03-01 Thread Daniel Pravat
, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Repository: mesos Description --- Windows: Added suppport for `slave/monitor.cpp`. Diffs (updated) - src/CMakeLists.txt 5cf0ec8c475839ad8717192a37f01546cbcccd7a Diff: https

Re: Review Request 41632: Windows: Forked signal handling in `signalhandler.hpp`.

2016-03-01 Thread Daniel Pravat
, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Repository: mesos Description --- Windows: Forked signal handling in `signalhandler.hpp`. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/Makefile.am

Re: Review Request 44141: Windows: Forked subprocess.cpp, added `Windows` implementation.

2016-03-01 Thread Daniel Pravat
, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Summary (updated) - Windows: Forked subprocess.cpp, added `Windows` implementation. Repository: mesos Description (updated) --- Windows: Forked subprocess.cpp, added `Windows

Re: Review Request 40115: Windows: Added support for `slave/gc.cpp`.

2016-03-01 Thread Daniel Pravat
://reviews.apache.org/r/40115/diff/ Testing --- Windows 10: make.bat OSX: make check Ubuntu: 15.1 make check Thanks, Daniel Pravat

Re: Review Request 41632: Windows: Forked signal handling in `signalhandler.hpp`.

2016-03-01 Thread Daniel Pravat
, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Bugs: MESOS-3644 https://issues.apache.org/jira/browse/MESOS-3644 Repository: mesos Description --- Windows: Forked signal handling in `signalhandler.hpp`. Diffs - 3rdparty/libprocess

Re: Review Request 40938: Stout: Mark `os::chroot` as deleted on Windows.

2016-03-01 Thread Daniel Pravat
/3rdparty/stout/include/stout/windows/os.hpp d917a99a46841156dc1e359c44010938cc45e943 Diff: https://reviews.apache.org/r/40938/diff/ Testing --- OSX: make check Windows: make.bat Thanks, Daniel Pravat

Re: Review Request 40939: Windows: Unified POSIX and Windows implementation of su

2016-03-01 Thread Daniel Pravat
/stout/include/stout/os/windows/su.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 42733d429814bf0512540188264830aeaabcabbe Diff: https://reviews.apache.org/r/40939/diff/ Testing --- OSX: make check Windows: make.bat Thanks, Daniel Pravat

Re: Review Request 40938: Stout: Mark `os::chroot` as deleted on Windows.

2016-03-01 Thread Daniel Pravat
-------- On March 1, 2016, 10:07 p.m., Daniel Pravat wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40938/ > --

Re: Review Request 40939: Stout: Marked `os::su` as deleted on Windows.

2016-03-01 Thread Daniel Pravat
/diff/ Testing --- OSX: make check Windows: make.bat Thanks, Daniel Pravat

Re: Review Request 43707: Windows:[1/3] Added zlib definitions for Windows.

2016-03-10 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43707/#review122993 --- Ship it! Ship It! - Daniel Pravat On Feb. 18, 2016, 5:25

Re: Review Request 43709: Windows:[3/3] Enabled zlib compression tests.

2016-03-10 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43709/#review122998 --- Ship it! Ship It! - Daniel Pravat On Feb. 18, 2016, 5:25

Re: Review Request 44138: Windows:[1/2] Lifted socket API into Stout.

2016-03-14 Thread Daniel Pravat
, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Repository: mesos Description --- Windows:[1/2] Lifted socket API into Stout. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/socket.hpp PRE-CREATION 3rdparty

Re: Review Request 44139: Windows:[2/2] Lifted socket API into Stout.

2016-03-14 Thread Daniel Pravat
, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Repository: mesos Description --- Windows:[2/2] Lifted socket API into Stout. Diffs (updated) - 3rdparty/libprocess/include/process/network.hpp 7d203f0ff1cdb3145bc2b914f8bd606203878f09

Re: Review Request 44139: Windows:[2/2] Lifted socket API into Stout.

2016-03-18 Thread Daniel Pravat
, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Repository: mesos Description --- Windows:[2/2] Lifted socket API into Stout. Diffs (updated) - 3rdparty/libprocess/include/process/network.hpp

Re: Review Request 44135: Libprocess: Use Windows-compatible memory fence in logging.

2016-03-19 Thread Daniel Pravat
, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Summary (updated) - Libprocess: Use Windows-compatible memory fence in logging. Repository: mesos Description (updated) --- Libprocess: Use Windows-compatible memory fence

Re: Review Request 44748: Stout: Added implementation of `read` that works on Windows.

2016-03-11 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44748/#review123268 --- Ship it! Ship It! - Daniel Pravat On March 12, 2016, 1:28

Re: Review Request 44090: Windows: Added a cast for `get/setsockopt` parameters.

2016-03-11 Thread Daniel Pravat
, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Summary (updated) - Windows: Added a cast for `get/setsockopt` parameters. Repository: mesos Description (updated) --- Windows: Added a cast for `get/setsockopt` parameters. Diffs

Re: Review Request 44138: Windows:[1/2] Lifted socket API into Stout.

2016-03-11 Thread Daniel Pravat
, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Repository: mesos Description --- Windows:[1/2] Lifted socket API into Stout. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/socket.hpp PRE-CREATION 3rdparty

Re: Review Request 44760: Windows: Fixed non-blocking connect.

2016-03-19 Thread Daniel Pravat
, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Repository: mesos Description --- Windows: Fixed non-blocking connect. Diffs (updated) - 3rdparty/libprocess/include/process/network.hpp

Re: Review Request 44090: Windows: Changed the calling parameters for Windows API.

2016-03-19 Thread Daniel Pravat
, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Repository: mesos Description --- Windows: Changed the calling parameters for Windows API. Diffs - 3rdparty/libprocess/src/libevent.cpp c4a8da8a70b97dd575b1256179c4f43742131a1e

Re: Review Request 44089: Windows: Used os::read/write from Stout for proper OS isolation.

2016-03-19 Thread Daniel Pravat
, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Repository: mesos Description --- Windows: Used os::read/write from Stout for proper OS isolation. Diffs - 3rdparty/libprocess/src/io.cpp

Re: Review Request 44760: Windows: Fixed non-blocking connect.

2016-03-19 Thread Daniel Pravat
, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Repository: mesos Description --- Windows: Fixed non-blocking connect. Diffs - 3rdparty/libprocess/include/process/network.hpp 7d203f0ff1cdb3145bc2b914f8bd606203878f09

Re: Review Request 44089: Windows: Used os::read/write from Stout for proper OS isolation.

2016-03-12 Thread Daniel Pravat
, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Repository: mesos Description --- Windows: Used os::read/write from Stout for proper OS isolation. Diffs (updated) - 3rdparty/libprocess/src/io.cpp 4a58d6dff3787ca262ee2ade2cbea7578ad27e95

Re: Review Request 44090: Windows: Changed the calling parameters for Windows API.

2016-03-12 Thread Daniel Pravat
, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Summary (updated) - Windows: Changed the calling parameters for Windows API. Repository: mesos Description (updated) --- Windows: Changed the calling parameters for Windows API

Review Request 44760: Windows: Fixed non-blocking connect.

2016-03-12 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44760/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris

  1   2   3   4   >