Re: Review Request 47804: Fixed a memory leak in SchedulerProcess.decline.

2016-05-24 Thread Dario Rexin
sched/sched.cpp 9e55885 Diff: https://reviews.apache.org/r/47804/diff/ Testing --- make check Thanks, Dario Rexin

Re: Review Request 47804: Fixed a memory leak in SchedulerProcess.decline

2016-05-24 Thread Dario Rexin
, Dario Rexin

Re: Review Request 47804: Fixed a memory leak in SchedulerProcess.decline

2016-05-24 Thread Dario Rexin
); > > > > ``` Thanks for the feedback. I updated the patch accordingly. - Dario --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47804/#review134676 --- On May 25, 2016, 3:45 a.m., Dario

Review Request 47804: Fixed a memory leak in SchedulerProcess.decline

2016-05-24 Thread Dario Rexin
. The changed version of declineOffer however did not remove the offerId from the savedOffers map, causing a memory leak. Diffs - src/sched/sched.cpp 9e55885 Diff: https://reviews.apache.org/r/47804/diff/ Testing --- make check Thanks, Dario Rexin

Re: Review Request 47260: Added 'ReviveAndSuppress' test for the allocator.

2016-05-16 Thread Dario Rexin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47260/#review133408 --- Ship it! Ship It! - Dario Rexin On May 12, 2016, 4:01 p.m

Re: Review Request 61058: Added a lock-free event queue.

2017-07-31 Thread Dario Rexin
ssible to reason about message ordering between two actors. - Dario Rexin On July 29, 2017, 8:52 p.m., Benjamin Hindman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 61058: Added a lock-free event queue.

2017-07-31 Thread Dario Rexin
> On July 31, 2017, 9:05 p.m., Dario Rexin wrote: > > 3rdparty/libprocess/src/event_queue.hpp > > Lines 328 (patched) > > <https://reviews.apache.org/r/61058/diff/3/?file=1785564#file1785564line331> > > > > I don't think this queue match

Re: Review Request 62515: Added mpsc_linked_queue and use it as the concurrent event queue.

2018-06-27 Thread Dario Rexin
/2018/06/15/b010f4cb-6492-4192-aa3b-bcbace547274__queue.patch Thanks, Dario Rexin

Re: Review Request 62515: Added mpsc_linked_queue and use it as the concurrent event queue.

2018-06-27 Thread Dario Rexin
/2018/06/15/b010f4cb-6492-4192-aa3b-bcbace547274__queue.patch Thanks, Dario Rexin

Re: Review Request 68149: Replace exchange in MpscLinkedQueue::dequeue with load/store.

2018-08-02 Thread Dario Rexin
-dc9f522ae192__mpsc-load-store.patch Thanks, Dario Rexin

Re: Review Request 68149: Replace exchange in MpscLinkedQueue::dequeue with load/store.

2018-08-02 Thread Dario Rexin
/uploaded/files/2018/08/02/b8bd71a1-a1c7-47b1-beae-dc9f522ae192__mpsc-load-store.patch Thanks, Dario Rexin

Re: Review Request 68149: Replace exchange in MpscLinkedQueue::dequeue with load/store.

2018-08-05 Thread Dario Rexin
/uploaded/files/2018/08/02/b8bd71a1-a1c7-47b1-beae-dc9f522ae192__mpsc-load-store.patch Thanks, Dario Rexin

Re: Review Request 68039: Padded using the type name in `MpscLinkedQueue`.

2018-07-25 Thread Dario Rexin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68039/#review206461 --- Ship it! Ship It! - Dario Rexin On July 25, 2018, 2:42 p.m

Re: Review Request 67921: Bug fix for semaphore decomission "deadlock".

2018-07-16 Thread Dario Rexin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67921/#review206111 --- Ship it! Ship It! - Dario Rexin On July 15, 2018, 5:09 p.m

Re: Review Request 68001: Fix padding in MpscLinkedQueue.

2018-07-23 Thread Dario Rexin
Requires e.g., > `#include `. It would probably work for the padding between head and tail, but what about the padding after tail? Should we `alignas(64) char tailPad;` or somethign like that? - Dario ------- This is

Re: Review Request 68001: Fix padding in MpscLinkedQueue.

2018-07-23 Thread Dario Rexin
__` is a GNU extension, missing check of `sizeof(var) < 64`). > > Benjamin Bannier wrote: > I should have used a real variable for `CACHE_LINE` above to make this > less nasty, e.g., > > static constexpr std::size_t CACHE_LINE = 64; // Requires e.g.,

Re: Review Request 68001: Fix padding in MpscLinkedQueue.

2018-07-24 Thread Dario Rexin
line. Diffs (updated) - 3rdparty/libprocess/src/mpsc_linked_queue.hpp 48c95093d Diff: https://reviews.apache.org/r/68001/diff/3/ Changes: https://reviews.apache.org/r/68001/diff/2-3/ Testing --- make check & benchmarks Thanks, Dario Rexin

Re: Review Request 68001: Fix padding in MpscLinkedQueue.

2018-07-24 Thread Dario Rexin
line. Diffs (updated) - 3rdparty/libprocess/src/mpsc_linked_queue.hpp 48c95093d Diff: https://reviews.apache.org/r/68001/diff/4/ Changes: https://reviews.apache.org/r/68001/diff/3-4/ Testing --- make check & benchmarks Thanks, Dario Rexin

Re: Review Request 68001: Fix padding in MpscLinkedQueue.

2018-07-24 Thread Dario Rexin
line. Diffs (updated) - 3rdparty/libprocess/src/mpsc_linked_queue.hpp 48c95093d Diff: https://reviews.apache.org/r/68001/diff/2/ Changes: https://reviews.apache.org/r/68001/diff/1-2/ Testing --- make check & benchmarks Thanks, Dario Rexin