since cleanup() here does GC on mount points
that are children of the sandbox.
- James DeFelice
On July 12, 2015, 4:46 a.m., Ian Downes wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
://reviews.apache.org/r/37443/diff/
Testing
---
make check
Thanks,
James DeFelice
579c009
src/master/master.hpp 4e29470
src/tests/fault_tolerance_tests.cpp c63599a
src/tests/master_tests.cpp a4703af
Diff: https://reviews.apache.org/r/37443/diff/
Testing
---
make check
Thanks,
James DeFelice
/r/37443/#comment150206
This comment is out of date. Will fix ASAP
- James DeFelice
On Aug. 13, 2015, 7:39 p.m., James DeFelice wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
src/tests/fault_tolerance_tests.cpp c63599a
src/tests/master_tests.cpp a4703af
Diff: https://reviews.apache.org/r/37443/diff/
Testing
---
make check
Thanks,
James DeFelice
/tests/fault_tolerance_tests.cpp c63599a
src/tests/master_tests.cpp a4703af
Diff: https://reviews.apache.org/r/37443/diff/
Testing
---
make check
Thanks,
James DeFelice
4e29470
src/tests/fault_tolerance_tests.cpp c63599a
src/tests/master_tests.cpp a4703af
Diff: https://reviews.apache.org/r/37443/diff/
Testing
---
make check
Thanks,
James DeFelice
(evil agent!):
```
../../../3rdparty/libprocess/src/tests/http_tests.cpp:461: Failure
Value of: response.get().status
Actual: 202 Accepted
Expected: http::statuses[200]
Which is: 200 OK
[ FAILED ] HTTPTest.NestedGet (2 ms)
```
- James DeFelice
On Aug. 14, 2015, 11:58 a.m., James DeFelice wrote
4e29470
src/tests/fault_tolerance_tests.cpp c63599a
src/tests/master_tests.cpp a4703af
Diff: https://reviews.apache.org/r/37443/diff/
Testing
---
make check
Thanks,
James DeFelice
org/r/44657/#comment185970>
I don't understand this comment as written. Can this be clarified?
- James DeFelice
On March 15, 2016, 4:04 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e-mail.
ing that I'd expect to be documented in the
protobuf
- James DeFelice
On March 9, 2016, 3 p.m., Jan Schlicht wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
/dvd_client.cpp (line 66)
<https://reviews.apache.org/r/45360/#comment192205>
options must be specified as follows:
`--volumeopts={param.key}={param.value}`
- James DeFelice
On April 13, 2016, 9:17 a.m., Guangya Liu
106)
<https://reviews.apache.org/r/45370/#comment192209>
we should probably validate (or else sanitize) the contents of driver,
name, and options
- James DeFelice
On April 4, 2016, 9:21 a.m., Guangya Liu
tps://reviews.apache.org/r/45214/#comment192212>
I definitely prefer this form, but there's also a Parameters message type.
Which is more idiomatic in this context?
- James DeFelice
On April 13, 2016, 3:09 a.m., Guangya Liu
g/r/45370/#comment192207>
other `--flag` params are computed elsewhere (e.g. DvdClient::mount);
should do the same here. Just construct Parameters instead
- James DeFelice
On April 4, 2016, 9:21 a.m., Guangya Liu wrote:
>
> ---
> Thi
64)
<https://reviews.apache.org/r/45326/#comment192208>
should we verify that the dvdcli binary actually exists here (and if not
generate an error)?
- James DeFelice
On April 2, 2016, 3:54 p.m., Guangya Liu
/isolator.cpp (line 494)
<https://reviews.apache.org/r/50215/#comment209535>
what stops a user from injecting a '; in the source and then following it
up with an arbitrary command?
- James DeFelice
On July 26, 2016, 9:08 p.m., Gilbert Song
--
>
> (Updated Aug. 12, 2016, 11:12 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Benjamin Hindman, Benjamin Mahler,
> James DeFelice, and Jie Yu.
>
>
> Bugs: MESOS-6036
> https://issues.apache.org/jira/browse/M
consistency?
- James DeFelice
On Aug. 12, 2016, 11:12 p.m., Vinod Kone wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
g/r/54846/#comment236449>
should we include the pid namespace as well, or is that implicit (or
handled elsewhere)?
- James DeFelice
On Dec. 18, 2016, 5:30 p.m., haosdent huang wrote:
>
> ---
> This is an automatically g
hings may result in unpredictable behavior from the
perspective of an application that already (pre-this-diff) includes environment
variables defined with such non-docker-envfile compatible values.
- James DeFelice
On Nov. 28, 2016, 4:47 p.m., Till
, how might someone query the state of the
requested launch operation/container?
2. When a stand alone container terminates (either success or failure), who is
notified and when?
3. What are the expected failure modes/codes for this API and what are the
recovery semantics?
- James DeFelice
volume mounts and persistent vols
- James DeFelice
On July 10, 2017, 6 p.m., Gilbert Song wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
iner's
sandbox).
this is typically why containers use this workaround approach, because
there's an absolute path in the container's mountns that some process wants to
read-from/write-to
- James DeFelice
On July 10, 2017, 6 p.m., Gilbert Song
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62820/#review187316
---
Ship it!
Ship It!
- James DeFelice
On Oct. 6, 2017, 9:42
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62820/#review187318
---
- James DeFelice
On Oct. 6, 2017, 9:42 p.m., Jie Yu wrote
tps://reviews.apache.org/r/63001/#comment265303>
unique in the context of the framework? or universally unique?
include/mesos/mesos.proto
Lines 2166 (patched)
<https://reviews.apache.org/r/63001/#comment265302>
isn't UNKNOWN standard here?
- James DeFelice
On Oct. 17, 2017, 5:08 a.m.,
ment264836>
ditto: s/source/volume/
- James DeFelice
On Oct. 12, 2017, 11:39 a.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail. To
tps://reviews.apache.org/r/62929/#comment264838>
need the same s/source/volume/ changes for the v1 protos
- James DeFelice
On Oct. 12, 2017, 2:01 p.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62929/#review187804
---
Ship it!
Ship It!
- James DeFelice
On Oct. 12, 2017, 3:34
tps://reviews.apache.org/r/58021/#comment260925>
I'd love to see documentation for these new operations to distinguish them
from the CREATE and DESTROY operations
- James DeFelice
On Aug. 31, 2017, 11:33 a.m., Jan Schlicht
NestedContainer` optional fields be deprecated as well?
include/mesos/agent/agent.proto
Line 354 (original), 427 (patched)
<https://reviews.apache.org/r/60890/#comment260050>
deprecated?
- James DeFelice
On Aug.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63642/#review190415
---
Ship it!
Ship It!
- James DeFelice
On Nov. 7, 2017, 6:47
tps://reviews.apache.org/r/63901/#comment271916>
s/Update/Add/
- James DeFelice
On Dec. 8, 2017, 10 p.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64495/#review193389
---
Ship it!
Ship It!
- James DeFelice
On Dec. 11, 2017, 6:55
sources as BLOCK (or MOUNT)
volumes instead of RAW. I don't *think* it's a blocker for MVP, but we've had a
couple of conversations recently about exposing low-level primitives to
specialized storage frameworks, and that it might be useful to report block
devices as BLOCK disk resources, by default.
-
skip the subsequent notifications if nothing has changed. we don't expect
profiles to change very frequently.
- James DeFelice
On May 11, 2018, 3:32 a.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an automatically generated e-mail.
> On May 11, 2018, 12:05 p.m., James DeFelice wrote:
> > src/resource_provider/storage/uri_disk_profile_adaptor.cpp
> > Line 281 (original)
> > <https://reviews.apache.org/r/67078/diff/1/?file=2019745#file2019745line281>
> >
> > this seems like a pretty
default value of the corresponding
field type.
This difference is probably important to note. The example provided
continues to use snake_case for protobuf3 json fields (e.g. fs_type vs fsType).
- James DeFelice
On Dec. 29, 2017, 4:53 a.m., Jie Yu wrote:
>
> -
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65391/#review196529
---
Ship it!
Ship It!
- James DeFelice
On Jan. 30, 2018, 12:05
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65392/#review196530
---
Ship it!
Ship It!
- James DeFelice
On Jan. 29, 2018, 6:19
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65538/#review197063
---
Ship it!
Ship It!
- James DeFelice
On Feb. 7, 2018, 9:07
(patched)
<https://reviews.apache.org/r/65538/#comment276960>
maybe add a comment that specifying a `selector` is REQUIRED?
- James DeFelice
On Feb. 7, 2018, 1:12 a.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an automatica
as "experimental", for
clarity? e.g. `CreateVolume`
- James DeFelice
On April 14, 2018, 1:06 a.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66616/#review201282
---
Ship it!
Ship It!
- James DeFelice
On April 16, 2018, 11:31
y..."
again, I have e2e tests that prove otherwise
- James DeFelice
On March 27, 2018, 11:27 p.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an automaticall
(patched)
<https://reviews.apache.org/r/66325/#comment280750>
has RP ID already been brought into alignment here?
src/resource_provider/daemon.cpp
Lines 239 (patched)
<https://reviews.apache.org/r/66325/#comment280751>
ditto, has RP ID already been brought into alignment?
- Ja
tps://reviews.apache.org/r/69010/#comment293974>
Why is the default `false` here? If someone is calling the `checkpoint`
func because they want atomic semantics ... wouldn't they *normally* want
`sync==true` (and shouldn't the *exception* to the rule be `sync==false`)?
- James DeFelice
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69053/#review209647
---
Ship it!
Ship It!
- James DeFelice
On Oct. 16, 2018, 6:57
the volume
and won't deprovision it .. then how does one go about actually removing it via
Mesos APIs to reclaim space in the storage pool?
- James DeFelice
On Oct. 17, 2018, 11:21 p.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an
> is no longer known by Mesos
- James DeFelice
On Oct. 23, 2018, 2:37 a.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
> On Oct. 23, 2018, 2:51 p.m., James DeFelice wrote:
> > include/mesos/mesos.proto
> > Lines 2030 (patched)
> > <https://reviews.apache.org/r/69036/diff/4/?file=2101986#file2101986line2030>
> >
> > Referring to an implementation artifact like the &q
ion status
update messages. This is not always possible, e.g., some operations
might fail validation so that no corresponding IDs can be extracted
Will the framework be expected to ACK in these cases? If so, missing the IDs is
problematic.
- James DeFelice
On Oct. 25, 2018, 10:54 a.m., Benja
)
<https://reviews.apache.org/r/69162/#comment294673>
For these "certain cases" does Mesos still expect an ACK? If so, that's a
problem.
- James DeFelice
On Oct. 25, 2018, 10:54 a.m., Benjam
(original), 2655 (patched)
<https://reviews.apache.org/r/69360/#comment295305>
s/into/as/ ?
- James DeFelice
On Nov. 16, 2018, 12:02 a.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an automatically generated e-mail.
(original), 2655 (patched)
<https://reviews.apache.org/r/69360/#comment295305>
s/into/as/ ?
- James DeFelice
On Nov. 16, 2018, 12:02 a.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an automatically generated e-mail.
(original), 2655 (patched)
<https://reviews.apache.org/r/69360/#comment295305>
s/into/as/ ?
- James DeFelice
On Nov. 16, 2018, 12:02 a.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an automatically generated e-mail.
)
<https://reviews.apache.org/r/69811/#comment297969>
+1
It's not clear why we're doing special things for PROBE vs the other calls.
- James DeFelice
On Jan. 23, 2019, 7:07 a.m., Chun-Hung Hsiao
igated
by a retry. It's not clear that the SLRP has enough information for a retry in
every such case. Needs more thought.
src/resource_provider/storage/provider.cpp
Lines 1916 (patched)
<https://reviews.apache.org/r/69812/#comment297971>
what about a metric for call retries?
- Ja
che.org/r/69037/
> ---
>
> (Updated Dec. 7, 2018, 4:31 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, Jie Yu, and Jan
> Schlicht.
>
>
> Bugs: MESOS-9321
> https://issu
> On Dec. 4, 2018, 11:20 p.m., James DeFelice wrote:
> > include/mesos/v1/mesos.proto
> > Lines 2434 (patched)
> > <https://reviews.apache.org/r/69162/diff/7/?file=2111243#file2111243line2434>
> >
> > I'd like this part to be a bit more fleshed o
> On Dec. 4, 2018, 11:20 p.m., James DeFelice wrote:
> > include/mesos/v1/mesos.proto
> > Lines 2434 (patched)
> > <https://reviews.apache.org/r/69162/diff/7/?file=2111243#file2111243line2434>
> >
> > I'd like this part to be a bit more fleshed o
acknowledge the status
update by using the specified `agent_id` and `resource_provider_id` (for local
providers); and `resource_provider_id` (for external providers).
- James DeFelice
On Nov. 30, 2018, 11:06 a.m., Benjamin B
> On Dec. 4, 2018, 11:20 p.m., James DeFelice wrote:
> > include/mesos/v1/mesos.proto
> > Lines 2434 (patched)
> > <https://reviews.apache.org/r/69162/diff/7/?file=2111243#file2111243line2434>
> >
> > I'd like this part to be a bit more fleshed o
Chun-Hung Hsiao wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69356/
> -------
>
> (Updated Nov. 19
> On March 27, 2019, 12:01 p.m., James DeFelice wrote:
> > src/csi/state.proto
> > Line 19 (original), 19 (patched)
> > <https://reviews.apache.org/r/70248/diff/5/?file=2134483#file2134483line19>
> >
> > are the protos in src/csi considered part o
egrate?
- James DeFelice
On March 28, 2019, 7:51 a.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
> On March 27, 2019, 12:01 p.m., James DeFelice wrote:
> > src/csi/state.proto
> > Line 19 (original), 19 (patched)
> > <https://reviews.apache.org/r/70248/diff/5/?file=2134483#file2134483line19>
> >
> > are the protos in src/csi considered part o
> On April 2, 2019, 5:46 p.m., James DeFelice wrote:
> > support/packaging/centos/mesos.spec
> > Lines 94 (patched)
> > <https://reviews.apache.org/r/70295/diff/1/?file=2133927#file2133927line94>
> >
> > ```
> > %{!?el6:%defi
tps://reviews.apache.org/r/70295/#comment300497>
```
%{!?el6:%define launcher_sealing --enable-launcher-sealing}
% configure %{launcher_sealing} \
...
```
- James DeFelice
On March 25, 2019, 3:09 p.m., Benjamin Bannier
tps://reviews.apache.org/r/70248/#comment300271>
are the protos in src/csi considered part of the "stable" mesos v1 API? if
so, should they follow the same directory naming convention as the other mesos
v1 APIs?
- James DeFelice
On March 27, 2019, 5:54 a.m., Chun-
g/wiki/Packaging:DistTag
- James DeFelice
On March 25, 2019, 3:09 p.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70313/#review214073
---
Ship it!
Ship It!
- James DeFelice
On March 27, 2019, 2:38
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70024/#review212987
---
Ship it!
Ship It!
- James DeFelice
On Feb. 20, 2019, 7:18
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70025/#review212988
---
Ship it!
Ship It!
- James DeFelice
On Feb. 20, 2019, 7:18
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70221/#review213763
---
Ship it!
Ship It!
- James DeFelice
On March 15, 2019, 10:37
tps://reviews.apache.org/r/69818/#comment298435>
Each `ResourceQuantities` item here represents a "shape" that will be
matched against a potential offer, yes?
- James DeFelice
On Feb. 4, 2019, 8:37 p.m., Benjam
rated e-mail. To reply, visit:
> https://reviews.apache.org/r/69892/
> ---
>
> (Updated Feb. 5, 2019, 7:40 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu.
>
>
> Bugs:
> On Jan. 23, 2019, 3:33 p.m., James DeFelice wrote:
> > src/resource_provider/storage/provider.cpp
> > Lines 1916 (patched)
> > <https://reviews.apache.org/r/69812/diff/1/?file=2121403#file2121403line1916>
> >
> > what about a metric for c
)
<https://reviews.apache.org/r/69871/#comment298228>
What about OPERATION_UNKNOWN, where does that fit in here?
- James DeFelice
On Jan. 31, 2019, 2:11 a.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69894/#review212548
---
Ship it!
Ship It!
- James DeFelice
On Feb. 5, 2019, 7:43
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70868/#review215925
---
Ship it!
Ship It!
- James DeFelice
On June 17, 2019, 10:49
API
documentation, along w/ expected response codes from mesos?
- James DeFelice
On June 21, 2019, 1:10 p.m., Joseph Wu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
r well-known types.
- James DeFelice
On June 21, 2019, 1:10 p.m., Joseph Wu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70627/#review215195
---
Ship it!
Ship It!
- James DeFelice
On May 10, 2019, 9:17
)
<https://reviews.apache.org/r/70620/#comment301769>
how often are these conversions applied? i suppose it's every time that
reconciliation happens - how often is that?
- James DeFelice
On May 10, 2019, 1:14 a.m., Chun-Hung Hsiao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70628/#review215201
---
Ship it!
Ship It!
- James DeFelice
On May 10, 2019, 11:07
87 matches
Mail list logo
