Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

2015-04-23 Thread Joris Van Remoortere
: change from `FirewallRule *rule` to `FirewallRule* rule`. - Joris Van Remoortere On April 22, 2015, 2:35 p.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33295

Re: Review Request 33274: Fix capture by reference of temporary strings in Libprocess.

2015-04-22 Thread Joris Van Remoortere
check Thanks, Joris Van Remoortere

Re: Review Request 33271: Update style guide to disallow capturing temporaries by reference.

2015-04-22 Thread Joris Van Remoortere
de1b93e9f210cd20db2355bd666991339fa4f50b Diff: https://reviews.apache.org/r/33271/diff/ Testing --- Thanks, Joris Van Remoortere

Re: Review Request 33275: Fix capture by reference of temporaries in Stout.

2015-04-22 Thread Joris Van Remoortere
/3rdparty/stout/tests/os_tests.cpp 343f95be7f316170b37c9358627f3c2090f0e29e Diff: https://reviews.apache.org/r/33275/diff/ Testing --- make check Thanks, Joris Van Remoortere

Re: Review Request 33572: Add C++11 unrestricted union to the C++ style guide.

2015-04-29 Thread Joris Van Remoortere
once that patch set is committed. - Joris Van Remoortere On April 26, 2015, 8:26 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33572

Re: Review Request 33271: Update style guide to disallow capturing temporaries by reference.

2015-04-29 Thread Joris Van Remoortere
-guide.md 451d2475e72e07e0a5deec4e62af9d6746d94bc0 Diff: https://reviews.apache.org/r/33271/diff/ Testing --- Thanks, Joris Van Remoortere

Re: Review Request 32630: Add style change proposal for constant reference to temporaries.

2015-04-29 Thread Joris Van Remoortere
Van Remoortere

Re: Review Request 33558: Add C++11 lambdas to the C++ style guide.

2015-04-29 Thread Joris Van Remoortere
align the same as the capture list? - Joris Van Remoortere On April 28, 2015, 5:33 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33558

Re: Review Request 33572: Add C++11 unrestricted union to the C++ style guide.

2015-04-29 Thread Joris Van Remoortere
-mail. To reply, visit: https://reviews.apache.org/r/33572/ --- (Updated April 26, 2015, 8:26 p.m.) Review request for mesos, Ben Mahler, Joris Van Remoortere, Michael Park, and Vinod Kone. Repository: mesos Description

Re: Review Request 33376: MESOS-2633 Moved struct Framework methods to their own implementation class.

2015-04-30 Thread Joris Van Remoortere
On April 29, 2015, 8:24 p.m., Joris Van Remoortere wrote: src/master/framework.cpp, lines 101-102 https://reviews.apache.org/r/33376/diff/3/?file=939881#file939881line101 The style is either: Follow the alignment if you stay on the 1st line: ``` bool Framework

Re: Review Request 32837: Re-order structs in Slave State.hpp to prevent forward declaration dependency.

2015-04-30 Thread Joris Van Remoortere
31dfdd5a4b644f466756a712deded1b025a73c02 Diff: https://reviews.apache.org/r/32837/diff/ Testing --- Thanks, Joris Van Remoortere

Re: Review Request 32838: Use unrestricted union to remove dynamic allocation from Option.

2015-04-30 Thread Joris Van Remoortere
://reviews.apache.org/r/32838/#review82065 --- On April 30, 2015, 4:22 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https

Review Request 33828: Fix for MESOS-2690. Issue with enable-optimize build.

2015-05-04 Thread Joris Van Remoortere
the compilation warnings are gone. Would love someone to confirm this does not break the clang builds. Thanks, Joris Van Remoortere

Re: Review Request 33643: Add EMPTY to stout hashset

2015-05-05 Thread Joris Van Remoortere
. Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp d2b74393b7c4b65477698d9c810dfe3c8673c2ab Diff: https://reviews.apache.org/r/33643/diff/ Testing --- make check Thanks, Joris Van Remoortere

Re: Review Request 33505: Add state-summary endpoint to master.

2015-05-05 Thread Joris Van Remoortere
Diff: https://reviews.apache.org/r/33505/diff/ Testing --- make check Thanks, Joris Van Remoortere

Re: Review Request 34017: Update existing lambdas to meet style guide

2015-05-16 Thread Joris Van Remoortere
;-) - Joris Van Remoortere On May 9, 2015, 7:52 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34017

Re: Review Request 34018: Update existing lambdas to meet style guide

2015-05-16 Thread Joris Van Remoortere
. 2) I re-wrapped the comment to the 70 character boundary. 3) I got rid of the white-space between the closing brackets: ` ` - ``. Yay newer compilers :-) - Joris Van Remoortere On May 9, 2015, 7:52 p.m., haosdent huang wrote

Re: Review Request 33794: Update existing lambdas to meet style guide

2015-05-16 Thread Joris Van Remoortere
bind changes? Thanks! - Joris Van Remoortere On May 3, 2015, 12:12 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33794

Review Request 34371: Add framework's pid to json summary of framework.

2015-05-18 Thread Joris Van Remoortere
, Joris Van Remoortere

Re: Review Request 34442: Support manipulating scheduler affinity on Linux.

2015-05-19 Thread Joris Van Remoortere
/sched_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/34442/diff/ Testing --- Added a test that bounces around on different cores. Thanks, Joris Van Remoortere

Review Request 34442: Support manipulating scheduler affinity on Linux.

2015-05-19 Thread Joris Van Remoortere
: https://reviews.apache.org/r/34442/diff/ Testing --- Added a test that bounces around on different cores. Thanks, Joris Van Remoortere

Re: Review Request 34309: Support manipulating scheduler policy on Linux.

2015-05-19 Thread Joris Van Remoortere
On May 19, 2015, 6:56 p.m., Joris Van Remoortere wrote: Hey Ian, looks good. I have a prototype for testing the pre-emption. I will add some reviews that depend on this patch set, as I will need to introduce sched_affinity first. I've added the test in subsequent reviews: https

Re: Review Request 34442: Support manipulating scheduler affinity on Linux.

2015-05-19 Thread Joris Van Remoortere
queues. Diffs (updated) - src/linux/sched.hpp PRE-CREATION src/tests/sched_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/34442/diff/ Testing --- Added a test that bounces around on different cores. Thanks, Joris Van Remoortere

Re: Review Request 34309: Support manipulating scheduler policy on Linux.

2015-05-19 Thread Joris Van Remoortere
!= 0) { ``` Feel free to ignore, either way works :-) - Joris Van Remoortere On May 18, 2015, 8:48 p.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34309

Re: Review Request 33275: Fix capture by reference of temporaries in Stout.

2015-05-20 Thread Joris Van Remoortere
. To reply, visit: https://reviews.apache.org/r/33275/#review83478 --- On April 22, 2015, 6:11 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 34193: Refactored common functionality into BaseFlags

2015-05-20 Thread Joris Van Remoortere
this is great safe programming :-) - Joris Van Remoortere On May 19, 2015, 10:31 p.m., Marco Massenzio wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34193

Re: Review Request 33271: Update style guide to disallow capturing temporaries by reference.

2015-05-20 Thread Joris Van Remoortere
--- Follow up from r32630. Diffs (updated) - docs/mesos-c++-style-guide.md 13312f6f4fe1788791479bd768f60df0a8e80e69 Diff: https://reviews.apache.org/r/33271/diff/ Testing --- Thanks, Joris Van Remoortere

Re: Review Request 34193: Refactored common functionality into BaseFlags

2015-05-20 Thread Joris Van Remoortere
On May 18, 2015, 10:04 p.m., Joris Van Remoortere wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, line 633 https://reviews.apache.org/r/34193/diff/2/?file=963013#file963013line633 Did you substitute the `std::endl` with `\n\n` on purpose? Why not stay

Re: Review Request 33272: Fix capture by reference of temporary strings in Stout.

2015-05-20 Thread Joris Van Remoortere
/tests/flags_tests.cpp 00281195b53d2597bdb46e3fe6cd9d46a5e9b1f1 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 343f95be7f316170b37c9358627f3c2090f0e29e Diff: https://reviews.apache.org/r/33272/diff/ Testing --- make check Thanks, Joris Van Remoortere

Re: Review Request 33276: Fix capture by reference of temporaries in Libprocess.

2015-05-20 Thread Joris Van Remoortere
3rdparty/libprocess/src/tests/process_tests.cpp 67e582cc250a9767a389e2bd0cc68985477f3ffb 3rdparty/libprocess/src/tests/reap_tests.cpp a18d54c43fba44d084e722abdc67d32e5d4504e4 Diff: https://reviews.apache.org/r/33276/diff/ Testing --- make check Thanks, Joris Van Remoortere

Re: Review Request 33274: Fix capture by reference of temporary strings in Libprocess.

2015-05-20 Thread Joris Van Remoortere
://reviews.apache.org/r/33274/diff/ Testing --- make check Thanks, Joris Van Remoortere

Re: Review Request 33271: Update style guide to disallow capturing temporaries by reference.

2015-05-20 Thread Joris Van Remoortere
13312f6f4fe1788791479bd768f60df0a8e80e69 Diff: https://reviews.apache.org/r/33271/diff/ Testing --- Thanks, Joris Van Remoortere

Re: Review Request 33275: Fix capture by reference of temporaries in Stout.

2015-05-20 Thread Joris Van Remoortere
--- make check Thanks, Joris Van Remoortere

Re: Review Request 34193: Refactored common functionality into BaseFlags

2015-05-20 Thread Joris Van Remoortere
On May 18, 2015, 10:04 p.m., Joris Van Remoortere wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, line 45 https://reviews.apache.org/r/34193/diff/2/?file=963013#file963013line45 It is best practice to make base class constructors protected to prevent

Re: Review Request 35102: Remove common/lock. Use synchronized instead.

2015-06-04 Thread Joris Van Remoortere
988dff524e3d9f6c0bafa3398f6c3c258829cfe3 src/common/lock.cpp bb8ea3ada6b710357e6872959868d2d8a2035371 Diff: https://reviews.apache.org/r/35102/diff/ Testing --- make check Thanks, Joris Van Remoortere

Re: Review Request 34565: Allowed explicitly-defaulted functions in styleguide.

2015-06-02 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34565/#review86179 --- Ship it! Ship It! - Joris Van Remoortere On May 21, 2015, 8:54

Re: Review Request 33271: Update style guide to disallow capturing temporaries by reference.

2015-06-02 Thread Joris Van Remoortere
/mesos-c++-style-guide.md 13312f6f4fe1788791479bd768f60df0a8e80e69 Diff: https://reviews.apache.org/r/33271/diff/ Testing --- Thanks, Joris Van Remoortere

Review Request 35102: Remove common/lock. Use synchronized instead.

2015-06-04 Thread Joris Van Remoortere
bb8ea3ada6b710357e6872959868d2d8a2035371 Diff: https://reviews.apache.org/r/35102/diff/ Testing --- make check Thanks, Joris Van Remoortere

Review Request 35088: Add dependent include to synchronized.

2015-06-04 Thread Joris Van Remoortere
--- Thanks, Joris Van Remoortere

Review Request 35096: Update mesos scheduler to use synchronized.

2015-06-04 Thread Joris Van Remoortere
/35096/diff/ Testing --- Thanks, Joris Van Remoortere

Review Request 35100: Update hook manager to use synchronized.

2015-06-04 Thread Joris Van Remoortere
-2805 https://issues.apache.org/jira/browse/MESOS-2805 Repository: mesos Description --- See summary. Diffs - src/hook/manager.cpp 54b0d34b6e9f2f8a8cf7a6c2f5ded2f6ab6c6955 Diff: https://reviews.apache.org/r/35100/diff/ Testing --- Thanks, Joris Van Remoortere

Review Request 35098: Update module manager to use synchronized.

2015-06-04 Thread Joris Van Remoortere
/35098/diff/ Testing --- Thanks, Joris Van Remoortere

Review Request 35090: Update libprocess process to use synchronized.

2015-06-04 Thread Joris Van Remoortere
Diff: https://reviews.apache.org/r/35090/diff/ Testing --- Thanks, Joris Van Remoortere

Review Request 35094: Update libprocess gate to use synchronized.

2015-06-04 Thread Joris Van Remoortere
-2805 https://issues.apache.org/jira/browse/MESOS-2805 Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/src/gate.hpp 69c906baabbc05fdc33aca94b587fc3c8633f7b6 Diff: https://reviews.apache.org/r/35094/diff/ Testing --- Thanks, Joris Van Remoortere

Review Request 35092: Rebase master_contender_detector_tests with gmock synchronized.

2015-06-04 Thread Joris Van Remoortere
Van Remoortere

Review Request 35101: Update zookeeper tests to use synchronized.

2015-06-04 Thread Joris Van Remoortere
/35101/diff/ Testing --- Thanks, Joris Van Remoortere

Review Request 35095: Update linux fs to use synchronized.

2015-06-04 Thread Joris Van Remoortere
-2805 https://issues.apache.org/jira/browse/MESOS-2805 Repository: mesos Description --- See summary. Diffs - src/linux/fs.cpp 1c9cf3f2ffead37148e4f6a81cefdbb97f679b09 Diff: https://reviews.apache.org/r/35095/diff/ Testing --- Thanks, Joris Van Remoortere

Review Request 35091: Update libprocess gmock to use synchronized.

2015-06-04 Thread Joris Van Remoortere
Van Remoortere

Review Request 35093: Update libprocess once to use synchronized.

2015-06-04 Thread Joris Van Remoortere
Van Remoortere

Review Request 35089: Replace lock_guard with synchronized in fetcher_cache_test.

2015-06-04 Thread Joris Van Remoortere
-2805 https://issues.apache.org/jira/browse/MESOS-2805 Repository: mesos Description --- See summary. Diffs - src/tests/fetcher_cache_tests.cpp cbd44b98d19953d174fac977f509d4900a37481f Diff: https://reviews.apache.org/r/35089/diff/ Testing --- Thanks, Joris Van

Re: Review Request 35097: Update mesos executor to use synchronized.

2015-06-04 Thread Joris Van Remoortere
0dfd5a6a45a9b2dabeee5e402ab1c5e310c24848 Diff: https://reviews.apache.org/r/35097/diff/ Testing --- Thanks, Joris Van Remoortere

Re: Review Request 35102: Remove common/lock. Use synchronized instead.

2015-06-04 Thread Joris Van Remoortere
988dff524e3d9f6c0bafa3398f6c3c258829cfe3 src/common/lock.cpp bb8ea3ada6b710357e6872959868d2d8a2035371 Diff: https://reviews.apache.org/r/35102/diff/ Testing --- make check Thanks, Joris Van Remoortere

Re: Review Request 33271: Update style guide to disallow capturing temporaries by reference.

2015-06-05 Thread Joris Van Remoortere
before the openening parenthesis. - Ben Mahler On June 2nd, 2015, 9:34 a.m. UTC, Joris Van Remoortere wrote: Review request for mesos, Bernd Mathiske, Cody Maloney, Joerg Schad, Michael Park, and Till Toenshoff. By Joris Van Remoortere. *Updated June 2, 2015, 9:34 a.m.* *Bugs: * MESOS

Re: Review Request 35090: Update libprocess process to use synchronized.

2015-06-05 Thread Joris Van Remoortere
79d1719932a3fdc90b6247d3a77adee123e72435 3rdparty/libprocess/src/process.cpp d1b4d469a11abc618c1406bce602300dd9793b58 Diff: https://reviews.apache.org/r/35090/diff/ Testing --- Thanks, Joris Van Remoortere

Review Request 35120: Use non-POD type for alias example in c++ style guide.

2015-06-05 Thread Joris Van Remoortere
Description --- Also got rid of an unused struct. Diffs - docs/mesos-c++-style-guide.md 38dd201a22dd775971fad190378d022c50885969 Diff: https://reviews.apache.org/r/35120/diff/ Testing --- Thanks, Joris Van Remoortere

Re: Review Request 33159: Pump updateFramework through Allocator from Master.

2015-06-05 Thread Joris Van Remoortere
be0db42da3c59761aa154439653d715556465256 src/tests/mesos.hpp 86660ac4d7476bc6cc077fc2d474c4a9ac81c031 Diff: https://reviews.apache.org/r/33159/diff/ Testing --- make check Thanks, Joris Van Remoortere

Re: Review Request 35102: Remove common/lock. Use synchronized instead.

2015-06-05 Thread Joris Van Remoortere
988dff524e3d9f6c0bafa3398f6c3c258829cfe3 src/common/lock.cpp bb8ea3ada6b710357e6872959868d2d8a2035371 Diff: https://reviews.apache.org/r/35102/diff/ Testing --- make check Thanks, Joris Van Remoortere

Re: Review Request 33271: Update style guide to disallow capturing temporaries by reference.

2015-06-05 Thread Joris Van Remoortere
Here is the review. I used std::string instead. Also cleaned up an unused struct. https://reviews.apache.org/r/35120 On Fri, Jun 5, 2015 at 9:58 AM, Joris Van Remoortere joris.van.remoort...@gmail.com wrote: Hey BenM, BenH added spaces before the commit, but thanks for also catching

Review Request 35129: Refactor Future::Data to use ResultT. Remove dynamic allocation.

2015-06-05 Thread Joris Van Remoortere
Thanks, Joris Van Remoortere

Re: Review Request 33159: Pump updateFramework through Allocator from Master.

2015-06-05 Thread Joris Van Remoortere
/master/master.cpp be0db42da3c59761aa154439653d715556465256 src/tests/mesos.hpp 86660ac4d7476bc6cc077fc2d474c4a9ac81c031 Diff: https://reviews.apache.org/r/33159/diff/ Testing --- make check Thanks, Joris Van Remoortere

Re: Review Request 29406: Introduce libevent ssl socket.

2015-06-08 Thread Joris Van Remoortere
3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35 Diff: https://reviews.apache.org/r/29406/diff/ Testing --- make check (uses non-ssl socket) benchmarks using ssl sockets master, slave, framework, webui launch with ssl sockets Thanks, Joris Van Remoortere

Re: Review Request 29406: Introduce libevent ssl socket.

2015-06-09 Thread Joris Van Remoortere
/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35 Diff: https://reviews.apache.org/r/29406/diff/ Testing --- make check (uses non-ssl socket) benchmarks using ssl sockets master, slave, framework, webui launch with ssl sockets Thanks, Joris Van Remoortere

Re: Review Request 34644: Update existing lambdas to meet style guide

2015-06-09 Thread Joris Van Remoortere
commit. 3rdparty/libprocess/src/tests/process_tests.cpp https://reviews.apache.org/r/34644/#comment139465 Comments end with a period '.' - Joris Van Remoortere On June 1, 2015, 5:45 p.m., haosdent huang wrote

Re: Review Request 29406: Introduce libevent ssl socket.

2015-06-08 Thread Joris Van Remoortere
/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35 Diff: https://reviews.apache.org/r/29406/diff/ Testing --- make check (uses non-ssl socket) benchmarks using ssl sockets master, slave, framework, webui launch with ssl sockets Thanks, Joris Van Remoortere

Re: Review Request 32360: Refactor Mutex to use synchronized.

2015-06-03 Thread Joris Van Remoortere
/32360/diff/ Testing --- make check Thanks, Joris Van Remoortere

Review Request 35012: Move synchronized.hpp into stout.

2015-06-03 Thread Joris Van Remoortere
-CREATION Diff: https://reviews.apache.org/r/35012/diff/ Testing --- Thanks, Joris Van Remoortere

Re: Review Request 32362: Refactor Metrics::Timer to use synchronized.

2015-06-03 Thread Joris Van Remoortere
://reviews.apache.org/r/32362/diff/ Testing --- make check Thanks, Joris Van Remoortere

Re: Review Request 32361: Refactor Queue to use synchronized.

2015-06-03 Thread Joris Van Remoortere
/32361/diff/ Testing --- make check Thanks, Joris Van Remoortere

Re: Review Request 32364: Refactor http to use synchronized.

2015-06-03 Thread Joris Van Remoortere
1d318b9b6348eb3768a404d0d390080e7ff40038 Diff: https://reviews.apache.org/r/32364/diff/ Testing --- make check Thanks, Joris Van Remoortere

Re: Review Request 32356: Refactor synchronized to use mutex, recursive_mutex, atomic_flag.

2015-06-03 Thread Joris Van Remoortere
6a341b851d516bcecb2f893fbb5d08a769b09b3a Diff: https://reviews.apache.org/r/32356/diff/ Testing --- make check Thanks, Joris Van Remoortere

Re: Review Request 29406: Introduce libevent ssl socket.

2015-06-09 Thread Joris Van Remoortere
launch with ssl sockets Thanks, Joris Van Remoortere

Re: Review Request 28763: Add configure flag to enable SSL.

2015-06-09 Thread Joris Van Remoortere
710490b2a7c71f35434494e87e2d132f78ef370a Diff: https://reviews.apache.org/r/28763/diff/ Testing --- configure with '--enable-libevent --enable--ssl' and without. Thanks, Joris Van Remoortere

Review Request 35065: Fix uninitialized warning introduced by synchronized patches.

2015-06-04 Thread Joris Van Remoortere
--- This warning was only showing with clang. Diffs - 3rdparty/libprocess/include/process/metrics/timer.hpp 92cef2b920c966ca12b759d3f51665b3e3e8b48e Diff: https://reviews.apache.org/r/35065/diff/ Testing --- make check with clang++-3.6 Thanks, Joris Van Remoortere

Re: Review Request 28763: Add configure flag to enable SSL.

2015-06-09 Thread Joris Van Remoortere
710490b2a7c71f35434494e87e2d132f78ef370a Diff: https://reviews.apache.org/r/28763/diff/ Testing --- configure with '--enable-libevent --enable--ssl' and without. Thanks, Joris Van Remoortere

Re: Review Request 29406: Introduce libevent ssl socket.

2015-06-09 Thread Joris Van Remoortere
://reviews.apache.org/r/29406/diff/ Testing --- make check (uses non-ssl socket) benchmarks using ssl sockets master, slave, framework, webui launch with ssl sockets Thanks, Joris Van Remoortere

Re: Review Request 35841: Fix usage of ATOMIC_FLAG_INIT

2015-06-25 Thread Joris Van Remoortere
. This accomplished both the goal of conforming to the standard as well as maintaining readability! - Joris Van Remoortere On June 25, 2015, 5:27 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 35287: Rename OptionT::get(const T _t) to getOrElse() and refactor original functions (stout)

2015-06-25 Thread Joris Van Remoortere
20, 2015, 4:48 p.m.) Review request for mesos and Joris Van Remoortere. Bugs: MESOS-2800 https://issues.apache.org/jira/browse/MESOS-2800 Repository: mesos Description --- Rename OptionT::get(const T _t) to getOrElse() and refactor original functions (stout

Review Request 35908: Fix ATOMIC_FLAG_INIT typo.

2015-06-25 Thread Joris Van Remoortere
--- See summary. Diffs - 3rdparty/libprocess/src/libevent_ssl_socket.hpp e94e6d5df42bcec96bb837bcd0674c7bb1f019d0 Diff: https://reviews.apache.org/r/35908/diff/ Testing --- Thanks, Joris Van Remoortere

Re: Review Request 35853: Refactor Openssl certificate Subject Alternative Name logic.

2015-06-25 Thread Joris Van Remoortere
and Michael Park. Changes --- rebased. Repository: mesos Description --- See summary. Diffs (updated) - 3rdparty/libprocess/src/openssl.cpp 090e98584acd45d2ee3dcb1c1d09a46287a159e1 Diff: https://reviews.apache.org/r/35853/diff/ Testing --- Thanks, Joris Van

Re: Review Request 35888: clear protocol filters for openssl before initializing.

2015-06-25 Thread Joris Van Remoortere
`SSL_CTX_set_options`. Diffs (updated) - 3rdparty/libprocess/src/openssl.cpp 090e98584acd45d2ee3dcb1c1d09a46287a159e1 Diff: https://reviews.apache.org/r/35888/diff/ Testing --- Thanks, Joris Van Remoortere

Re: Review Request 35852: Error if trying to create SSL socket when SSL is disabled.

2015-06-25 Thread Joris Van Remoortere
, Joris Van Remoortere

Re: Review Request 35854: Add openssl utility functions.

2015-06-25 Thread Joris Van Remoortere
3rdparty/libprocess/src/openssl_util.cpp PRE-CREATION Diff: https://reviews.apache.org/r/35854/diff/ Testing --- Thanks, Joris Van Remoortere

Re: Review Request 35622: Adding a link to example framework implementations (RENDLR)

2015-06-18 Thread Joris Van Remoortere
://reviews.apache.org/r/35622/#comment140951 s/implementations is C++/implementations in C++/ - Joris Van Remoortere On June 18, 2015, 9 p.m., Artem Harutyunyan wrote: --- This is an automatically generated e-mail. To reply, visit: https

Review Request 35974: Fix missing new line in ssl_client.

2015-06-27 Thread Joris Van Remoortere
Description --- See summary. Diffs - 3rdparty/libprocess/src/tests/ssl_client.cpp PRE-CREATION Diff: https://reviews.apache.org/r/35974/diff/ Testing --- Thanks, Joris Van Remoortere

Re: Review Request 35287: Rename OptionT::get(const T _t) to getOrElse() and refactor original functions (stout)

2015-06-18 Thread Joris Van Remoortere
? The same applies for the test below. - Joris Van Remoortere On June 10, 2015, 8:11 a.m., Mark Wang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35287

Re: Review Request 35129: Refactor Future::Data to use ResultT. Remove dynamic allocation.

2015-06-19 Thread Joris Van Remoortere
adfad6faf89a52bf2da90d10a29e3d34502898bd Diff: https://reviews.apache.org/r/35129/diff/ Testing --- make check Thanks, Joris Van Remoortere

Review Request 35962: Add mutable get() to TryT.

2015-06-26 Thread Joris Van Remoortere
--- See summary. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp bf1540bbb58dc1445afdb1bbde9cc7fbb081a879 Diff: https://reviews.apache.org/r/35962/diff/ Testing --- Thanks, Joris Van Remoortere

Re: Review Request 35889: Add SSL tests.

2015-06-26 Thread Joris Van Remoortere
--- make check with --enable-ssl --enable-libevent. Thanks, Joris Van Remoortere

Re: Review Request 35889: Add SSL tests.

2015-06-26 Thread Joris Van Remoortere
-libevent. Thanks, Joris Van Remoortere

Review Request 35955: Update default value for Socket.recv().

2015-06-26 Thread Joris Van Remoortere
--- This was defaulted in the Impl, but not the interface. Diffs - 3rdparty/libprocess/include/process/socket.hpp 96dd6f7f887cd7fbe3057cc676c9f0fbede92e29 Diff: https://reviews.apache.org/r/35955/diff/ Testing --- Thanks, Joris Van Remoortere

Re: Review Request 29406: Introduce libevent ssl socket.

2015-06-11 Thread Joris Van Remoortere
non-ssl socket) benchmarks using ssl sockets master, slave, framework, webui launch with ssl sockets Thanks, Joris Van Remoortere

Re: Review Request 28763: Add configure flag to enable SSL.

2015-06-11 Thread Joris Van Remoortere
710490b2a7c71f35434494e87e2d132f78ef370a Diff: https://reviews.apache.org/r/28763/diff/ Testing --- configure with '--enable-libevent --enable--ssl' and without. Thanks, Joris Van Remoortere

Re: Review Request 29406: Introduce libevent ssl socket.

2015-06-11 Thread Joris Van Remoortere
0e1cebb19e21c706b152d35a0b8722924c971a35 Diff: https://reviews.apache.org/r/29406/diff/ Testing --- make check (uses non-ssl socket) benchmarks using ssl sockets master, slave, framework, webui launch with ssl sockets Thanks, Joris Van Remoortere

Review Request 35463: Fix typos in stout README.

2015-06-15 Thread Joris Van Remoortere
--- See summary. Diffs - 3rdparty/libprocess/3rdparty/stout/README.md 6fc09d6d3cc80c7155a6edc76467c765b160a465 Diff: https://reviews.apache.org/r/35463/diff/ Testing --- Thanks, Joris Van Remoortere

Re: Review Request 35129: Refactor Future::Data to use ResultT. Remove dynamic allocation.

2015-06-14 Thread Joris Van Remoortere
: https://reviews.apache.org/r/35129/diff/ Testing --- make check Thanks, Joris Van Remoortere

Re: Review Request 29406: Introduce libevent ssl socket.

2015-06-13 Thread Joris Van Remoortere
--- make check (uses non-ssl socket) benchmarks using ssl sockets master, slave, framework, webui launch with ssl sockets Thanks, Joris Van Remoortere

Re: Review Request 28763: Add configure flag to enable SSL.

2015-06-13 Thread Joris Van Remoortere
710490b2a7c71f35434494e87e2d132f78ef370a Diff: https://reviews.apache.org/r/28763/diff/ Testing --- configure with '--enable-libevent --enable--ssl' and without. Thanks, Joris Van Remoortere

Re: Review Request 29406: Introduce libevent ssl socket.

2015-06-13 Thread Joris Van Remoortere
/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35 Diff: https://reviews.apache.org/r/29406/diff/ Testing --- make check (uses non-ssl socket) benchmarks using ssl sockets master, slave, framework, webui launch with ssl sockets Thanks, Joris Van Remoortere

Re: Review Request 29406: Introduce libevent ssl socket.

2015-06-13 Thread Joris Van Remoortere
0e1cebb19e21c706b152d35a0b8722924c971a35 Diff: https://reviews.apache.org/r/29406/diff/ Testing --- make check (uses non-ssl socket) benchmarks using ssl sockets master, slave, framework, webui launch with ssl sockets Thanks, Joris Van Remoortere

Re: Review Request 29406: Introduce libevent ssl socket.

2015-06-13 Thread Joris Van Remoortere
/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35 Diff: https://reviews.apache.org/r/29406/diff/ Testing --- make check (uses non-ssl socket) benchmarks using ssl sockets master, slave, framework, webui launch with ssl sockets Thanks, Joris Van Remoortere

  1   2   3   4   5   6   7   8   9   10   >