On July 6, 2015, 11:39 a.m., Joseph Wu wrote:
docs/mesos-doxygen-style-guide.md, line 102
https://reviews.apache.org/r/36193/diff/1/?file=999588#file999588line102
This isn't part of the diff, but should this `@note` tag be replaced
with a `**NOTE:**`?
Joerg Schad wrote
://reviews.apache.org/r/36193/#comment143651
It might be worthwhile to emphasize that markdown syntax can/should be used
in with the comment blocks. I think Javadocs generally use plain HTML for
links, tables, etc.
- Joseph Wu
On July 6, 2015, 2:01 a.m., Joerg Schad wrote
-checked conversion of Path to string.
Thanks,
Joseph Wu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37280/#review95168
---
Ship it!
Ship It!
- Joseph Wu
On Aug. 10, 2015, 12:05 a.m
/37284/#comment150020
This `continue` seems extraneous.
src/master/master.cpp (line 3162)
https://reviews.apache.org/r/37284/#comment150019
Is this `continue` necessary?
(Same question for the other instances below.)
- Joseph Wu
On Aug. 10, 2015, 12:06 a.m., Joris Van
JIRAs,
see MESOS-1474).
Diffs (updated)
-
include/mesos/mesos.proto 8a423a56a341e380434e7df91868f1813024840c
Diff: https://reviews.apache.org/r/36321/diff/
Testing
---
`make check`
Thanks,
Joseph Wu
to
https://reviews.apache.org/r/36321/ .
- Joseph Wu
On Aug. 10, 2015, 12:05 a.m., Joris Van Remoortere wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37234
/master/master.cpp (lines 4795 - 4796)
https://reviews.apache.org/r/37180/#comment150011
This second sentence might be better placed in the InverseOffer protobuf.
src/master/master.cpp (line 5667)
https://reviews.apache.org/r/37180/#comment150014
`callled`
- Joseph Wu
On Aug. 10, 2015
[frameworkId]` always undefined?
- Joseph Wu
On Aug. 10, 2015, 12:05 a.m., Joris Van Remoortere wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37177
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37282/#review95179
---
Ship it!
Ship It!
- Joseph Wu
On Aug. 10, 2015, 12:06 a.m
=\${GMOCK_CONFIG_CXXFLAGS}\
^ ^ ^
```
- Joseph Wu
On Aug. 15, 2015, 5:07 a.m., haosdent huang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37502
://reviews.apache.org/r/37172/#comment151021
s/machines/machine_infos/
- Joseph Wu
On Aug. 18, 2015, 11:57 a.m., Joris Van Remoortere wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37172
(line 478)
https://reviews.apache.org/r/37175/#comment150913
Why is this return type `Nothing`, instead of `void`?
- Joseph Wu
On Aug. 18, 2015, 11:57 a.m., Joris Van Remoortere wrote:
---
This is an automatically generated e-mail
://reviews.apache.org/r/37180/#comment150914
Typo still present.
- Joseph Wu
On Aug. 18, 2015, 11:58 a.m., Joris Van Remoortere wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37180
://reviews.apache.org/r/37170/#comment150904
Note: There might be a rebase conflict with
https://reviews.apache.org/r/37314/diff/4#3 since both have the same text.
- Joseph Wu
On Aug. 18, 2015, 11:57 a.m., Joris Van Remoortere wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37173/#review95782
---
Ship it!
LGTM
- Joseph Wu
On Aug. 18, 2015, 11:57 a.m., Joris
with
Duration.
Diffs
-
include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193
Diff: https://reviews.apache.org/r/37655/diff/
Testing
---
`make check`
Thanks,
Joseph Wu
---
On Aug. 12, 2015, 3:07 p.m., Joseph Wu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36321
(that part is tracked in separate JIRAs,
see MESOS-1474).
Diffs (updated)
-
include/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193
Diff: https://reviews.apache.org/r/36321/diff/
Testing
---
`make check`
Thanks,
Joseph Wu
be misleading for
users.
Joseph Wu wrote:
A while ago, I posted a few diffs where this object was called `Interval`
(https://reviews.apache.org/r/36321/diff/7/). The reason why it was changed
back to `Unavailability` is that we may wish to extend this object to be more
specific
9fd71d1ddf442712977596e7a13969ff5c1d68db
src/master/registry.proto a1995e56886f5296bc71d1bdfebec0d8316396c6
Diff: https://reviews.apache.org/r/36571/diff/
Testing
---
`make check`
Thanks,
Joseph Wu
lists.
Schedules some machines. Deactivates some. Tests some valid and invalid
lists.
Checks that the schedule is modified.
Thanks,
Joseph Wu
with some valid and invalid schedules.
Only tests a subset of invalid schedules (requires other endpoints to fully
test).
Thanks,
Joseph Wu
:
MasterMaintenanceTest.FailToUnscheduleDeactivatedMachines
Extra test case for the /maintenance.schedule endpoint, which requires all
three endpoints to work.
MasterMaintenanceTest.MachineStatus
Schedules, starts, and stops maintenance. Checks machine statuses after
each step.
Thanks,
Joseph Wu
On Aug. 12, 2015, 10:31 a.m., Joseph Wu wrote:
src/master/maintenance.cpp, lines 126-130
https://reviews.apache.org/r/37325/diff/2/?file=1037747#file1037747line126
Note: Considering the machine field in the master's local state
(https://reviews.apache.org/r/37170/diff/2#0.8
,
Joseph Wu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37177/#review95785
---
Ship it!
Ship It!
- Joseph Wu
On Aug. 18, 2015, 11:57 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37283/#review95788
---
Ship it!
Ship It!
- Joseph Wu
On Aug. 18, 2015, 11:58 a.m
3rdparty/libprocess/3rdparty/stout/include/stout/windows/thread.hpp
PRE-CREATION
Diff: https://reviews.apache.org/r/36625/diff/
Testing
---
`make` and `make check` (Mac OSX)
Thanks,
Joseph Wu
`typename...` .
Diffs (updated)
-
3rdparty/libprocess/include/process/help.hpp
316ed21b5300496f283d0c331fa6d9dad441d332
Diff: https://reviews.apache.org/r/36865/diff/
Testing
---
`make check`
Thanks,
Joseph Wu
[thanks to Alex (hausdorff)].
Thanks,
Joseph Wu
.)
Review request for mesos, Joris Van Remoortere, Joseph Wu, and Till Toenshoff.
Bugs: MESOS-830
https://issues.apache.org/jira/browse/MESOS-830
Repository: mesos
Description
---
Fix flaky ExamplesTest.JavaFramework
Diffs
-
src/examples/java/TestFramework.java
:
https://issues.apache.org/jira/browse/MESOS-3264
Since this change makes the test less flaky, I say it LGTM.
- Joseph Wu
On Aug. 13, 2015, 9:49 a.m., Greg Mann wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
:
https://issues.apache.org/jira/browse/MESOS-3264
Since this change makes the test less flaky, I say it LGTM.
- Joseph Wu
On Aug. 13, 2015, 9:56 p.m., Greg Mann wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
to pass the new schedule info along.
Instead, I think adding another method for passing unavailabilities along
would be better. We could call that method after agent registration or after
hitting the maintenance endpoints.
- Joseph Wu
On Aug. 10, 2015, 12:05 a.m., Joris Van
On Aug. 12, 2015, 12:01 p.m., Joseph Wu wrote:
include/mesos/master/allocator.hpp, lines 96-101
https://reviews.apache.org/r/37173/diff/2/?file=1035790#file1035790line96
I'm not convinced that `addSlave` is the appropriate place to pass the
unavailability
3649)
https://reviews.apache.org/r/37170/#comment149936
Ditto.
src/master/master.cpp (line 3855)
https://reviews.apache.org/r/37170/#comment149938
Ditto.
- Joseph Wu
On Aug. 10, 2015, 12:04 a.m., Joris Van Remoortere wrote
=
Druation::create(unavailability.get().duration());`
- Joseph Wu
On Aug. 10, 2015, 12:05 a.m., Joris Van Remoortere wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37175
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37176/#review95160
---
Ship it!
Ship It!
- Joseph Wu
On Aug. 10, 2015, 12:05 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36783/#review94159
---
On July 29, 2015, 4:24 p.m., Joseph Wu wrote:
---
This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36829/#review93144
---
Ship it!
Ship It!
- Joseph Wu
On July 27, 2015, 12:11 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36842/#review93146
---
Ship it!
Ship It!
- Joseph Wu
On July 27, 2015, 12:19 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36830/#review93145
---
Ship it!
Ship It!
- Joseph Wu
On July 27, 2015, 12:17 a.m
/thread_local.hpp (line 25)
https://reviews.apache.org/r/36845/#comment147404
`TLS` might be a bit too short for readable code. (And people that google
it will come up with Transport Layer Security, instead of Thread Local Storage.)
Maybe `THREAD_LOCAL` would be better.
- Joseph Wu
On July 27
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36844/#review93187
---
Ship it!
Ship It!
- Joseph Wu
On July 27, 2015, 2:15 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36674/#review92804
---
Ship it!
Ship It!
- Joseph Wu
On July 21, 2015, 10:56 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36629/#review92800
---
Ship it!
- Joseph Wu
On July 22, 2015, 12:07 p.m., Michael Park
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36673/#review92802
---
Ship it!
Ship It!
- Joseph Wu
On July 21, 2015, 10:55 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36672/#review92801
---
Ship it!
Ship It!
- Joseph Wu
On July 21, 2015, 9:07 p.m
/libprocess/3rdparty/stout/include/stout/linux/abort.hpp PRE-CREATION
3rdparty/libprocess/3rdparty/stout/include/stout/windows/abort.hpp
PRE-CREATION
Diff: https://reviews.apache.org/r/36625/diff/
Testing
---
`make` and `make check`
Thanks,
Joseph Wu
) {
...
}
```
- Joseph Wu
On July 23, 2015, 10:26 a.m., Anand Mazumdar wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36733/
---
(Updated
-CREATION
Diff: https://reviews.apache.org/r/36625/diff/
Testing
---
`make` and `make check` (Mac OSX)
Thanks,
Joseph Wu
- 4143)
https://reviews.apache.org/r/37175/#comment151700
Should be possible to do something like:
```
Duration start = Seconds(unavailability.get().start().seconds()) +
Nanoseconds(unavailability.get().start().nanoseconds());
LOG(INFO) ... start.secs();
```
- Joseph Wu
.
Thanks,
Joseph Wu
invalid lists.
Schedules some machines. Deactivates some. Tests some valid and invalid
lists.
Checks that the schedule is modified.
Thanks,
Joseph Wu
endpoint with some valid and invalid schedules.
Only tests a subset of invalid schedules (requires other endpoints to fully
test).
Thanks,
Joseph Wu
(line 258)
https://reviews.apache.org/r/37172/#comment151695
Might need a `static_castint64_t` here.
src/tests/master_maintenance_tests.cpp (line 277)
https://reviews.apache.org/r/37172/#comment151694
Should be changed to an int comparison.
- Joseph Wu
On Aug. 24, 2015, 7:12 p.m
---
On Aug. 24, 2015, 12:08 p.m., Joseph Wu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37362
in this chain.
Diffs (updated)
-
src/tests/hierarchical_allocator_tests.cpp
9748ca0b3fee25dcec51c64d8ba84dbd4aaf
Diff: https://reviews.apache.org/r/37582/diff/
Testing
---
`make check`
Thanks,
Joseph Wu
---
Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2
Checked for markdown correctness.
Thanks,
Joseph Wu
/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf
Diff: https://reviews.apache.org/r/37314/diff/
Testing
---
`make check`
Thanks,
Joseph Wu
.
Repository: mesos
Description
---
Some refactoring in https://reviews.apache.org/r/36763 missed these lines.
Diffs
-
include/mesos/slave/isolator.hpp 970730f0ffc7f3359685ccf81452856bea1c4a06
Diff: https://reviews.apache.org/r/37729/diff/
Testing
---
`make check`
Thanks,
Joseph
`
Thanks,
Joseph Wu
correctness.
Thanks,
Joseph Wu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36571/#review96301
---
On Aug. 24, 2015, 11:33 a.m., Joseph Wu wrote
---
On Aug. 24, 2015, 11:26 a.m., Joseph Wu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36321/
---
(Updated
/mesos/mesos.proto 33e1b28f1ccbe227657a14395f81df20e0a9e193
include/mesos/v1/mesos.proto 382b978dca769757171c5558b7f259870592c321
Diff: https://reviews.apache.org/r/36321/diff/
Testing
---
`make check`
Thanks,
Joseph Wu
. Removes machines.
MasterMaintenanceTest.UpdateSchedule
Hits the new endpoint with some valid and invalid schedules.
Only tests a subset of invalid schedules (requires other endpoints to fully
test).
Thanks,
Joseph Wu
:
MasterMaintenanceTest.FailToUnscheduleDeactivatedMachines
Extra test case for the /maintenance.schedule endpoint, which requires all
three endpoints to work.
MasterMaintenanceTest.MachineStatus
Schedules, starts, and stops maintenance. Checks machine statuses after
each step.
Thanks,
Joseph Wu
://reviews.apache.org/r/37358/#review96309
---
On Aug. 24, 2015, 11:54 a.m., Joseph Wu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37358
oto 8131778fe5c5f3a47ae9300a811e3d857a22da6a
Diff: https://reviews.apache.org/r/39502/diff/
Testing (updated)
---
`make`
For now, this review is meant for checking which of these differences are
intentional.
Thanks,
Joseph Wu
le name. Seems
like you're describing the `max_alphabet_index`.
3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/mkdtemp.hpp (lines
62 - 74)
<https://reviews.apache.org/r/39559/#comment161908>
If you use `strings::endsWith` above, you won't need this validation.
- Josep
his function body different than all the other alias-like functions?
i.e. You could comment that stout/mktemp needs an open file, or similar.
- Joseph Wu
On Oct. 21, 2015, 8:35 p.m., Alex Clemmer wrote:
>
> ---
> Thi
/libprocess/3rdparty/stout/include/stout/os/constants.hpp (line 19)
<https://reviews.apache.org/r/39383/#comment161896>
We usually write constants like this:
```
const std::string DIRECTORY_SEPARATOR = "/";
```
- Joseph Wu
On Oct. 22, 2015, 10:40 a.m., Al
/libprocess/3rdparty/stout/include/stout/os/getcwd.hpp (line 17)
<https://reviews.apache.org/r/39540/#comment161891>
This isn't used, is it?
- Joseph Wu
On Oct. 21, 2015, 8:36 p.m., Alex Clemmer wrote:
>
> ---
> This is a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39541/#review103802
---
Ship it!
Confirmed that `chdir` logic is unchanged.
- Joseph Wu
duler.hpp and
> v1/scheduler/scheduler.proto. Where necessary, some notes were added about
> the backwards compatibility of messages which are not instantiated in the
> code base.
>
>
> Diffs
> -
>
> src/messages/messages.proto ea9a67e169a8a359a12be93b804783c7dcced0b7
>
> Diff: https://reviews.apache.org/r/39457/diff/
>
>
> Testing
> ---
>
> None. (Comment change only)
>
>
> Thanks,
>
> Joseph Wu
>
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39538/#review103698
---
Ship it!
Confirmed that touch logic did not change.
- Joseph Wu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39620/#review104077
---
Ship it!
Ship It!
- Joseph Wu
On Oct. 24, 2015, 9:32 a.m
review.
Thanks,
Joseph Wu
nks,
Joseph Wu
;https://reviews.apache.org/r/38705/#comment162313>
Nit: Extra space after function name.
- Joseph Wu
On Oct. 22, 2015, 11:16 p.m., Artem Harutyunyan wrote:
>
> ---
> This is an automatically generated e-mail. To rep
84/#comment162261>
Nit: Errors don't end with periods. Ditto for the other error messages.
3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp (line 134)
<https://reviews.apache.org/r/39584/#comment162265>
You seem to be missing an `if (recursive)` here...
- Josep
cf8aac383d6c6ec875b34af0460120ff521ce20e
Diff: https://reviews.apache.org/r/39499/diff/
Testing
---
```
../configure --enable-ssl --enable-libevent
make check
```
Thanks,
Joseph Wu
, like the original `SSLTest`.
Diffs (updated)
-
3rdparty/libprocess/include/process/ssl/gtest.hpp
91991f509e480a94de00c6bf20ff0abf083dda8a
Diff: https://reviews.apache.org/r/39501/diff/
Testing
---
```
../configure --enable-ssl --enable-libevent
make check
```
Thanks,
Joseph Wu
-test, rather than per-test-class basis.
Thanks,
Joseph Wu
: https://reviews.apache.org/r/39534/diff/
Testing
---
```
../configure
make check
```
```
../configure --enable-ssl --enable-libevent
make check
```
Thanks,
Joseph Wu
the issue I had with this line in the
previous review.
support/apply-reviews.py (line 41)
<https://reviews.apache.org/r/38883/#comment162326>
Seems like this could go into the previous review. Same for the next 2
commenting changes/additions.
- Joseph Wu
On Oct. 22, 2015,
> On Oct. 26, 2015, 1:43 p.m., Joseph Wu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp,
> > lines 35-40
> > <https://reviews.apache.org/r/39584/diff/2/?file=1105044#file1105044line35>
> >
> > Use `strings::endsWit
ly, visit:
https://reviews.apache.org/r/39502/#review103456
---
On Oct. 20, 2015, 6:04 p.m., Joseph Wu wrote:
>
> ---
> This is an automatically generated e-mail. To rep
check
```
Note: Only the tests will call `reinitialize`.
Thanks,
Joseph Wu
that section from
this: https://reviews.apache.org/r/39502 ).
- Joseph Wu
On Oct. 21, 2015, 5:35 p.m., Connor Doyle wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
slower, by a few dozen ms per test, since SetUp happens on a
per-test, rather than per-test-class basis.
Thanks,
Joseph Wu
---
```
../configure --enable-ssl --enable-libevent
make check
```
Thanks,
Joseph Wu
-
src/tests/containerizer/provisioner_docker_tests.cpp
01d3025f59d4a2714a856fe0f3a57192be023990
Diff: https://reviews.apache.org/r/39499/diff/
Testing
---
```
../configure --enable-ssl --enable-libevent
make check
```
Thanks,
Joseph Wu
.
3rdparty/libprocess/3rdparty/stout/include/stout/os/utime.hpp (lines 17 - 21)
<https://reviews.apache.org/r/39537/#comment161674>
Nit: Can you flip the `#ifndef`? No need to negate the conditional if
there's an `#else`.
- Joseph Wu
On Oct. 21, 2015, 8:35 p.m., Alex Clemmer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39851/#review105926
---
Ship it!
Double-checked non-Windows build.
- Joseph Wu
On Nov
The tree structure of the reviews is intentional (at the moment).
It's currently roughly split into components like:
/ Registrar / POST
Protobufs - /quota endpoint - Authentication
\ Allocator \ \ GET
\- DELETE
~Joseph
On Tue, Nov 10,
describing this helper) about how
`validateQuotaRequest` will always set the role? Otherwise, it looks like
you're checking one optional field, but not this one.
- Joseph Wu
On Nov. 10, 2015, 4:56 a.m., Jan Schlicht wrote:
>
> --
> On Nov. 5, 2015, 4:39 p.m., Joseph Wu wrote:
> > src/tests/master_quota_tests.cpp, lines 110-112
> > <https://reviews.apache.org/r/38956/diff/8/?file=1114104#file1114104line110>
> >
> > The resource string you have is equivalent to the resource s
1 - 100 of 2780 matches
Mail list logo