Re: Review Request 32140: Enabled 'Resources' to handle 'Resource::ReservationInfo'.

2015-04-23 Thread Michael Park
--- make check Thanks, Michael Park

Re: Review Request 33527: Updated documentation for ClangFormat.

2015-04-26 Thread Michael Park
: https://reviews.apache.org/r/33527/diff/ Testing (updated) --- Thanks, Michael Park

Re: Review Request 32150: Enabled the master to handle reservation operations.

2015-04-28 Thread Michael Park
without a principal reserve resources (the answer is no, I suppose, because in the current desgin a principal register resources, not a framework)? DO you mind adding tests for these cases? Michael Park wrote: Thanks for this! Fixed and added a test

Re: Review Request 32150: Enabled the master to handle reservation operations.

2015-04-28 Thread Michael Park
/master_validation_tests.cpp 4f2ad58c3ae0f611fb476c4d91a37dd6a5541395 Diff: https://reviews.apache.org/r/32150/diff/ Testing --- make check Thanks, Michael Park

Re: Review Request 32150: Enabled the master to handle reservation operations.

2015-05-01 Thread Michael Park
On April 8, 2015, 10:38 p.m., Jie Yu wrote: src/master/validation.cpp, lines 581-584 https://reviews.apache.org/r/32150/diff/5/?file=920955#file920955line581 Is this necessary, or will be captured by the resources contains check later? Michael Park wrote: It probably

Re: Review Request 29748: Added tests for dynamic reservation.

2015-05-01 Thread Michael Park
://reviews.apache.org/r/29748/diff/ Testing --- make check Thanks, Michael Park

Re: Review Request 29748: Added tests for dynamic reservation.

2015-05-01 Thread Michael Park
generated e-mail. To reply, visit: https://reviews.apache.org/r/29748/#review81298 --- On May 2, 2015, 4:14 a.m., Michael Park wrote: --- This is an automatically generated e-mail

Re: Review Request 32150: Enabled the master to handle reservation operations.

2015-05-01 Thread Michael Park
https://reviews.apache.org/r/32150/diff/8/?file=944524#file944524line598 No snake_case please:) Also, instead of using a boolean, can you pass an Optionstring principal as you did in `validate(reserve)`? Michael Park wrote: No snake_case please:) Grr

Re: Review Request 32150: Enabled the master to handle reservation operations.

2015-05-01 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32150/#review82045 --- On May 2, 2015, 12:27 a.m., Michael Park wrote

Re: Review Request 29748: Added tests for dynamic reservation.

2015-05-01 Thread Michael Park
;ports:[]` resources, while expect `cpus:1;mem:512` in the offer. Michael Park wrote: The slave resources are specified as `cpus:1;mem:512;disk:0;ports:[]` because we use `Containerizer::resources` to parse the string which tries to prove the OS for a value if unspecified. In these test

Re: Review Request 32150: Enabled the master to handle reservation operations.

2015-05-01 Thread Michael Park
dc25995bf57397d42fcde458414f0402d19bf792 src/tests/master_validation_tests.cpp 4f2ad58c3ae0f611fb476c4d91a37dd6a5541395 Diff: https://reviews.apache.org/r/32150/diff/ Testing --- make check Thanks, Michael Park

Re: Review Request 29748: Added tests for dynamic reservation.

2015-05-01 Thread Michael Park
93c7c8a807a33ab639be6289535bbd32022aa85b src/tests/reservation_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/29748/diff/ Testing --- make check Thanks, Michael Park

Re: Review Request 29748: Added tests for dynamic reservation.

2015-05-01 Thread Michael Park
/tests/reservation_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/29748/diff/ Testing --- make check Thanks, Michael Park

Re: Review Request 32149: Enabled 'Resources::apply' to handle reservation operations.

2015-05-01 Thread Michael Park
if each resource is dynamically reserved (i.e., has ReservationInfo, role != `*`)? Michael Park wrote: Both of the checks you mentioned are checked by ``` OptionError master::validation::operation::validate( const Offer::Operation::Reserve reserve, const

Re: Review Request 32149: Enabled 'Resources::apply' to handle reservation operations.

2015-05-01 Thread Michael Park
/tests/resources_tests.cpp 7e0ad98c3366f647f190363a0e6b576dbfc7d415 Diff: https://reviews.apache.org/r/32149/diff/ Testing --- make check Thanks, Michael Park

Re: Review Request 29748: Added tests for dynamic reservation.

2015-05-01 Thread Michael Park
/tests/reservation_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/29748/diff/ Testing --- make check Thanks, Michael Park

Re: Review Request 29748: Added tests for dynamic reservation.

2015-05-01 Thread Michael Park
://reviews.apache.org/r/29748/diff/ Testing --- make check Thanks, Michael Park

Re: Review Request 32139: Added 'Resource::ReservationInfo' protobuf message.

2015-04-27 Thread Michael Park
otherwise. - Michael --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32139/#review81457 --- On April 27, 2015, 5:15 p.m., Michael Park wrote

Re: Review Request 32140: Enabled 'Resources' to handle 'Resource::ReservationInfo'.

2015-04-27 Thread Michael Park
/resources_tests.cpp 7e0ad98c3366f647f190363a0e6b576dbfc7d415 Diff: https://reviews.apache.org/r/32140/diff/ Testing --- make check Thanks, Michael Park

Re: Review Request 32150: Enabled the master to handle reservation operations.

2015-04-29 Thread Michael Park
/#review82045 --- On April 28, 2015, 10:43 p.m., Michael Park wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32150

Re: Review Request 32150: Enabled the master to handle reservation operations.

2015-04-28 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32150/#review81139 --- On April 27, 2015, 10:10 p.m., Michael Park wrote: --- This is an automatically

Re: Review Request 32150: Enabled the master to handle reservation operations.

2015-04-28 Thread Michael Park
-mail. To reply, visit: https://reviews.apache.org/r/32150/#review79442 --- On April 27, 2015, 10:10 p.m., Michael Park wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 32150: Enabled the master to handle reservation operations.

2015-04-28 Thread Michael Park
--- On April 27, 2015, 10:10 p.m., Michael Park wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32150

Re: Review Request 32140: Enabled 'Resources' to handle 'Resource::ReservationInfo'.

2015-05-08 Thread Michael Park
|cpp}`: https://reviews.apache.org/r/31904/. I think we should do the same here for consistency (most probably in a separate RR). Also, one more point to extract these out to `type_utils`. Michael Park wrote: Hm, I actually missed that review request. That pattern of comparisons

Re: Review Request 32982: Added reservation user guide.

2015-05-08 Thread Michael Park
., Michael Park wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32982/ --- (Updated May 8, 2015, 6:57 p.m.) Review request

Re: Review Request 29748: Added tests for dynamic reservation.

2015-05-09 Thread Michael Park
On April 23, 2015, 1:48 p.m., Michael Park wrote: As of now, the tests seem to take a long time to complete. We should investigate what the issue is before committing this patch. Jie Yu wrote: I suspect this is due to the default allocation interval (1 secs by default). Jie Yu

Re: Review Request 31667: Piped hashmapSlaveID, Resources from allocator through to sorter.

2015-05-09 Thread Michael Park
/sorter.hpp e2efb27b11dbea42dd73f81e5db0d6d2b0a6034b src/tests/sorter_tests.cpp 42442353afe7bd3d1a5b43992f8ae191ac19bdcd Diff: https://reviews.apache.org/r/31667/diff/ Testing --- make check Thanks, Michael Park

Re: Review Request 32398: Persisted the reservation state on the slave.

2015-05-11 Thread Michael Park
/common/resources_utils.cpp fe04d57227fa193d6d11d2f76529c46aea74c6a1 src/tests/reservation_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/32398/diff/ Testing --- make check Thanks, Michael Park

Re: Review Request 32398: Persisted the reservation state on the slave.

2015-05-11 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32398/#review79445 --- On May 11, 2015, 8:36 p.m., Michael Park wrote: --- This is an automatically generated e

Re: Review Request 32398: Persisted the reservation state on the slave.

2015-05-11 Thread Michael Park
235930ff2dbb3ea49a3a0696dc070f2bd56fba4b src/common/resources_utils.cpp fe04d57227fa193d6d11d2f76529c46aea74c6a1 src/tests/reservation_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/32398/diff/ Testing --- make check Thanks, Michael Park

Re: Review Request 32398: Persisted the reservation state on the slave.

2015-05-11 Thread Michael Park
/resources_utils.cpp fe04d57227fa193d6d11d2f76529c46aea74c6a1 src/tests/reservation_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/32398/diff/ Testing --- make check Thanks, Michael Park

Re: Review Request 29748: Added tests for dynamic reservation.

2015-05-12 Thread Michael Park
/reservation_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/29748/diff/ Testing --- make check Thanks, Michael Park

Re: Review Request 32398: Persisted the reservation state on the slave.

2015-05-12 Thread Michael Park
/common/resources_utils.cpp fe04d57227fa193d6d11d2f76529c46aea74c6a1 src/tests/reservation_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/32398/diff/ Testing --- make check Thanks, Michael Park

Re: Review Request 29748: Added tests for dynamic reservation.

2015-05-12 Thread Michael Park
/reservation_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/29748/diff/ Testing --- make check Thanks, Michael Park

Re: Review Request 33271: Update style guide to disallow capturing temporaries by reference.

2015-05-12 Thread Michael Park
! docs/mesos-c++-style-guide.md https://reviews.apache.org/r/33271/#comment134451 Perhaps `s/temporaries/*temporaries*/` to emphasize that it's only temporaries that we disallow? - Michael Park On April 29, 2015, 9:34 p.m., Joris Van Remoortere wrote

Re: Review Request 29748: Added tests for dynamic reservation.

2015-05-12 Thread Michael Park
. To reply, visit: https://reviews.apache.org/r/29748/#review83313 --- On May 12, 2015, 5:13 p.m., Michael Park wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 32982: Added reservation user guide.

2015-05-13 Thread Michael Park
the master endpoints as it gets more solified. The purpose of including it was/is to get initial feedback on how it generally works. Diffs - docs/reservation.md PRE-CREATION Diff: https://reviews.apache.org/r/32982/diff/ Testing --- Documentation. Thanks, Michael Park

Re: Review Request 34016: Change the type of signaledWrapper to unique_ptr

2015-05-13 Thread Michael Park
On May 11, 2015, 10:19 p.m., Ben Mahler wrote: src/slave/slave.cpp, line 155 https://reviews.apache.org/r/34016/diff/1/?file=954524#file954524line155 unique_ptr is not a POD, so this will still try to run the destructor of the function during exit of the program. Can

Re: Review Request 32398: Persisted the reservation state on the slave.

2015-05-13 Thread Michael Park
., Michael Park wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32398/ --- (Updated May 12, 2015, 6:44 p.m.) Review request

Review Request 34375: Removed use of namespace aliases.

2015-05-18 Thread Michael Park
://reviews.apache.org/r/34375/diff/ Testing --- make check Thanks, Michael Park

Re: Review Request 33271: Update style guide to disallow capturing temporaries by reference.

2015-05-20 Thread Michael Park
)); // Try to use the alias, we segfault here. std::cout *elem std::endl; } ``` - Michael Park On May 20, 2015, 9:28 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 34193: Refactored common functionality into BaseFlags

2015-05-20 Thread Michael Park
On May 18, 2015, 10:04 p.m., Joris Van Remoortere wrote: 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp, line 511 https://reviews.apache.org/r/34193/diff/2/?file=963014#file963014line511 Since we're in an implementation file, we can `using std::ostringstream;` and then

Re: Review Request 33276: Fix capture by reference of temporaries in Libprocess.

2015-05-20 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33276/#review84620 --- Ship it! Ship It! - Michael Park On May 20, 2015, 10:36 p.m

Re: Review Request 35703: Set refuse seconds on the correct filter in reservation test.

2015-06-22 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35703/#review88784 --- On June 20, 2015, 8:51 p.m., Michael Park wrote

Re: Review Request 35702: [WIP] Added /reserve HTTP endpoint to the master.

2015-06-22 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/#review88760 --- On June 22, 2015, 5:29 a.m., Michael Park wrote

Re: Review Request 35714: Added a new HTTP response type: PreconditionFailed.

2015-06-22 Thread Michael Park
--- On June 22, 2015, 5:08 a.m., Michael Park wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35714/ --- (Updated June 22

Re: Review Request 35701: Minor formatting cleanup in the Master.

2015-06-22 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35701/#review88821 --- On June 20, 2015, 8 p.m., Michael Park wrote: --- This is an automatically

Re: Review Request 35697: mesos: Fixed test names.

2015-06-22 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35697/#review88840 --- On June 20, 2015, 7:14 p.m., Michael Park wrote

Review Request 35715: Added revocable resource state validation.

2015-06-21 Thread Michael Park
)` Diffs - src/common/resources.cpp eb5476a0365fe65f474afd0ab7a52ad7f1e04521 src/tests/resources_tests.cpp 9f96b14a6a4ce416d044934dd7ab4d28e4bc7332 Diff: https://reviews.apache.org/r/35715/diff/ Testing --- `make check` Thanks, Michael Park

Re: Review Request 35717: Add reservations support to master's state.json

2015-06-21 Thread Michael Park
/http.cpp (line 88) https://reviews.apache.org/r/35717/#comment141259 `s/key/role/` src/master/http.cpp (line 234) https://reviews.apache.org/r/35717/#comment141260 This is a bug from before, we should use `slave.totalResources` here instead. - Michael Park On June 21, 2015, 5:35 p.m

Re: Review Request 35702: [WIP] Added /reserve HTTP endpoint to the master.

2015-06-21 Thread Michael Park
9157ac079808d2686592e54ea26a26e6a0825ed3 src/tests/reserve_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/35702/diff/ Testing --- Added `src/tests/reserve_tests.cpp` which still need to be fleshed out for error cases (missing parameters, unauthorized client, etc). Thanks, Michael Park

Re: Review Request 35714: Added a new HTTP response type: PreconditionFailed.

2015-06-21 Thread Michael Park
/cram_md5_authentication_tests.cpp 9d15b55f881aaecba32c8ce0afa6fa1ccd236e21 Diff: https://reviews.apache.org/r/35714/diff/ Testing --- `make check` Thanks, Michael Park

Re: Review Request 35702: [WIP] Added /reserve HTTP endpoint to the master.

2015-06-21 Thread Michael Park
/reserve_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/35702/diff/ Testing --- Added `src/tests/reserve_tests.cpp`. Thanks, Michael Park

Re: Review Request 35702: [WIP] Added /reserve HTTP endpoint to the master.

2015-06-21 Thread Michael Park
9157ac079808d2686592e54ea26a26e6a0825ed3 src/tests/reserve_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/35702/diff/ Testing --- Added `src/tests/reserve_tests.cpp`. Thanks, Michael Park

Re: Review Request 35680: Added Sorter::allocation() overload for getting resources of a particular slave.

2015-06-19 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35680/#review88619 --- Ship it! Ship It! - Michael Park On June 20, 2015, 1:04 a.m

Review Request 35686: Change the if statement to a CHECK at the end of _runTask.

2015-06-19 Thread Michael Park
--- Follow-up from [r35433](https://reviews.apache.org/r/35433/#comment141187). Diffs - src/slave/slave.cpp e73913b072e323033a81e64b5345cb9457137e3e Diff: https://reviews.apache.org/r/35686/diff/ Testing --- `make check` Thanks, Michael Park

Re: Review Request 35433: Sent StatusUpdates if checkpointed resources don't exist on the slave.

2015-06-19 Thread Michael Park
for this. - Michael --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35433/#review88595 --- On June 19, 2015, 2:31 p.m., Michael Park wrote

Re: Review Request 35717: Add reservations support to master's state.json

2015-06-21 Thread Michael Park
://reviews.apache.org/r/35717/#comment141263 No need to make a copy here. If we just want a shorter name, let's alias it with a const-ref. `const Resources totalResources = slave.totalResources;` - Michael Park On June 21, 2015, 6:07 p.m., haosdent huang wrote

Re: Review Request 35702: [WIP] Added /reserve HTTP endpoint to the master.

2015-06-25 Thread Michael Park
--- Added `src/tests/reserve_tests.cpp`. Thanks, Michael Park

Re: Review Request 35841: Fix usage of ATOMIC_FLAG_INIT

2015-06-24 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35841/#review89245 --- Ship it! Ship It! - Michael Park On June 24, 2015, 8:15 p.m

Re: Review Request 35816: Fixed the incorrect CHECK_EQ in updateAllocation.

2015-06-24 Thread Michael Park
-allocated due to oversubscription (currently the total from addSlave doesn't include the oversubpription resources, and in the future we might want to express over-allocation, see: [MESOS-2930](https://issues.apache.org/jira/browse/MESOS-2930). Michael Park wrote: Hey Ben! I think

Review Request 35816: Fixed the incorrect CHECK_EQ in updateAllocation.

2015-06-24 Thread Michael Park
`HierarchicalAllocatorTest.UpdateAllocationMultipleFrameworks` which breaks the previous `CHECK_EQ` condition. (2) `make check` Thanks, Michael Park

Re: Review Request 35702: [WIP] Added /reserve HTTP endpoint to the master.

2015-06-24 Thread Michael Park
src/tests/reserve_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/35702/diff/ Testing --- Added `src/tests/reserve_tests.cpp`. Thanks, Michael Park

Re: Review Request 35699: Added an invariant CHECK_EQ for available resources in HierarchicalAllocator::updateAllocation.

2015-06-24 Thread Michael Park
generated e-mail. To reply, visit: https://reviews.apache.org/r/35699/#review89107 --- On June 20, 2015, 7:52 p.m., Michael Park wrote: --- This is an automatically generated e-mail

Re: Review Request 35863: Fix a typo in docs/docker-containerizer.md file

2015-06-24 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35863/#review89316 --- Ship it! Ship It! - Michael Park On June 25, 2015, 5:47 a.m

Re: Review Request 35714: Added a new HTTP response type: PreconditionFailed.

2015-06-24 Thread Michael Park
other conditionals): http://stackoverflow.com/a/5369582 What will the pre-conditions be for /reserve? If the request does not contain explicit pre-conditions, it seems a little non-idiomatic to return 412..? Michael Park wrote: I was hoping to keep `BadRequest` to situations where

Re: Review Request 35433: Send StatusUpdates if checkpointed resources don't exist on the slave.

2015-06-18 Thread Michael Park
6caab134fdbf3894f9fae801daf9491a13888c7d support/post-reviews.py 10861a9eb9739a519732fef02a14dc4514463a8c Diff: https://reviews.apache.org/r/35433/diff/ Testing --- `make check` Thanks, Michael Park

Re: Review Request 35433: Send StatusUpdates if checkpointed resources don't exist on the slave.

2015-06-18 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35433/#review88393 --- On June 18, 2015, 5:03 p.m., Michael Park wrote

Re: Review Request 35433: Send StatusUpdates if checkpointed resources don't exist on the slave.

2015-06-18 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35433/#review88393 --- On June 18, 2015, 5:03 p.m., Michael Park wrote

Review Request 35638: Removed const-ref to temporaries from the Slave.

2015-06-18 Thread Michael Park
. Repository: mesos Description --- See summary. Diffs - src/slave/slave.cpp a5ad29f59fadba919ed82ba2892c2febe551660b Diff: https://reviews.apache.org/r/35638/diff/ Testing --- `make check` Thanks, Michael Park

Re: Review Request 35638: Removed const-ref to temporaries from the Slave.

2015-06-18 Thread Michael Park
--- `make check` Thanks, Michael Park

Re: Review Request 35433: Sent StatusUpdates if checkpointed resources don't exist on the slave.

2015-06-18 Thread Michael Park
- src/slave/slave.cpp a5ad29f59fadba919ed82ba2892c2febe551660b Diff: https://reviews.apache.org/r/35433/diff/ Testing --- `make check` Thanks, Michael Park

Re: Review Request 35635: Formatting cleanup in the Slave.

2015-06-18 Thread Michael Park
a5ad29f59fadba919ed82ba2892c2febe551660b Diff: https://reviews.apache.org/r/35635/diff/ Testing --- `make check` Thanks, Michael Park

Re: Review Request 35638: Removed const-ref to temporaries from the Slave.

2015-06-19 Thread Michael Park
://reviews.apache.org/r/35638/diff/ Testing --- `make check` Thanks, Michael Park

Review Request 35647: Fix logic for calling erase inside loop.

2015-06-19 Thread Michael Park
, and Till Toenshoff. Repository: mesos Description --- See summary. Diffs - src/slave/slave.cpp a5ad29f59fadba919ed82ba2892c2febe551660b Diff: https://reviews.apache.org/r/35647/diff/ Testing --- `make check` Thanks, Michael Park

Re: Review Request 35635: Formatting cleanup in the Slave.

2015-06-19 Thread Michael Park
for incorrect formatting as well as acceptable-but-can-be-improved formatting. Diffs (updated) - src/slave/slave.cpp a5ad29f59fadba919ed82ba2892c2febe551660b Diff: https://reviews.apache.org/r/35635/diff/ Testing --- `make check` Thanks, Michael Park

Re: Review Request 35647: Fix logic for calling erase inside loop.

2015-06-19 Thread Michael Park
, visit: https://reviews.apache.org/r/35647/#review88532 --- On June 19, 2015, 12:24 p.m., Michael Park wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 35638: Removed const-ref to temporaries from the Slave.

2015-06-19 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35638/#review88511 --- On June 19, 2015, 11:53 a.m., Michael Park wrote

Re: Review Request 35433: Sent StatusUpdates if checkpointed resources don't exist on the slave.

2015-06-19 Thread Michael Park
this in the dynamic reservations patches. Diffs - src/slave/slave.cpp a5ad29f59fadba919ed82ba2892c2febe551660b Diff: https://reviews.apache.org/r/35433/diff/ Testing --- `make check` Thanks, Michael Park

Re: Review Request 35433: Sent StatusUpdates if checkpointed resources don't exist on the slave.

2015-06-19 Thread Michael Park
a5ad29f59fadba919ed82ba2892c2febe551660b Diff: https://reviews.apache.org/r/35433/diff/ Testing --- `make check` Thanks, Michael Park

Re: Review Request 35433: Send StatusUpdates if checkpointed resources don't exist on the slave.

2015-06-18 Thread Michael Park
/35433/#review88405 --- On June 18, 2015, 7:47 p.m., Michael Park wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35433

Review Request 35702: [WIP] Add /reserve HTTP endpoint to the master.

2015-06-20 Thread Michael Park
still need to be fleshed out for error cases (missing parameters, unauthorized client, etc). Thanks, Michael Park

Re: Review Request 35702: [WIP] Add /reserve HTTP endpoint to the master.

2015-06-20 Thread Michael Park
/reserve_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/35702/diff/ Testing --- Added `src/tests/reserve_tests.cpp` which still need to be fleshed out for error cases (missing parameters, unauthorized client, etc). Thanks, Michael Park

Review Request 35699: Added an invariant CHECK_EQ for available resources in HierarchicalAllocator::updateAllocation.

2015-06-20 Thread Michael Park
--- See summary. Diffs - src/master/allocator/mesos/hierarchical.hpp 646ee8c1c0fb824e1d17150b4e96e6281c65358f Diff: https://reviews.apache.org/r/35699/diff/ Testing --- `make check` Thanks, Michael Park

Review Request 35768: Consistent 'Test' suffix in stout test names.

2015-06-23 Thread Michael Park
, Michael Park

Review Request 35770: Consistent 'Test' suffix in mesos test names.

2015-06-23 Thread Michael Park
86e6f5a57bb029202a12aff7bbf1d69018bf0579 Diff: https://reviews.apache.org/r/35770/diff/ Testing --- `make check` Thanks, Michael Park

Re: Review Request 32982: [WIP] Added reservation user guide.

2015-06-26 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32982/#review83054 --- On June 26, 2015, 3:36 p.m., Michael Park wrote

Re: Review Request 32982: [WIP] Added reservation user guide.

2015-06-26 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32982/#review83212 --- On June 26, 2015, 3:36 p.m., Michael Park wrote

Re: Review Request 32982: Added reservation user guide.

2015-06-26 Thread Michael Park
as it gets more solified. The purpose of including it was/is to get initial feedback on how it generally works. Diffs (updated) - docs/reservation.md PRE-CREATION Diff: https://reviews.apache.org/r/32982/diff/ Testing --- Documentation. Thanks, Michael Park

Re: Review Request 35920: Change EXPECT to ASSERT when relying on the assertion afterwards.

2015-06-26 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35920/#review89503 --- Ship it! Ship It! - Michael Park On June 26, 2015, 1:12 p.m

Re: Review Request 32982: [WIP] Added reservation user guide.

2015-06-26 Thread Michael Park
initial feedback on how it generally works. Diffs (updated) - docs/reservation.md PRE-CREATION Diff: https://reviews.apache.org/r/32982/diff/ Testing --- Documentation. Thanks, Michael Park

Re: Review Request 32982: Added reservation user guide.

2015-06-26 Thread Michael Park
generated e-mail. To reply, visit: https://reviews.apache.org/r/32982/#review83054 --- On June 26, 2015, 4:54 p.m., Michael Park wrote: --- This is an automatically generated e-mail

Re: Review Request 32982: Added reservation user guide.

2015-06-26 Thread Michael Park
solified. The purpose of including it was/is to get initial feedback on how it generally works. Diffs (updated) - docs/reservation.md PRE-CREATION Diff: https://reviews.apache.org/r/32982/diff/ Testing --- Documentation. Thanks, Michael Park

Re: Review Request 32982: Added reservation user guide.

2015-06-26 Thread Michael Park
. Thanks, Michael Park

Re: Review Request 32982: Added reservation user guide.

2015-06-26 Thread Michael Park
initial feedback on how it generally works. Diffs (updated) - docs/reservation.md PRE-CREATION Diff: https://reviews.apache.org/r/32982/diff/ Testing --- Documentation. Thanks, Michael Park

Re: Review Request 32982: Added reservation user guide.

2015-06-26 Thread Michael Park
generated e-mail. To reply, visit: https://reviews.apache.org/r/32982/#review83678 --- On June 26, 2015, 6:13 p.m., Michael Park wrote: --- This is an automatically generated e-mail

Re: Review Request 32982: Added reservation user guide.

2015-06-26 Thread Michael Park
. Thanks, Michael Park

Re: Review Request 35910: Updated the executor driver to set TaskStatus.uuid.

2015-06-26 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35910/#review89565 --- Just a question: what do we mean by a pure client here? - Michael

Re: Review Request 32982: Added reservation user guide.

2015-06-26 Thread Michael Park
: docs/reservation.md, line 25 https://reviews.apache.org/r/32982/diff/1/?file=921006#file921006line25 existed prior to 0.23.0 seems to imply it no longer exists after 0.23.0? Michael Park wrote: I went with `introduced in 0.14.0` instead. Actually decided to go with `since 0.14.0

Re: Review Request 32982: Added reservation user guide.

2015-06-26 Thread Michael Park
/diff/ Testing --- Documentation. Thanks, Michael Park

  1   2   3   4   5   6   7   8   9   10   >