., Paul Brett wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33040/
---
(Updated April 24, 2015, 7:28 p.m.)
Review request
PRE-CREATION
src/linux/routing/queueing/handle.hpp
5f0cb7775f9190caba6b85cabf9019a97b2a7de2
src/tests/routing_tests.cpp 6bf5e63aecf2dee36fb8cf3575c0bd2625d29dfa
Diff: https://reviews.apache.org/r/34321/diff/
Testing
---
make check
Thanks,
Paul Brett
6bf5e63aecf2dee36fb8cf3575c0bd2625d29dfa
Diff: https://reviews.apache.org/r/34426/diff/
Testing
---
make check
Thanks,
Paul Brett
(updated)
---
make check
Thanks,
Paul Brett
b8c2db6d0a02f79d38a21c227575299880980502
src/tests/routing_tests.cpp 6bf5e63aecf2dee36fb8cf3575c0bd2625d29dfa
Diff: https://reviews.apache.org/r/34426/diff/
Testing
---
make check
Thanks,
Paul Brett
/34321/diff/
Testing
---
make check
Thanks,
Paul Brett
src/tests/port_mapping_tests.cpp b8c2db6d0a02f79d38a21c227575299880980502
Diff: https://reviews.apache.org/r/34432/diff/
Testing
---
make check
Thanks,
Paul Brett
-CREATION
src/linux/routing/queueing/htb.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/34431/diff/
Testing
---
make check
Thanks,
Paul Brett
b8c2db6d0a02f79d38a21c227575299880980502
src/tests/routing_tests.cpp 6bf5e63aecf2dee36fb8cf3575c0bd2625d29dfa
Diff: https://reviews.apache.org/r/34426/diff/
Testing
---
make check
Thanks,
Paul Brett
---
make check
Thanks,
Paul Brett
/port_mapping.cpp
49e983edab598e2ac487bb488fdd12840a9e7dfc
Diff: https://reviews.apache.org/r/34426/diff/
Testing
---
make check
Thanks,
Paul Brett
Thanks,
Paul Brett
/port_mapping.cpp
871e9cf1625d96d1feef50edd4081972c097d191
Diff: https://reviews.apache.org/r/35152/diff/
Testing
---
make check
Thanks,
Paul Brett
db5b5df48634ff322baf9328fc605b2667b56eed
Diff: https://reviews.apache.org/r/35165/diff/
Testing
---
make check
Thanks,
Paul Brett
src/slave/containerizer/isolators/network/port_mapping.cpp
d2da1a4e96baeac7d1af9a5468f90c2e4c1cb50f
Diff: https://reviews.apache.org/r/35229/diff/
Testing
---
sudo make check
Thanks,
Paul Brett
10b190288425d735b116ed2dd3f040e871c5cb18
src/linux/routing/queueing/htb.hpp PRE-CREATION
src/linux/routing/queueing/htb.cpp PRE-CREATION
src/tests/routing_tests.cpp 4be9967d38177d9f7def5c0da98d4c4266e7f0b5
Diff: https://reviews.apache.org/r/35225/diff/
Testing
---
sudo make check
Thanks,
Paul Brett
/queueing/htb.cpp PRE-CREATION
src/tests/routing_tests.cpp 4be9967d38177d9f7def5c0da98d4c4266e7f0b5
Diff: https://reviews.apache.org/r/35225/diff/
Testing
---
sudo make check
Thanks,
Paul Brett
/35152/diff/
Testing
---
make check
Thanks,
Paul Brett
---
make check
Thanks,
Paul Brett
/routing/handle.hpp c107a7ef16f5060210b16b91e3a881af84ba6c10
Diff: https://reviews.apache.org/r/35150/diff/
Testing
---
make check
Thanks,
Paul Brett
/port_mapping.cpp
871e9cf1625d96d1feef50edd4081972c097d191
Diff: https://reviews.apache.org/r/35152/diff/
Testing
---
make check
Thanks,
Paul Brett
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34894/#review86033
---
On June 1, 2015, 4:40 p.m., Paul Brett wrote:
---
This is an automatically generated
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34956/#review86313
---
Ship it!
Ship It!
- Paul Brett
On June 2, 2015, 10:04 p.m., Jie
On June 2, 2015, 11:09 p.m., Paul Brett wrote:
src/linux/routing/queueing/internal.hpp, line 143
https://reviews.apache.org/r/34957/diff/1/?file=976870#file976870line143
Not your problem, but we really should either explain why we have to
increment the reference counter here
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34958/#review86307
---
Ship it!
Ship It!
- Paul Brett
On June 2, 2015, 10:06 p.m., Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34957/#review86305
---
Ship it!
Ship It!
- Paul Brett
On June 2, 2015, 10:05 p.m., Jie
/35257/diff/
Testing
---
'sudo make check' for backward compatability
Adhoc creation of master/slave with running network task and probing the
statistics.json endpoint. Additional tests will be added as part of a later
review.
Thanks,
Paul Brett
---
On June 9, 2015, 5:29 p.m., Paul Brett wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35229/
---
(Updated June 9
/containerizer/isolators/network/port_mapping.hpp
4c719b186b519fad0c3869dbdae8b60c3a2c20cc
src/slave/containerizer/isolators/network/port_mapping.cpp
d2da1a4e96baeac7d1af9a5468f90c2e4c1cb50f
Diff: https://reviews.apache.org/r/35229/diff/
Testing
---
sudo make check
Thanks,
Paul
., Paul Brett wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35225/
---
(Updated June 8, 2015, 10:58 p.m.)
Review request
,
Paul Brett
Thanks,
Paul Brett
/ingress.cpp
e96f547200dc4ad5b2e33fd1ffbd7fb92b955a46
src/linux/routing/queueing/internal.hpp
3713f6a4d3f9a44b142b8150e85cf911e53e34e9
src/linux/routing/queueing/statistics.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/34426/diff/
Testing
---
make check
Thanks,
Paul Brett
/tests/routing_tests.cpp 2066a56571f43a012992b4294fbf5b6e07c2b159
Diff: https://reviews.apache.org/r/34832/diff/
Testing
---
make check
Thanks,
Paul Brett
---
On June 3, 2015, 9:19 p.m., Paul Brett wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34426
Diff: https://reviews.apache.org/r/35257/diff/
Testing
---
'sudo make check' for backward compatability
Adhoc creation of master/slave with running network task and probing the
statistics.json endpoint. Additional tests will be added as part of a later
review.
Thanks,
Paul Brett
4c719b186b519fad0c3869dbdae8b60c3a2c20cc
src/slave/containerizer/isolators/network/port_mapping.cpp
d2da1a4e96baeac7d1af9a5468f90c2e4c1cb50f
Diff: https://reviews.apache.org/r/35229/diff/
Testing
---
sudo make check
Thanks,
Paul Brett
/containerizer.cpp 80b910515694c81cf5b1eace1d79a5178cf35426
src/tests/metrics_tests.cpp 6896727a23c1d6b0e2055ee661042a0a66b09067
src/tests/slave_tests.cpp 50301983c674ef50a64294816db9587bf065aa9e
Diff: https://reviews.apache.org/r/35738/diff/
Testing
---
sudo make check
Thanks,
Paul
generated e-mail. To reply, visit:
https://reviews.apache.org/r/35861/#review89330
---
On June 25, 2015, 4:29 a.m., Paul Brett wrote:
---
This is an automatically generated e-mail
/libevent_ssl_socket.hpp
d65638b1dc1330c6393dc79efc7226dc9560c3b0
Diff: https://reviews.apache.org/r/35841/diff/
Testing
---
sudo make check
Thanks,
Paul Brett
/3rdparty/stout/tests/uuid_tests.cpp
bcf7252730fd5cefbd4e851c333c40948a8ad751
Diff: https://reviews.apache.org/r/35861/diff/
Testing
---
sudo make check
Thanks,
Paul Brett
3rdparty/libprocess/3rdparty/stout/tests/uuid_tests.cpp
bcf7252730fd5cefbd4e851c333c40948a8ad751
Diff: https://reviews.apache.org/r/35861/diff/
Testing
---
sudo make check
Thanks,
Paul Brett
., Paul Brett wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35861/
---
(Updated June 25, 2015, 6:32 p.m.)
Review request
a mesos present with a MesosInfo message with no image mean?
- Paul Brett
On June 22, 2015, 4:42 p.m., Ian Downes wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34136
/tests/uuid_tests.cpp
bcf7252730fd5cefbd4e851c333c40948a8ad751
Diff: https://reviews.apache.org/r/35861/diff/
Testing
---
sudo make check
Thanks,
Paul Brett
Description
---
Add constexpr to C++11 whitelist
Diffs (updated)
-
docs/mesos-c++-style-guide.md 94107ed21c6f09349ce691f9f4d36b43bbbe809e
Diff: https://reviews.apache.org/r/34835/diff/
Testing
---
Thanks,
Paul Brett
---
On June 24, 2015, 9:14 p.m., Paul Brett wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34835
bcf7252730fd5cefbd4e851c333c40948a8ad751
Diff: https://reviews.apache.org/r/35861/diff/
Testing
---
sudo make check
Thanks,
Paul Brett
3rdparty/libprocess/src/libevent_ssl_socket.hpp
d65638b1dc1330c6393dc79efc7226dc9560c3b0
Diff: https://reviews.apache.org/r/35841/diff/
Testing
---
sudo make check
Thanks,
Paul Brett
,
Paul Brett
Thanks,
Paul Brett
25, 2015, 9:58 p.m., Paul Brett wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35861/
---
(Updated June 25, 2015, 9:58 p.m
3rdparty/libprocess/include/process/mutex.hpp
8fff089e2654bf1a5ac3cfec91def7688e0009ca
3rdparty/libprocess/include/process/queue.hpp
1496b3850648957ff34bf2bbe240d1ab0888c6f8
Diff: https://reviews.apache.org/r/35841/diff/
Testing
---
sudo make check
Thanks,
Paul Brett
e55e7b62bc29125458f9c0fb5477057ecc5a90df
Diff: https://reviews.apache.org/r/35257/diff/
Testing
---
'sudo make check' for backward compatability
Adhoc creation of master/slave with running network task and probing the
statistics.json endpoint. Additional tests will be added as part of a later
review.
Thanks,
Paul
/port_mapping.hpp
4c719b186b519fad0c3869dbdae8b60c3a2c20cc
src/slave/containerizer/isolators/network/port_mapping.cpp
e55e7b62bc29125458f9c0fb5477057ecc5a90df
Diff: https://reviews.apache.org/r/35229/diff/
Testing
---
sudo make check
Thanks,
Paul Brett
/
Testing (updated)
---
sudo make check
Thanks,
Paul Brett
4c719b186b519fad0c3869dbdae8b60c3a2c20cc
src/slave/containerizer/isolators/network/port_mapping.cpp
432b05ce5a99c8239fafc47a6b65d46a0fbac26e
src/tests/port_mapping_tests.cpp f8372df74cd71df37de4a2438069ef0ea8878512
Diff: https://reviews.apache.org/r/35536/diff/
Testing
---
Thanks,
Paul Brett
/port_mapping.hpp
4c719b186b519fad0c3869dbdae8b60c3a2c20cc
src/slave/containerizer/isolators/network/port_mapping.cpp
e55e7b62bc29125458f9c0fb5477057ecc5a90df
Diff: https://reviews.apache.org/r/35229/diff/
Testing
---
sudo make check
Thanks,
Paul Brett
---
sudo make check
Thanks,
Paul Brett
., Paul Brett wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35229/
---
(Updated June 17, 2015, 10:58 p.m.)
Review request
f8372df74cd71df37de4a2438069ef0ea8878512
Diff: https://reviews.apache.org/r/35536/diff/
Testing
---
sudo make check
Thanks,
Paul Brett
---
On June 16, 2015, 8:27 p.m., Paul Brett wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35536/
---
(Updated June 16
---
sudo make check
Thanks,
Paul Brett
fece104648307e97755d5a38123e67c442a70474
Diff: https://reviews.apache.org/r/34782/diff/
Testing
---
make check
Thanks,
Paul Brett
---
make check
Thanks,
Paul Brett
: https://reviews.apache.org/r/34426/diff/
Testing
---
make check
Thanks,
Paul Brett
.
- Paul
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34426/#review85274
---
On May 31, 2015, 7:53 p.m., Paul Brett wrote
.
Repository: mesos
Description
---
Add new message for Traffic Control statistics
Diffs
-
include/mesos/mesos.proto 5cf81e20bc77288eb4c183722c608827b5000cb4
Diff: https://reviews.apache.org/r/34894/diff/
Testing
---
make check
Thanks,
Paul Brett
:
https://reviews.apache.org/r/34830/#review86006
---
On May 30, 2015, 9 p.m., Paul Brett wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
src/linux/routing/queueing/ingress.cpp
ae0c38d2215e7fabcc1060e7385484bd455e1699
Diff: https://reviews.apache.org/r/34899/diff/
Testing
---
make check
Thanks,
Paul Brett
://reviews.apache.org/r/34830/diff/
Testing
---
make check
Thanks,
Paul Brett
2066a56571f43a012992b4294fbf5b6e07c2b159
Diff: https://reviews.apache.org/r/34832/diff/
Testing
---
Thanks,
Paul Brett
/linux/routing/queueing/fq_codel.cpp
64b5c73e8cfa672141ddb663e879c58b4babfdbc
src/linux/routing/queueing/ingress.cpp
ae0c38d2215e7fabcc1060e7385484bd455e1699
Diff: https://reviews.apache.org/r/34899/diff/
Testing
---
make check
Thanks,
Paul Brett
)
-
src/linux/routing/handle.hpp 52055d0a92afffdba26f68aed1f86fa648ef8fe4
src/linux/routing/queueing/fq_codel.cpp
64b5c73e8cfa672141ddb663e879c58b4babfdbc
Diff: https://reviews.apache.org/r/34900/diff/
Testing
---
make check
Thanks,
Paul Brett
---
On May 29, 2015, 10:09 p.m., Paul Brett wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34832/
---
(Updated May 29, 2015
., Paul Brett wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34426/
---
(Updated May 31, 2015, 7:53 p.m.)
Review request
52055d0a92afffdba26f68aed1f86fa648ef8fe4
src/linux/routing/queueing/fq_codel.cpp
64b5c73e8cfa672141ddb663e879c58b4babfdbc
Diff: https://reviews.apache.org/r/34900/diff/
Testing
---
make check
Thanks,
Paul Brett
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34426/#review86058
---
On May 31, 2015, 7:53 p.m., Paul Brett wrote:
---
This is an automatically generated e
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34894/#review86048
---
On June 1, 2015, 4:40 p.m., Paul Brett wrote
)
-
src/linux/routing/queueing/fq_codel.cpp
4dc2a9d2ed52937f0a78a083980db488c06b45a7
src/linux/routing/queueing/ingress.cpp
ae0c38d2215e7fabcc1060e7385484bd455e1699
Diff: https://reviews.apache.org/r/34899/diff/
Testing
---
make check
Thanks,
Paul Brett
src/linux/routing/queueing/ingress.hpp
84506fecd01522471a7998176c28bea8f1367aed
src/linux/routing/queueing/internal.hpp
d43a9fd405af2e59dc57cfc7ba9b5e77cb9f6b70
Diff: https://reviews.apache.org/r/34830/diff/
Testing
---
make check
Thanks,
Paul Brett
696e359de66305512eedf8e269543fafa21f4bc3
src/tests/port_mapping_tests.cpp b8c2db6d0a02f79d38a21c227575299880980502
Diff: https://reviews.apache.org/r/34432/diff/
Testing
---
make check
Thanks,
Paul Brett
b8c2db6d0a02f79d38a21c227575299880980502
Diff: https://reviews.apache.org/r/34558/diff/
Testing
---
make check
Thanks,
Paul Brett
/port_mapping_tests.cpp b8c2db6d0a02f79d38a21c227575299880980502
Diff: https://reviews.apache.org/r/34558/diff/
Testing
---
make check
Thanks,
Paul Brett
://reviews.apache.org/r/32664/diff/
Testing
---
make check
Thanks,
Paul Brett
/34830/diff/
Testing
---
make check
Thanks,
Paul Brett
/34832/diff/
Testing
---
Thanks,
Paul Brett
13312f6f4fe1788791479bd768f60df0a8e80e69
Diff: https://reviews.apache.org/r/34835/diff/
Testing
---
Thanks,
Paul Brett
://reviews.apache.org/r/34140/#comment137031
Do we cache the hashes?
src/slave/containerizer/provisioners/appc/store.cpp
https://reviews.apache.org/r/34140/#comment137032
Why not do the decompress, hash untar as a pipeline to reduce disk usage?
- Paul Brett
On May 26, 2015, 6:25 p.m., Ian
ae0c38d2215e7fabcc1060e7385484bd455e1699
src/linux/routing/queueing/internal.hpp
d43a9fd405af2e59dc57cfc7ba9b5e77cb9f6b70
Diff: https://reviews.apache.org/r/34426/diff/
Testing
---
make check
Thanks,
Paul Brett
)
-
src/tests/routing_tests.cpp 2066a56571f43a012992b4294fbf5b6e07c2b159
Diff: https://reviews.apache.org/r/34832/diff/
Testing (updated)
---
make check
Thanks,
Paul Brett
2066a56571f43a012992b4294fbf5b6e07c2b159
Diff: https://reviews.apache.org/r/34863/diff/
Testing
---
make check
Thanks,
Paul Brett
-mail. To reply, visit:
https://reviews.apache.org/r/34782/#review85761
---
On May 29, 2015, 4:37 p.m., Paul Brett wrote:
---
This is an automatically generated e-mail. To reply, visit
/linux/routing/queueing/ingress.cpp
fece104648307e97755d5a38123e67c442a70474
Diff: https://reviews.apache.org/r/34782/diff/
Testing
---
make check
Thanks,
Paul Brett
. To reply, visit:
https://reviews.apache.org/r/34426/#review86040
---
On May 31, 2015, 7:53 p.m., Paul Brett wrote:
---
This is an automatically generated e-mail. To reply, visit
/#comment143147
Not your code but we should propagate the failure to the caller so that
sample can fail rather than halt and catch fire here.
- Paul Brett
On July 1, 2015, 10:43 p.m., Chi Zhang wrote:
---
This is an automatically
)
https://reviews.apache.org/r/36115/#comment143155
Ditto.
src/tests/perf_tests.cpp (line 170)
https://reviews.apache.org/r/36115/#comment143156
Ditto.
src/tests/perf_tests.cpp (line 240)
https://reviews.apache.org/r/36115/#comment143157
Ditto.
- Paul Brett
On July 1, 2015, 10:44
/#comment143149
Could you replace the function pointer with a lambda?
src/linux/perf.cpp (line 488)
https://reviews.apache.org/r/36113/#comment143150
Seems odd to return cgroup= when there is no cgroup rather than just not
add a cgroup entry to the map at all.
- Paul Brett
On July 1
/#comment143176
How about extract_post_linux_2_6_39 for the name?
src/linux/perf.cpp (line 498)
https://reviews.apache.org/r/36114/#comment143177
extract_post_linux_3_12_0?
- Paul Brett
On July 1, 2015, 10:44 p.m., Chi Zhang wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34436/#review84884
---
On May 21, 2015, 11:31 p.m., Paul Brett wrote
1 - 100 of 212 matches
Mail list logo