Re: Review Request 32660: Report network isolator statistics on a per container basis (MESOS-2332)

2015-04-24 Thread Paul Brett
fb334e53bc8d73bced402095daddab5e06dc2dd1 src/slave/containerizer/mesos/containerizer.cpp ea3b499258b6be4a643d246159a17a0eaeedf904 Diff: https://reviews.apache.org/r/32660/diff/ Testing --- make check Thanks, Paul Brett

Review Request 33765: MESOS-2665: fix queuing discipline wrapper in linux/routing/queueing

2015-05-01 Thread Paul Brett
fc0fa4c2086f0be84ab7ddc04b85dec4a3b5b5dc src/tests/port_mapping_tests.cpp b8c2db6d0a02f79d38a21c227575299880980502 src/tests/routing_tests.cpp 7cc3b57a3b71544874557d2b1cf88a241b7062ba Diff: https://reviews.apache.org/r/33765/diff/ Testing --- make check Thanks, Paul Brett

Re: Review Request 33040: Expose qdisc statistics from libnl

2015-05-01 Thread Paul Brett
., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33040/ --- (Updated April 24, 2015, 7:28 p.m.) Review request

Review Request 34321: Merge class Handle which is duplicated between filter/handle and queueing/handle.

2015-05-18 Thread Paul Brett
PRE-CREATION src/linux/routing/queueing/handle.hpp 5f0cb7775f9190caba6b85cabf9019a97b2a7de2 src/tests/routing_tests.cpp 6bf5e63aecf2dee36fb8cf3575c0bd2625d29dfa Diff: https://reviews.apache.org/r/34321/diff/ Testing --- make check Thanks, Paul Brett

Review Request 34426: Extend the Traffic Control queueing models to allow dynamically allocated Handles, extend API to allow searching by handle (or parent).

2015-05-19 Thread Paul Brett
6bf5e63aecf2dee36fb8cf3575c0bd2625d29dfa Diff: https://reviews.apache.org/r/34426/diff/ Testing --- make check Thanks, Paul Brett

Review Request 34431: Add htb queueing discipline

2015-05-20 Thread Paul Brett
PRE-CREATION Diff: https://reviews.apache.org/r/34431/diff/ Testing --- make check Thanks, Paul Brett

Re: Review Request 34428: Extend queueing discipline wrappers to expose network isolator statistics

2015-05-20 Thread Paul Brett
(updated) --- make check Thanks, Paul Brett

Re: Review Request 34426: Extend the Traffic Control queueing models to allow dynamically allocated Handles, extend API to allow searching by handle (or parent).

2015-05-19 Thread Paul Brett
b8c2db6d0a02f79d38a21c227575299880980502 src/tests/routing_tests.cpp 6bf5e63aecf2dee36fb8cf3575c0bd2625d29dfa Diff: https://reviews.apache.org/r/34426/diff/ Testing --- make check Thanks, Paul Brett

Re: Review Request 34321: Merge class Handle which is duplicated between filter/handle and queueing/handle.

2015-05-19 Thread Paul Brett
/34321/diff/ Testing --- make check Thanks, Paul Brett

Review Request 34432: Remove duplicate constant string references to mesos-containerizer

2015-05-20 Thread Paul Brett
src/tests/port_mapping_tests.cpp b8c2db6d0a02f79d38a21c227575299880980502 Diff: https://reviews.apache.org/r/34432/diff/ Testing --- make check Thanks, Paul Brett

Re: Review Request 34431: Add htb queueing discipline

2015-05-20 Thread Paul Brett
-CREATION src/linux/routing/queueing/htb.cpp PRE-CREATION Diff: https://reviews.apache.org/r/34431/diff/ Testing --- make check Thanks, Paul Brett

Re: Review Request 34426: Extend the Traffic Control queueing models to allow dynamically allocated Handles, extend API to allow searching by handle (or parent).

2015-05-20 Thread Paul Brett
b8c2db6d0a02f79d38a21c227575299880980502 src/tests/routing_tests.cpp 6bf5e63aecf2dee36fb8cf3575c0bd2625d29dfa Diff: https://reviews.apache.org/r/34426/diff/ Testing --- make check Thanks, Paul Brett

Re: Review Request 34428: Extend queueing discipline wrappers to expose network isolator statistics

2015-05-20 Thread Paul Brett
--- make check Thanks, Paul Brett

Re: Review Request 34134: Add container rootfs to Isolator::prepare().

2015-05-20 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34134/#review84641 --- LGTM - Paul Brett On May 13, 2015, 12:44 a.m., Ian Downes wrote

Re: Review Request 34426: Report per-container metrics for network bandwidth throttling

2015-05-20 Thread Paul Brett
/port_mapping.cpp 49e983edab598e2ac487bb488fdd12840a9e7dfc Diff: https://reviews.apache.org/r/34426/diff/ Testing --- make check Thanks, Paul Brett

Re: Review Request 34138: AppC hash computation.

2015-05-20 Thread Paul Brett
/ --- (Updated May 13, 2015, 12:47 a.m.) Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone. Repository: mesos Description --- AppC hash computation. Diffs - src/Makefile.am

Re: Review Request 34426: Report per-container metrics for network bandwidth throttling

2015-06-03 Thread Paul Brett
Thanks, Paul Brett

Re: Review Request 34832: Add new qdisc tests

2015-06-03 Thread Paul Brett
) - src/tests/routing_tests.cpp 2066a56571f43a012992b4294fbf5b6e07c2b159 Diff: https://reviews.apache.org/r/34832/diff/ Testing --- make check Thanks, Paul Brett

Re: Review Request 34863: Add tests for new qdisc statistics functions.

2015-06-03 Thread Paul Brett
2066a56571f43a012992b4294fbf5b6e07c2b159 Diff: https://reviews.apache.org/r/34863/diff/ Testing --- make check Thanks, Paul Brett

Re: Review Request 34426: Report per-container metrics for network bandwidth throttling

2015-06-03 Thread Paul Brett
--- make check Thanks, Paul Brett

Re: Review Request 34894: Add new message for Traffic Control statistics

2015-06-03 Thread Paul Brett
/34894/diff/ Testing --- make check Thanks, Paul Brett

Re: Review Request 34863: Add tests for new qdisc statistics functions.

2015-06-03 Thread Paul Brett
2066a56571f43a012992b4294fbf5b6e07c2b159 Diff: https://reviews.apache.org/r/34863/diff/ Testing --- make check Thanks, Paul Brett

Re: Review Request 34894: Add new message for Traffic Control statistics

2015-06-03 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34894/#review86048 --- On June 2, 2015, 8:52 p.m., Paul Brett wrote

Re: Review Request 35152: Document and consolidate qdisc handles

2015-06-08 Thread Paul Brett
/port_mapping.cpp 871e9cf1625d96d1feef50edd4081972c097d191 Diff: https://reviews.apache.org/r/35152/diff/ Testing --- make check Thanks, Paul Brett

Re: Review Request 35165: Extend fq_codel to allow parent and handle to be specified at runtime.

2015-06-08 Thread Paul Brett
db5b5df48634ff322baf9328fc605b2667b56eed Diff: https://reviews.apache.org/r/35165/diff/ Testing --- make check Thanks, Paul Brett

Review Request 35229: Report per-container metrics for network bandwidth throttling to the slave.

2015-06-08 Thread Paul Brett
src/slave/containerizer/isolators/network/port_mapping.cpp d2da1a4e96baeac7d1af9a5468f90c2e4c1cb50f Diff: https://reviews.apache.org/r/35229/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 35225: Add HTB queueing discipline wrapper class

2015-06-08 Thread Paul Brett
10b190288425d735b116ed2dd3f040e871c5cb18 src/linux/routing/queueing/htb.hpp PRE-CREATION src/linux/routing/queueing/htb.cpp PRE-CREATION src/tests/routing_tests.cpp 4be9967d38177d9f7def5c0da98d4c4266e7f0b5 Diff: https://reviews.apache.org/r/35225/diff/ Testing --- sudo make check Thanks, Paul Brett

Review Request 35225: Add HTB queueing discipline wrapper class

2015-06-08 Thread Paul Brett
/queueing/htb.cpp PRE-CREATION src/tests/routing_tests.cpp 4be9967d38177d9f7def5c0da98d4c4266e7f0b5 Diff: https://reviews.apache.org/r/35225/diff/ Testing --- sudo make check Thanks, Paul Brett

Review Request 35152: Document and consolidate qdisc handles

2015-06-05 Thread Paul Brett
/35152/diff/ Testing --- make check Thanks, Paul Brett

Review Request 35165: Extend fq_codel to allow parent and handle to be specified at runtime.

2015-06-05 Thread Paul Brett
--- make check Thanks, Paul Brett

Re: Review Request 35150: Add output stream operation for handle to use in port_mapping.cpp

2015-06-05 Thread Paul Brett
/routing/handle.hpp c107a7ef16f5060210b16b91e3a881af84ba6c10 Diff: https://reviews.apache.org/r/35150/diff/ Testing --- make check Thanks, Paul Brett

Re: Review Request 35152: Document and consolidate qdisc handles

2015-06-08 Thread Paul Brett
/port_mapping.cpp 871e9cf1625d96d1feef50edd4081972c097d191 Diff: https://reviews.apache.org/r/35152/diff/ Testing --- make check Thanks, Paul Brett

Re: Review Request 34894: Add new message for Traffic Control statistics

2015-06-02 Thread Paul Brett
://reviews.apache.org/r/34894/diff/ Testing --- make check Thanks, Paul Brett

Re: Review Request 34894: Add new message for Traffic Control statistics

2015-06-02 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34894/#review86033 --- On June 1, 2015, 4:40 p.m., Paul Brett wrote: --- This is an automatically generated

Re: Review Request 34956: Refactored the queueing discipline data structure.

2015-06-02 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34956/#review86313 --- Ship it! Ship It! - Paul Brett On June 2, 2015, 10:04 p.m., Jie

Re: Review Request 34957: Fixed a bug in qdisc search function.

2015-06-02 Thread Paul Brett
On June 2, 2015, 11:09 p.m., Paul Brett wrote: src/linux/routing/queueing/internal.hpp, line 143 https://reviews.apache.org/r/34957/diff/1/?file=976870#file976870line143 Not your problem, but we really should either explain why we have to increment the reference counter here

Re: Review Request 34958: Moved ingress root handle to a proper location.

2015-06-02 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34958/#review86307 --- Ship it! Ship It! - Paul Brett On June 2, 2015, 10:06 p.m., Jie

Re: Review Request 34957: Fixed a bug in qdisc search function.

2015-06-02 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34957/#review86305 --- Ship it! Ship It! - Paul Brett On June 2, 2015, 10:05 p.m., Jie

Review Request 35257: Decode network statistics from helper

2015-06-09 Thread Paul Brett
/35257/diff/ Testing --- 'sudo make check' for backward compatability Adhoc creation of master/slave with running network task and probing the statistics.json endpoint. Additional tests will be added as part of a later review. Thanks, Paul Brett

Re: Review Request 35229: Report per-container metrics for network bandwidth throttling to the slave.

2015-06-09 Thread Paul Brett
--- On June 9, 2015, 5:29 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35229/ --- (Updated June 9

Re: Review Request 35229: Report per-container metrics for network bandwidth throttling to the slave.

2015-06-09 Thread Paul Brett
/containerizer/isolators/network/port_mapping.hpp 4c719b186b519fad0c3869dbdae8b60c3a2c20cc src/slave/containerizer/isolators/network/port_mapping.cpp d2da1a4e96baeac7d1af9a5468f90c2e4c1cb50f Diff: https://reviews.apache.org/r/35229/diff/ Testing --- sudo make check Thanks, Paul

Re: Review Request 35225: Add HTB queueing discipline wrapper class

2015-06-09 Thread Paul Brett
., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35225/ --- (Updated June 8, 2015, 10:58 p.m.) Review request

Re: Review Request 35225: Add HTB queueing discipline wrapper class

2015-06-09 Thread Paul Brett
, Paul Brett

Re: Review Request 35229: Report per-container metrics for network bandwidth throttling to the slave.

2015-06-09 Thread Paul Brett
Thanks, Paul Brett

Re: Review Request 34426: Report per-container metrics for network bandwidth throttling

2015-06-03 Thread Paul Brett
/ingress.cpp e96f547200dc4ad5b2e33fd1ffbd7fb92b955a46 src/linux/routing/queueing/internal.hpp 3713f6a4d3f9a44b142b8150e85cf911e53e34e9 src/linux/routing/queueing/statistics.hpp PRE-CREATION Diff: https://reviews.apache.org/r/34426/diff/ Testing --- make check Thanks, Paul Brett

Re: Review Request 34832: Add new qdisc tests

2015-06-03 Thread Paul Brett
/tests/routing_tests.cpp 2066a56571f43a012992b4294fbf5b6e07c2b159 Diff: https://reviews.apache.org/r/34832/diff/ Testing --- make check Thanks, Paul Brett

Re: Review Request 34426: Report per-container metrics for network bandwidth throttling

2015-06-03 Thread Paul Brett
--- On June 3, 2015, 9:19 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34426

Re: Review Request 35257: Decode network statistics from helper

2015-06-09 Thread Paul Brett
Diff: https://reviews.apache.org/r/35257/diff/ Testing --- 'sudo make check' for backward compatability Adhoc creation of master/slave with running network task and probing the statistics.json endpoint. Additional tests will be added as part of a later review. Thanks, Paul Brett

Re: Review Request 35229: Report per-container metrics for network bandwidth throttling to the slave.

2015-06-09 Thread Paul Brett
4c719b186b519fad0c3869dbdae8b60c3a2c20cc src/slave/containerizer/isolators/network/port_mapping.cpp d2da1a4e96baeac7d1af9a5468f90c2e4c1cb50f Diff: https://reviews.apache.org/r/35229/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 34894: Add new message for Traffic Control statistics

2015-06-07 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34894/#review86875 --- On June 3, 2015, 9:54 p.m., Paul Brett wrote

Re: Review Request 35738: Add slave metric to count container launch failures.

2015-06-22 Thread Paul Brett
/containerizer.cpp 80b910515694c81cf5b1eace1d79a5178cf35426 src/tests/metrics_tests.cpp 6896727a23c1d6b0e2055ee661042a0a66b09067 src/tests/slave_tests.cpp 50301983c674ef50a64294816db9587bf065aa9e Diff: https://reviews.apache.org/r/35738/diff/ Testing --- sudo make check Thanks, Paul

Re: Review Request 35861: Correct include list errors for stout

2015-06-25 Thread Paul Brett
generated e-mail. To reply, visit: https://reviews.apache.org/r/35861/#review89330 --- On June 25, 2015, 4:29 a.m., Paul Brett wrote: --- This is an automatically generated e-mail

Re: Review Request 35841: Fix usage of ATOMIC_FLAG_INIT

2015-06-25 Thread Paul Brett
/libevent_ssl_socket.hpp d65638b1dc1330c6393dc79efc7226dc9560c3b0 Diff: https://reviews.apache.org/r/35841/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 35861: Correct include list errors for stout

2015-06-25 Thread Paul Brett
/3rdparty/stout/tests/uuid_tests.cpp bcf7252730fd5cefbd4e851c333c40948a8ad751 Diff: https://reviews.apache.org/r/35861/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 35861: Correct include list errors for stout

2015-06-25 Thread Paul Brett
3rdparty/libprocess/3rdparty/stout/tests/uuid_tests.cpp bcf7252730fd5cefbd4e851c333c40948a8ad751 Diff: https://reviews.apache.org/r/35861/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 35861: Correct include list errors for stout

2015-06-25 Thread Paul Brett
., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35861/ --- (Updated June 25, 2015, 6:32 p.m.) Review request

Re: Review Request 34136: Add ContainerImage protobuf.

2015-06-25 Thread Paul Brett
a mesos present with a MesosInfo message with no image mean? - Paul Brett On June 22, 2015, 4:42 p.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34136

Re: Review Request 35861: Correct include list errors for stout

2015-06-25 Thread Paul Brett
/tests/uuid_tests.cpp bcf7252730fd5cefbd4e851c333c40948a8ad751 Diff: https://reviews.apache.org/r/35861/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 35841: Fix usage of ATOMIC_FLAG_INIT

2015-06-24 Thread Paul Brett
://reviews.apache.org/r/35841/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 34835: Add constexpr to C++ whitelist

2015-06-24 Thread Paul Brett
Description --- Add constexpr to C++11 whitelist Diffs (updated) - docs/mesos-c++-style-guide.md 94107ed21c6f09349ce691f9f4d36b43bbbe809e Diff: https://reviews.apache.org/r/34835/diff/ Testing --- Thanks, Paul Brett

Re: Review Request 34835: Add constexpr to C++ whitelist

2015-06-24 Thread Paul Brett
--- On June 24, 2015, 9:14 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34835

Review Request 35861: Correct include list errors for stout

2015-06-24 Thread Paul Brett
bcf7252730fd5cefbd4e851c333c40948a8ad751 Diff: https://reviews.apache.org/r/35861/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 35841: Fix usage of ATOMIC_FLAG_INIT

2015-06-24 Thread Paul Brett
3rdparty/libprocess/src/libevent_ssl_socket.hpp d65638b1dc1330c6393dc79efc7226dc9560c3b0 Diff: https://reviews.apache.org/r/35841/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 35841: Fix usage of ATOMIC_FLAG_INIT

2015-06-24 Thread Paul Brett
/libprocess/src/libevent_ssl_socket.hpp d65638b1dc1330c6393dc79efc7226dc9560c3b0 Diff: https://reviews.apache.org/r/35841/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 35861: Correct include list errors for stout

2015-06-24 Thread Paul Brett
, Paul Brett

Re: Review Request 35841: Fix usage of ATOMIC_FLAG_INIT

2015-06-24 Thread Paul Brett
/libprocess/src/libevent_ssl_socket.hpp d65638b1dc1330c6393dc79efc7226dc9560c3b0 Diff: https://reviews.apache.org/r/35841/diff/ Testing --- sudo make check Thanks, Paul Brett

Review Request 35738: Add slave metric to count container launch failures.

2015-06-22 Thread Paul Brett
Thanks, Paul Brett

Re: Review Request 35861: Correct include list errors for stout

2015-06-26 Thread Paul Brett
25, 2015, 9:58 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35861/ --- (Updated June 25, 2015, 9:58 p.m

Review Request 35841: Fix usage of ATOMIC_FLAG_INIT

2015-06-24 Thread Paul Brett
3rdparty/libprocess/include/process/mutex.hpp 8fff089e2654bf1a5ac3cfec91def7688e0009ca 3rdparty/libprocess/include/process/queue.hpp 1496b3850648957ff34bf2bbe240d1ab0888c6f8 Diff: https://reviews.apache.org/r/35841/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 34835: Add constexpr to C++ whitelist

2015-06-26 Thread Paul Brett
Description --- Add constexpr to C++11 whitelist Diffs (updated) - docs/mesos-c++-style-guide.md a8bec8e242a57a9cb4f5fe96932eebac39ad65a1 Diff: https://reviews.apache.org/r/34835/diff/ Testing --- Thanks, Paul Brett

Re: Review Request 35257: Decode network statistics from helper

2015-06-16 Thread Paul Brett
e55e7b62bc29125458f9c0fb5477057ecc5a90df Diff: https://reviews.apache.org/r/35257/diff/ Testing --- 'sudo make check' for backward compatability Adhoc creation of master/slave with running network task and probing the statistics.json endpoint. Additional tests will be added as part of a later review. Thanks, Paul

Re: Review Request 35229: Report per-container metrics for network bandwidth throttling to the slave.

2015-06-16 Thread Paul Brett
/port_mapping.hpp 4c719b186b519fad0c3869dbdae8b60c3a2c20cc src/slave/containerizer/isolators/network/port_mapping.cpp e55e7b62bc29125458f9c0fb5477057ecc5a90df Diff: https://reviews.apache.org/r/35229/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 35536: Replace adhoc JSON conversion functions for ResourceStatistics with a protocol buffer to JSON converter.

2015-06-16 Thread Paul Brett
/ Testing (updated) --- sudo make check Thanks, Paul Brett

Review Request 35536: Replace adhoc JSON conversion functions for ResourceStatistics with a protocol buffer to JSON converter.

2015-06-16 Thread Paul Brett
4c719b186b519fad0c3869dbdae8b60c3a2c20cc src/slave/containerizer/isolators/network/port_mapping.cpp 432b05ce5a99c8239fafc47a6b65d46a0fbac26e src/tests/port_mapping_tests.cpp f8372df74cd71df37de4a2438069ef0ea8878512 Diff: https://reviews.apache.org/r/35536/diff/ Testing --- Thanks, Paul Brett

Re: Review Request 35229: Report per-container metrics for network bandwidth throttling to the slave.

2015-06-17 Thread Paul Brett
/port_mapping.hpp 4c719b186b519fad0c3869dbdae8b60c3a2c20cc src/slave/containerizer/isolators/network/port_mapping.cpp e55e7b62bc29125458f9c0fb5477057ecc5a90df Diff: https://reviews.apache.org/r/35229/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 35229: Report per-container metrics for network bandwidth throttling to the slave.

2015-06-17 Thread Paul Brett
--- sudo make check Thanks, Paul Brett

Re: Review Request 35229: Report per-container metrics for network bandwidth throttling to the slave.

2015-06-17 Thread Paul Brett
., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35229/ --- (Updated June 17, 2015, 10:58 p.m.) Review request

Re: Review Request 35536: Replace adhoc JSON conversion functions for ResourceStatistics with a protocol buffer to JSON converter.

2015-06-16 Thread Paul Brett
f8372df74cd71df37de4a2438069ef0ea8878512 Diff: https://reviews.apache.org/r/35536/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 35536: Replace adhoc JSON conversion functions for ResourceStatistics with a protocol buffer to JSON converter.

2015-06-16 Thread Paul Brett
--- On June 16, 2015, 8:27 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35536/ --- (Updated June 16

Review Request 35482: Replace adhoc JSON conversion functions for ResourceStatistics with a protocol buffer to JSON converter.

2015-06-15 Thread Paul Brett
--- sudo make check Thanks, Paul Brett

Review Request 34782: Convert Non-POD static variables in fq_codel and ingress to constexpr

2015-05-28 Thread Paul Brett
fece104648307e97755d5a38123e67c442a70474 Diff: https://reviews.apache.org/r/34782/diff/ Testing --- make check Thanks, Paul Brett

Re: Review Request 34782: Convert Non-POD static variables in fq_codel and ingress to constexpr

2015-05-29 Thread Paul Brett
/linux/routing/queueing/ingress.cpp fece104648307e97755d5a38123e67c442a70474 Diff: https://reviews.apache.org/r/34782/diff/ Testing --- make check Thanks, Paul Brett

Review Request 34863: Add tests for new qdisc statistics functions.

2015-05-31 Thread Paul Brett
--- make check Thanks, Paul Brett

Re: Review Request 34426: Report per-container metrics for network bandwidth throttling

2015-05-31 Thread Paul Brett
: https://reviews.apache.org/r/34426/diff/ Testing --- make check Thanks, Paul Brett

Re: Review Request 34426: Report per-container metrics for network bandwidth throttling

2015-05-31 Thread Paul Brett
. - Paul --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34426/#review85274 --- On May 31, 2015, 7:53 p.m., Paul Brett wrote

Review Request 34894: Add new message for Traffic Control statistics

2015-06-01 Thread Paul Brett
. Repository: mesos Description --- Add new message for Traffic Control statistics Diffs - include/mesos/mesos.proto 5cf81e20bc77288eb4c183722c608827b5000cb4 Diff: https://reviews.apache.org/r/34894/diff/ Testing --- make check Thanks, Paul Brett

Re: Review Request 34830: Fix routing ingress/fq_codel search returning wrong qdisc.

2015-06-01 Thread Paul Brett
: https://reviews.apache.org/r/34830/#review86006 --- On May 30, 2015, 9 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https

Review Request 34899: Eliminate multiple uses of literal string in fq_codel and ingress queueing disciplines.

2015-06-01 Thread Paul Brett
src/linux/routing/queueing/ingress.cpp ae0c38d2215e7fabcc1060e7385484bd455e1699 Diff: https://reviews.apache.org/r/34899/diff/ Testing --- make check Thanks, Paul Brett

Re: Review Request 34830: Fix routing ingress/fq_codel search returning wrong qdisc.

2015-06-01 Thread Paul Brett
://reviews.apache.org/r/34830/diff/ Testing --- make check Thanks, Paul Brett

Re: Review Request 34830: Fix routing ingress/fq_codel search returning wrong qdisc.

2015-06-01 Thread Paul Brett
7de1e31d4c43ac9cbffab1e472ea51140719f900 src/linux/routing/queueing/ingress.hpp 84506fecd01522471a7998176c28bea8f1367aed src/linux/routing/queueing/internal.hpp d43a9fd405af2e59dc57cfc7ba9b5e77cb9f6b70 Diff: https://reviews.apache.org/r/34830/diff/ Testing --- make check Thanks, Paul Brett

Re: Review Request 34832: Add new qdisc tests

2015-06-01 Thread Paul Brett
2066a56571f43a012992b4294fbf5b6e07c2b159 Diff: https://reviews.apache.org/r/34832/diff/ Testing --- Thanks, Paul Brett

Re: Review Request 34899: Eliminate multiple uses of literal string in fq_codel and ingress queueing disciplines.

2015-06-01 Thread Paul Brett
/linux/routing/queueing/fq_codel.cpp 64b5c73e8cfa672141ddb663e879c58b4babfdbc src/linux/routing/queueing/ingress.cpp ae0c38d2215e7fabcc1060e7385484bd455e1699 Diff: https://reviews.apache.org/r/34899/diff/ Testing --- make check Thanks, Paul Brett

Re: Review Request 34900: Convert EGRESS_ROOT to constexpr Handle.

2015-06-01 Thread Paul Brett
) - src/linux/routing/handle.hpp 52055d0a92afffdba26f68aed1f86fa648ef8fe4 src/linux/routing/queueing/fq_codel.cpp 64b5c73e8cfa672141ddb663e879c58b4babfdbc Diff: https://reviews.apache.org/r/34900/diff/ Testing --- make check Thanks, Paul Brett

Re: Review Request 34832: Add new qdisc tests

2015-06-01 Thread Paul Brett
--- On May 29, 2015, 10:09 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34832/ --- (Updated May 29, 2015

Re: Review Request 34426: Report per-container metrics for network bandwidth throttling

2015-06-01 Thread Paul Brett
., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34426/ --- (Updated May 31, 2015, 7:53 p.m.) Review request

Re: Review Request 34900: Convert EGRESS_ROOT to constexpr Handle.

2015-06-01 Thread Paul Brett
52055d0a92afffdba26f68aed1f86fa648ef8fe4 src/linux/routing/queueing/fq_codel.cpp 64b5c73e8cfa672141ddb663e879c58b4babfdbc Diff: https://reviews.apache.org/r/34900/diff/ Testing --- make check Thanks, Paul Brett

Re: Review Request 34426: Report per-container metrics for network bandwidth throttling

2015-06-01 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34426/#review86058 --- On May 31, 2015, 7:53 p.m., Paul Brett wrote: --- This is an automatically generated e

Re: Review Request 34894: Add new message for Traffic Control statistics

2015-06-01 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34894/#review86048 --- On June 1, 2015, 4:40 p.m., Paul Brett wrote

Re: Review Request 34899: Eliminate multiple uses of literal string in fq_codel and ingress queueing disciplines.

2015-06-01 Thread Paul Brett
) - src/linux/routing/queueing/fq_codel.cpp 4dc2a9d2ed52937f0a78a083980db488c06b45a7 src/linux/routing/queueing/ingress.cpp ae0c38d2215e7fabcc1060e7385484bd455e1699 Diff: https://reviews.apache.org/r/34899/diff/ Testing --- make check Thanks, Paul Brett

Re: Review Request 34830: Fix routing ingress/fq_codel search returning wrong qdisc.

2015-06-01 Thread Paul Brett
src/linux/routing/queueing/ingress.hpp 84506fecd01522471a7998176c28bea8f1367aed src/linux/routing/queueing/internal.hpp d43a9fd405af2e59dc57cfc7ba9b5e77cb9f6b70 Diff: https://reviews.apache.org/r/34830/diff/ Testing --- make check Thanks, Paul Brett

  1   2   3   >