://reviews.apache.org/r/9/diff/
Testing
---
make test
Thanks,
haosdent huang
Diff: https://reviews.apache.org/r/9/diff/
Testing (updated)
---
make test
Thanks,
haosdent huang
of framework
20150423-012731-16777343-5050-14024-0002 from executor(1)@127.0.0.1:56334
```
Thanks,
haosdent huang
105629ca5673f3bdbcb4321214825a79dc791b3d
src/jvm/org/apache/zookeeper.hpp 0797d474920a5b8127424906d69f7c08bcad9535
src/jvm/org/apache/zookeeper.cpp 192b6478ff31b7c0e84492b221aa05681a8fd239
Diff: https://reviews.apache.org/r/33781/diff/
Testing (updated)
---
make check
Thanks,
haosdent huang
192b6478ff31b7c0e84492b221aa05681a8fd239
Diff: https://reviews.apache.org/r/33781/diff/
Testing
---
Thanks,
haosdent huang
105629ca5673f3bdbcb4321214825a79dc791b3d
src/jvm/org/apache/zookeeper.hpp 0797d474920a5b8127424906d69f7c08bcad9535
src/jvm/org/apache/zookeeper.cpp 192b6478ff31b7c0e84492b221aa05681a8fd239
Diff: https://reviews.apache.org/r/33781/diff/
Testing
---
Thanks,
haosdent huang
/http.hpp
5210ce07c8ea47cf67681455c2f5eb0fda4bb426
Diff: https://reviews.apache.org/r/33793/diff/
Testing
---
make check
Thanks,
haosdent huang
3rdparty/libprocess/3rdparty/stout/tests/insensitivehashmap_tests.cpp
PRE-CREATION
Diff: https://reviews.apache.org/r/33792/diff/
Testing
---
make check
Thanks,
haosdent huang
5210ce07c8ea47cf67681455c2f5eb0fda4bb426
Diff: https://reviews.apache.org/r/33793/diff/
Testing
---
make check
Thanks,
haosdent huang
check
Thanks,
haosdent huang
3fb4ef54e18b377e432b8f8fc918563403e23ab0
Diff: https://reviews.apache.org/r/33794/diff/
Testing
---
make check
Thanks,
haosdent huang
://reviews.apache.org/r/33794/diff/
Testing
---
make check
Thanks,
haosdent huang
---
Thanks,
haosdent huang
24dc369ec271ec2f35449e6ccf49c5b829ca6ce8
3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp
e8a932e5474bf2ba1a93a945ff9bc61fb5146c02
Diff: https://reviews.apache.org/r/33792/diff/
Testing
---
make check
Thanks,
haosdent huang
24dc369ec271ec2f35449e6ccf49c5b829ca6ce8
Diff: https://reviews.apache.org/r/33792/diff/
Testing
---
make check
Thanks,
haosdent huang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34016/#review83299
---
On May 9, 2015, 5:07 p.m., haosdent huang wrote
.
Repository: mesos
Description
---
Change the type of signaledWrapper to unique_ptr
Diffs (updated)
-
src/slave/slave.cpp bf290bfd7d9a59ce7197ce34cbd8cf42e7dd17a3
Diff: https://reviews.apache.org/r/34016/diff/
Testing
---
make check
Thanks,
haosdent huang
you just use a raw pointer here and leak it? (Not ideal but we use
this in many places)
haosdent huang wrote:
Yes, I use raw pointer before. But got this error
```
../../src/slave/slave.cpp:519:19: error: cannot convert
‘process::_Deferredstd::_Bindstd::_Mem_fnvoid (std
24dc369ec271ec2f35449e6ccf49c5b829ca6ce8
Diff: https://reviews.apache.org/r/33792/diff/
Testing
---
make check
Thanks,
haosdent huang
.
Repository: mesos
Description
---
Change the type of signaledWrapper to unique_ptr
Diffs (updated)
-
src/slave/slave.cpp bf290bfd7d9a59ce7197ce34cbd8cf42e7dd17a3
Diff: https://reviews.apache.org/r/34016/diff/
Testing
---
make check
Thanks,
haosdent huang
of framework
20150423-012731-16777343-5050-14024-0002 from executor(1)@127.0.0.1:56334
```
Thanks,
haosdent huang
24dc369ec271ec2f35449e6ccf49c5b829ca6ce8
3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp
e8a932e5474bf2ba1a93a945ff9bc61fb5146c02
Diff: https://reviews.apache.org/r/33792/diff/
Testing
---
make check
Thanks,
haosdent huang
24dc369ec271ec2f35449e6ccf49c5b829ca6ce8
3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp
e8a932e5474bf2ba1a93a945ff9bc61fb5146c02
Diff: https://reviews.apache.org/r/33792/diff/
Testing
---
make check
Thanks,
haosdent huang
/src/encoder.hpp f1b91cf4fc215b6cc8f73285408384269a9bb894
3rdparty/libprocess/src/tests/http_tests.cpp
d29cd29d8c0544671a09d204ca8ba4f24340e2de
Diff: https://reviews.apache.org/r/33793/diff/
Testing
---
make check
Thanks,
haosdent huang
---
Change the type of signaledWrapper to unique_ptr
Diffs
-
src/slave/slave.cpp bf290bfd7d9a59ce7197ce34cbd8cf42e7dd17a3
Diff: https://reviews.apache.org/r/34016/diff/
Testing
---
make check
Thanks,
haosdent huang
/libprocess/3rdparty/stout/tests/hashmap_tests.cpp
e8a932e5474bf2ba1a93a945ff9bc61fb5146c02
Diff: https://reviews.apache.org/r/33792/diff/
Testing
---
make check
Thanks,
haosdent huang
/src/encoder.hpp f1b91cf4fc215b6cc8f73285408384269a9bb894
3rdparty/libprocess/src/tests/http_tests.cpp
d29cd29d8c0544671a09d204ca8ba4f24340e2de
Diff: https://reviews.apache.org/r/33793/diff/
Testing
---
make check
Thanks,
haosdent huang
/libprocess/3rdparty/stout/tests/hashmap_tests.cpp
e8a932e5474bf2ba1a93a945ff9bc61fb5146c02
Diff: https://reviews.apache.org/r/33792/diff/
Testing
---
make check
Thanks,
haosdent huang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33792/#review82415
---
On May 9, 2015, 3:04 p.m., haosdent huang wrote
/libprocess/3rdparty/stout/tests/hashmap_tests.cpp
e8a932e5474bf2ba1a93a945ff9bc61fb5146c02
Diff: https://reviews.apache.org/r/33792/diff/
Testing
---
make check
Thanks,
haosdent huang
/src/encoder.hpp f1b91cf4fc215b6cc8f73285408384269a9bb894
3rdparty/libprocess/src/tests/http_tests.cpp
d29cd29d8c0544671a09d204ca8ba4f24340e2de
Diff: https://reviews.apache.org/r/33793/diff/
Testing
---
make check
Thanks,
haosdent huang
---
make check
Thanks,
haosdent huang
://reviews.apache.org/r/34017/diff/
Testing
---
make check
Thanks,
haosdent huang
588bd3e40a0b350ceca15bb8f3f78290ba41d173
3rdparty/libprocess/src/tests/benchmarks.cpp
0d6714807f7027e6ab199eb0d9ff57bc8a3a2d8a
Diff: https://reviews.apache.org/r/34017/diff/
Testing
---
make check
Thanks,
haosdent huang
/port_mapping.cpp
a4abaff30bb4646b1b1edfdbbc243c9e3f6851df
src/slave/containerizer/mesos/containerizer.cpp
f2587280dc0e1d566d2b856a80358c7b3896c603
Diff: https://reviews.apache.org/r/34018/diff/
Testing
---
make check
Thanks,
haosdent huang
588bd3e40a0b350ceca15bb8f3f78290ba41d173
3rdparty/libprocess/src/tests/benchmarks.cpp
0d6714807f7027e6ab199eb0d9ff57bc8a3a2d8a
Diff: https://reviews.apache.org/r/34017/diff/
Testing
---
make check
Thanks,
haosdent huang
.
Repository: mesos
Description
---
Change the type of signaledWrapper to unique_ptr
Diffs (updated)
-
src/slave/slave.cpp bf290bfd7d9a59ce7197ce34cbd8cf42e7dd17a3
Diff: https://reviews.apache.org/r/34016/diff/
Testing
---
make check
Thanks,
haosdent huang
you just use a raw pointer here and leak it? (Not ideal but we use
this in many places)
haosdent huang wrote:
Yes, I use raw pointer before. But got this error
```
../../src/slave/slave.cpp:519:19: error: cannot convert
‘process::_Deferredstd::_Bindstd::_Mem_fnvoid (std
2ac7fba7a3aac913540f1b09768777393b79284a
src/master/http.cpp 7fa47a9fa2f5667631169876964dccf7fdcc172e
src/slave/http.cpp b5e77b09435e50db5231a2b32faf76dab91dae54
Diff: https://reviews.apache.org/r/34362/diff/
Testing
---
make check
Thanks,
haosdent huang
://issues.apache.org/jira/browse/MESOS-2743
Repository: mesos
Description
---
Include ExecutorInfos in master/state.json
Diffs
-
src/master/http.cpp 7fa47a9fa2f5667631169876964dccf7fdcc172e
Diff: https://reviews.apache.org/r/34362/diff/
Testing
---
make check
Thanks,
haosdent huang
/33754/#comment135310
Maybe we could search the whole project and replace acx_pthread.m4 -
ax_pthread.m4
- haosdent huang
On May 1, 2015, 4:02 p.m., James Peach wrote:
---
This is an automatically generated e-mail. To reply, visit
,
haosdent huang
588bd3e40a0b350ceca15bb8f3f78290ba41d173
3rdparty/libprocess/src/tests/benchmarks.cpp
0d6714807f7027e6ab199eb0d9ff57bc8a3a2d8a
Diff: https://reviews.apache.org/r/34017/diff/
Testing
---
make check
Thanks,
haosdent huang
588bd3e40a0b350ceca15bb8f3f78290ba41d173
3rdparty/libprocess/src/tests/benchmarks.cpp
0d6714807f7027e6ab199eb0d9ff57bc8a3a2d8a
Diff: https://reviews.apache.org/r/34017/diff/
Testing
---
make check
Thanks,
haosdent huang
---
On May 17, 2015, 10:11 a.m., haosdent huang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34018
24dc369ec271ec2f35449e6ccf49c5b829ca6ce8
Diff: https://reviews.apache.org/r/33792/diff/
Testing
---
make check
Thanks,
haosdent huang
. To reply, visit:
https://reviews.apache.org/r/34017/#review84041
---
On May 9, 2015, 7:52 p.m., haosdent huang wrote:
---
This is an automatically generated e-mail. To reply, visit
f1b91cf4fc215b6cc8f73285408384269a9bb894
3rdparty/libprocess/src/tests/http_tests.cpp
d29cd29d8c0544671a09d204ca8ba4f24340e2de
Diff: https://reviews.apache.org/r/34068/diff/
Testing
---
make check
Thanks,
haosdent huang
., haosdent huang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34068/
---
(Updated May 20, 2015, 7:10 p.m.)
Review request
f1b91cf4fc215b6cc8f73285408384269a9bb894
3rdparty/libprocess/src/tests/http_tests.cpp
d29cd29d8c0544671a09d204ca8ba4f24340e2de
Diff: https://reviews.apache.org/r/34068/diff/
Testing
---
make check
Thanks,
haosdent huang
/
Testing
---
make check
Thanks,
haosdent huang
/src/encoder.hpp f1b91cf4fc215b6cc8f73285408384269a9bb894
3rdparty/libprocess/src/tests/http_tests.cpp
d29cd29d8c0544671a09d204ca8ba4f24340e2de
Diff: https://reviews.apache.org/r/33793/diff/
Testing
---
make check
Thanks,
haosdent huang
/
Testing
---
make check
Thanks,
haosdent huang
://reviews.apache.org/r/34068/#comment136019
yes, let me update
- haosdent huang
On May 20, 2015, 7:10 p.m., haosdent huang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34068
/containerizer/mesos/containerizer.cpp
8c102fb7d1f79ee768cb06de3a976ea12f958712
Diff: https://reviews.apache.org/r/35194/diff/
Testing
---
make check
Thanks,
haosdent huang
examples?
- haosdent
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9/#review86113
---
On May 18, 2015, 4:42 p.m., haosdent huang
On June 1, 2015, 8:34 a.m., Adam B wrote:
src/master/http.cpp, line 1038
https://reviews.apache.org/r/34646/diff/3/?file=975522#file975522line1038
Could I ask you to write a quick unit test for this?
haosdent huang wrote:
yes
haosdent huang wrote:
@adam-mesos, I have
---
Disallow special characters in role name.
Diffs
-
src/master/master.hpp af83d3e82d2c161b3cc4583e78a8cbbd2f9a4064
src/master/master.cpp 0135c155181546d3cb43e9e05bb874af846d928d
Diff: https://reviews.apache.org/r/35711/diff/
Testing
---
Thanks,
haosdent huang
4c8102e3cd75e9284dac3d535545370ca37f502c
src/master/http.cpp b893013ddd052cb58c520ac0328f4a5f0fed862e
src/tests/common/http_tests.cpp 97a0eba896aa56acc244afbff83c155024aaedbf
Diff: https://reviews.apache.org/r/35717/diff/
Testing
---
Thanks,
haosdent huang
0135c155181546d3cb43e9e05bb874af846d928d
Diff: https://reviews.apache.org/r/35711/diff/
Testing
---
Thanks,
haosdent huang
4c8102e3cd75e9284dac3d535545370ca37f502c
src/master/http.cpp b893013ddd052cb58c520ac0328f4a5f0fed862e
src/tests/common/http_tests.cpp 97a0eba896aa56acc244afbff83c155024aaedbf
Diff: https://reviews.apache.org/r/35717/diff/
Testing
---
Thanks,
haosdent huang
4c8102e3cd75e9284dac3d535545370ca37f502c
src/master/http.cpp b893013ddd052cb58c520ac0328f4a5f0fed862e
src/tests/common/http_tests.cpp 97a0eba896aa56acc244afbff83c155024aaedbf
Diff: https://reviews.apache.org/r/35717/diff/
Testing
---
Thanks,
haosdent huang
/35728/diff/
Testing
---
Thanks,
haosdent huang
---
Fix failing test: SlaveTest.ROOT_RunTaskWithCommandInfoWithUser.
Diffs
-
src/tests/slave_tests.cpp 50301983c674ef50a64294816db9587bf065aa9e
Diff: https://reviews.apache.org/r/35728/diff/
Testing
---
Thanks,
haosdent huang
., haosdent huang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35782/
---
(Updated June 23, 2015, 10:14 a.m.)
Review
---
On June 22, 2015, 1:56 a.m., haosdent huang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35721
the
volume is guaranteed access to the volume.
haosdent huang wrote:
Thank you very much for your review. If we change the persistent volume
in _runTask, does it cause the scenario like this:
task_A use user_A, task_B use user_B. And then they running at the same
time
---
Thanks,
haosdent huang
af83d3e82d2c161b3cc4583e78a8cbbd2f9a4064
src/master/validation.hpp 469d6f56c3de28a34177124aae81ce24cb4ad160
src/master/validation.cpp 9d128aa1b349b018b8e4a1916434d848761ca051
Diff: https://reviews.apache.org/r/35711/diff/
Testing
---
Thanks,
haosdent huang
/#review89140
---
On June 27, 2015, 8:36 a.m., haosdent huang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35711
/resources_tests.cpp 30c10f3246b807800985f20f8835090657a2d56e
Diff: https://reviews.apache.org/r/35711/diff/
Testing (updated)
---
make -j8 check
Thanks,
haosdent huang
/#review89222
---
On June 27, 2015, 11:35 a.m., haosdent huang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35711
/resources_tests.cpp 30c10f3246b807800985f20f8835090657a2d56e
Diff: https://reviews.apache.org/r/35711/diff/
Testing
---
make -j8 check
Thanks,
haosdent huang
. To reply, visit:
https://reviews.apache.org/r/35728/#review89458
---
On June 27, 2015, 4:37 p.m., haosdent huang wrote:
---
This is an automatically generated e-mail. To reply, visit
/#comment142281
I also replace spaces to tabs here.
- haosdent huang
On June 27, 2015, 11:35 a.m., haosdent huang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35711
/#comment142280
Here are use spaces before, so I replace spaces to tabs.
- haosdent huang
On June 27, 2015, 11:35 a.m., haosdent huang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
`, it not need to
generate `build/src/.libs/lt-mesos-executor`. And then it could finish its
tasks successfully.
Thanks,
haosdent huang
`, it not need to
generate `build/src/.libs/lt-mesos-executor`. And then it could finish its
tasks successfully.
Thanks,
haosdent huang
PRE-CREATION
Diff: https://reviews.apache.org/r/9/diff/
Testing
---
make check
Thanks,
haosdent huang
PRE-CREATION
Diff: https://reviews.apache.org/r/9/diff/
Testing
---
make check
Thanks,
haosdent huang
in a more meaningful way?
TestXxxx should be reserved for test classes.
haosdent huang wrote:
Hmm, name it to TestPersistentVolumeScheduler is follow other exist
examples. Like `TestScheduler` in `TestFramework.java`
Adam B wrote:
At least a few of the other example
PRE-CREATION
Diff: https://reviews.apache.org/r/9/diff/
Testing
---
make check
Thanks,
haosdent huang
/commons-cli/
haosdent huang wrote:
Yes, but it would add a new dependence to Maven. Is it acceptable? Other
exist java examples also simple handle the args.
Marco Massenzio wrote:
I am not sure what the official policy is here - but this is a widely
used library (and not a major
://reviews.apache.org/r/35815/#comment141719
Should change to stout/protobuf.hpp here?
src/tests/master_contender_detector_tests.cpp (line 844)
https://reviews.apache.org/r/35815/#comment141720
Seems the indent is not correct here.
- haosdent huang
On June 24, 2015, 1:15 a.m., Marco
://reviews.apache.org/r/35815/#comment141722
Oh, you are follow the test case before.
- haosdent huang
On June 24, 2015, 1:15 a.m., Marco Massenzio wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35815/#review89123
---
Ship it!
Ship It!
- haosdent huang
On June 24, 2015, 1:15 a.m
the to instance of the `receiver` object. It
also had the same un-documented dangerous behavior.
The same goes for `event2` below.
haosdent huang wrote:
Agree here, seems a lot of lambda::bind need use capture reference if we
want to convert it. And it's danger. I also find some
a `std::bind`. I think the lambda is more
readable, the bind is more explicit about what is going on :-)
Depending on the way the community votes, I would add a comment here just
stating that this is a proxy lambda. What do you think?
haosdent huang wrote:
I think it would be better
/src/encoder.hpp f1b91cf4fc215b6cc8f73285408384269a9bb894
3rdparty/libprocess/src/tests/http_tests.cpp
d29cd29d8c0544671a09d204ca8ba4f24340e2de
Diff: https://reviews.apache.org/r/33793/diff/
Testing
---
make check
Thanks,
haosdent huang
/r/33793/#review85769
---
On May 31, 2015, 6:14 p.m., haosdent huang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33793
Diff: https://reviews.apache.org/r/34068/diff/
Testing
---
make check
Thanks,
haosdent huang
/hashmap.hpp
215007b7ba8c4093ce95b79a07fd84445048b58a
Diff: https://reviews.apache.org/r/33792/diff/
Testing
---
make check
Thanks,
haosdent huang
/libprocess/src/encoder.hpp f1b91cf4fc215b6cc8f73285408384269a9bb894
3rdparty/libprocess/src/tests/http_tests.cpp
d29cd29d8c0544671a09d204ca8ba4f24340e2de
Diff: https://reviews.apache.org/r/33793/diff/
Testing
---
make check
Thanks,
haosdent huang
```
Thanks,
haosdent huang
.
- haosdent
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34646/#review85528
---
On June 1, 2015, 6:35 a.m., haosdent huang wrote
seems the order here is follow dictionary order, so how about move them
after `tests/authorization_tests.cpp`?
- haosdent huang
On May 31, 2015, 2:58 a.m., Marco Massenzio wrote:
---
This is an automatically generated e-mail
/#comment137766
How about change 'ID, port and IP' to 'id, port and ip'?
- haosdent huang
On May 31, 2015, 2:58 a.m., Marco Massenzio wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34687
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34687/#review85949
---
Ship it!
Ship It!
- haosdent huang
On May 31, 2015, 2:58 a.m
85e1bdec8d7e8f46477d0f3d88847baeca2dcc9c
Diff: https://reviews.apache.org/r/34655/diff/
Testing
---
Thanks,
haosdent huang
3rdparty/libprocess/src/encoder.hpp f1b91cf4fc215b6cc8f73285408384269a9bb894
3rdparty/libprocess/src/tests/http_tests.cpp
d29cd29d8c0544671a09d204ca8ba4f24340e2de
Diff: https://reviews.apache.org/r/33793/diff/
Testing
---
make check
Thanks,
haosdent huang
1 - 100 of 3716 matches
Mail list logo