Review Request 33554: Avoid Python declineOffer raise exception when filters is assigned to None explicitly

2015-04-25 Thread haosdent huang
: https://reviews.apache.org/r/33554/diff/ Testing --- make check Thanks, haosdent huang

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

2015-04-25 Thread haosdent huang
://reviews.apache.org/r/9/diff/ Testing --- make test Thanks, haosdent huang

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

2015-04-25 Thread haosdent huang
Diff: https://reviews.apache.org/r/9/diff/ Testing (updated) --- make test Thanks, haosdent huang

Re: Review Request 33109: Allow setting environment variables in mesos-execute

2015-04-25 Thread haosdent huang
of framework 20150423-012731-16777343-5050-14024-0002 from executor(1)@127.0.0.1:56334 ``` Thanks, haosdent huang

Re: Review Request 33781: Add license blobs to Java JNI cpp files

2015-05-02 Thread haosdent huang
105629ca5673f3bdbcb4321214825a79dc791b3d src/jvm/org/apache/zookeeper.hpp 0797d474920a5b8127424906d69f7c08bcad9535 src/jvm/org/apache/zookeeper.cpp 192b6478ff31b7c0e84492b221aa05681a8fd239 Diff: https://reviews.apache.org/r/33781/diff/ Testing (updated) --- make check Thanks, haosdent huang

Review Request 33781: Add license blobs to Java JNI cpp files

2015-05-02 Thread haosdent huang
192b6478ff31b7c0e84492b221aa05681a8fd239 Diff: https://reviews.apache.org/r/33781/diff/ Testing --- Thanks, haosdent huang

Re: Review Request 33781: Add license blobs to Java JNI cpp files

2015-05-02 Thread haosdent huang
105629ca5673f3bdbcb4321214825a79dc791b3d src/jvm/org/apache/zookeeper.hpp 0797d474920a5b8127424906d69f7c08bcad9535 src/jvm/org/apache/zookeeper.cpp 192b6478ff31b7c0e84492b221aa05681a8fd239 Diff: https://reviews.apache.org/r/33781/diff/ Testing --- Thanks, haosdent huang

Re: Review Request 33793: HTTP headers should be considered case-insensitive.

2015-05-03 Thread haosdent huang
/http.hpp 5210ce07c8ea47cf67681455c2f5eb0fda4bb426 Diff: https://reviews.apache.org/r/33793/diff/ Testing --- make check Thanks, haosdent huang

Review Request 33792: Add InsensitiveHashMap.

2015-05-03 Thread haosdent huang
3rdparty/libprocess/3rdparty/stout/tests/insensitivehashmap_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/33792/diff/ Testing --- make check Thanks, haosdent huang

Review Request 33793: HTTP headers should be considered case-insensitive.

2015-05-03 Thread haosdent huang
5210ce07c8ea47cf67681455c2f5eb0fda4bb426 Diff: https://reviews.apache.org/r/33793/diff/ Testing --- make check Thanks, haosdent huang

Review Request 33794: Update existing lambdas to meet style guide

2015-05-03 Thread haosdent huang
check Thanks, haosdent huang

Re: Review Request 33794: Update existing lambdas to meet style guide

2015-05-03 Thread haosdent huang
3fb4ef54e18b377e432b8f8fc918563403e23ab0 Diff: https://reviews.apache.org/r/33794/diff/ Testing --- make check Thanks, haosdent huang

Re: Review Request 33794: Update existing lambdas to meet style guide

2015-05-03 Thread haosdent huang
://reviews.apache.org/r/33794/diff/ Testing --- make check Thanks, haosdent huang

Review Request 33795: Add a shutdownExecutor() method to the scheduler driver

2015-05-03 Thread haosdent huang
--- Thanks, haosdent huang

Re: Review Request 33792: Extend hashmap to support custom equality and hash

2015-05-11 Thread haosdent huang
24dc369ec271ec2f35449e6ccf49c5b829ca6ce8 3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp e8a932e5474bf2ba1a93a945ff9bc61fb5146c02 Diff: https://reviews.apache.org/r/33792/diff/ Testing --- make check Thanks, haosdent huang

Re: Review Request 33792: Extend hashmap to support custom equality and hash

2015-05-11 Thread haosdent huang
24dc369ec271ec2f35449e6ccf49c5b829ca6ce8 Diff: https://reviews.apache.org/r/33792/diff/ Testing --- make check Thanks, haosdent huang

Re: Review Request 34016: Change the type of signaledWrapper to unique_ptr

2015-05-11 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34016/#review83299 --- On May 9, 2015, 5:07 p.m., haosdent huang wrote

Re: Review Request 34016: Change the type of signaledWrapper to unique_ptr

2015-05-11 Thread haosdent huang
. Repository: mesos Description --- Change the type of signaledWrapper to unique_ptr Diffs (updated) - src/slave/slave.cpp bf290bfd7d9a59ce7197ce34cbd8cf42e7dd17a3 Diff: https://reviews.apache.org/r/34016/diff/ Testing --- make check Thanks, haosdent huang

Re: Review Request 33792: Extend hashmap to support custom equality and hash

2015-05-11 Thread haosdent huang
. To reply, visit: https://reviews.apache.org/r/33792/#review83303 --- On May 12, 2015, 12:55 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 34016: Change the type of signaledWrapper to unique_ptr

2015-05-11 Thread haosdent huang
. Repository: mesos Description --- Change the type of signaledWrapper to unique_ptr Diffs (updated) - src/slave/slave.cpp bf290bfd7d9a59ce7197ce34cbd8cf42e7dd17a3 Diff: https://reviews.apache.org/r/34016/diff/ Testing --- make check Thanks, haosdent huang

Re: Review Request 34016: Change the type of signaledWrapper to unique_ptr

2015-05-11 Thread haosdent huang
you just use a raw pointer here and leak it? (Not ideal but we use this in many places) haosdent huang wrote: Yes, I use raw pointer before. But got this error ``` ../../src/slave/slave.cpp:519:19: error: cannot convert ‘process::_Deferredstd::_Bindstd::_Mem_fnvoid (std

Re: Review Request 33792: Extend hashmap to support custom equality and hash

2015-05-11 Thread haosdent huang
24dc369ec271ec2f35449e6ccf49c5b829ca6ce8 Diff: https://reviews.apache.org/r/33792/diff/ Testing --- make check Thanks, haosdent huang

Review Request 34068: The test case of extend hashmap to support custom equality and hash

2015-05-11 Thread haosdent huang
, haosdent huang

Re: Review Request 34016: Change the type of signaledWrapper to unique_ptr

2015-05-11 Thread haosdent huang
. Repository: mesos Description --- Change the type of signaledWrapper to unique_ptr Diffs (updated) - src/slave/slave.cpp bf290bfd7d9a59ce7197ce34cbd8cf42e7dd17a3 Diff: https://reviews.apache.org/r/34016/diff/ Testing --- make check Thanks, haosdent huang

Re: Review Request 33109: Allow setting environment variables in mesos-execute

2015-05-12 Thread haosdent huang
of framework 20150423-012731-16777343-5050-14024-0002 from executor(1)@127.0.0.1:56334 ``` Thanks, haosdent huang

Re: Review Request 33109: Allow setting environment variables in mesos-execute

2015-05-12 Thread haosdent huang
of framework 20150423-012731-16777343-5050-14024-0002 from executor(1)@127.0.0.1:56334 ``` Thanks, haosdent huang

Re: Review Request 33792: Extend hashmap to support custom equality and hash

2015-05-09 Thread haosdent huang
24dc369ec271ec2f35449e6ccf49c5b829ca6ce8 3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp e8a932e5474bf2ba1a93a945ff9bc61fb5146c02 Diff: https://reviews.apache.org/r/33792/diff/ Testing --- make check Thanks, haosdent huang

Re: Review Request 33792: Extend hashmap to support custom equality and hash

2015-05-09 Thread haosdent huang
24dc369ec271ec2f35449e6ccf49c5b829ca6ce8 3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp e8a932e5474bf2ba1a93a945ff9bc61fb5146c02 Diff: https://reviews.apache.org/r/33792/diff/ Testing --- make check Thanks, haosdent huang

Re: Review Request 33793: HTTP headers should be considered case-insensitive.

2015-05-09 Thread haosdent huang
/src/encoder.hpp f1b91cf4fc215b6cc8f73285408384269a9bb894 3rdparty/libprocess/src/tests/http_tests.cpp d29cd29d8c0544671a09d204ca8ba4f24340e2de Diff: https://reviews.apache.org/r/33793/diff/ Testing --- make check Thanks, haosdent huang

Review Request 34016: Change the type of signaledWrapper to unique_ptr

2015-05-09 Thread haosdent huang
--- Change the type of signaledWrapper to unique_ptr Diffs - src/slave/slave.cpp bf290bfd7d9a59ce7197ce34cbd8cf42e7dd17a3 Diff: https://reviews.apache.org/r/34016/diff/ Testing --- make check Thanks, haosdent huang

Re: Review Request 33792: Extend hashmap to support custom equality and hash

2015-05-09 Thread haosdent huang
/libprocess/3rdparty/stout/tests/hashmap_tests.cpp e8a932e5474bf2ba1a93a945ff9bc61fb5146c02 Diff: https://reviews.apache.org/r/33792/diff/ Testing --- make check Thanks, haosdent huang

Re: Review Request 33793: HTTP headers should be considered case-insensitive.

2015-05-09 Thread haosdent huang
/src/encoder.hpp f1b91cf4fc215b6cc8f73285408384269a9bb894 3rdparty/libprocess/src/tests/http_tests.cpp d29cd29d8c0544671a09d204ca8ba4f24340e2de Diff: https://reviews.apache.org/r/33793/diff/ Testing --- make check Thanks, haosdent huang

Re: Review Request 33793: HTTP headers should be considered case-insensitive.

2015-05-09 Thread haosdent huang
/src/encoder.hpp f1b91cf4fc215b6cc8f73285408384269a9bb894 3rdparty/libprocess/src/tests/http_tests.cpp d29cd29d8c0544671a09d204ca8ba4f24340e2de Diff: https://reviews.apache.org/r/33793/diff/ Testing --- make check Thanks, haosdent huang

Re: Review Request 33792: Extend hashmap to support custom equality and hash

2015-05-09 Thread haosdent huang
/libprocess/3rdparty/stout/tests/hashmap_tests.cpp e8a932e5474bf2ba1a93a945ff9bc61fb5146c02 Diff: https://reviews.apache.org/r/33792/diff/ Testing --- make check Thanks, haosdent huang

Re: Review Request 33792: Extend hashmap to support custom equality and hash

2015-05-09 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33792/#review82415 --- On May 9, 2015, 3:04 p.m., haosdent huang wrote

Re: Review Request 33792: Extend hashmap to support custom equality and hash

2015-05-09 Thread haosdent huang
/libprocess/3rdparty/stout/tests/hashmap_tests.cpp e8a932e5474bf2ba1a93a945ff9bc61fb5146c02 Diff: https://reviews.apache.org/r/33792/diff/ Testing --- make check Thanks, haosdent huang

Re: Review Request 33793: HTTP headers should be considered case-insensitive.

2015-05-09 Thread haosdent huang
/src/encoder.hpp f1b91cf4fc215b6cc8f73285408384269a9bb894 3rdparty/libprocess/src/tests/http_tests.cpp d29cd29d8c0544671a09d204ca8ba4f24340e2de Diff: https://reviews.apache.org/r/33793/diff/ Testing --- make check Thanks, haosdent huang

Review Request 34017: Update existing lambdas to meet style guide

2015-05-09 Thread haosdent huang
--- make check Thanks, haosdent huang

Re: Review Request 34017: Update existing lambdas to meet style guide

2015-05-09 Thread haosdent huang
://reviews.apache.org/r/34017/diff/ Testing --- make check Thanks, haosdent huang

Re: Review Request 34017: Update existing lambdas to meet style guide

2015-05-09 Thread haosdent huang
588bd3e40a0b350ceca15bb8f3f78290ba41d173 3rdparty/libprocess/src/tests/benchmarks.cpp 0d6714807f7027e6ab199eb0d9ff57bc8a3a2d8a Diff: https://reviews.apache.org/r/34017/diff/ Testing --- make check Thanks, haosdent huang

Re: Review Request 34018: Update existing lambdas to meet style guide

2015-05-09 Thread haosdent huang
/port_mapping.cpp a4abaff30bb4646b1b1edfdbbc243c9e3f6851df src/slave/containerizer/mesos/containerizer.cpp f2587280dc0e1d566d2b856a80358c7b3896c603 Diff: https://reviews.apache.org/r/34018/diff/ Testing --- make check Thanks, haosdent huang

Re: Review Request 34017: Update existing lambdas to meet style guide

2015-05-09 Thread haosdent huang
588bd3e40a0b350ceca15bb8f3f78290ba41d173 3rdparty/libprocess/src/tests/benchmarks.cpp 0d6714807f7027e6ab199eb0d9ff57bc8a3a2d8a Diff: https://reviews.apache.org/r/34017/diff/ Testing --- make check Thanks, haosdent huang

Re: Review Request 34018: Update existing lambdas to meet style guide

2015-05-09 Thread haosdent huang
/port_mapping.cpp a4abaff30bb4646b1b1edfdbbc243c9e3f6851df src/slave/containerizer/mesos/containerizer.cpp f2587280dc0e1d566d2b856a80358c7b3896c603 Diff: https://reviews.apache.org/r/34018/diff/ Testing --- make check Thanks, haosdent huang

Re: Review Request 34016: Change the type of signaledWrapper to unique_ptr

2015-05-12 Thread haosdent huang
. Repository: mesos Description --- Change the type of signaledWrapper to unique_ptr Diffs (updated) - src/slave/slave.cpp bf290bfd7d9a59ce7197ce34cbd8cf42e7dd17a3 Diff: https://reviews.apache.org/r/34016/diff/ Testing --- make check Thanks, haosdent huang

Re: Review Request 34016: Change the type of signaledWrapper to unique_ptr

2015-05-12 Thread haosdent huang
you just use a raw pointer here and leak it? (Not ideal but we use this in many places) haosdent huang wrote: Yes, I use raw pointer before. But got this error ``` ../../src/slave/slave.cpp:519:19: error: cannot convert ‘process::_Deferredstd::_Bindstd::_Mem_fnvoid (std

Re: Review Request 34362: Include ExecutorInfos in master/state.json

2015-05-18 Thread haosdent huang
2ac7fba7a3aac913540f1b09768777393b79284a src/master/http.cpp 7fa47a9fa2f5667631169876964dccf7fdcc172e src/slave/http.cpp b5e77b09435e50db5231a2b32faf76dab91dae54 Diff: https://reviews.apache.org/r/34362/diff/ Testing --- make check Thanks, haosdent huang

Review Request 34362: Include ExecutorInfos in master/state.json

2015-05-18 Thread haosdent huang
://issues.apache.org/jira/browse/MESOS-2743 Repository: mesos Description --- Include ExecutorInfos in master/state.json Diffs - src/master/http.cpp 7fa47a9fa2f5667631169876964dccf7fdcc172e Diff: https://reviews.apache.org/r/34362/diff/ Testing --- make check Thanks, haosdent huang

Re: Review Request 33753: Update pthread and python autoconf macros for Mesos.

2015-05-18 Thread haosdent huang
Should we change acx_pthread.m4 to ax_pthread.m4 here? - haosdent huang On May 1, 2015, 4:02 p.m., James Peach wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33753

Re: Review Request 33754: Update pthread autoconf macros for libprocess.

2015-05-18 Thread haosdent huang
/33754/#comment135310 Maybe we could search the whole project and replace acx_pthread.m4 - ax_pthread.m4 - haosdent huang On May 1, 2015, 4:02 p.m., James Peach wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 33753: Update pthread and python autoconf macros for Mesos.

2015-05-18 Thread haosdent huang
/#comment135311 Could not understand why need add conf('SYSLIBS')) here? Could you explain this? Thank you - haosdent huang On May 1, 2015, 4:02 p.m., James Peach wrote: --- This is an automatically generated e-mail. To reply, visit: https

Review Request 34327: Update existing lambdas to meet style guide

2015-05-17 Thread haosdent huang
, haosdent huang

Re: Review Request 34017: Update existing lambdas to meet style guide

2015-05-17 Thread haosdent huang
588bd3e40a0b350ceca15bb8f3f78290ba41d173 3rdparty/libprocess/src/tests/benchmarks.cpp 0d6714807f7027e6ab199eb0d9ff57bc8a3a2d8a Diff: https://reviews.apache.org/r/34017/diff/ Testing --- make check Thanks, haosdent huang

Re: Review Request 34017: Update existing lambdas to meet style guide

2015-05-17 Thread haosdent huang
588bd3e40a0b350ceca15bb8f3f78290ba41d173 3rdparty/libprocess/src/tests/benchmarks.cpp 0d6714807f7027e6ab199eb0d9ff57bc8a3a2d8a Diff: https://reviews.apache.org/r/34017/diff/ Testing --- make check Thanks, haosdent huang

Re: Review Request 34018: Update existing lambdas to meet style guide

2015-05-17 Thread haosdent huang
/port_mapping.cpp a4abaff30bb4646b1b1edfdbbc243c9e3f6851df src/slave/containerizer/mesos/containerizer.cpp b644b9c74bc23cf78c0a53284544be6cdaef2f8a Diff: https://reviews.apache.org/r/34018/diff/ Testing --- make check Thanks, haosdent huang

Re: Review Request 34018: Update existing lambdas to meet style guide

2015-05-17 Thread haosdent huang
--- On May 17, 2015, 10:11 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34018

Re: Review Request 33792: Extend hashmap to support custom equality and hash

2015-05-19 Thread haosdent huang
24dc369ec271ec2f35449e6ccf49c5b829ca6ce8 Diff: https://reviews.apache.org/r/33792/diff/ Testing --- make check Thanks, haosdent huang

Re: Review Request 34017: Update existing lambdas to meet style guide

2015-05-17 Thread haosdent huang
. To reply, visit: https://reviews.apache.org/r/34017/#review84041 --- On May 9, 2015, 7:52 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 34068: The test case of extend hashmap to support custom equality and hash

2015-05-20 Thread haosdent huang
/ Testing --- make check Thanks, haosdent huang

Re: Review Request 34068: The test case of extend hashmap to support custom equality and hash

2015-05-20 Thread haosdent huang
/ Testing --- make check Thanks, haosdent huang

Re: Review Request 34068: The test case of extend hashmap to support custom equality and hash

2015-05-20 Thread haosdent huang
f1b91cf4fc215b6cc8f73285408384269a9bb894 3rdparty/libprocess/src/tests/http_tests.cpp d29cd29d8c0544671a09d204ca8ba4f24340e2de Diff: https://reviews.apache.org/r/34068/diff/ Testing --- make check Thanks, haosdent huang

Re: Review Request 34068: The test case of extend hashmap to support custom equality and hash

2015-05-20 Thread haosdent huang
., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34068/ --- (Updated May 20, 2015, 7:10 p.m.) Review request

Re: Review Request 34068: The test case of extend hashmap to support custom equality and hash

2015-05-20 Thread haosdent huang
f1b91cf4fc215b6cc8f73285408384269a9bb894 3rdparty/libprocess/src/tests/http_tests.cpp d29cd29d8c0544671a09d204ca8ba4f24340e2de Diff: https://reviews.apache.org/r/34068/diff/ Testing --- make check Thanks, haosdent huang

Re: Review Request 34068: The test case of extend hashmap to support custom equality and hash

2015-05-20 Thread haosdent huang
/ Testing --- make check Thanks, haosdent huang

Re: Review Request 33793: HTTP headers should be considered case-insensitive.

2015-05-20 Thread haosdent huang
/src/encoder.hpp f1b91cf4fc215b6cc8f73285408384269a9bb894 3rdparty/libprocess/src/tests/http_tests.cpp d29cd29d8c0544671a09d204ca8ba4f24340e2de Diff: https://reviews.apache.org/r/33793/diff/ Testing --- make check Thanks, haosdent huang

Re: Review Request 34068: The test case of extend hashmap to support custom equality and hash

2015-05-20 Thread haosdent huang
/ Testing --- make check Thanks, haosdent huang

Re: Review Request 34068: The test case of extend hashmap to support custom equality and hash

2015-05-21 Thread haosdent huang
://reviews.apache.org/r/34068/#comment136019 yes, let me update - haosdent huang On May 20, 2015, 7:10 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34068

Review Request 35194: Exposing Resources along with ResourceStatistics

2015-06-07 Thread haosdent huang
/containerizer/mesos/containerizer.cpp 8c102fb7d1f79ee768cb06de3a976ea12f958712 Diff: https://reviews.apache.org/r/35194/diff/ Testing --- make check Thanks, haosdent huang

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

2015-06-06 Thread haosdent huang
examples? - haosdent --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/#review86113 --- On May 18, 2015, 4:42 p.m., haosdent huang

Re: Review Request 34646: Redirect to the leader master when current master is not a leader.

2015-06-07 Thread haosdent huang
On June 1, 2015, 8:34 a.m., Adam B wrote: src/master/http.cpp, line 1038 https://reviews.apache.org/r/34646/diff/3/?file=975522#file975522line1038 Could I ask you to write a quick unit test for this? haosdent huang wrote: yes haosdent huang wrote: @adam-mesos, I have

Review Request 35711: Disallow special characters in role name.

2015-06-21 Thread haosdent huang
--- Disallow special characters in role name. Diffs - src/master/master.hpp af83d3e82d2c161b3cc4583e78a8cbbd2f9a4064 src/master/master.cpp 0135c155181546d3cb43e9e05bb874af846d928d Diff: https://reviews.apache.org/r/35711/diff/ Testing --- Thanks, haosdent huang

Re: Review Request 35717: Add reservations support to master's state.json

2015-06-21 Thread haosdent huang
4c8102e3cd75e9284dac3d535545370ca37f502c src/master/http.cpp b893013ddd052cb58c520ac0328f4a5f0fed862e src/tests/common/http_tests.cpp 97a0eba896aa56acc244afbff83c155024aaedbf Diff: https://reviews.apache.org/r/35717/diff/ Testing --- Thanks, haosdent huang

Re: Review Request 35711: Disallow special characters in role name.

2015-06-21 Thread haosdent huang
0135c155181546d3cb43e9e05bb874af846d928d Diff: https://reviews.apache.org/r/35711/diff/ Testing --- Thanks, haosdent huang

Re: Review Request 35721: Set the owner of persistent volumes to frameworkInfo.user .

2015-06-21 Thread haosdent huang
1c8d79e3fca365520cdd67051f8730593955cab6 src/slave/slave.hpp f1cf3b85ccb3eaf614fe844c830f7cc44f7916fe src/slave/slave.cpp 40c0c33add392591af4767f76ce566196f24e6ee Diff: https://reviews.apache.org/r/35721/diff/ Testing --- Thanks, haosdent huang

Re: Review Request 35717: Add reservations support to master's state.json

2015-06-21 Thread haosdent huang
4c8102e3cd75e9284dac3d535545370ca37f502c src/master/http.cpp b893013ddd052cb58c520ac0328f4a5f0fed862e src/tests/common/http_tests.cpp 97a0eba896aa56acc244afbff83c155024aaedbf Diff: https://reviews.apache.org/r/35717/diff/ Testing --- Thanks, haosdent huang

Re: Review Request 35717: Add reservations support to master's state.json

2015-06-21 Thread haosdent huang
On June 21, 2015, 5:56 p.m., Michael Park wrote: src/common/http.cpp, line 88 https://reviews.apache.org/r/35717/diff/1/?file=989232#file989232line88 `s/key/role/` haosdent huang wrote: I think use key may be more general. Because this method not only could be used

Re: Review Request 35717: Add reservations support to master's state.json

2015-06-22 Thread haosdent huang
4c8102e3cd75e9284dac3d535545370ca37f502c src/master/http.cpp b893013ddd052cb58c520ac0328f4a5f0fed862e src/tests/common/http_tests.cpp 97a0eba896aa56acc244afbff83c155024aaedbf Diff: https://reviews.apache.org/r/35717/diff/ Testing --- Thanks, haosdent huang

Re: Review Request 35728: Fix failing test: SlaveTest.ROOT_RunTaskWithCommandInfoWithUser.

2015-06-22 Thread haosdent huang
/35728/diff/ Testing --- Thanks, haosdent huang

Review Request 35728: Fix failing test: SlaveTest.ROOT_RunTaskWithCommandInfoWithUser.

2015-06-22 Thread haosdent huang
--- Fix failing test: SlaveTest.ROOT_RunTaskWithCommandInfoWithUser. Diffs - src/tests/slave_tests.cpp 50301983c674ef50a64294816db9587bf065aa9e Diff: https://reviews.apache.org/r/35728/diff/ Testing --- Thanks, haosdent huang

Re: Review Request 35782: fix web UI shows YYYY for year instead of year

2015-06-24 Thread haosdent huang
., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35782/ --- (Updated June 23, 2015, 10:14 a.m.) Review

Re: Review Request 35721: Set the owner of persistent volumes to frameworkInfo.user .

2015-06-24 Thread haosdent huang
--- On June 22, 2015, 1:56 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35721

Re: Review Request 32750: MESOS-2585: Use full width for mesos div.container

2015-06-24 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32750/#review89139 --- Ship it! Ship It! - haosdent huang On April 2, 2015, 10:26 p.m

Re: Review Request 35721: Set the owner of persistent volumes to frameworkInfo.user .

2015-06-24 Thread haosdent huang
the volume is guaranteed access to the volume. haosdent huang wrote: Thank you very much for your review. If we change the persistent volume in _runTask, does it cause the scenario like this: task_A use user_A, task_B use user_B. And then they running at the same time

Review Request 35782: fix web UI shows YYYY for year instead of year

2015-06-23 Thread haosdent huang
--- Thanks, haosdent huang

Re: Review Request 35711: Disallow special characters in role name.

2015-06-27 Thread haosdent huang
af83d3e82d2c161b3cc4583e78a8cbbd2f9a4064 src/master/validation.hpp 469d6f56c3de28a34177124aae81ce24cb4ad160 src/master/validation.cpp 9d128aa1b349b018b8e4a1916434d848761ca051 Diff: https://reviews.apache.org/r/35711/diff/ Testing --- Thanks, haosdent huang

Re: Review Request 35711: Disallow special characters in role name.

2015-06-27 Thread haosdent huang
/#review89140 --- On June 27, 2015, 8:36 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711

Re: Review Request 35711: Disallow special characters in role name.

2015-06-27 Thread haosdent huang
/resources_tests.cpp 30c10f3246b807800985f20f8835090657a2d56e Diff: https://reviews.apache.org/r/35711/diff/ Testing (updated) --- make -j8 check Thanks, haosdent huang

Re: Review Request 35711: Disallow special characters in role name.

2015-06-27 Thread haosdent huang
/#review89222 --- On June 27, 2015, 11:35 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711

Re: Review Request 35711: Disallow special characters in role name.

2015-06-27 Thread haosdent huang
/resources_tests.cpp 30c10f3246b807800985f20f8835090657a2d56e Diff: https://reviews.apache.org/r/35711/diff/ Testing --- make -j8 check Thanks, haosdent huang

Re: Review Request 35728: Fix failing test: SlaveTest.ROOT_RunTaskWithCommandInfoWithUser.

2015-06-27 Thread haosdent huang
. To reply, visit: https://reviews.apache.org/r/35728/#review89458 --- On June 27, 2015, 4:37 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 35711: Disallow special characters in role name.

2015-06-27 Thread haosdent huang
/#comment142281 I also replace spaces to tabs here. - haosdent huang On June 27, 2015, 11:35 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711

Re: Review Request 35711: Disallow special characters in role name.

2015-06-27 Thread haosdent huang
/#comment142280 Here are use spaces before, so I replace spaces to tabs. - haosdent huang On June 27, 2015, 11:35 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r

Re: Review Request 35728: Fix failing test: SlaveTest.ROOT_RunTaskWithCommandInfoWithUser.

2015-06-27 Thread haosdent huang
`, it not need to generate `build/src/.libs/lt-mesos-executor`. And then it could finish its tasks successfully. Thanks, haosdent huang

Re: Review Request 35728: Fix failing test: SlaveTest.ROOT_RunTaskWithCommandInfoWithUser.

2015-06-27 Thread haosdent huang
`, it not need to generate `build/src/.libs/lt-mesos-executor`. And then it could finish its tasks successfully. Thanks, haosdent huang

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

2015-06-20 Thread haosdent huang
PRE-CREATION Diff: https://reviews.apache.org/r/9/diff/ Testing --- make check Thanks, haosdent huang

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

2015-06-20 Thread haosdent huang
PRE-CREATION Diff: https://reviews.apache.org/r/9/diff/ Testing --- make check Thanks, haosdent huang

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

2015-06-20 Thread haosdent huang
in a more meaningful way? TestXxxx should be reserved for test classes. haosdent huang wrote: Hmm, name it to TestPersistentVolumeScheduler is follow other exist examples. Like `TestScheduler` in `TestFramework.java` Adam B wrote: At least a few of the other example

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

2015-06-21 Thread haosdent huang
PRE-CREATION Diff: https://reviews.apache.org/r/9/diff/ Testing --- make check Thanks, haosdent huang

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

2015-06-21 Thread haosdent huang
/commons-cli/ haosdent huang wrote: Yes, but it would add a new dependence to Maven. Is it acceptable? Other exist java examples also simple handle the args. Marco Massenzio wrote: I am not sure what the official policy is here - but this is a widely used library (and not a major

Re: Review Request 35815: Testing JSON paylodad in ZooKeeper

2015-06-23 Thread haosdent huang
://reviews.apache.org/r/35815/#comment141719 Should change to stout/protobuf.hpp here? src/tests/master_contender_detector_tests.cpp (line 844) https://reviews.apache.org/r/35815/#comment141720 Seems the indent is not correct here. - haosdent huang On June 24, 2015, 1:15 a.m., Marco

Re: Review Request 35815: Testing JSON paylodad in ZooKeeper

2015-06-23 Thread haosdent huang
://reviews.apache.org/r/35815/#comment141722 Oh, you are follow the test case before. - haosdent huang On June 24, 2015, 1:15 a.m., Marco Massenzio wrote: --- This is an automatically generated e-mail. To reply, visit: https

  1   2   3   4   5   6   7   8   9   10   >