Re: Review Request 14309: Properly get gethostbyname2_r error on OS X.

2015-06-14 Thread Benjamin Hindman


> On June 12, 2015, 10:47 p.m., Niklas Nielsen wrote:
> > BenH: Still want this in?

I'll do one better, since these macros are no longer used I'll just remove all 
of that code! See https://reviews.apache.org/r/35441.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14309/#review87774
---


On Sept. 24, 2013, 6:03 a.m., Benjamin Hindman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14309/
> ---
> 
> (Updated Sept. 24, 2013, 6:03 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 728122ec9eeb903723daa9294e258fed2141bea6 
> 
> Diff: https://reviews.apache.org/r/14309/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>



Re: Review Request 14309: Properly get gethostbyname2_r error on OS X.

2015-06-12 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14309/#review87791
---


Bad patch!

Reviews applied: [14309]

Failed command: ./support/apply-review.sh -n -r 14309

Error:
 2015-06-13 00:54:43 URL:https://reviews.apache.org/r/14309/diff/raw/ 
[1058/1058] -> "14309.patch" [1]
error: patch failed: 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp:71
error: 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp: patch does not 
apply
Failed to apply patch

- Mesos ReviewBot


On Sept. 24, 2013, 6:03 a.m., Benjamin Hindman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14309/
> ---
> 
> (Updated Sept. 24, 2013, 6:03 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 728122ec9eeb903723daa9294e258fed2141bea6 
> 
> Diff: https://reviews.apache.org/r/14309/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>



Re: Review Request 14309: Properly get gethostbyname2_r error on OS X.

2015-06-12 Thread Niklas Nielsen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14309/#review87774
---


BenH: Still want this in?

- Niklas Nielsen


On Sept. 23, 2013, 11:03 p.m., Benjamin Hindman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14309/
> ---
> 
> (Updated Sept. 23, 2013, 11:03 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 728122ec9eeb903723daa9294e258fed2141bea6 
> 
> Diff: https://reviews.apache.org/r/14309/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>