Re: Review Request 14960: implementation of CLI mesos-status
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14960/#review141463 --- Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md) for reopening reviews. - Joris Van Remoortere On Nov. 19, 2013, 11:47 p.m., Du Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14960/ > --- > > (Updated Nov. 19, 2013, 11:47 p.m.) > > > Review request for mesos, Benjamin Hindman, Benjamin Mahler, and Shingo Omura. > > > Repository: mesos > > > Description > --- > > This commit implements the CLI command mesos-status, which reports three > categories of hosts: > > (1) The hosts that are reported by the /master/state.json and responded to > /slave(1)/health query; > (2) Those that are reported by master but failed to respond to health query > by timeout; > (3) Those that are included in the var/mesos/deploy/slaves files but not > reported by the master. > > > Diffs > - > > src/cli/mesos-status PRE-CREATION > > Diff: https://reviews.apache.org/r/14960/diff/ > > > Testing > --- > > has been tested on a local cluster of 12 servers. > > > Thanks, > > Du Li > >
Re: Review Request 14960: implementation of CLI mesos-status
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14960/#review87773 --- Hi Du! I am sorry this ended up being a stale reviewl: If you still want it in, would you mind addressing Shingo's comment and run a pep8 style checker? - Niklas Nielsen On Nov. 19, 2013, 3:47 p.m., Du Li wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14960/ --- (Updated Nov. 19, 2013, 3:47 p.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, and Shingo Omura. Repository: mesos Description --- This commit implements the CLI command mesos-status, which reports three categories of hosts: (1) The hosts that are reported by the /master/state.json and responded to /slave(1)/health query; (2) Those that are reported by master but failed to respond to health query by timeout; (3) Those that are included in the var/mesos/deploy/slaves files but not reported by the master. Diffs - src/cli/mesos-status PRE-CREATION Diff: https://reviews.apache.org/r/14960/diff/ Testing --- has been tested on a local cluster of 12 servers. Thanks, Du Li
Re: Review Request 14960: implementation of CLI mesos-status
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14960/#review87790 --- Patch looks great! Reviews applied: [14960] All tests passed. - Mesos ReviewBot On Nov. 19, 2013, 11:47 p.m., Du Li wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14960/ --- (Updated Nov. 19, 2013, 11:47 p.m.) Review request for mesos, Benjamin Hindman, Ben Mahler, and Shingo Omura. Repository: mesos Description --- This commit implements the CLI command mesos-status, which reports three categories of hosts: (1) The hosts that are reported by the /master/state.json and responded to /slave(1)/health query; (2) Those that are reported by master but failed to respond to health query by timeout; (3) Those that are included in the var/mesos/deploy/slaves files but not reported by the master. Diffs - src/cli/mesos-status PRE-CREATION Diff: https://reviews.apache.org/r/14960/diff/ Testing --- has been tested on a local cluster of 12 servers. Thanks, Du Li
