Re: Review Request 29748: Added tests for dynamic reservation.

2015-05-12 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29748/ --- (Updated May 12, 2015, 5:13 p.m.) Review request for mesos, Alexander

Re: Review Request 29748: Added tests for dynamic reservation.

2015-05-12 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29748/ --- (Updated May 12, 2015, 6:41 p.m.) Review request for mesos, Alexander

Re: Review Request 29748: Added tests for dynamic reservation.

2015-05-12 Thread Michael Park
On May 11, 2015, 11:32 p.m., Jie Yu wrote: src/tests/reservation_tests.cpp, line 365 https://reviews.apache.org/r/29748/diff/17/?file=954334#file954334line365 YOu do need a snake_case checker:) Sigh... Sorry :( Fixed. On May 11, 2015, 11:32 p.m., Jie Yu wrote:

Re: Review Request 29748: Added tests for dynamic reservation.

2015-05-11 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29748/#review83313 --- Ship it! src/tests/reservation_tests.cpp

Re: Review Request 29748: Added tests for dynamic reservation.

2015-05-09 Thread Michael Park
On April 23, 2015, 1:48 p.m., Michael Park wrote: As of now, the tests seem to take a long time to complete. We should investigate what the issue is before committing this patch. Jie Yu wrote: I suspect this is due to the default allocation interval (1 secs by default). Jie Yu

Re: Review Request 29748: Added tests for dynamic reservation.

2015-05-01 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29748/ --- (Updated May 2, 2015, 4:14 a.m.) Review request for mesos, Alexander

Re: Review Request 29748: Added tests for dynamic reservation.

2015-05-01 Thread Michael Park
On April 23, 2015, 4:15 p.m., Alexander Rukletsov wrote: src/tests/reservation_tests.cpp, line 108 https://reviews.apache.org/r/29748/diff/11/?file=920958#file920958line108 How about we use a single resource string for clarity? Here we start a slave with

Re: Review Request 29748: Added tests for dynamic reservation.

2015-05-01 Thread Michael Park
On April 23, 2015, 4:15 p.m., Alexander Rukletsov wrote: src/tests/reservation_tests.cpp, line 108 https://reviews.apache.org/r/29748/diff/11/?file=920958#file920958line108 How about we use a single resource string for clarity? Here we start a slave with

Re: Review Request 29748: Added tests for dynamic reservation.

2015-05-01 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29748/ --- (Updated May 2, 2015, 4 a.m.) Review request for mesos, Alexander Rukletsov,

Re: Review Request 29748: Added tests for dynamic reservation.

2015-05-01 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29748/ --- (Updated May 2, 2015, 1:29 a.m.) Review request for mesos, Alexander

Re: Review Request 29748: Added tests for dynamic reservation.

2015-05-01 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29748/ --- (Updated May 2, 2015, 12:49 a.m.) Review request for mesos, Alexander

Re: Review Request 29748: Added tests for dynamic reservation.

2015-05-01 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29748/ --- (Updated May 2, 2015, 1:32 a.m.) Review request for mesos, Alexander

Re: Review Request 29748: Added tests for dynamic reservation.

2015-04-23 Thread Jie Yu
On April 23, 2015, 1:48 p.m., Michael Park wrote: As of now, the tests seem to take a long time to complete. We should investigate what the issue is before committing this patch. I suspect this is due to the default allocation interval (1 secs by default). - Jie