Re: Review Request 30643: Optionally specify executor for "mesos execute".

2016-07-09 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30643/#review141465 --- Closing this review due to inactivity. Please see our

Re: Review Request 30643: Optionally specify executor for mesos execute.

2015-06-30 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30643/#review89976 --- Ship it! Ship It! src/cli/execute.cpp (line 101)

Re: Review Request 30643: Optionally specify executor for mesos execute.

2015-06-16 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30643/#review88140 --- This is pretty hacky. Can you elaborate why this is beneficial for

Re: Review Request 30643: Optionally specify executor for mesos execute.

2015-06-16 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30643/#review88151 --- Can you split this review into 1) adding support for a custom

Re: Review Request 30643: Optionally specify executor for mesos execute.

2015-05-26 Thread Ian Downes
On Feb. 4, 2015, 5:44 p.m., Timothy Chen wrote: src/launcher/executor.cpp, line 137 https://reviews.apache.org/r/30643/diff/1/?file=849116#file849116line137 I think it's worth commenting somewhere high level that the command executor is expecting executorInfo's data to be an

Re: Review Request 30643: Optionally specify executor for mesos execute.

2015-05-26 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30643/ --- (Updated May 26, 2015, 3:49 p.m.) Review request for mesos, Timothy Chen and

Re: Review Request 30643: Optionally specify executor for mesos execute.

2015-05-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30643/#review83550 --- Patch looks great! Reviews applied: [30643] All tests passed. -

Re: Review Request 30643: Optionally specify executor for mesos execute.

2015-05-12 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30643/ --- (Updated May 12, 2015, 5:22 p.m.) Review request for mesos, Timothy Chen and