Re: Review Request 30774: Fetcher Cache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/#review87615 --- src/tests/fetcher_cache_tests.cpp

Re: Review Request 30774: Fetcher Cache

> On June 5, 2015, 7:10 p.m., Ben Mahler wrote: > > Just took a cursory glance since this is a huge diff, could it have been > > broken apart further? We've found large diffs like this one are next to > > impossible to review thoroughly :) Agreed that this is normally the case. And this had be

Re: Review Request 30774: Fetcher Cache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/#review86871 --- Just took a cursory glance since this is a huge diff, could it have

Re: Review Request 30774: Fetcher Cache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/#review84857 --- Ship it! src/slave/containerizer/fetcher.hpp

Re: Review Request 30774: Fetcher Cache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/ --- (Updated May 21, 2015, 9:05 a.m.) Review request for mesos, Adam B, Benjamin Hi

Re: Review Request 30774: Fetcher Cache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/ --- (Updated May 21, 2015, 5:06 a.m.) Review request for mesos, Adam B, Benjamin Hi

Re: Review Request 30774: Fetcher Cache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/ --- (Updated May 19, 2015, 8:58 a.m.) Review request for mesos, Adam B, Benjamin Hi

Re: Review Request 30774: Fetcher Cache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/ --- (Updated May 15, 2015, 3:07 p.m.) Review request for mesos, Adam B, Benjamin Hi

Re: Review Request 30774: Fetcher Cache

> On May 15, 2015, 10:34 a.m., Bernd Mathiske wrote: > > src/tests/fetcher_cache_tests.cpp, line 426 > > > > > > This needs to be a pointer. Or use a simple struct. Name: > > FetcherCacheTest::Task > > Bernd Mathisk

Re: Review Request 30774: Fetcher Cache

> On May 15, 2015, 10:34 a.m., Bernd Mathiske wrote: > > src/tests/fetcher_cache_tests.cpp, line 426 > > > > > > This needs to be a pointer. Or use a simple struct. Name: > > FetcherCacheTest::Task Can't use the ret

Re: Review Request 30774: Fetcher Cache

> On May 1, 2015, 12:17 p.m., Benjamin Hindman wrote: > > src/tests/fetcher_cache_tests.cpp, line 1179 > > > > > > Path > > { > > Try executable() const; > > }; > > > > > > Path(runDirecto

Re: Review Request 30774: Fetcher Cache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/#review83946 --- - Bernd Mathiske On May 13, 2015, 3:07 p.m., Bernd Mathiske wrote:

Re: Review Request 30774: Fetcher Cache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/#review83945 --- src/tests/fetcher_cache_tests.cpp

Re: Review Request 30774: Fetcher Cache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/#review83944 --- src/tests/fetcher_cache_tests.cpp

Re: Review Request 30774: Fetcher Cache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/ --- (Updated May 13, 2015, 3:07 p.m.) Review request for mesos, Adam B, Benjamin Hi

Re: Review Request 30774: Fetcher Cache

> On April 29, 2015, 3:41 p.m., Benjamin Hindman wrote: > > src/slave/containerizer/fetcher.cpp, lines 408-417 > > > > > > For the future: > > > > auto futures = filter(entries, [](const auto& entry) { return

Re: Review Request 30774: Fetcher Cache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/ --- (Updated May 12, 2015, 3:43 p.m.) Review request for mesos, Adam B, Benjamin Hi

Re: Review Request 30774: Fetcher Cache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/ --- (Updated May 4, 2015, 4:29 p.m.) Review request for mesos, Adam B, Benjamin Hin

Re: Review Request 30774: Fetcher Cache

> On May 1, 2015, 12:17 p.m., Benjamin Hindman wrote: > > src/tests/fetcher_cache_tests.cpp, line 247 > > > > > > Why are we doing 'driver->start();' here? Good point, does not belong inside here. Moved it out of thi

Re: Review Request 30774: Fetcher Cache

> On March 10, 2015, 8:35 a.m., Benjamin Hindman wrote: > > src/launcher/fetcher.cpp, lines 403-404 > > > > > > As mentioned above, it would be great to really capture the > > relationship between the FetcherInfo and

Re: Review Request 30774: Fetcher Cache

> On March 19, 2015, 9:40 a.m., Timothy Chen wrote: > > src/slave/containerizer/fetcher.cpp, line 379 > > > > > > benh, what do you think of Bernd's contentionBarrier injection? > > commonly we always just mock the c

Re: Review Request 30774: Fetcher Cache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/#review82260 --- src/tests/fetcher_cache_tests.cpp

Re: Review Request 30774: Fetcher Cache

> On April 29, 2015, 1:46 p.m., Benjamin Hindman wrote: > > src/slave/containerizer/fetcher.cpp, lines 386-387 > > > > > > How about still calling this s/reference/get/ and then checking the > > references? Also, we'

Re: Review Request 30774: Fetcher Cache

> On March 10, 2015, 8:35 a.m., Benjamin Hindman wrote: > > src/launcher/fetcher.cpp, lines 364-366 > > > > > > Why are these not CHECKs? Since you're the one setting up the > > FetcherInfo it seems like you should k

Re: Review Request 30774: Fetcher Cache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/ --- (Updated April 30, 2015, 7:40 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 30774: Fetcher Cache

> On April 29, 2015, 3:41 p.m., Benjamin Hindman wrote: > > src/slave/containerizer/fetcher.cpp, line 386 > > > > > > Kill the const &. Killed the &. Any reason this should not be const? > On April 29, 2015, 3:41 p

Re: Review Request 30774: Fetcher Cache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/#review82017 --- src/slave/containerizer/fetcher.hpp

Re: Review Request 30774: Fetcher Cache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/#review78530 --- include/mesos/type_utils.hpp

Re: Review Request 30774: Fetcher Cache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/ --- (Updated April 29, 2015, 1:42 p.m.) Review request for mesos, Adam B, Benjamin