----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31838/#review88636 -----------------------------------------------------------
Ship it! LGTM, although I agree with Alex that you could clean up the if/else-if/else formatting. I could do it before committing, or you could. - Adam B On March 8, 2015, 5:54 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31838/ > ----------------------------------------------------------- > > (Updated March 8, 2015, 5:54 p.m.) > > > Review request for mesos, Adam B, Alexander Rojas, Joerg Schad, and Vinod > Kone. > > > Bugs: MESOS-2464 > https://issues.apache.org/jira/browse/MESOS-2464 > > > Repository: mesos-incubating > > > Description > ------- > > see summary. > > > Diffs > ----- > > src/slave/slave.cpp 364d911 > > Diff: https://reviews.apache.org/r/31838/diff/ > > > Testing > ------- > > make check && functional testing with failed authentication > > > Thanks, > > Till Toenshoff > >