Re: Review Request 32149: Enabled 'Resources::apply' to handle reservation operations.

2015-05-03 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32149/#review82348 --- Ship it! Ship It! - Jie Yu On May 1, 2015, 10:50 p.m., Michael P

Re: Review Request 32149: Enabled 'Resources::apply' to handle reservation operations.

2015-05-01 Thread Michael Park
> On April 8, 2015, 9:19 p.m., Jie Yu wrote: > > src/common/resources.cpp, line 663 > > > > > > Do you need to call validate(operation.reserve().resources()) first > > (like we did in CREATE/DESTROY)? Do you also want

Re: Review Request 32149: Enabled 'Resources::apply' to handle reservation operations.

2015-05-01 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32149/ --- (Updated May 1, 2015, 10:50 p.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 32149: Enabled 'Resources::apply' to handle reservation operations.

2015-04-29 Thread Jie Yu
> On April 8, 2015, 9:19 p.m., Jie Yu wrote: > > src/common/resources.cpp, line 663 > > > > > > Do you need to call validate(operation.reserve().resources()) first > > (like we did in CREATE/DESTROY)? Do you also want

Re: Review Request 32149: Enabled 'Resources::apply' to handle reservation operations.

2015-04-27 Thread Michael Park
> On April 8, 2015, 9:19 p.m., Jie Yu wrote: > > src/common/resources.cpp, line 663 > > > > > > Do you need to call validate(operation.reserve().resources()) first > > (like we did in CREATE/DESTROY)? Do you also want

Re: Review Request 32149: Enabled 'Resources::apply' to handle reservation operations.

2015-04-27 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32149/ --- (Updated April 27, 2015, 5:48 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 32149: Enabled 'Resources::apply' to handle reservation operations.

2015-04-23 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32149/#review81364 --- src/tests/resources_tests.cpp

Re: Review Request 32149: Enabled 'Resources::apply' to handle reservation operations.

2015-04-23 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32149/#review81349 --- Ship it! Ship It! - Timothy Chen On April 23, 2015, 4:38 p.m., M

Re: Review Request 32149: Enabled 'Resources::apply' to handle reservation operations.

2015-04-23 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32149/ --- (Updated April 23, 2015, 4:38 p.m.) Review request for mesos, Alexander Ruklets