Re: Review Request 32700: Removed FrameworkID from FrameworkState.

2016-07-08 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32700/#review141261 --- Discarded this patch because it's old and stale. Feel free to reop

Re: Review Request 32700: Removed FrameworkID from FrameworkState.

2015-09-12 Thread Adam B
> On Aug. 3, 2015, 6:41 p.m., Adam B wrote: > > Looks great! Just a couple of questions. > > Did you run `sudo make check`, since you modified `ROOT_` tests? @karya, should we revive this patch now, or discard it? - Adam --- This is an

Re: Review Request 32700: Removed FrameworkID from FrameworkState.

2015-08-03 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32700/#review93988 --- Looks great! Just a couple of questions. Did you run `sudo make chec

Re: Review Request 32700: Removed FrameworkID from FrameworkState.

2015-08-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32700/#review93847 --- Patch looks great! Reviews applied: [32700] All tests passed. - M

Re: Review Request 32700: Removed FrameworkID from FrameworkState.

2015-08-01 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32700/ --- (Updated Aug. 1, 2015, 3:13 p.m.) Review request for mesos and Adam B. Bugs: