---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9/#review95611
---
src/examples/java/TestPersistentVolumeFramework.java (lines 535 -
On Aug. 14, 2015, 10:28 p.m., haosdent huang wrote:
Again, sorry it's taken so long to get round to doing this review and s
many thanks for doing this!
I've only got halfway through, I'll try my best to do more in the next few
days, less craziness (here's to hoping, anyway!)
On Aug. 14, 2015, 10:28 p.m., Marco Massenzio wrote:
[mmm turns out that it matters WHICH boxes you put your general comments in :)
- copied here, as they make sense *before* the nitpicking that follows]
Again, sorry it's taken so long to get round to doing this review and s
many
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9/#review95473
---
src/examples/java/TestPersistentVolumeFramework.java (line 34)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9/#review88697
---
Patch looks great!
Reviews applied: [9]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9/#review88691
---
Patch looks great!
Reviews applied: [9]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9/
---
(Updated June 21, 2015, 9:42 a.m.)
Review request for mesos, Adam B, Jie Yu,
On June 1, 2015, 11:32 p.m., Marco Massenzio wrote:
src/examples/java/TestPersistentVolumeFramework.java, lines 529-542
https://reviews.apache.org/r/9/diff/10/?file=941652#file941652line529
Please consider using Apache Commons CLI instead:
On June 1, 2015, 4:32 p.m., Marco Massenzio wrote:
This is great -sorry it took so long to get to do a review.
Thanks for doing it, I'm quite looking forward to using it to learning more
about the Persistent Framework :)
it would be great if we could have a bit more comments in the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9/
---
(Updated June 21, 2015, 5:17 a.m.)
Review request for mesos, Adam B, Jie Yu,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9/
---
(Updated June 21, 2015, 5:37 a.m.)
Review request for mesos, Adam B, Jie Yu,
On June 1, 2015, 11:32 p.m., Marco Massenzio wrote:
src/examples/java/TestPersistentVolumeFramework.java, line 239
https://reviews.apache.org/r/9/diff/10/?file=941652#file941652line239
unless I'm mistaken and this is a unit test (is it?) can we please
rename this class in a
On June 1, 2015, 11:32 p.m., Marco Massenzio wrote:
This is great -sorry it took so long to get to do a review.
Thanks for doing it, I'm quite looking forward to using it to learning more
about the Persistent Framework :)
it would be great if we could have a bit more comments in the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9/#review86956
---
Patch looks great!
Reviews applied: [9]
All tests passed.
-
On June 1, 2015, 11:32 p.m., Marco Massenzio wrote:
src/examples/java/TestPersistentVolumeFramework.java, line 29
https://reviews.apache.org/r/9/diff/10/?file=941652#file941652line29
as this is an example framework, it'd be great if it could have
(extensive) javadocs: newbies
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9/#review86113
---
This is great -sorry it took so long to get to do a review.
Thanks
On June 1, 2015, 11:32 p.m., Marco Massenzio wrote:
This is great -sorry it took so long to get to do a review.
Thanks for doing it, I'm quite looking forward to using it to learning more
about the Persistent Framework :)
it would be great if we could have a bit more comments in the
On June 1, 2015, 11:32 p.m., Marco Massenzio wrote:
This is great -sorry it took so long to get to do a review.
Thanks for doing it, I'm quite looking forward to using it to learning more
about the Persistent Framework :)
it would be great if we could have a bit more comments in the
On June 1, 2015, 11:32 p.m., Marco Massenzio wrote:
This is great -sorry it took so long to get to do a review.
Thanks for doing it, I'm quite looking forward to using it to learning more
about the Persistent Framework :)
it would be great if we could have a bit more comments in the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9/
---
(Updated April 25, 2015, 6:07 p.m.)
Review request for mesos and Jie Yu.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9/
---
(Updated April 25, 2015, 6:05 p.m.)
Review request for mesos and Jie Yu.
21 matches
Mail list logo
